Files
pmd-sky/include
cecilarmitais 7487d6f73d Address PR #300 review: restore field comments, de-duplicate a forward
declaration, fix case indentation

Six review comments from AnonymousRandomPerson on pret/pmd-sky#300.

Comments restored, in include/common.h (struct ground_monster's level,
level_at_first_evo, level_at_second_evo, iq and max_hp) and in
include/ground_bg.h (BmaHeader's numLayers, hasDataLayer, hasCollision). These
were not removed deliberately: each line was rewritten for a type correction and
its trailing comment went with it. Every one of those retypes is the same
character width as what it replaced, so the original column alignment is
restored verbatim.

struct team_member keeps u8 flags, with the labelled bitfield preserved as a
comment in the form struct item already uses for the same situation.

struct ground_monster; is no longer forward-declared anywhere. All three headers
that carried it - main_02055410.h, main_02056914.h and main_0205A288.h - now
include common.h instead. main_02056914.h previously had no includes at all, so
this makes it self-contained as well.

Case indentation in src/main_0203D538.c and src/overlay_29_0231CBC8.c. The
defect was wider than the two labels the review pointed at: whole regions were
de-indented, consistent with a splice artifact. overlay_29_0231CBC8.c's switch
ran at column 8, then 4, then 0, then 4; main_0203D538.c had two contiguous
blocks short by 4 and by 8. Re-indented by brace depth, so every switch in both
files is now internally consistent with its own earlier cases.

The comments in this commit were added under build-tools/precommit.py's
--allow-comments override, which exists for exactly this case: they were
requested by the upstream maintainer in review, not authored here.

Authored by Claude (Opus 5) under human direction. Proved byte-neutral rather
than argued, because two of these changes could in principle move codegen: the
eight translation units reaching any of the three edited headers, and the two
re-indented files, each compiled in the build image with the real flags
(including -W all -W pedantic -W error) before and after. All 30 objects are
byte-identical across NORTH_AMERICA, EUROPE and JAPAN.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-20 00:59:34 -07:00
..
2023-09-14 13:39:03 +02:00
2023-07-02 00:21:29 -04:00
2023-12-28 11:30:48 -05:00
2024-12-01 18:20:37 -06:00
2025-06-17 22:49:24 -05:00
2025-09-24 19:54:43 -04:00
2026-07-18 09:27:28 -07:00
2026-04-06 16:25:40 -07:00
2025-03-11 22:53:44 -04:00
2026-01-31 08:58:35 -08:00
2026-01-09 10:00:14 -08:00
2025-10-26 21:26:51 -04:00
2025-07-18 20:18:27 -04:00
2025-06-18 18:45:30 -05:00
2025-09-22 23:44:07 -04:00
2025-06-17 22:25:10 -05:00
2024-12-02 00:02:39 -06:00
2025-07-18 20:57:20 -04:00
2025-07-19 11:12:11 -04:00
2025-03-28 00:01:20 -04:00
2024-10-15 21:50:55 -07:00
2025-09-19 16:40:00 -04:00
2025-06-16 19:17:24 -05:00
2025-12-18 20:19:02 +00:00
2026-01-09 09:15:46 -08:00
2023-08-18 21:25:54 -04:00
2023-08-27 22:06:17 -04:00
2025-07-18 20:36:26 -04:00
2025-12-04 23:36:51 -05:00
2026-01-03 13:06:03 -08:00
2026-04-26 23:30:17 -04:00
2026-04-26 23:18:03 -04:00
2026-07-11 17:18:26 -04:00
2026-04-26 23:19:39 -04:00
2025-08-06 18:07:19 -04:00
2026-06-12 17:09:45 -04:00
2026-03-19 23:44:13 -04:00
2026-03-17 22:59:00 -04:00
2026-03-18 17:43:47 -04:00
2026-03-17 22:05:24 -04:00
2026-05-06 12:49:58 -04:00
2026-04-16 12:23:36 -04:00
2026-05-06 12:49:58 -04:00
2026-06-21 19:17:04 -04:00
2026-06-16 19:29:57 -04:00
2026-03-19 22:23:31 -04:00
2026-03-19 22:23:31 -04:00
2026-03-19 22:20:19 -04:00
2026-03-19 22:23:31 -04:00
2026-03-19 23:38:50 -04:00
2026-05-15 19:05:14 -04:00
2026-05-15 19:05:14 -04:00
2026-07-11 17:18:25 -04:00
2026-07-11 17:18:25 -04:00
2025-09-19 18:11:31 -04:00
2026-04-26 23:27:29 -04:00
2026-01-09 08:51:36 -08:00
2026-05-06 12:49:58 -04:00
2026-07-11 17:18:26 -04:00
2026-01-03 13:06:03 -08:00
2026-05-06 12:49:58 -04:00
2026-03-16 22:18:04 -04:00
2026-08-16 13:45:14 -07:00
2026-07-25 15:16:15 -07:00
2025-10-22 21:15:44 -04:00
2024-11-22 22:47:03 -05:00
2025-08-06 18:07:19 -04:00
2026-04-26 23:31:27 -04:00
2026-01-09 10:14:05 -08:00
2026-07-11 17:18:26 -04:00
2026-09-15 19:14:06 +00:00
2026-05-06 12:49:58 -04:00
2024-11-22 22:47:03 -05:00
2025-11-03 15:18:17 +01:00
2025-09-11 23:39:48 -04:00
2025-07-17 22:31:32 -04:00
2025-09-13 22:59:13 -04:00
2026-06-12 17:33:06 -04:00
2026-01-09 08:51:36 -08:00
2026-01-09 08:51:36 -08:00
2026-05-25 15:32:06 -04:00
2026-03-28 18:46:39 -07:00
2025-07-21 16:47:18 +02:00
2026-07-02 20:51:00 -04:00
2026-07-02 20:51:00 -04:00
2026-07-02 20:51:00 -04:00
2025-08-06 18:07:19 -04:00
2026-08-02 15:25:56 -07:00
2026-08-12 12:19:47 -07:00
2025-09-07 23:37:58 -04:00
2025-06-15 17:52:45 -05:00
2025-03-06 00:04:18 -05:00
2025-03-06 00:04:18 -05:00
2026-01-09 10:00:14 -08:00
2025-03-06 00:04:18 -05:00
2025-06-15 17:31:53 -05:00
2025-06-15 17:44:13 -05:00
2026-05-25 15:32:06 -04:00
2025-11-29 20:11:47 -08:00
2026-06-21 19:27:18 -04:00
2025-10-22 21:41:40 -04:00
2024-11-15 00:45:43 -05:00
2025-08-06 18:07:19 -04:00
2025-08-08 23:47:03 -04:00
2025-08-06 18:07:19 -04:00
2026-04-26 23:11:33 -04:00
2025-11-17 23:40:54 -05:00
2025-10-23 22:39:13 -04:00
2025-12-18 13:09:43 +00:00
2023-09-14 13:39:03 +02:00
2025-10-24 00:04:32 -04:00
2026-06-04 18:39:56 -07:00
2025-07-18 20:24:21 -04:00
2026-07-11 17:18:26 -04:00
2025-07-14 18:03:16 -04:00