Commit Graph

860 Commits

Author SHA1 Message Date
dannye
bc2354dd66 Merge branch 'master' of https://github.com/pret/pokered
Some checks failed
CI / build (push) Has been cancelled
CI / build-macos (push) Has been cancelled
2026-01-17 22:38:33 -06:00
DrNyk
4e22af12bc
Replace hard-coded numbers with constants in haze.asm (#564) 2026-01-17 16:42:12 -05:00
SnorlaxMonster
85b9d866c8
Align move grammar with pokecrystal (#565)
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
2026-01-17 16:41:37 -05:00
Rangi
0e49aef88e
Use macros to enforce "hidden object" constraints, and rename them to "hidden events" (#559) 2026-01-07 22:05:37 -05:00
Rangi
fe1e76466b
Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" (#557) 2026-01-07 22:05:20 -05:00
abcboy101
772ec10339
Identify characters in _OakSpeechText2B and Printer_GetMonStats.IDNo (#144) 2025-12-30 12:07:40 -05:00
Jordan Moore
0555b42dc0
Replace magic number $7 with SLP_MASK constant (#555) 2025-12-26 12:20:49 -05:00
Rangi
d79c578abd
Specify a max item length for list_start (#552) 2025-12-15 15:16:40 -05:00
Narishma-gb
e9d3324bc0
Comment more unreferenced local labels (#550) 2025-12-15 15:14:17 -05:00
Narishma-gb
8bb03542bd
Update StatusScreen, add *_STATS_BOX constants (#546) 2025-12-01 13:46:28 -06:00
Rangi
9a6bb3ed0c
Define player and rival names once, to be used in two places (#545) 2025-12-01 11:00:56 -05:00
Narishma-gb
3a4382c605
Use more Pokemon data constants, create MOVE_NAME_LENGTH (#543) 2025-11-27 13:39:25 -05:00
Rangi
e92d1af478
Avoid magic numbers for most CopyData calls (#542) 2025-11-25 16:53:29 -06:00
Rangi
308189b638
Use ld_hli_a_string macro to make byte-by-byte strings more obvious (#540) 2025-11-23 21:19:21 -06:00
Narishma-gb
f332678625
Use more hardware and graphics constants (#532)
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
dannye
324ae167d1 Merge branch 'master' of https://github.com/pret/pokered
Some checks failed
CI / build (push) Has been cancelled
2025-11-12 17:56:10 -06:00
Rangi
5943b96cf6
Use features of RGBDS 1.0.0 (#537) 2025-11-12 15:44:07 -05:00
Rangi
e3af20b907 Consistently use ld [hli]/ld [hld], not ldi/ldd 2025-10-05 10:53:31 -04:00
Rangi
628797baff Revise some RAM buffer constants 2025-09-26 16:55:23 -04:00
Narishma-gb
d237b01cfb
Misc. naming and cleanup (#139)
Some checks failed
CI / build (push) Has been cancelled
* Name some printer/diploma routines

* Name `wd434`

* Name `NAME_LENGTH_JP`

* Rename `callabd`/`calladb` to `farcall`/`callfar`
2025-09-10 00:31:11 -04:00
PokefanMarcel
108bf2981d
Use RAMG_SRAM_ENABLE (#530) 2025-09-07 12:46:26 -04:00
dannye
377749ca4e Merge branch 'master' of https://github.com/pret/pokered
Some checks failed
CI / build (push) Has been cancelled
2025-09-06 16:54:17 -05:00
Narishma-gb
d18d7089c7
Fix .tilemap file extension, fix some typos (#138) 2025-09-06 16:50:51 -04:00
Vortyne
8da7deb893
Update comment for clarity (#529)
Actually copies from battle struct to party struct to make HP and status changes to a pokemon permanent
2025-09-03 11:59:22 -04:00
Narishma-gb
4d2594cb24
Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Narishma-gb
126c3f3366
Document a bug in PrintBenchGuyText (#523) 2025-08-17 10:00:34 -04:00
Rangi
5e8b835ba3
Use dname macro to automatically pad names with "@" characters (#525) 2025-08-17 09:58:09 -04:00
PokefanMarcel
31fc2e229d
Use <STAT>_UP1_EFFECT constants (#522) 2025-08-16 08:37:08 -04:00
Rangi42
1eb6f61d62 Identify JOYP_SGB_MLT_REQ constant 2025-08-11 16:35:07 -04:00
Rangi42
bdbc8cbd48 Update hardware.inc to 5.3.0 and use its JOYP_SGB_* constants 2025-08-11 15:43:27 -04:00
PokefanMarcel
b9352be74f
Rename .asm_39c46 to .loopSkipTrainer (#122)
Some checks failed
CI / build (push) Has been cancelled
---------

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2025-07-23 22:40:33 -04:00
kagnusdev
03388ca248
Replace hardcoded offset with address (#132) 2025-07-23 22:36:13 -04:00
thoth-33
6e9c7198a1
Add more labels and constants for Options menu (#133)
* Copy more structure from pokecrystal

---------

Co-authored-by: Rangi42 <sylvie.oukaour+rangi42@gmail.com>
2025-07-23 17:43:31 -04:00
kagnusdev
4eaccc4a7a
Use less generic labels for party finding loops (#514) 2025-07-07 18:59:17 -04:00
Rangi42
5a142e3fee Use hardware.inc constants in places unique to Yellow
Some checks failed
CI / build (push) Has been cancelled
2025-07-02 23:39:15 -04:00
dannye
ca019eac8f Merge branch 'master' of https://github.com/pret/pokered 2025-07-02 21:15:13 -05:00
Rangi42
78e44a8fb1 Use combined hardware constants 2025-06-30 13:45:24 -04:00
Rangi
56c405de09
Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
Rangi42
fcb61ae0e4 Distinguish single trainer pics section from Pokemon pics 2025-06-25 23:59:47 -04:00
dannye
fd043a66c2 Fix typos 2025-06-03 23:48:35 -05:00
Rangi
b4bae4a5d5
Add a CANNOT_MOVE constant (#508) 2025-05-31 15:08:23 -04:00
dannye
4500fe4296 Use more ldpikacry
Some checks failed
CI / build (push) Has been cancelled
2025-05-25 19:46:44 -05:00
dannye
2c74f137fc Merge branch 'master' of https://github.com/pret/pokered 2025-05-10 12:25:27 -05:00
Vortyne
d7de1595c0
Fix sprite data comment (#507)
Reduces confusion if someone edits this file since the wrong byte was commented
2025-05-09 18:47:29 -04:00
Narishma-gb
0ecc36c83a
Use constants in PrintBCDNumber calls (#503) 2025-04-08 22:17:32 -05:00
SatoMew
cf73d6ee0f
Further improve NPC trade labels and comments (#493) 2025-04-08 22:17:12 -05:00
edave64
e1b7b8af0a
Use constants for PP masks instead of magic numbers (#504) 2025-04-02 10:49:15 -04:00
Rangi
147914d179
Use constants for trade text indexes (#501) 2025-03-08 11:16:42 -05:00
Rangi
b460637b81
Avoid using EQUS when EQU or MACRO will do (#496) 2025-02-27 13:07:17 -05:00
dannye
6cb885a9f6 Merge branch 'master' of https://github.com/pret/pokered
Some checks failed
CI / build (push) Has been cancelled
2025-01-30 21:40:19 -06:00