Rangi
147914d179
Use constants for trade text indexes ( #501 )
2025-03-08 11:16:42 -05:00
Rangi
b460637b81
Avoid using EQUS when EQU or MACRO will do ( #496 )
2025-02-27 13:07:17 -05:00
dannye
6cb885a9f6
Merge branch 'master' of https://github.com/pret/pokered
CI / build (push) Has been cancelled
2025-01-30 21:40:19 -06:00
Narishma-gb
43f21cc494
Fix some label typos, and add some constants instead of raw numbers ( #492 )
2025-01-30 17:26:55 -05:00
SatoMew
79518a602e
Consistently refer to CGB, not GBC ( #491 )
2025-01-30 17:13:40 -05:00
Rangi
ec37f6117d
Consistently capitalize ASSERT directives ( #489 )
2025-01-28 23:31:27 -05:00
Rangi
afb8990169
Miscellaneous cleanup ( #488 )
...
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Engezerstorung
96fc617c69
Correct wTileMapBackup declared space ( #487 )
2025-01-28 12:08:12 -05:00
Engezerstorung
636e1192f6
Identify unnamed functions in map_sprites.asm ( #126 )
...
CI / build (push) Has been cancelled
Also fix a label name
2025-01-23 19:08:38 -05:00
Rangi42
f023c68417
Use EFFECT_1E
2024-12-27 20:27:34 -05:00
Rangi
f8a7ac34b9
Don't pass redundant label names to table_width and list_start ( #125 )
2024-12-27 12:52:30 -05:00
Rangi
cd647df3b5
Don't pass redundant label names to table_width and list_start ( #484 )
2024-12-27 12:52:24 -05:00
Rangi
cde1cb7b1f
Use RGBDS 0.9.0 ( #123 )
2024-12-25 21:24:25 -05:00
Rangi
cd1065b7a9
Use RGBDS 0.9.0 ( #482 )
2024-12-25 21:24:21 -05:00
Rangi42
47b784a4fb
Merge branch 'master' of https://github.com/pret/pokered
2024-12-25 16:53:04 -05:00
Rangi42
a59c2bbaf9
Use SERIAL_RNS_LENGTH in BattleRandom
2024-12-21 21:04:36 -05:00
Rangi42
67084c9d26
Remove redundant parentheses
2024-12-16 10:35:55 -05:00
Rangi42
ff76bba507
Use "gray", not "grey"
...
This matches the in-game text, e.g. Pewter is "A Stone Gray City"
2024-12-16 10:29:59 -05:00
Sylvie
f801d67f8e
Assert the relations between some move effect constants ( #478 )
2024-11-24 19:13:11 -05:00
TiKevin83
6e94bc3d76
Fix comments around battle evolution code ( #120 )
...
CI / build (push) Has been cancelled
the bug that allows item evolutions to happen after battles is patched here in Yellow where it isn't in Red/Blue. Updated a comment to reflect this.
2024-11-17 22:03:46 -06:00
dannye
942c5f13ea
Merge branch 'master' of https://github.com/pret/pokered
2024-10-09 21:56:57 -05:00
Vortyne
678d014aef
FreezeEnemyTrainerSprite -> SetEnemyTrainerToStayAndFaceAnyDirection
2024-10-07 12:03:26 -04:00
Vortyne
1aa3fb24ec
dbsprite is the wrong macro for WriteOAMBlock data (#472 )
2024-09-29 18:54:41 -04:00
dannye
716f8608c1
Rename off-by-one wram labels
2024-09-29 10:50:46 -05:00
Sylvie
7d9858fec4
Identify more bit flags ( #119 )
...
* Identify more bit flags
* Bit serves dual use in debug mode
2024-09-29 10:24:35 -05:00
Vortyne
af36156a5b
This byte is written to, but not used ( #471 )
...
it's written to in init_player_data.asm
```
ld hl, wObtainedBadges
ld [hli], a
ld [hl], a
```
2024-09-25 22:02:15 -05:00
dannye
a02a98ee7a
Merge branch 'master' of https://github.com/pret/pokered
2024-09-25 00:45:00 -05:00
Sylvie
635b9c4cab
Identify wCurrentMapScriptFlags bits ( #467 )
2024-09-24 11:39:44 -04:00
Sylvie
6ae63a8cea
Identify hardware register bits ( #469 )
2024-09-24 10:48:10 -04:00
Sylvie
b5d2540e7c
Identify more bit flags ( #465 )
...
* Identify more bit flags
* Space
2024-09-24 09:33:33 -04:00
Vortyne
c3f297e98b
Fix comment: Road -> Roar ( #466 )
2024-09-24 07:32:47 -05:00
Sylvie
8f1dcf07e5
Identify more flag bits ( #464 )
2024-09-23 23:51:44 -04:00
Sylvie
5a622f628d
Identify remaining uses of wd0b5 and wd11e ( #463 )
2024-09-18 21:41:58 -04:00
Sylvie
613d34678b
Split hSpriteIndexOrTextID into hSpriteIndex and hTextID ( #462 )
...
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Vortyne
1f6e2bf999
Use correct label in get_trainer_name.asm ( #461 )
2024-09-09 20:22:58 -04:00
Sylvie
77d051479b
Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem ( #457 )
2024-08-04 10:05:33 -04:00
Sylvie
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others ( #455 )
2024-07-24 12:21:59 -04:00
Sylvie
8fafca714c
Identify various flag labels and bit constants ( #454 )
2024-07-16 13:02:54 -04:00
SatoMew
57bec62508
Improve documentation of some SRAM routines ( #114 )
2024-06-26 21:19:06 -05:00
Sylvie
fc23e72a39
Identify some unused WRAM variables ( #453 )
2024-06-15 12:18:00 -04:00
dannye
b135272f95
Merge branch 'master' of https://github.com/pret/pokered
2024-05-05 11:06:40 -05:00
dannye
d870ad6ea8
Fix hard-coded bank
2024-05-05 09:41:56 -05:00
Rangi
fabe2b3fb3
Update to RGBDS 0.7.0 ( #447 )
2024-01-03 10:59:04 -05:00
SatoMew
07cefd462f
Clean up item comments ( #443 )
2023-12-18 18:30:37 -06:00
colawsol
f6017ddbfd
Correct StarterDex function comment ( #440 )
2023-12-06 19:34:37 -06:00
vulcandth
1dcc16b347
Delete a couple EOL whitespace.
2023-11-22 15:09:21 +00:00
dannye
0ebc2025bc
Rename pikachu palette packets
2023-11-21 21:54:53 -06:00
dannye
04f7f7f506
Merge branch 'master' of https://github.com/pret/pokered
2023-11-21 20:56:28 -06:00
dannye
a247120ac1
Fix a few usages of EFFECTIVE
2023-11-21 20:18:04 -06:00
Rangi42
41ec74e1f0
Fix inaccurate comment in UpdateNPCSprite
...
Fixes #404
2023-11-21 20:36:00 -05:00
Rangi42
0a616ae560
Get rid of wEvosMoves, MAX_EVOLUTIONS, and EVOLUTION_SIZE
...
Fixes #430
2023-11-21 20:33:03 -05:00
Rangi42
d4e7a39dd8
Use some more constants in place of raw numbers
2023-11-21 20:15:30 -05:00
RainbowMetalPigeon
465b859c4c
Replace some $a with EFFECTIVE ( #399 )
2023-11-21 20:01:20 -05:00
SatoMew
a681f718ac
Rename EV_* constants to EVOLVE_* like pokecrystal ( #407 )
2023-11-21 19:54:39 -05:00
BlueZangoose
9827190aea
Use MEGA_PUNCH constant in explosion animation routine ( #434 )
...
* Use MEGA_PUNCH constant in explosion animation routine
* Add AnimationType constants and assert
---------
Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-21 19:52:53 -05:00
dannye
298e99d377
Merge branch 'master' of https://github.com/pret/pokered
2023-11-20 20:23:27 -06:00
Rangi42
77887be251
Identify wSavedCoordIndex and its other usages
2023-11-20 18:53:23 -05:00
Rangi42
b066d3c9bc
Add bigdw and dc data macros
2023-11-20 17:53:19 -05:00
Vortyne
7a7a6d689c
Identify the unnamed HRAM variables and one WRAM label ( #438 )
2023-11-20 17:23:22 -05:00
Vortyne
5739aea990
Name unnamed labels in seafoam islands and pokemon mansion script files ( #435 )
...
* Update PokemonMansion1F.asm
* Name unnamed seafoam/mansion labels
2023-11-19 15:09:33 -06:00
Rangi42
26a342b104
Identify more map script labels
2023-11-18 19:44:03 -05:00
vulcandth
64061e2092
.calculateHPBarCoords incorrectly referenced OAM
...
Resolves #411
Co-Authored-By: SnDream <12762219+sndream@users.noreply.github.com>
2023-11-17 22:36:21 -06:00
Linus Unnebäck
83b373ad73
Add constants for wMapConnections bits and group map header wram labels
...
* Add constants for wMapConnections bits
* Apply Vulcandth and Rangi42 feedback
---------
Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 12:50:27 -06:00
strager
30c244ae4f
Use PSN constant in PoisonEffect routine ( #426 )
2023-09-20 15:43:27 -04:00
SatoMew
a38c7922dd
Improve comment about the "ED" tile bug ( #421 )
2023-07-16 20:22:06 -05:00
Linus Unnebäck
c42b7167ce
Use charmap in link_battle_versus_text ( #415 )
2023-07-16 16:21:20 -05:00
SatoMew
f46db37d50
Thoroughly document debug code ( #410 )
2023-07-15 18:36:59 -04:00
vulcandth
d001ced41b
Add macros, constants, and labels for map scripts and text ( #367 )
...
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
2023-07-13 21:27:56 -04:00
dannye
667f1febbe
Merge branch 'master' of https://github.com/pret/pokered
2023-04-25 19:52:12 -05:00
Vortyne
17eaf761e3
Name some unnamed animation constants ( #396 )
2023-03-25 23:31:59 -04:00
SatoMew
5c4795d5bc
Complete and improve debug name labels ( #408 )
2023-02-26 11:14:21 -05:00
Rangi
2f00afe935
Move ShoreTiles and WaterTile into data/
2022-10-05 07:20:54 -04:00
Rangi
7dd9d7dc80
Merge remote-tracking branch 'remotes/pokered/master'
2022-10-02 22:42:26 -04:00
Rangi
22859c4bb7
Revert PR #395
2022-09-26 15:17:26 -04:00
Vortyne
742dd00eb7
Bug: Sprites can receive the wrong movement byte ( #395 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-26 14:53:16 -04:00
BlueZangoose
0f5a9eb146
Change names of move subanimations to be meaningful ( #389 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-09-25 14:17:39 -04:00
Rangi
c299cf1067
Use a SPRITE_SET_LENGTH constant
2022-09-24 11:39:39 -04:00
Rangi
d2be79adf1
Add constants and table macros for the map sprite sets ( #392 )
...
Fixes #391
2022-09-24 11:30:29 -04:00
dannye
ecab35295a
Merge branch 'master' of https://github.com/pret/pokered
2022-09-12 00:53:37 -05:00
Rangi
bbb0e7e82d
Use the same music headers as pokecrystal ( #382 )
2022-08-11 21:23:08 -04:00
SatoMew
ac7263b1ad
Update comments related to Swift and Substitute checks ( #380 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-11 21:22:57 -04:00
Chatot4444
8b19405590
Replace Hard-Coded Number With Constant ( #381 )
...
Replace a hard coded $a in CheckMapForMon with NUM_WILDMONS
2022-08-11 07:51:18 -05:00
Chatot4444
8f369bfaee
Replace Hard-Coded Number With Constant
...
Replace a hard coded $a in CheckMapForMon with NUM_WILDMONS
2022-08-11 07:50:11 -05:00
Rangi
423f56c284
Fix some whitespace
2022-08-07 00:40:22 -04:00
Rangi
72b5656305
Clarify how Metronome picks a move
2022-07-26 00:02:05 -04:00
Rangi
498da6ab09
Clarify how Metronome picks a move
2022-07-26 00:01:21 -04:00
Rangi
96656fdc69
Identify some .asm_* labels
2022-07-10 21:27:24 -04:00
Rangi
8f81e71f19
Identify some .asm_* labels
2022-07-10 21:11:03 -04:00
Rangi
a66adbcc5c
Sync Pokédex rating text with pokeyellow
2022-07-10 19:26:18 -04:00
Rangi
927b5a4700
Identify Pokédex rating text
2022-07-10 19:16:17 -04:00
Colton G. Rushton
c0085ea1b2
wOAMBuffer -> wShadowOAM ( #95 )
2022-07-09 17:18:20 -04:00
Colton G. Rushton
cc46b0e510
wOAMBuffer -> wShadowOAM ( #370 )
2022-07-09 17:18:18 -04:00
vulcandth
69e9d359e5
party_struct constants and ExchangeBytes size ( #91 )
...
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-07-04 01:08:19 -04:00
vulcandth
70cbb48328
party_struct constants and ExchangeBytes size ( #364 )
...
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-07-04 01:08:17 -04:00
vulcandth
fcd6e5a1b2
Stop_reducing_move_anim_flashing_Dream_Eater -> Stop_reducing_move_anim_flashing_Blizzard ( #369 )
2022-06-30 21:24:33 -04:00
vulcandth
d3bdb249af
VC ExchangeBytes Aliases ( #90 )
...
Co-authored-by: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-22 20:15:59 -04:00
vulcandth
610ec0fd22
VC ExchangeBytes Aliases ( #363 )
...
Co-authored-by: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-22 20:15:58 -04:00
Rangi
46aeb3012f
cp MR_FUJIS_HOUSE -> cp POKEMON_TOWER_7F + 1
2022-06-17 22:58:48 -04:00
Rangi
4e96f9d232
cp MR_FUJIS_HOUSE -> cp POKEMON_TOWER_7F + 1
...
Fixes #362
2022-06-17 22:58:46 -04:00
vulcandth
10cfe09034
Rename SLP to SLP_MASK ( #89 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:53 -04:00
