Leahnaya/pokeyellow
1
0
Fork 0
mirror of https://github.com/pret/pokeyellow.git synced 2026-04-26 09:42:51 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
3,618 Commits 2 Branches 0 Tags 32 MiB
master
Commit Graph

863 Commits

Author SHA1 Message Date
Rangi42
0a616ae560 Get rid of wEvosMoves, MAX_EVOLUTIONS, and EVOLUTION_SIZE 
Fixes #430
 2023-11-21 20:33:03 -05:00
Rangi42
d4e7a39dd8 Use some more constants in place of raw numbers 2023-11-21 20:15:30 -05:00
RainbowMetalPigeon
465b859c4c
Replace some $a with EFFECTIVE (#399) 2023-11-21 20:01:20 -05:00
SatoMew
a681f718ac
Rename EV_* constants to EVOLVE_* like pokecrystal (#407) 2023-11-21 19:54:39 -05:00
BlueZangoose
9827190aea
Use MEGA_PUNCH constant in explosion animation routine (#434) 
* Use MEGA_PUNCH constant in explosion animation routine

* Add AnimationType constants and assert

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-11-21 19:52:53 -05:00
dannye
298e99d377 Merge branch 'master' of https://github.com/pret/pokered 2023-11-20 20:23:27 -06:00
Rangi42
77887be251 Identify wSavedCoordIndex and its other usages 2023-11-20 18:53:23 -05:00
Rangi42
b066d3c9bc Add bigdw and dc data macros 2023-11-20 17:53:19 -05:00
Vortyne
7a7a6d689c
Identify the unnamed HRAM variables and one WRAM label (#438) 2023-11-20 17:23:22 -05:00
Vortyne
5739aea990
Name unnamed labels in seafoam islands and pokemon mansion script files (#435) 
* Update PokemonMansion1F.asm

* Name unnamed seafoam/mansion labels
 2023-11-19 15:09:33 -06:00
Rangi42
26a342b104 Identify more map script labels 2023-11-18 19:44:03 -05:00
vulcandth
64061e2092 .calculateHPBarCoords incorrectly referenced OAM 
Resolves #411

Co-Authored-By: SnDream <12762219+sndream@users.noreply.github.com>
 2023-11-17 22:36:21 -06:00
Linus Unnebäck
83b373ad73
Add constants for wMapConnections bits and group map header wram labels 
* Add constants for wMapConnections bits

* Apply Vulcandth and Rangi42 feedback

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-11-17 12:50:27 -06:00
strager
30c244ae4f
Use PSN constant in PoisonEffect routine (#426) 2023-09-20 15:43:27 -04:00
SatoMew
a38c7922dd
Improve comment about the "ED" tile bug (#421) 2023-07-16 20:22:06 -05:00
Linus Unnebäck
c42b7167ce
Use charmap in link_battle_versus_text (#415) 2023-07-16 16:21:20 -05:00
SatoMew
f46db37d50
Thoroughly document debug code (#410) 2023-07-15 18:36:59 -04:00
vulcandth
d001ced41b
Add macros, constants, and labels for map scripts and text (#367) 
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
 2023-07-13 21:27:56 -04:00
dannye
667f1febbe Merge branch 'master' of https://github.com/pret/pokered 2023-04-25 19:52:12 -05:00
Vortyne
17eaf761e3
Name some unnamed animation constants (#396) 2023-03-25 23:31:59 -04:00
SatoMew
5c4795d5bc
Complete and improve debug name labels (#408) 2023-02-26 11:14:21 -05:00
Rangi
2f00afe935 Move ShoreTiles and WaterTile into data/ 2022-10-05 07:20:54 -04:00
Rangi
7dd9d7dc80 Merge remote-tracking branch 'remotes/pokered/master' 2022-10-02 22:42:26 -04:00
Rangi
22859c4bb7
Revert PR #395 2022-09-26 15:17:26 -04:00
Vortyne
742dd00eb7
Bug: Sprites can receive the wrong movement byte (#395) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-09-26 14:53:16 -04:00
BlueZangoose
0f5a9eb146
Change names of move subanimations to be meaningful (#389) 
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
 2022-09-25 14:17:39 -04:00
Rangi
c299cf1067 Use a SPRITE_SET_LENGTH constant 2022-09-24 11:39:39 -04:00
Rangi
d2be79adf1
Add constants and table macros for the map sprite sets (#392) 
Fixes #391
 2022-09-24 11:30:29 -04:00
dannye
ecab35295a Merge branch 'master' of https://github.com/pret/pokered 2022-09-12 00:53:37 -05:00
Rangi
bbb0e7e82d
Use the same music headers as pokecrystal (#382) 2022-08-11 21:23:08 -04:00
SatoMew
ac7263b1ad
Update comments related to Swift and Substitute checks (#380) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-08-11 21:22:57 -04:00
Chatot4444
8b19405590
Replace Hard-Coded Number With Constant (#381) 
Replace a hard coded $a in CheckMapForMon with NUM_WILDMONS
 2022-08-11 07:51:18 -05:00
Chatot4444
8f369bfaee Replace Hard-Coded Number With Constant 
Replace a hard coded $a in CheckMapForMon with NUM_WILDMONS
 2022-08-11 07:50:11 -05:00
Rangi
423f56c284 Fix some whitespace 2022-08-07 00:40:22 -04:00
Rangi
72b5656305 Clarify how Metronome picks a move 2022-07-26 00:02:05 -04:00
Rangi
498da6ab09 Clarify how Metronome picks a move 2022-07-26 00:01:21 -04:00
Rangi
96656fdc69 Identify some .asm_* labels 2022-07-10 21:27:24 -04:00
Rangi
8f81e71f19 Identify some .asm_* labels 2022-07-10 21:11:03 -04:00
Rangi
a66adbcc5c Sync Pokédex rating text with pokeyellow 2022-07-10 19:26:18 -04:00
Rangi
927b5a4700 Identify Pokédex rating text 2022-07-10 19:16:17 -04:00
Colton G. Rushton
c0085ea1b2
wOAMBuffer -> wShadowOAM (#95) 2022-07-09 17:18:20 -04:00
Colton G. Rushton
cc46b0e510
wOAMBuffer -> wShadowOAM (#370) 2022-07-09 17:18:18 -04:00
vulcandth
69e9d359e5
party_struct constants and ExchangeBytes size (#91) 
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-07-04 01:08:19 -04:00
vulcandth
70cbb48328
party_struct constants and ExchangeBytes size (#364) 
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-07-04 01:08:17 -04:00
vulcandth
fcd6e5a1b2
Stop_reducing_move_anim_flashing_Dream_Eater -> Stop_reducing_move_anim_flashing_Blizzard (#369) 2022-06-30 21:24:33 -04:00
vulcandth
d3bdb249af
VC ExchangeBytes Aliases (#90) 
Co-authored-by: aaaaaa123456789 <aaaaaa123456789@acidch.at>
 2022-06-22 20:15:59 -04:00
vulcandth
610ec0fd22
VC ExchangeBytes Aliases (#363) 
Co-authored-by: aaaaaa123456789 <aaaaaa123456789@acidch.at>
 2022-06-22 20:15:58 -04:00
Rangi
46aeb3012f cp MR_FUJIS_HOUSE -> cp POKEMON_TOWER_7F + 1 2022-06-17 22:58:48 -04:00
Rangi
4e96f9d232 cp MR_FUJIS_HOUSE -> cp POKEMON_TOWER_7F + 1 
Fixes #362
 2022-06-17 22:58:46 -04:00
vulcandth
10cfe09034
Rename SLP to SLP_MASK (#89) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-06-17 22:25:53 -04:00
vulcandth
edb55e00f8
Rename SLP to SLP_MASK (#361) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-06-17 22:25:52 -04:00
vulcandth
c1ef7b7597
RGBDS syntax updates (#86) 
New MACRO and DEF syntax
 2022-06-06 17:25:34 -04:00
vulcandth
6b5be9129c
RGBDS syntax updates (#358) 
New MACRO and DEF syntax
 2022-06-06 17:25:31 -04:00
vulcandth
85c97397c3
Improved Virtual Console patch identifiers (#85) 2022-06-06 17:22:38 -04:00
vulcandth
d7808d110f
Improved Virtual Console patch identifiers (#357) 2022-06-06 17:22:34 -04:00
vulcandth
a7fb0998b6
Add hSerialConnectionStatus vc_assert (#83) 2022-04-17 14:44:58 -04:00
vulcandth
0fd9ba5670
Add hSerialConnectionStatus vc_assert (#354) 2022-04-17 14:44:57 -04:00
Alberto Leal
0192d594cc
Identify local labels for OptionsMenu_TextSpeed (#76) 2022-04-08 17:03:26 -04:00
vulcandth
fbaa5c9d4b
Build the Virtual Console patch with make yellow_vc (#80) 2022-03-26 22:05:06 -04:00
vulcandth
fe8d3c51a4
Build the Virtual Console patches with make red_vc and make blue_vc (#351) 2022-03-26 16:59:36 -04:00
Rangi
be03e53465 Gen 1's Minimize graphic was not a complete 8x8 tile 2022-03-04 18:22:46 -05:00
Rangi
7e78c1171d Gen 1's Minimize graphic was not a complete 8x8 tile 2022-03-04 18:21:12 -05:00
Rangi
7574e186e7 Merge remote-tracking branch 'remotes/pokered/master' 2021-11-23 21:19:29 -05:00
Rangi
09e92c554c Use ~X instead of $ff ^ X 2021-11-23 21:00:07 -05:00
Yoann Fievez
f68af5c6e9
Add some constants for options (#344) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2021-11-05 19:45:09 -04:00
Yoann Fievez
8349bfd8e6
Refactorize check button pressed (#340) 2021-11-05 15:40:15 -04:00
Rangi
2ee8ce26da Comment on the CooltrainerFAI bug 
Fixes #308
 2021-11-03 17:07:08 -04:00
Rangi
58d08bff43 Identify some percentage constant values 2021-11-02 19:57:08 -04:00
Daniel Harding
70baa4f3e8
Identify starter pikachu happiness boost medicine check (#72) 2021-11-02 19:34:35 -04:00
dannye
501a21fa5d Merge branch 'master' of https://github.com/pret/pokered 2021-09-26 22:43:09 -05:00
Amber Brault
30acb46b98
Fix typos (#334) 2021-09-26 21:57:55 -05:00
Rangi
7ee8a6509e wcf4b -> wStringBuffer 2021-08-28 17:02:20 -04:00
SnorlaxMonster
b6e0d649e7 Correct comments on SwitchAndTeleportEffect 
The comments in the SwitchAndTeleportEffect section incorrectly stated
that the random number was generated in the
half-open interval [0, playerLevel + enemyLevel),
instead of the closed interval [0, playerLevel + enemyLevel].
 2021-06-19 21:56:40 +10:00
SnorlaxMonster
319c29c751 Correct comments on SwitchAndTeleportEffect 
The comments in the SwitchAndTeleportEffect section incorrectly stated
that the random number was generated in the
half-open interval [0, playerLevel + enemyLevel),
instead of the closed interval [0, playerLevel + enemyLevel].
 2021-06-14 21:47:19 +10:00
Rangi
7d4ec90538 Some miscellaneous changes, syncing more with pokered 2021-05-31 19:40:14 -04:00
Rangi
1caab64abe Clean up Yellow's WRAM 2021-05-31 19:16:44 -04:00
dannye
7a23e2a635 Merge branch 'master' of https://github.com/pret/pokered 2021-05-31 16:51:45 -05:00
Rangi
f9ae7b1240 More WRAM label cleanup (still needs UNIONs and renaming) 2021-05-31 16:25:16 -04:00
Rangi
c2ad19728a Reformat MoveBoulderDustFunctionPointerTable 2021-05-31 13:09:33 -04:00
Rangi
1e58df98af Improve some RAM formatting 2021-05-31 11:46:13 -04:00
Rangi
8701ef4d61 Improve some RAM formatting 2021-05-31 11:46:10 -04:00
Rangi
b3eadb3508 Merge remote-tracking branch 'remotes/pokered/master' 2021-05-30 17:34:50 -04:00
Rangi
198795bbb0 Merge remote-tracking branch 'remotes/pokered/master' 2021-05-23 22:09:45 -04:00
Rangi
346ce9454a Use macros for bit arrays 2021-05-23 22:09:02 -04:00
Rangi
05925cba37 Merge remote-tracking branch 'remotes/pokered/master' 2021-05-09 12:56:39 -04:00
Rangi
c8626595b4 Use BANK("Pics #") for Pokémon and trainer pics 2021-05-06 23:04:00 -04:00
dannye
0cbd5acb76 Merge branch 'master' of https://github.com/pret/pokered 2021-04-30 14:03:34 -05:00
Rangi
6a31663c96 Use {interpolation} to generate sequences of RAM labels 
Fixes #319
 2021-04-27 15:49:59 -04:00
Rangi
3a97ec326c Use pokecrystal's sine_table macro 2021-04-18 15:51:07 -04:00
dannye
d4154b2891 Merge branch 'master' of https://github.com/pret/pokered 2021-04-17 21:00:28 -05:00
Rangi
dd690920c9 Use rgbds 0.5.0 features: 
- FOR loops
- {interpolation}
- REDEF EQUS
- \# for all macro args
 2021-04-17 19:06:56 -04:00
Rangi
a108185620 Merge remote-tracking branch 'remotes/pokered/master' 2021-04-13 20:11:29 -04:00
Rangi
4b64b146e4 Use assertions to catch the GetName bug, and use a NAME_BUFFER_LENGTH constant 2021-04-13 20:08:38 -04:00
dannye
3af309e805 Merge branch 'master' of https://github.com/pret/pokered 2021-04-13 17:48:44 -05:00
Rangi
3ce276892c Trim extra newlines from some files 2021-04-08 12:51:33 -04:00
Rangi
2954013da1 Trim extra newlines from some files 2021-04-08 12:51:25 -04:00
dannye
fa206ce835 Fix incorrect sfx id 
AUDIO_1 is loaded during trade animations, not AUDIO_2
 2021-03-30 01:03:30 -05:00
dannye
eb47bda8ee Merge branch 'master' of https://github.com/pret/pokered 2021-03-25 17:39:44 -05:00
Rangi
95ec2cf039 Verify data table and name list sizes with assertion macros 
Fixes #312
 2021-03-25 16:44:41 -04:00
dannye
780931886d Merge branch 'master' of https://github.com/pret/pokered 2021-02-21 11:50:23 -06:00
dannye
5c9c7bf362 Clean up handling of extra effective status effects 2021-02-21 11:43:38 -06:00
Rangi
95353fdefa Identify hUILayoutFlags 2021-02-13 19:48:34 -05:00
Rangi
205fd1ac81 Identify hUILayoutFlags and hPikachuSpriteVRAMOffset 2021-02-13 19:48:21 -05:00
AriaHiro64
b6ec1cd884
Proper translation comments in debug_menu.asm 2021-02-05 13:06:17 -05:00
dannye
2654da5d15 Merge branch 'master' of https://github.com/pret/pokered 2020-12-15 11:05:12 -06:00
SatoMew
5d9957293c Delete unnecessary comment 2020-11-29 22:47:51 +00:00
SatoMew
083cb38e33 Update related tile animation constants 2020-11-29 21:28:38 +00:00
SatoMew
242b2e05cf Label and document hFFD7 more accurately 2020-11-29 20:17:29 +00:00
Rangi
6adbaefde1 Keep wGrassMons and wWaterMons together with a UNION 2020-11-28 17:11:12 -05:00
dannye
48dc6a8cf4 Merge branch 'master' of https://github.com/pret/pokered 2020-11-14 21:54:23 -06:00
dannye
66377fca32 Fix file modes 2020-11-14 20:52:10 -06:00
Rangi
b88572fbcc Add constants for player and rival starters 2020-11-13 11:10:03 -05:00
dannye
ead36b7ba2 Fix typo 2020-11-07 21:12:03 -06:00
dannye
70ec534467 Use more joypad constants 2020-11-07 21:07:31 -06:00
dannye
afc4ce2dc5 Use more joypad constants 2020-11-07 21:07:07 -06:00
dannye
c501e663f5 Add label for unknown debug byte 2020-11-07 20:53:32 -06:00
dannye
88967a2323 Finish debug yellow 2020-11-07 20:15:28 -06:00
dannye
453107ab8a More debug yellow 
only debug menu left
 2020-11-07 14:35:40 -06:00
Rangi
0da16c1625 Use STARTER1 and STARTER2 for the title screen 2020-11-07 10:27:03 -05:00
dannye
989545f0e0 Start disassembling debug yellow 
non matching
 2020-11-06 23:11:17 -06:00
Rangi
45eaaf835c Identify wSpriteStateData[12] offset uses 2020-11-06 11:01:21 -05:00
Rangi
62f64aa793 Define OAM_HIGH_PALS for %100 in OAM attributes 2020-11-06 10:47:36 -05:00
Rangi
4efb3e307c Sync more with pokered 2020-11-06 10:34:05 -05:00
Rangi
13d4d533f7 Sync more with pokeyellow 2020-11-06 10:33:58 -05:00
Rangi
3de7ab601d Sync more with pokered 2020-11-05 16:55:42 -05:00
Rangi
e16dec874a Sync more with pokeyellow 2020-11-05 16:55:39 -05:00
Rangi
ed7a2d49d7 Remove trailing whitespace 2020-11-05 15:17:48 -05:00
Rangi
2a4b8b5a24 Remove trailing whitespace 2020-11-05 15:17:39 -05:00
Rangi
472f5824a6 Sync more with pokered 2020-11-05 15:15:37 -05:00
Rangi
2db54ecb9b Sync more with pokeyellow 2020-11-05 13:23:57 -05:00
Rangi
5d57fec783 Remove unused RG/RB graphics 2020-11-05 11:04:52 -05:00
Rangi
379a563c43 All battle back pictures end with "b" 2020-11-05 11:04:20 -05:00
Rangi
6fe56af2cd Organize home and macro code 2020-11-05 10:51:02 -05:00
Rangi
d3e81422d5 Sync home and macro code with pokeyellow 2020-11-05 10:50:30 -05:00
Rangi
aae999f72b Start reorganizing pokeyellow 2020-11-04 19:44:31 -05:00
Rangi
abaf9fee7c Port some formatting from pokeyellow 2020-11-04 16:31:47 -05:00
dannye
5647ca687b Sync with pokered 2020-11-04 00:06:44 -06:00
Rangi
bc287b9b80 Some formatting changes 2020-10-19 20:26:35 -04:00
Rangi
53fcd05aa2
Merge pull request #55 from Deokishisu/patch-1 
Label Unknown Entries in HappinessChangeTable
 2020-10-04 15:40:00 -04:00
SatoMew
8d359d48ba Add constant for ghost Marowak like pokered 2020-09-27 00:26:11 +01:00
SatoMew
2ff7b40d82 Replace ghost Marowak's ambiguous constant 2020-09-22 18:38:29 +01:00
Deokishisu
0df8594e46
Label Unknown Entries in HappinessChangeTable 
The two unknown entries in the HappinessChangeTable for Pikachu appear to be when the starter Pikachu faints to an opponent Pokemon 30 levels higher (PIKAHAPPY_CARELESSTRAINER) and when the starter Pikachu is traded away (PIKAHAPPY_TRADE). I have labelled them in the comments like the other fields.
 2020-09-17 22:27:49 -04:00
Rangi
8ce20e5c31 Define a constant for the ghost Marowak (hard-coded throughout the engine, like the starters) 2020-08-31 10:58:41 -04:00
Rangi
bfd9f617c9 Use constants to delineate map types, and factor out more data 2020-08-31 10:23:19 -04:00
Rangi
6ee9cb9f97 Document more hidden object data and behavior 2020-08-30 15:45:41 -04:00
Rangi
407b813250 Separate splash screen, intro, and credits (like pokegold/pokecrystal) 2020-08-28 09:54:57 -04:00
Rangi
f82097b894 Identify some map object related constants 2020-08-17 14:22:27 -04:00
Rangi
204bf74a7f Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1) 2020-07-21 19:46:12 -04:00
Rangi
69788c536b Add comments associating constants with data, and identify some more data 2020-07-20 12:31:35 -04:00
Rangi
76289dfda0 Port dbsprite macro for OAM y,x,tile,attr data from pokecrystal 2020-07-17 15:58:06 -04:00