Commit Graph

67 Commits

Author SHA1 Message Date
dannye
0f3c9354a9 Avoid magic numbers for most CopyData calls (#542) 2025-11-25 22:54:43 +00:00
Rangi42
266074c0c1 Use more hardware and graphics constants (#532)
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 20:18:49 +00:00
Rangi42
cf35ddabaf Revise some RAM buffer constants 2025-09-26 20:59:42 +00:00
Rangi42
f7eca25494 Clean up home/copy2.asm (#531)
* Use `SCREEN_WIDTH`, rename loop, and remove obsolete comment in `ClearScreenArea`

* Use `SCREEN_HEIGHT` and `lb` in `CopyScreenTileBufferToVRAM`

* Use `SCREEN_AREA` in `ClearScreen`
2025-09-10 19:49:51 +00:00
Rangi42
7657950bff Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 15:57:25 +00:00
Rangi42
3c757b1cf0 List end markers (-1 aka $FF) are not part of table data 2025-08-13 19:12:59 +00:00
Rangi42
3de40a562d Update hardware.inc to 5.3.0 and use its JOYP_SGB_* constants 2025-08-11 19:48:00 +00:00
Rangi42
16acb4f1fb Update hardware.inc to 5.2.0 2025-07-22 13:13:35 +00:00
Rangi42
d8738435bf Use less generic labels for party finding loops (#514) 2025-07-07 23:01:29 +00:00
dannye
9fb3ddc1b2 Require RGBDS 0.9.3 for its DMG palette specs (#513) 2025-07-03 00:19:11 +00:00
Rangi42
961b5ad7be Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 16:49:32 +00:00
Rangi42
1a353dcd61 Distinguish single trainer pics section from Pokemon pics 2025-06-26 04:02:02 +00:00
dannye
59c0dee03e Fix typos 2025-06-04 04:50:52 +00:00
Rangi42
700a18e52b Add a CANNOT_MOVE constant (#508) 2025-05-31 19:10:17 +00:00
Rangi42
484ab2a9f2 Rename Green1/2/3 to Rival1/2/3 for consistency 2025-04-20 14:42:38 +00:00
dannye
652641b0c5 Use constants in PrintBCDNumber calls (#503) 2025-04-09 03:18:34 +00:00
Rangi42
5f7b4e1b36 Use constants for PP masks instead of magic numbers (#504) 2025-04-02 14:50:26 +00:00
Rangi42
c3ea02b086 Fix some label typos, and add some constants instead of raw numbers (#492) 2025-01-30 22:28:00 +00:00
Rangi42
310a5d97e0 Consistently refer to CGB, not GBC (#491) 2025-01-30 22:14:47 +00:00
Rangi42
daca963007 Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-29 04:32:15 +00:00
Rangi42
30fc246ed7 Correct wTileMapBackup declared space (#487) 2025-01-28 17:09:21 +00:00
Rangi42
46f1627f5f Use exported constants for VC patch (#483) 2024-12-27 18:11:18 +00:00
Rangi42
22db77018d Don't pass redundant label names to table_width and list_start (#484) 2024-12-27 17:53:29 +00:00
Rangi42
20576b0b80 Use RGBDS 0.9.0 (#482) 2024-12-26 02:25:30 +00:00
Rangi42
a645bb099f FreezeEnemyTrainerSprite -> SetEnemyTrainerToStayAndFaceAnyDirection 2024-10-07 16:04:26 +00:00
Rangi42
67e8be05d6 dbsprite is the wrong macro for WriteOAMBlock data (#472) 2024-09-29 22:55:36 +00:00
dannye
5a337a4018 This byte is written to, but not used (#471)
it's written to in init_player_data.asm

```
	ld hl, wObtainedBadges
	ld [hli], a
	ld [hl], a
```
2024-09-26 03:03:15 +00:00
Rangi42
2d96359563 Identify wCurrentMapScriptFlags bits (#467) 2024-09-24 15:40:43 +00:00
Rangi42
7d65b6cbf6 Identify hardware register bits (#469) 2024-09-24 14:49:03 +00:00
Rangi42
91ef44a568 Identify more flag bits (#464) 2024-09-24 03:52:37 +00:00
Rangi42
14d6e42395 Identify remaining uses of wd0b5 and wd11e (#463) 2024-09-19 01:42:55 +00:00
Rangi42
3444289b57 Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-19 01:02:23 +00:00
Rangi42
d1c6682d5b Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 17:50:25 +00:00
Rangi42
77656d7537 Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 16:22:56 +00:00
Rangi42
39b09fa28f Identify various flag labels and bit constants (#454) 2024-07-16 17:03:54 +00:00
Rangi42
095c7d7227 Build with RGBDS 0.8.0, though it is not yet required 2024-06-28 20:13:33 +00:00
Rangi42
ce77a33575 Identify some unused WRAM variables (#453) 2024-06-15 16:18:42 +00:00
Rangi42
b5bf00e104 Update to RGBDS 0.7.0 (#447) 2024-01-03 15:59:52 +00:00
dannye
dd013130d3 Clean up item comments (#443) 2023-12-19 00:31:11 +00:00
Rangi42
437ab7a940 Get rid of wEvosMoves, MAX_EVOLUTIONS, and EVOLUTION_SIZE
Fixes #430
2023-11-22 01:34:17 +00:00
Rangi42
c7890aa70a Identify wSavedCoordIndex and its other usages 2023-11-20 23:54:46 +00:00
Rangi42
54f3a49013 Identify the unnamed HRAM variables and one WRAM label (#438) 2023-11-20 22:24:05 +00:00
dannye
22d1c961eb Name 2 unnamed labels I missed in SeafoamIslandsB4F and PokemonMansion3F (#437) 2023-11-19 23:38:34 +00:00
dannye
43de270d4b Name unnamed labels in seafoam islands and pokemon mansion script files (#435)
* Update PokemonMansion1F.asm

* Name unnamed seafoam/mansion labels
2023-11-19 21:10:11 +00:00
dannye
a5634d399a Fix HallOfFake typo 2023-11-19 19:18:31 +00:00
dannye
92da5318e3 Fix Celedon typo 2023-11-19 18:35:33 +00:00
Rangi42
1b8bf4fd7e Identify more map script labels 2023-11-19 00:46:03 +00:00
vulcandth
a9eea15048 Add constants for wMapConnections bits and group map header wram labels
* Add constants for wMapConnections bits

* Apply Vulcandth and Rangi42 feedback

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 18:51:09 +00:00
dannye
966b3ed511 CI copy .map files to symbols branch (#428) 2023-08-26 15:11:50 +00:00
Rangi42
312388188b Thoroughly document debug code (#410) 2023-07-15 22:37:40 +00:00