Commit Graph

573 Commits

Author SHA1 Message Date
mid-kid
09d2148d6d
Use separate constants for wChosenCableClubRoom (#144)
Some checks failed
CI / build (push) Has been cancelled
CI / build-macos (push) Has been cancelled
These numbers aren't related to the LINK_ values at all, it's just a
coincidence.

Changing these is an easy way for games to force incompatibility with
the original game.
2026-02-08 13:47:25 -05:00
Rangi
a3dd44d76e Use hardware.inc OAM offset constants for overworld map objects 2026-01-20 19:12:08 -05:00
Jordan Moore
be1ddee94d Replace magic numbers with constants in engine/battle/ai/switch.asm (#1216) 2026-01-20 19:09:39 -05:00
SourApple
ba069a1fad Bug: AI use of Full Heal or Full Restore does not cure Attack or Speed drops from burn or paralysis
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-01-20 19:08:34 -05:00
Pyrois81
d80786f4e8 Mention another bug in the catching formula 2026-01-20 19:05:53 -05:00
Rangi
d2c9e2d74f
Use features of RGBDS 1.0.0 (#138)
Some checks are pending
CI / build (push) Waiting to run
2025-11-12 15:44:00 -05:00
Linus Unnebäck
b8ed9517ab
Make wBargainShopFlags 16 bits (#137)
Some checks failed
CI / build (push) Has been cancelled
2025-09-06 16:47:47 -04:00
Rangi
fd52552151
Use dname macro to automatically pad names with "@" characters (#135)
Some checks failed
CI / build (push) Has been cancelled
2025-08-17 09:48:06 -04:00
Linus Unnebäck
9b3df7e0d6
Inline NoSwarmWildmon label (#134)
Some checks failed
CI / build (push) Has been cancelled
2025-08-15 16:08:50 -04:00
Rangi42
33df401392 Identify JOYP_SGB_MLT_REQ constant
Some checks failed
CI / build (push) Has been cancelled
2025-08-11 16:36:33 -04:00
Rangi42
a17b2c580e Update hardware.inc to 5.3.0 and use its new constants
Some checks are pending
CI / build (push) Waiting to run
2025-08-11 15:56:17 -04:00
Rangi42
58b9a05a1f Use combined joypad masks
Some checks failed
CI / build (push) Has been cancelled
2025-06-30 12:47:34 -04:00
Rangi42
b03ba1a549 Update hardware.inc to 5.1.0 2025-06-30 12:47:34 -04:00
Rangi
f57be98873
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#130) 2025-06-23 09:11:35 -04:00
Rangi42
9a798b0137 Use offsets from ANIM_* constants for wBattleAfterAnim (formerly wNumHits) 2025-05-31 15:22:54 -04:00
Rangi42
4be4d4708e Define constants for wBillsPCPokemonList entries 2025-05-31 15:17:06 -04:00
Rangi42
24db8a0183 Add a CANNOT_MOVE constant 2025-05-31 15:12:11 -04:00
Rangi42
897dda77bd Verify the battle BG effect pointer table length
Some checks failed
CI / build (push) Has been cancelled
2025-03-15 01:22:56 -04:00
Rangi42
a7fb4e069e Sync further with pokecrystal 2025-03-15 01:03:21 -04:00
Rangi42
bd94c01a44 Verify the trade dialog pointer table length 2025-03-15 00:49:22 -04:00
Rangi42
5032f98fac Verify the mart types pointer table length 2025-03-15 00:44:27 -04:00
Rangi42
81a1dc3e18 Use SIZEOF/STARTOF from RGBDS 0.7.0 2025-03-15 00:39:08 -04:00
Rangi42
83e31d7c07 Correct wrong and misleading comments about enemy trainer AI 2025-03-14 23:13:09 -04:00
Rangi42
359d7ae325 Separate constants for name types and naming screen types 2025-03-14 21:44:48 -04:00
Rangi42
2571edf37b Avoid using EQUS when EQU or MACRO will do 2025-03-14 21:38:49 -04:00
Rangi42
44226aa43d Add assert to note _CGB_Diploma also loads PartyMenuOBPals 2025-03-14 21:31:52 -04:00
Rangi42
1a7bc6b1f5 Remove "skip" prefix from AI move score labels
Some checks failed
CI / build (push) Has been cancelled
2024-12-29 15:33:40 -05:00
Rangi
3affb23969
Don't pass redundant label names to table_width and list_start (#126) 2024-12-27 12:35:41 -05:00
Rangi
bcb1092774
Use RGBDS 0.9.0 (#124)
Some checks failed
CI / build (push) Has been cancelled
2024-12-25 21:24:31 -05:00
Jordan Moore
990f43865b Rename checkcurl to checkrollout 2024-12-25 12:05:58 +01:00
Rangi42
0388785af8 Use SERIAL_RNS_LENGTH in _BattleRandom
Some checks failed
CI / build (push) Has been cancelled
2024-12-21 21:05:39 -05:00
Sylvie
201d12d44e
Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F (#123)
Some checks failed
CI / build (push) Has been cancelled
2024-11-30 17:25:26 -05:00
Rangi42
3257bc1924 Add documentation for HideHeadbuttTree
Some checks failed
CI / build (push) Has been cancelled
2024-11-28 22:03:14 -05:00
Rangi42
9b19999aee Some formatting cleanup 2024-11-28 22:02:24 -05:00
Sylvie
7ebc4324db
Identify more bit flags (#120)
Some checks are pending
CI / build (push) Waiting to run
2024-11-28 14:50:00 -05:00
Rangi42
8e9706d8a4 Fix AI_Smart_Curse labels
Some checks failed
CI / build (push) Has been cancelled
2024-10-17 17:28:27 -04:00
Rangi42
b1e3ef3b45 Update mislabeled sweet_scent.asm subroutine 2024-10-17 17:20:57 -04:00
Rangi42
fe8254c900 Rename dt and dd to bigdt and bigdd
Some checks are pending
CI / build (push) Waiting to run
This makes their big-endianness obvious and matches `dw`
2024-10-17 14:56:47 -04:00
vulcandth
00fa23fdb1 Use NUM_TRAINER_ATTRIBUTES const in AI scoring Layers 2024-07-27 22:13:19 -05:00
Rangi42
10552c2e39 Consolidate the duplicate stat level data files 2024-06-12 13:14:01 -04:00
Sylvie
98d728262f
Identify various "????"s (#116) 2024-06-11 20:54:43 -04:00
Rangi42
0d3575ce8e Rename wram_constants.asm to ram_constants.asm 2024-05-22 21:07:42 -04:00
Rangi42
3ea3640e1f wPrinterQueueLength values are divisible by 2 2024-05-22 21:02:56 -04:00
Rangi42
1675a00a42 Use constants for VBlank handlers 2024-05-22 21:02:56 -04:00
Idain
a62dfe8548 Add more assert cases in the codebase (pret/pokecrystal#1115)
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
2024-04-27 12:23:02 -05:00
SnorlaxMonster
144133d98e Rename MON_ID to MON_OT_ID (pret/pokecrystal#1114)
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2024-04-27 12:21:32 -05:00
vulcandth
202797a008 Fix/update sprite y-coord offscreen definitions (pret/pokecrystal#1108) 2024-04-14 16:09:18 -05:00
xCrystal
257d56018d Address PR suggestions (#1078) 2024-01-30 00:42:08 +01:00
xCrystal
df10c9ea1a Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-30 00:41:51 +01:00
xCrystal
59642837e9 more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-30 00:41:00 +01:00