Commit Graph

235 Commits

Author SHA1 Message Date
CreamElDudJafar
4c7ce81527
Document SFX event bug inside Rocket Hideout B1F (#566) 2026-01-17 16:41:04 -05:00
Rangi
0e49aef88e
Use macros to enforce "hidden object" constraints, and rename them to "hidden events" (#559) 2026-01-07 22:05:37 -05:00
Rangi
fe1e76466b
Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" (#557) 2026-01-07 22:05:20 -05:00
Narishma-gb
e9d3324bc0
Comment more unreferenced local labels (#550) 2025-12-15 15:14:17 -05:00
Narishma-gb
3a4382c605
Use more Pokemon data constants, create MOVE_NAME_LENGTH (#543)
Some checks failed
CI / build (push) Has been cancelled
2025-11-27 13:39:25 -05:00
Narishma-gb
f332678625
Use more hardware and graphics constants (#532)
Some checks failed
CI / build (push) Has been cancelled
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
Rangi
5943b96cf6
Use features of RGBDS 1.0.0 (#537)
Some checks are pending
CI / build (push) Waiting to run
2025-11-12 15:44:07 -05:00
PokefanMarcel
b49679165e
Document visual glitch with Pewter City Gym guy (#526)
Some checks failed
CI / build (push) Has been cancelled
2025-09-03 12:01:15 -04:00
Narishma-gb
4d2594cb24
Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Rangi42
c51d1b7a1d List end markers (-1 aka $FF) are not part of table data
Some checks failed
CI / build (push) Has been cancelled
2025-08-13 15:09:12 -04:00
kagnusdev
e2f7c5cb73
Use hardware constants for tile attributes in VermilionDockOAMBlock (#516)
Some checks failed
CI / build (push) Has been cancelled
2025-07-11 17:36:45 -04:00
Rangi42
78e44a8fb1 Use combined hardware constants 2025-06-30 13:45:24 -04:00
Rangi
56c405de09
Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
Narishma-gb
0ecc36c83a
Use constants in PrintBCDNumber calls (#503)
Some checks failed
CI / build (push) Has been cancelled
2025-04-08 22:17:32 -05:00
Narishma-gb
43f21cc494
Fix some label typos, and add some constants instead of raw numbers (#492)
Some checks failed
CI / build (push) Has been cancelled
2025-01-30 17:26:55 -05:00
Rangi
ec37f6117d
Consistently capitalize ASSERT directives (#489)
Some checks failed
CI / build (push) Has been cancelled
2025-01-28 23:31:27 -05:00
Rangi
afb8990169
Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Rangi
cd647df3b5
Don't pass redundant label names to table_width and list_start (#484) 2024-12-27 12:52:24 -05:00
Rangi42
f92ebdcfbd Let CheckEitherEventSet reuse A like CheckBothEventsSet
Some checks failed
CI / build (push) Has been cancelled
2024-12-16 10:44:44 -05:00
Vortyne
1aa3fb24ec
dbsprite is the wrong macro for WriteOAMBlock data (#472) 2024-09-29 18:54:41 -04:00
Sylvie
635b9c4cab
Identify wCurrentMapScriptFlags bits (#467) 2024-09-24 11:39:44 -04:00
Sylvie
b5d2540e7c
Identify more bit flags (#465)
* Identify more bit flags

* Space
2024-09-24 09:33:33 -04:00
Sylvie
8f1dcf07e5
Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie
5a622f628d
Identify remaining uses of wd0b5 and wd11e (#463) 2024-09-18 21:41:58 -04:00
Sylvie
613d34678b
Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Sylvie
77d051479b
Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 10:05:33 -04:00
Sylvie
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 12:21:59 -04:00
Sylvie
8fafca714c
Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
Sylvie
fc23e72a39
Identify some unused WRAM variables (#453) 2024-06-15 12:18:00 -04:00
dannye
3c76871600 Fix some map text constants 2023-11-21 20:25:12 -06:00
dannye
d3e713f6c6 Fix event check 2023-11-20 21:03:38 -06:00
Rangi42
77887be251 Identify wSavedCoordIndex and its other usages 2023-11-20 18:53:23 -05:00
Vortyne
3bbd38aa15
Name 2 unnamed labels I missed in SeafoamIslandsB4F and PokemonMansion3F (#437) 2023-11-19 17:37:59 -06:00
dannye
7d2dde5c84 Fix incorrect fallthrough comment 2023-11-19 16:24:11 -06:00
dannye
e7f94cc520 Fix inconsistent object const names 2023-11-19 16:03:49 -06:00
Vortyne
5739aea990
Name unnamed labels in seafoam islands and pokemon mansion script files (#435)
* Update PokemonMansion1F.asm

* Name unnamed seafoam/mansion labels
2023-11-19 15:09:33 -06:00
dannye
4ac6f54c67 Fix HallOfFake typo 2023-11-19 13:17:51 -06:00
dannye
9f2d6aa0a8 Fix Celedon typo 2023-11-19 12:33:30 -06:00
Rangi42
26a342b104 Identify more map script labels 2023-11-18 19:44:03 -05:00
Linus Unnebäck
83b373ad73
Add constants for wMapConnections bits and group map header wram labels
* Add constants for wMapConnections bits

* Apply Vulcandth and Rangi42 feedback

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 12:50:27 -06:00
Vortyne
9a780d4501
Missing usage of def_script_pointers (#423) 2023-08-26 10:08:59 -05:00
SatoMew
f46db37d50
Thoroughly document debug code (#410) 2023-07-15 18:36:59 -04:00
vulcandth
d001ced41b
Add macros, constants, and labels for map scripts and text (#367)
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
2023-07-13 21:27:56 -04:00
Rangi
3520a4c99a Distinguish Elite 4 "meta" constants from event constants
Fixes #390
2022-09-15 18:10:45 -04:00
Rangi
bbb0e7e82d
Use the same music headers as pokecrystal (#382) 2022-08-11 21:23:08 -04:00
Colton G. Rushton
cc46b0e510
wOAMBuffer -> wShadowOAM (#370) 2022-07-09 17:18:18 -04:00
Rangi
09e92c554c Use ~X instead of $ff ^ X 2021-11-23 21:00:07 -05:00
Daniel Harding
f3dbec09a8
Merge pull request #325 from CelestialAmber/master
Partially document CeruleanCity.asm
2021-05-31 15:43:57 -05:00
Daniel Harding
c5bb400e08
Merge pull request #323 from KqesaR/master
Clean many labels of scripts of gyms
2021-05-31 15:42:41 -05:00
Rangi
f9ae7b1240 More WRAM label cleanup (still needs UNIONs and renaming) 2021-05-31 16:25:16 -04:00