Commit Graph

2801 Commits

Author SHA1 Message Date
SnorlaxMonster
fbcf7d0e19
Repair Iwata Asks URL (#568)
Some checks failed
CI / build (push) Has been cancelled
CI / build-macos (push) Has been cancelled
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
2026-01-24 09:00:02 -06:00
Engezerstorung
c4f02f18de
Use macros for WildMonEncounterSlotChances (#562) 2026-01-17 16:42:57 -05:00
Narishma-gb
70f654bda7
Use map names with ToggleData* symbols (#563) 2026-01-17 16:42:34 -05:00
DrNyk
4e22af12bc
Replace hard-coded numbers with constants in haze.asm (#564) 2026-01-17 16:42:12 -05:00
SnorlaxMonster
85b9d866c8
Align move grammar with pokecrystal (#565)
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
2026-01-17 16:41:37 -05:00
CreamElDudJafar
4c7ce81527
Document SFX event bug inside Rocket Hideout B1F (#566) 2026-01-17 16:41:04 -05:00
Rangi
059ae5d44c
Fix CI for Linux and add CI for macOS (#567) 2026-01-17 16:27:41 -05:00
Nishant Chatterjee
7e6fdbbda7
Do not compile tools with LTO 2026-01-07 22:09:42 -05:00
Rangi
0e49aef88e
Use macros to enforce "hidden object" constraints, and rename them to "hidden events" (#559) 2026-01-07 22:05:37 -05:00
Rangi
fe1e76466b
Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" (#557) 2026-01-07 22:05:20 -05:00
Rangi
2f76b969c3 Update RGBDS to 1.0.1 (although 1.0.0 still works) 2026-01-01 01:35:57 -05:00
Jordan Moore
0555b42dc0
Replace magic number $7 with SLP_MASK constant (#555) 2025-12-26 12:20:49 -05:00
Rangi
d79c578abd
Specify a max item length for list_start (#552)
Some checks failed
CI / build (push) Has been cancelled
2025-12-15 15:16:40 -05:00
Narishma-gb
e9d3324bc0
Comment more unreferenced local labels (#550) 2025-12-15 15:14:17 -05:00
Rangi
e1948fe4b3
Clarify how the order of map constants matters for the Town Map (#553) 2025-12-15 15:02:37 -05:00
Narishma-gb
8bb03542bd
Update StatusScreen, add *_STATS_BOX constants (#546)
Some checks failed
CI / build (push) Has been cancelled
2025-12-01 13:46:28 -06:00
Rangi
917a0ebf4d Correct comment 2025-12-01 14:13:46 -05:00
Rangi
7272d9bb8a Comment that farcall and callfar are interchangable 2025-12-01 13:58:30 -05:00
Rangi
9a6bb3ed0c
Define player and rival names once, to be used in two places (#545)
Some checks are pending
CI / build (push) Waiting to run
2025-12-01 11:00:56 -05:00
Narishma-gb
3a4382c605
Use more Pokemon data constants, create MOVE_NAME_LENGTH (#543)
Some checks failed
CI / build (push) Has been cancelled
2025-11-27 13:39:25 -05:00
Rangi
e92d1af478
Avoid magic numbers for most CopyData calls (#542)
Some checks failed
CI / build (push) Has been cancelled
2025-11-25 16:53:29 -06:00
Rangi
308189b638
Use ld_hli_a_string macro to make byte-by-byte strings more obvious (#540)
Some checks failed
CI / build (push) Has been cancelled
2025-11-23 21:19:21 -06:00
Narishma-gb
f332678625
Use more hardware and graphics constants (#532)
Some checks failed
CI / build (push) Has been cancelled
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
Rangi
70b5ab9399 Add _vc patch targets to .PHONY
Some checks failed
CI / build (push) Has been cancelled
2025-11-13 13:36:30 -05:00
Rangi
5943b96cf6
Use features of RGBDS 1.0.0 (#537)
Some checks are pending
CI / build (push) Waiting to run
2025-11-12 15:44:07 -05:00
Rangi42
8105df94a3 Use the same tools/make_patch.c as Gen 2
The `--ignore` flag is not needed in Gen 1
2025-11-12 13:42:41 -05:00
PokefanMarcel
c2d81fb598
Expand comment on _AfterTrade2Text to mention pokeyellow's changes (#536)
Some checks failed
CI / build (push) Has been cancelled
2025-11-06 14:06:33 -05:00
Rangi
e3af20b907 Consistently use ld [hli]/ld [hld], not ldi/ldd
Some checks failed
CI / build (push) Has been cancelled
2025-10-05 10:53:31 -04:00
Rangi
628797baff Revise some RAM buffer constants 2025-09-26 16:55:23 -04:00
PokefanMarcel
59da8c8122
Clean up home/copy2.asm (#531)
Some checks failed
CI / build (push) Has been cancelled
* Use `SCREEN_WIDTH`, rename loop, and remove obsolete comment in `ClearScreenArea`

* Use `SCREEN_HEIGHT` and `lb` in `CopyScreenTileBufferToVRAM`

* Use `SCREEN_AREA` in `ClearScreen`
2025-09-10 15:48:30 -04:00
PokefanMarcel
108bf2981d
Use RAMG_SRAM_ENABLE (#530)
Some checks failed
CI / build (push) Has been cancelled
2025-09-07 12:46:26 -04:00
PokefanMarcel
b49679165e
Document visual glitch with Pewter City Gym guy (#526)
Some checks failed
CI / build (push) Has been cancelled
2025-09-03 12:01:15 -04:00
Vortyne
8da7deb893
Update comment for clarity (#529)
Actually copies from battle struct to party struct to make HP and status changes to a pokemon permanent
2025-09-03 11:59:22 -04:00
Narishma-gb
4d2594cb24
Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Rangi42
d98b5e6f02 Document where badge and elevator floor "items" are used
Some checks failed
CI / build (push) Has been cancelled
2025-08-28 19:22:16 -04:00
Rangi42
fd5dc11cfd Specify file extensions that make does not generate
Some checks failed
CI / build (push) Has been cancelled
2025-08-27 11:49:46 -04:00
Narishma-gb
126c3f3366
Document a bug in PrintBenchGuyText (#523)
Some checks failed
CI / build (push) Has been cancelled
2025-08-17 10:00:34 -04:00
Rangi
5e8b835ba3
Use dname macro to automatically pad names with "@" characters (#525) 2025-08-17 09:58:09 -04:00
PokefanMarcel
31fc2e229d
Use <STAT>_UP1_EFFECT constants (#522)
Some checks are pending
CI / build (push) Waiting to run
2025-08-16 08:37:08 -04:00
Rangi42
c51d1b7a1d List end markers (-1 aka $FF) are not part of table data
Some checks failed
CI / build (push) Has been cancelled
2025-08-13 15:09:12 -04:00
Rangi42
263a35a3fb Say how many bytes the assertion macros expected vs got 2025-08-13 13:03:45 -04:00
Rangi42
1eb6f61d62 Identify JOYP_SGB_MLT_REQ constant
Some checks failed
CI / build (push) Has been cancelled
2025-08-11 16:35:07 -04:00
Rangi42
bdbc8cbd48 Update hardware.inc to 5.3.0 and use its JOYP_SGB_* constants 2025-08-11 15:43:27 -04:00
Rangi42
6f8ee8ab3c Try to catch missing commas in tmhm learnsets
Some checks failed
CI / build (push) Has been cancelled
2025-08-03 21:05:52 -04:00
Rangi42
fd86bcaa06 Update hardware.inc to 5.2.0
Some checks failed
CI / build (push) Has been cancelled
2025-07-22 09:04:52 -04:00
kagnusdev
e2f7c5cb73
Use hardware constants for tile attributes in VermilionDockOAMBlock (#516)
Some checks failed
CI / build (push) Has been cancelled
2025-07-11 17:36:45 -04:00
kagnusdev
4eaccc4a7a
Use less generic labels for party finding loops (#514)
Some checks failed
CI / build (push) Has been cancelled
2025-07-07 18:59:17 -04:00
Rangi
d6e9f53825
Require RGBDS 0.9.3 for its DMG palette specs (#513)
Some checks failed
CI / build (push) Has been cancelled
2025-07-02 19:17:19 -05:00
Rangi42
3f4b3ee96f Check limits for warp, bg, and object events 2025-07-02 18:32:31 -04:00
Rangi42
aa85c0046d Define MAX_WARP_EVENTS 2025-07-02 17:25:03 -04:00