Commit Graph

480 Commits

Author SHA1 Message Date
Narishma-gb
126c3f3366
Document a bug in PrintBenchGuyText (#523)
Some checks failed
CI / build (push) Has been cancelled
2025-08-17 10:00:34 -04:00
Rangi
5e8b835ba3
Use dname macro to automatically pad names with "@" characters (#525) 2025-08-17 09:58:09 -04:00
PokefanMarcel
31fc2e229d
Use <STAT>_UP1_EFFECT constants (#522)
Some checks are pending
CI / build (push) Waiting to run
2025-08-16 08:37:08 -04:00
Rangi42
1eb6f61d62 Identify JOYP_SGB_MLT_REQ constant
Some checks failed
CI / build (push) Has been cancelled
2025-08-11 16:35:07 -04:00
Rangi42
bdbc8cbd48 Update hardware.inc to 5.3.0 and use its JOYP_SGB_* constants 2025-08-11 15:43:27 -04:00
kagnusdev
4eaccc4a7a
Use less generic labels for party finding loops (#514)
Some checks failed
CI / build (push) Has been cancelled
2025-07-07 18:59:17 -04:00
Rangi42
78e44a8fb1 Use combined hardware constants 2025-06-30 13:45:24 -04:00
Rangi
56c405de09
Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
Rangi42
fcb61ae0e4 Distinguish single trainer pics section from Pokemon pics
Some checks failed
CI / build (push) Has been cancelled
2025-06-25 23:59:47 -04:00
dannye
fd043a66c2 Fix typos 2025-06-03 23:48:35 -05:00
Rangi
b4bae4a5d5
Add a CANNOT_MOVE constant (#508) 2025-05-31 15:08:23 -04:00
Vortyne
d7de1595c0
Fix sprite data comment (#507)
Some checks are pending
CI / build (push) Waiting to run
Reduces confusion if someone edits this file since the wrong byte was commented
2025-05-09 18:47:29 -04:00
Narishma-gb
0ecc36c83a
Use constants in PrintBCDNumber calls (#503)
Some checks failed
CI / build (push) Has been cancelled
2025-04-08 22:17:32 -05:00
SatoMew
cf73d6ee0f
Further improve NPC trade labels and comments (#493) 2025-04-08 22:17:12 -05:00
edave64
e1b7b8af0a
Use constants for PP masks instead of magic numbers (#504)
Some checks failed
CI / build (push) Has been cancelled
2025-04-02 10:49:15 -04:00
Rangi
147914d179
Use constants for trade text indexes (#501) 2025-03-08 11:16:42 -05:00
Rangi
b460637b81
Avoid using EQUS when EQU or MACRO will do (#496)
Some checks failed
CI / build (push) Has been cancelled
2025-02-27 13:07:17 -05:00
Narishma-gb
43f21cc494
Fix some label typos, and add some constants instead of raw numbers (#492)
Some checks failed
CI / build (push) Has been cancelled
2025-01-30 17:26:55 -05:00
SatoMew
79518a602e
Consistently refer to CGB, not GBC (#491) 2025-01-30 17:13:40 -05:00
Rangi
ec37f6117d
Consistently capitalize ASSERT directives (#489)
Some checks failed
CI / build (push) Has been cancelled
2025-01-28 23:31:27 -05:00
Rangi
afb8990169
Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Engezerstorung
96fc617c69
Correct wTileMapBackup declared space (#487) 2025-01-28 12:08:12 -05:00
Rangi42
f023c68417 Use EFFECT_1E
Some checks failed
CI / build (push) Has been cancelled
2024-12-27 20:27:34 -05:00
Rangi
cd647df3b5
Don't pass redundant label names to table_width and list_start (#484) 2024-12-27 12:52:24 -05:00
Rangi
cd1065b7a9
Use RGBDS 0.9.0 (#482)
Some checks failed
CI / build (push) Has been cancelled
2024-12-25 21:24:21 -05:00
Rangi42
a59c2bbaf9 Use SERIAL_RNS_LENGTH in BattleRandom
Some checks failed
CI / build (push) Has been cancelled
2024-12-21 21:04:36 -05:00
Rangi42
67084c9d26 Remove redundant parentheses 2024-12-16 10:35:55 -05:00
Rangi42
ff76bba507 Use "gray", not "grey"
This matches the in-game text, e.g. Pewter is "A Stone Gray City"
2024-12-16 10:29:59 -05:00
Sylvie
f801d67f8e
Assert the relations between some move effect constants (#478)
Some checks failed
CI / build (push) Has been cancelled
2024-11-24 19:13:11 -05:00
Vortyne
678d014aef
FreezeEnemyTrainerSprite -> SetEnemyTrainerToStayAndFaceAnyDirection 2024-10-07 12:03:26 -04:00
Vortyne
1aa3fb24ec
dbsprite is the wrong macro for WriteOAMBlock data (#472) 2024-09-29 18:54:41 -04:00
Vortyne
af36156a5b
This byte is written to, but not used (#471)
it's written to in init_player_data.asm

```
	ld hl, wObtainedBadges
	ld [hli], a
	ld [hl], a
```
2024-09-25 22:02:15 -05:00
Sylvie
635b9c4cab
Identify wCurrentMapScriptFlags bits (#467) 2024-09-24 11:39:44 -04:00
Sylvie
6ae63a8cea
Identify hardware register bits (#469) 2024-09-24 10:48:10 -04:00
Sylvie
b5d2540e7c
Identify more bit flags (#465)
* Identify more bit flags

* Space
2024-09-24 09:33:33 -04:00
Vortyne
c3f297e98b
Fix comment: Road -> Roar (#466) 2024-09-24 07:32:47 -05:00
Sylvie
8f1dcf07e5
Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie
5a622f628d
Identify remaining uses of wd0b5 and wd11e (#463) 2024-09-18 21:41:58 -04:00
Sylvie
613d34678b
Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Vortyne
1f6e2bf999
Use correct label in get_trainer_name.asm (#461) 2024-09-09 20:22:58 -04:00
Sylvie
77d051479b
Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 10:05:33 -04:00
Sylvie
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 12:21:59 -04:00
Sylvie
8fafca714c
Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
Sylvie
fc23e72a39
Identify some unused WRAM variables (#453) 2024-06-15 12:18:00 -04:00
dannye
d870ad6ea8 Fix hard-coded bank 2024-05-05 09:41:56 -05:00
Rangi
fabe2b3fb3
Update to RGBDS 0.7.0 (#447) 2024-01-03 10:59:04 -05:00
SatoMew
07cefd462f
Clean up item comments (#443) 2023-12-18 18:30:37 -06:00
colawsol
f6017ddbfd
Correct StarterDex function comment (#440) 2023-12-06 19:34:37 -06:00
vulcandth
1dcc16b347 Delete a couple EOL whitespace. 2023-11-22 15:09:21 +00:00
dannye
a247120ac1 Fix a few usages of EFFECTIVE 2023-11-21 20:18:04 -06:00