Rangi
fe1e76466b
Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" ( #557 )
2026-01-07 22:05:20 -05:00
Narishma-gb
e9d3324bc0
Comment more unreferenced local labels ( #550 )
2025-12-15 15:14:17 -05:00
Rangi
9a6bb3ed0c
Define player and rival names once, to be used in two places ( #545 )
CI / build (push) Waiting to run
2025-12-01 11:00:56 -05:00
Narishma-gb
3a4382c605
Use more Pokemon data constants, create MOVE_NAME_LENGTH ( #543 )
CI / build (push) Has been cancelled
2025-11-27 13:39:25 -05:00
Rangi
e92d1af478
Avoid magic numbers for most CopyData calls ( #542 )
CI / build (push) Has been cancelled
2025-11-25 16:53:29 -06:00
Narishma-gb
f332678625
Use more hardware and graphics constants ( #532 )
...
CI / build (push) Has been cancelled
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
Rangi
5943b96cf6
Use features of RGBDS 1.0.0 ( #537 )
CI / build (push) Waiting to run
2025-11-12 15:44:07 -05:00
Narishma-gb
4d2594cb24
Label and constant cleanup ( #528 )
...
* Label cleanup, add some constants instead of raw numbers
* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Rangi42
78e44a8fb1
Use combined hardware constants
2025-06-30 13:45:24 -04:00
Rangi
56c405de09
Replace hardware_constants.asm with hardware.inc ( #511 )
2025-06-30 12:47:22 -04:00
Narishma-gb
0ecc36c83a
Use constants in PrintBCDNumber calls ( #503 )
CI / build (push) Has been cancelled
2025-04-08 22:17:32 -05:00
Rangi
ec37f6117d
Consistently capitalize ASSERT directives ( #489 )
CI / build (push) Has been cancelled
2025-01-28 23:31:27 -05:00
Rangi
afb8990169
Miscellaneous cleanup ( #488 )
...
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Vortyne
1aa3fb24ec
dbsprite is the wrong macro for WriteOAMBlock data (#472 )
2024-09-29 18:54:41 -04:00
Vortyne
af36156a5b
This byte is written to, but not used ( #471 )
...
it's written to in init_player_data.asm
```
ld hl, wObtainedBadges
ld [hli], a
ld [hl], a
```
2024-09-25 22:02:15 -05:00
Sylvie
6ae63a8cea
Identify hardware register bits ( #469 )
2024-09-24 10:48:10 -04:00
Sylvie
b5d2540e7c
Identify more bit flags ( #465 )
...
* Identify more bit flags
* Space
2024-09-24 09:33:33 -04:00
Sylvie
5a622f628d
Identify remaining uses of wd0b5 and wd11e ( #463 )
2024-09-18 21:41:58 -04:00
Sylvie
77d051479b
Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem ( #457 )
2024-08-04 10:05:33 -04:00
Sylvie
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others ( #455 )
2024-07-24 12:21:59 -04:00
Sylvie
8fafca714c
Identify various flag labels and bit constants ( #454 )
2024-07-16 13:02:54 -04:00
Sylvie
fc23e72a39
Identify some unused WRAM variables ( #453 )
2024-06-15 12:18:00 -04:00
dannye
d870ad6ea8
Fix hard-coded bank
2024-05-05 09:41:56 -05:00
Rangi42
b066d3c9bc
Add bigdw and dc data macros
2023-11-20 17:53:19 -05:00
SatoMew
f46db37d50
Thoroughly document debug code ( #410 )
2023-07-15 18:36:59 -04:00
SatoMew
5c4795d5bc
Complete and improve debug name labels ( #408 )
2023-02-26 11:14:21 -05:00
BlueZangoose
0f5a9eb146
Change names of move subanimations to be meaningful ( #389 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-09-25 14:17:39 -04:00
Rangi
bbb0e7e82d
Use the same music headers as pokecrystal ( #382 )
2022-08-11 21:23:08 -04:00
Colton G. Rushton
cc46b0e510
wOAMBuffer -> wShadowOAM ( #370 )
2022-07-09 17:18:18 -04:00
vulcandth
6b5be9129c
RGBDS syntax updates ( #358 )
...
New MACRO and DEF syntax
2022-06-06 17:25:31 -04:00
Rangi
7ee8a6509e
wcf4b -> wStringBuffer
2021-08-28 17:02:20 -04:00
Rangi
6a31663c96
Use {interpolation} to generate sequences of RAM labels
...
Fixes #319
2021-04-27 15:49:59 -04:00
Rangi
4b64b146e4
Use assertions to catch the GetName bug, and use a NAME_BUFFER_LENGTH constant
2021-04-13 20:08:38 -04:00
SatoMew
242b2e05cf
Label and document hFFD7 more accurately
2020-11-29 20:17:29 +00:00
dannye
66377fca32
Fix file modes
2020-11-14 20:52:10 -06:00
Rangi
0da16c1625
Use STARTER1 and STARTER2 for the title screen
2020-11-07 10:27:03 -05:00
Rangi
d3e81422d5
Sync home and macro code with pokeyellow
2020-11-05 10:50:30 -05:00
Rangi
bc287b9b80
Some formatting changes
2020-10-19 20:26:35 -04:00
Rangi
8ce20e5c31
Define a constant for the ghost Marowak (hard-coded throughout the engine, like the starters)
2020-08-31 10:58:41 -04:00
Rangi
407b813250
Separate splash screen, intro, and credits (like pokegold/pokecrystal)
2020-08-28 09:54:57 -04:00
Rangi
69788c536b
Add comments associating constants with data, and identify some more data
2020-07-20 12:31:35 -04:00
Rangi
76289dfda0
Port dbsprite macro for OAM y,x,tile,attr data from pokecrystal
2020-07-17 15:58:06 -04:00
Rangi
3c1cdbc4d0
Identify remaining tilemap IDs
2020-07-17 13:47:33 -04:00
Rangi
7bcb4b19c7
Un-deduplicate gfx/intro_credits/gengar.png's tiles
2020-07-16 19:56:52 -04:00
Rangi
4b4ad9894e
Disassemble the BLUEMONS.GB debug ROM
2020-07-15 13:35:39 -04:00
Rangi
4a7d1513f3
Use 'tile' and 'tiles' macros
2020-07-07 16:21:26 -04:00
Rangi
13129459f1
Sync coordinate macros with pokecrystal
2020-07-07 11:30:10 -04:00
Rangi
45ed05decf
Use HIGH() and LOW()
2020-07-07 11:10:29 -04:00
Rangi
06db7ec55b
callba/callab -> farcall/callfar; jpba/jpab -> farjp/jpfar
2020-07-06 21:18:22 -04:00
Rangi
772fcc7588
Specify the ldh instruction, don't turn ld into ldh
2020-07-06 19:03:05 -04:00
