Commit Graph

499 Commits

Author SHA1 Message Date
DrNyk
4e22af12bc
Replace hard-coded numbers with constants in haze.asm (#564) 2026-01-17 16:42:12 -05:00
SnorlaxMonster
85b9d866c8
Align move grammar with pokecrystal (#565)
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
2026-01-17 16:41:37 -05:00
Rangi
0e49aef88e
Use macros to enforce "hidden object" constraints, and rename them to "hidden events" (#559) 2026-01-07 22:05:37 -05:00
Rangi
fe1e76466b
Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" (#557) 2026-01-07 22:05:20 -05:00
Jordan Moore
0555b42dc0
Replace magic number $7 with SLP_MASK constant (#555) 2025-12-26 12:20:49 -05:00
Rangi
d79c578abd
Specify a max item length for list_start (#552)
Some checks failed
CI / build (push) Has been cancelled
2025-12-15 15:16:40 -05:00
Narishma-gb
e9d3324bc0
Comment more unreferenced local labels (#550) 2025-12-15 15:14:17 -05:00
Narishma-gb
8bb03542bd
Update StatusScreen, add *_STATS_BOX constants (#546)
Some checks failed
CI / build (push) Has been cancelled
2025-12-01 13:46:28 -06:00
Rangi
9a6bb3ed0c
Define player and rival names once, to be used in two places (#545)
Some checks are pending
CI / build (push) Waiting to run
2025-12-01 11:00:56 -05:00
Narishma-gb
3a4382c605
Use more Pokemon data constants, create MOVE_NAME_LENGTH (#543)
Some checks failed
CI / build (push) Has been cancelled
2025-11-27 13:39:25 -05:00
Rangi
e92d1af478
Avoid magic numbers for most CopyData calls (#542)
Some checks failed
CI / build (push) Has been cancelled
2025-11-25 16:53:29 -06:00
Rangi
308189b638
Use ld_hli_a_string macro to make byte-by-byte strings more obvious (#540)
Some checks failed
CI / build (push) Has been cancelled
2025-11-23 21:19:21 -06:00
Narishma-gb
f332678625
Use more hardware and graphics constants (#532)
Some checks failed
CI / build (push) Has been cancelled
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
Rangi
5943b96cf6
Use features of RGBDS 1.0.0 (#537)
Some checks are pending
CI / build (push) Waiting to run
2025-11-12 15:44:07 -05:00
Rangi
e3af20b907 Consistently use ld [hli]/ld [hld], not ldi/ldd
Some checks failed
CI / build (push) Has been cancelled
2025-10-05 10:53:31 -04:00
Rangi
628797baff Revise some RAM buffer constants 2025-09-26 16:55:23 -04:00
PokefanMarcel
108bf2981d
Use RAMG_SRAM_ENABLE (#530)
Some checks failed
CI / build (push) Has been cancelled
2025-09-07 12:46:26 -04:00
Vortyne
8da7deb893
Update comment for clarity (#529)
Actually copies from battle struct to party struct to make HP and status changes to a pokemon permanent
2025-09-03 11:59:22 -04:00
Narishma-gb
4d2594cb24
Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Narishma-gb
126c3f3366
Document a bug in PrintBenchGuyText (#523)
Some checks failed
CI / build (push) Has been cancelled
2025-08-17 10:00:34 -04:00
Rangi
5e8b835ba3
Use dname macro to automatically pad names with "@" characters (#525) 2025-08-17 09:58:09 -04:00
PokefanMarcel
31fc2e229d
Use <STAT>_UP1_EFFECT constants (#522)
Some checks are pending
CI / build (push) Waiting to run
2025-08-16 08:37:08 -04:00
Rangi42
1eb6f61d62 Identify JOYP_SGB_MLT_REQ constant
Some checks failed
CI / build (push) Has been cancelled
2025-08-11 16:35:07 -04:00
Rangi42
bdbc8cbd48 Update hardware.inc to 5.3.0 and use its JOYP_SGB_* constants 2025-08-11 15:43:27 -04:00
kagnusdev
4eaccc4a7a
Use less generic labels for party finding loops (#514)
Some checks failed
CI / build (push) Has been cancelled
2025-07-07 18:59:17 -04:00
Rangi42
78e44a8fb1 Use combined hardware constants 2025-06-30 13:45:24 -04:00
Rangi
56c405de09
Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
Rangi42
fcb61ae0e4 Distinguish single trainer pics section from Pokemon pics
Some checks failed
CI / build (push) Has been cancelled
2025-06-25 23:59:47 -04:00
dannye
fd043a66c2 Fix typos 2025-06-03 23:48:35 -05:00
Rangi
b4bae4a5d5
Add a CANNOT_MOVE constant (#508) 2025-05-31 15:08:23 -04:00
Vortyne
d7de1595c0
Fix sprite data comment (#507)
Some checks are pending
CI / build (push) Waiting to run
Reduces confusion if someone edits this file since the wrong byte was commented
2025-05-09 18:47:29 -04:00
Narishma-gb
0ecc36c83a
Use constants in PrintBCDNumber calls (#503)
Some checks failed
CI / build (push) Has been cancelled
2025-04-08 22:17:32 -05:00
SatoMew
cf73d6ee0f
Further improve NPC trade labels and comments (#493) 2025-04-08 22:17:12 -05:00
edave64
e1b7b8af0a
Use constants for PP masks instead of magic numbers (#504)
Some checks failed
CI / build (push) Has been cancelled
2025-04-02 10:49:15 -04:00
Rangi
147914d179
Use constants for trade text indexes (#501) 2025-03-08 11:16:42 -05:00
Rangi
b460637b81
Avoid using EQUS when EQU or MACRO will do (#496)
Some checks failed
CI / build (push) Has been cancelled
2025-02-27 13:07:17 -05:00
Narishma-gb
43f21cc494
Fix some label typos, and add some constants instead of raw numbers (#492)
Some checks failed
CI / build (push) Has been cancelled
2025-01-30 17:26:55 -05:00
SatoMew
79518a602e
Consistently refer to CGB, not GBC (#491) 2025-01-30 17:13:40 -05:00
Rangi
ec37f6117d
Consistently capitalize ASSERT directives (#489)
Some checks failed
CI / build (push) Has been cancelled
2025-01-28 23:31:27 -05:00
Rangi
afb8990169
Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Engezerstorung
96fc617c69
Correct wTileMapBackup declared space (#487) 2025-01-28 12:08:12 -05:00
Rangi42
f023c68417 Use EFFECT_1E
Some checks failed
CI / build (push) Has been cancelled
2024-12-27 20:27:34 -05:00
Rangi
cd647df3b5
Don't pass redundant label names to table_width and list_start (#484) 2024-12-27 12:52:24 -05:00
Rangi
cd1065b7a9
Use RGBDS 0.9.0 (#482)
Some checks failed
CI / build (push) Has been cancelled
2024-12-25 21:24:21 -05:00
Rangi42
a59c2bbaf9 Use SERIAL_RNS_LENGTH in BattleRandom
Some checks failed
CI / build (push) Has been cancelled
2024-12-21 21:04:36 -05:00
Rangi42
67084c9d26 Remove redundant parentheses 2024-12-16 10:35:55 -05:00
Rangi42
ff76bba507 Use "gray", not "grey"
This matches the in-game text, e.g. Pewter is "A Stone Gray City"
2024-12-16 10:29:59 -05:00
Sylvie
f801d67f8e
Assert the relations between some move effect constants (#478)
Some checks failed
CI / build (push) Has been cancelled
2024-11-24 19:13:11 -05:00
Vortyne
678d014aef
FreezeEnemyTrainerSprite -> SetEnemyTrainerToStayAndFaceAnyDirection 2024-10-07 12:03:26 -04:00
Vortyne
1aa3fb24ec
dbsprite is the wrong macro for WriteOAMBlock data (#472) 2024-09-29 18:54:41 -04:00