* Feature/add support for localized versions (#3)
* Add support for gen I localizations
There currently is no way to automatically detect the localization yet though.
* Add gen1_determineGameLanguage() and use it automatically in Gen1GameReader if not specified in the constructor
* Add support for the gen II localizations
Note: for Korean games, specifically, I did not implement the Korean character set
(nor do I plan to)
The reason is that it is entirely different and more complex to implement than the other
character sets. I'm not personally invested nor interested enough to go through the hassle.
This affects the pokémon names that will be displayed when using libpokemegb. Instead as
a fallback, it will return "poke-<number>" for these roms.
Feel free to contribute proper Korean character set (and pokémon names) support!
* Streamline the Gen I localization code to be structured similarly to the gen II's
* Fix bug
When Gen1GameReader is triggering the language detection automatically, the
Gen1IconDecoder instance is not updated with the detected language
* Update README.md
* Fix markdown special char escape problem in README.md
* Fix name decoding for localizations
* Fix detection of German Pokémon Yellow
* Fix bug: Japanese saves were not detected correctly for gen I
* Convert every character map entry into UTF-8.
libdragon requires every string to be in UTF-8 encoding
* Fix bug with Japanese saves. Wrong offset was used for the party storage in several functions
* Fix OT names and nicknames for Japanese cartridges
* Fix another issue with Gen I nicknames. Gen II is also still entirely broken in this regard
* Also fix Japanese pokemon name retrieval in gen I
* Fix OT and nicknames for Japanese gen I games
* Add support for Japanese and Korean Gen II save offsets
Japenese and Korean Gen II saves have a different save structure (data at different offsets)
* Disable save corruption check for Japanese/Korean games.
I don't have the right save offsets nor can find them. (I'm not adept at decompilation myself and pokegold/pokecrystal don't have the japanese offsets. Nor does PkHex)
* Refactor the gen1 related code to store the different SRAM offsets for gen 1 saves similarly as we do for gen 2
* Remove unnecessary casts
* Avoid trying to decode Korean trainername and rival name.
We don't support the character set, neither in libpokemegb and PokeMe64.
The Korean character set is a lot more complex than the other ones. But it would also require the inclusion of a lot of additional character glyphs in PokeMe64
in order to show the characters. Right now I don't feel like doing that for a localization that won't be used by many in combination with PokeMe64.
So instead of showing the trainer name and rival name, I will just replace it with "player" and "rival". It's not an amazing solution, but it's the best I'm willing to do for now.
* Add support for the Korean character sets.
This was needed after all, because we don't want injected pokémon on a Korean cartridge to end up having a nickname like "poke-<indexnumber>".
So that implies the need for being able to decode and encode pokémon names in Korean.
So yeah, I bit the bullet and added support for it. This was really annoying to do, but it has been done!
* Feature/add japanese distribution pokemon (#4)
* Add Gen I Japanese Distribution Event Pokémon
* Remove external definitions of each individual distribution pokémon from the headers and make them static in the source file
* Add isJapanese field to Gen2DistributionPokemon struct and adapt every existing definition
* Fix mistake in last commit
* Make sure the OT name is replaced when dealing with Japanese distribution pokémon on a different language cart and vice versa
* Add Japanese Mystery Egg #3 gen II event distribution Pokémon
* Add remaining Japanese Event Distribution Pokémon
* Fix another issue with Gen I nicknames. Gen II is also still entirely broken in this regard
* Fix OT and nicknames for Japanese gen I games
* Refactor the gen1 related code to store the different SRAM offsets for gen 1 saves similarly as we do for gen 2
* Bugfix/fix distribution event pokemon inconsistencies (#5)
* Add Gen I Japanese Distribution Event Pokémon
* Remove external definitions of each individual distribution pokémon from the headers and make them static in the source file
* Add isJapanese field to Gen2DistributionPokemon struct and adapt every existing definition
* Fix mistake in last commit
* Make sure the OT name is replaced when dealing with Japanese distribution pokémon on a different language cart and vice versa
* Add Japanese Mystery Egg #3 gen II event distribution Pokémon
* Add remaining Japanese Event Distribution Pokémon
* Fix another issue with Gen I nicknames. Gen II is also still entirely broken in this regard
* Fix OT and nicknames for Japanese gen I games
* Refactor the gen1 related code to store the different SRAM offsets for gen 1 saves similarly as we do for gen 2
* Fix some inconsistencies with Gen II distribution event pokémon.
* Make use of the Move enum instead of magic numbers for the pokémon moves (#6)
* Add Gen1GameReader::getCurrentMap() function to retrieve the current map the player is on.
I may be able to use this when adding a move deleter for gen1 games later, to make sure the player is in the pokemon center.
(to make sure the player doesn't get trapped because he/she would delete an HM move)
* Fix broken Japanese PC Box support + add support for Pokémon Green (JPN) + fix currentMap retrieval on japanese saves
So, turns out that PC Box support was entirely broken for the Japanese games with PokeMe64.
Apparently, the japanese games only have 8 boxes instead of 12, but each of them has a capacity of 30 pokémon instead
of 20!
So that changes things for the save offsets.
Also: the currentMap offset was wrong for Japanese games. So I had to fix that too!
* Updated README.md
* Fix the same issue with PC Boxes for Japanese Gen II games.
The international releases have 14 pc boxes with 20 pokemon each. But the japanese gen II games have 9 pc boxes with 30 entries each.
* Rework rom offsets for pokémon blue to avoid duplicate rom offset definitions.
The only one different from the red/green offsets is the japanese one anyway.
* Replace "PokeMe64" OT with "PM64" when injecting japanese mons into international games.
Turns out the official character limit was 7
* Fill the unused bytes of a nickname with the terminator byte.
This is needed because according to Bulbapedia, a nickname is only considered not a nickname if it matches with the
uppercase species name with all unused bytes set to the 0x50 terminator.
* Add gen1_isAPokeCenter() function
* Move resetRtc functionality to libpokemegb
I'll need to use it in 2 places in PokeMe64 and this will allow me to reuse code
* Forgot to commit this line
Fix PokeMe64 bug #10 - Sprites error Pokemon Silver
Turns out that Pokemon Silver has the IconPointers list at a different rom offset for some reason.
This was an oversight during my testing because I don't personally own Pokemon Silver.
Fix: Use the right rom offset
The gen 2 saves contain 2 markers per section (main/backup) to serve as canary values to see whether an actual save is stored.
Because after all: checksum 0 is a valid checksum in some cases. So to distinguish between a valid and a corrupted save, these markers are used.
And now we use it too! This will be necessary to detect that there's no save file in case the save was wiped (or a reproduction cart is used)
This allows us to use the genx_prepareDistributionPokemon() functions followed by GenXGameReader::addPokemon()
instead of GenXGameReader::addDistributionPokemon() in order to actually show the resulting GenXTrainerPokemon in
a stats screen in PokeMe64. After all: the genx_prepareDistributionPokemon() function does things like generate IV,
decide the trainer OT name and ID and apply shinyness chances.
So when showing the resulting pokemon in a stats screen, we need the actual resulting pokemon in order to show the right
stats, OT and shinyness
Sprite decoding was broken on Big Endian CPUs (such as AMD or the Nintendo 64 MIPS CPU), while working
on Little Endian CPUs (Intel): the color palettes came out wrong because they were stored as little endian.
Now we byte swap the 16-bit colors when reading them from the rom/cartridge if running on a big endian CPU, which
solves the issue (while still remaining compatible with Little Endian CPUs)
- Add SpriteRenderer::OutputFormat::RGBA32 and SpriteRenderer::OutputFormat::RGBA16
- Move the removeBackground functionality out of the decodeSprite example application and into SpriteRenderer. It's RGBA32 only though
Now it not only unlocks the event, but it also makes it repeatable by removing the GS Ball from the players' inventory first
and resetting all GS Ball related event flags.
Not only does this cover up my screw up with PokeMe64. (it prevents players from having to create a new save
to get access to the GS Ball event if they used one of my previous versions of PokeMe64)
As a bonus, it also makes the event completely repeatable, which is nice!
When adding a pokémon to a save with a full party, the behaviour is completely broken.
Not only did we add a pokémon to every box, but it also would be a completely different one or even crash the game when trying to access the box.
Fixes:
- Stop after adding a pokemon to a box. Don't add it to all.
- In commit 77d5d15 I added a ::setPokemon function and reworked the Gen1Box::add() function to use it. That's where it went wrong:
in the add() function, we would modify the number_of_pokemon counter of the box, but not manipulate the species list and write it.
Then in the setPokemon() function, we would read the box metadata and correct it because the number did not match the species list. This is what went wrong.
To fix it, I just had to modify the species list in the add() function as well again.
Make it possible for Gen1PlayerPokemonStorages' Gen1Party and Gen1Box to
avoid the performance hit in ::getPokemon caused by the recalculation of
the pokemons' level. This recalculation would read the pokemon stats
datastructure, which could be slow on the N64 transfer pak.
