Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-06-23 13:02:21 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
45,695 Commits 14 Branches 20 Tags 1.7 GiB
95f3f8c6df
Commit Graph

33590 Commits

Author SHA1 Message Date
JosJuice
95f3f8c6df EXI/BBA: Add null check in CEXIETHERNET::DirectFIFOWrite 
Just in case. DMAWrite calls DirectFIFOWrite with the result of a
GetPointerForRange call without first checking if it's null.
 2026-06-20 15:15:28 +02:00
JosJuice
31eaf1d67c EXI/BBA: Fix tx_fifo memory safety issues 
Reported by MrSynAckster.
 2026-06-20 15:15:28 +02:00
Dentomologist
43210d1430
Merge pull request #14685 from JosJuice/netplayclient-pad-index 
NetPlayClient: Check for invalid pad indices
 2026-06-17 13:36:11 -07:00
JosJuice
32eaf7961f NetPlayClient: Check for invalid pad indices 
Like 29e577d but for the client instead of the server.
 2026-06-14 14:47:17 +02:00
JosJuice
107169bfd8
Merge pull request #14677 from doldol22312/netplay-validate-controller-packet-indices 
NetPlayServer: Fix remote crash via invalid pad index
 2026-06-14 13:51:46 +02:00
Tillmann Karras
37a3b0fe6a DolphinTool: fix crash when listing partition without filesystem 
We were also passing the wrong partition name.
 2026-06-13 17:39:08 +01:00
agalq13
5585aa0474 NetPlay: Stop game when mapped Wii Remote disconnects 2026-06-11 14:31:05 +03:00
agalq13
29e577d966 NetPlay: Validate controller packet indices 2026-06-11 13:20:48 +03:00
Admiral H. Curtiss
29f1bc4d4c
NANDImporter: Abort extraction if a NAND FST entry is visited more than once 2026-06-04 18:48:19 +02:00
Admiral H. Curtiss
aabea5b1e3
Merge pull request #14667 from JosJuice/nand-import-path-traversal 
Prevent path traversal in NANDImporter::ProcessEntry
 2026-06-04 17:31:33 +02:00
JosJuice
a6278030c2 JitArm64: Fix twx 
The conditions were in reverse order (maybe someone was reading the
PowerPC manual and forgot about IBM's bit numbering), and additionally
the two conditions for unsigned comparison were wrong.

Fixes https://bugs.dolphin-emu.org/issues/14054.
 2026-05-31 11:49:34 +02:00
JosJuice
2faa9760d3 Prevent path traversal in NANDImporter::ProcessEntry 
Reported by MrSynAckster. A specifically crafted NAND dump could use
path traversal to overwrite files on the host file system.

This is also an accuracy fix for importing NAND dumps that contain
file names that Dolphin is supposed to escape. Some games' save files
are affected.
 2026-05-30 11:51:14 +02:00
JosJuice
3abadcd507 Rework NANDImporter::GetPath slash handling 
GetPath has two special cases where it doesn't add a slash.

The first is for the root entry's special name "/". The next commit will
be neater if we can skip calling GetPath for the root entry, because '/'
is one of the characters that Common::EscapeFileName replaces with an
escape sequence. Let's check for entry number 0 instead.

The second is for parent paths that already end in a slash. There's no
actual need to check for this - double slashes are harmless, and for
comparison, NANDImporter::ExtractCertificates already appends slashes
without checking if there already is one. Let's remove this check.
 2026-05-30 11:51:14 +02:00
JosJuice
635fa74b4c Fix uninitialized variable warning in ZeldaAudioRenderer::ApplyReverb 
If CopyFromEmuSwapped considers the address to be invalid, nothing will
be written to the passed-in pointer.
 2026-05-29 22:09:13 +02:00
Dentomologist
379a1a7109
Merge pull request #14607 from elyashue/internal-resolution-display 
VideoCommon: Added option for showcasing internal resolution
 2026-05-25 12:17:29 -07:00
Admiral H. Curtiss
afd343ec9c
Reimplement custom cropping by adjusting the source aspect ratio 2026-05-24 20:51:23 +02:00
Admiral H. Curtiss
ba15ddd602
Revert the Presenter logic changes from #14506 2026-05-24 19:47:18 +02:00
Admiral H. Curtiss
d3217f65c3
Merge pull request #14506 from adamscott/crop-that-screen 
Add screen crop feature
 2026-05-23 20:53:31 +02:00
Admiral H. Curtiss
17b4b8fc07
Address minor nits in new cropping logic 2026-05-23 19:47:28 +02:00
Tillmann Karras
4618e4bb40 IOS/Network: reduce log verbosity of SO_EAGAIN to info level 
Otherwise IOCTL_SO_ACCEPT is very noisy until a client connects.
 2026-05-15 23:01:27 +01:00
Weston Heard
adcfbda2a3 AudioCommon: Add individual Wiimote audio mixer 
Also incremented STATE_VERSION.
 2026-05-14 14:50:45 -05:00
Admiral H. Curtiss
34311f5fa2
Merge pull request #14592 from jordan-woyak/memcard-manager-scrolling 
DolphinQt/GCMemcardManager: Set ScrollMode::ScrollPerPixel to make scrolling behavior less annoying.
 2026-05-11 23:04:22 +02:00
Admiral H. Curtiss
8bf1f8970a
Merge pull request #14613 from JosJuice/wad-tmd-checks 
DiscIO: Add extra IsValid checks for VolumeWAD::m_tmd
 2026-05-11 22:59:40 +02:00
Dentomologist
d19952cc11
Merge pull request #14634 from JosJuice/jitarm64-msr-dr-bit 
JitArm64: Fix DR check in MSRUpdated
 2026-05-07 17:21:50 -07:00
JosJuice
f09a736f14
Merge pull request #14645 from Dentomologist/msghandler_use_more_suitable_log_levels 
MsgHandler: Use LogLevel matching MsgType for alerts
 2026-05-07 11:07:41 +02:00
Dentomologist
8afc696a1e
Merge pull request #14644 from tom-pratt/fix_do_all_players_have_game 
DoAllPlayersHaveSameGame returns correct result instead of always true
 2026-05-06 15:07:33 -07:00
Dentomologist
cf20cdabd4
Merge pull request #14632 from vladfi1/upstream-pipe-inputs-fix 
Unconditionally lock in ControllerInterface::UpdateInput
 2026-05-06 13:40:16 -07:00
Vlad Firoiu
20718de37e Unconditionally lock in ControllerInterface::UpdateInput. 2026-05-06 15:57:03 -04:00
Dentomologist
dfda04c4e4 MsgHandler: Use log level matching MsgType for alerts 
When calling `ShowMessageAlert` with a given `MsgType`, log the alert
with a `LogLevel` matching the `MsgType` instead of always using
`LogLevel::LERROR`.
 2026-05-06 12:44:43 -07:00
Tom Pratt
bedb283d93 DoAllPlayersHaveSameGame returns correct result instead of always true 
SendGameStatus() was writing SyncIdentifierComparison as a u32 but the server reads it as a u8 enum, so the server always gets 0 (SameGame). This bug was introduced in commit 66276ac.
 2026-05-06 14:06:01 +02:00
Dentomologist
6d5399246e
Merge pull request #14532 from Dentomologist/autoupdatechecker_fix_edge_cases 
AutoUpdateChecker: Fix Edge Cases
 2026-05-05 16:23:16 -07:00
Jordan Woyak
b0eb643c61
Merge pull request #14642 from SuperSamus/cpp-move-fixup-nocubeb 
Fixup #14565 (compilation with `-DENABLE_CUBEB=OFF`)
 2026-05-05 11:45:55 -05:00
Martino Fontana
3c06541718 Fixup #14565 (compilation with -DENABLE_CUBEB=OFF) 2026-05-05 13:50:05 +02:00
Dentomologist
34646cb9a9 Replace some [[maybe_unused]] annotations with commented names 
Remove the [[maybe_unused]] annotation from various parameters that are
unconditionally unused and comment out their names instead. This makes
it unambiguous that the variables are unused, while making the remaining
[[maybe_unused]] annotations more reliable indicators that those
variables are in fact used in some contexts.

These parameters are mostly in overridden functions where the override
doesn't need that particular variable.
 2026-05-03 17:09:59 -07:00
JosJuice
058c7021b8 JitArm64: Fix DR check in MSRUpdated 
TBZ takes the index of the bit to test, not a LogicalImm.
 2026-05-01 10:23:59 +02:00
Jordan Woyak
1907ffa45d
Merge pull request #14384 from ethanuppal/editdsuservers 
Config: Add Edit button to DSU server menu
 2026-04-30 20:50:17 -05:00
Ethan Uppal
4e55d2518a
Config: Add Edit button to DSU server menu 
Signed-off-by: Ethan Uppal <113849268+ethanuppal@users.noreply.github.com>
 2026-04-30 02:23:41 -04:00
spaceage64
3944310308 Add Classic Controller support cheats for Animal Crossing (all regions) 2026-04-29 19:44:31 +02:00
Dentomologist
2b743639d8
Merge pull request #13505 from tygyh/Replace-find-with-contains 
Source/Core: Replace `find(x) != npos` with `contains(x)`
 2026-04-28 17:50:51 -07:00
Dentomologist
725a726174
Merge pull request #14602 from jordan-woyak/show-file-in-folder 
QtUtils: Add ShowFileInFolder function and make GameList right-click menu actions use it.
 2026-04-28 17:29:44 -07:00
JMC47
0e8fa3caca
Merge pull request #14601 from jordan-woyak/mkgp-wheel-fix 
HW/Triforce/MarioKartGP: Tweak the steering wheel FFB device responses to prevent "Wheel Error" screens.
 2026-04-27 16:48:28 -04:00
JMC47
6409c5beb3
Merge pull request #13931 from SuperSamus/pikmin-squared-60fps 
GameINI: Add 60 FPS code for Pikmin Squared
 2026-04-27 13:09:00 -04:00
Jordan Woyak
5e1185b979 HW/Triforce/MarioKartGP: Tweak the steering wheel FFB device responses to prevent "Wheel Error" screens. 2026-04-27 11:59:12 -05:00
Jordan Woyak
5588fe0022
Merge pull request #14308 from jordan-woyak/character-encoding 
StringUtil: Make UTF16ToUTF8 and UTF8ToUTF16 use custom encoding/decoding implementation.
 2026-04-25 14:59:27 -05:00
Dentomologist
ac78e52cf9 GCAdapter: Fix data races 
Make `s_is_adapter_wanted` and the elements of `s_config_rumble_enabled`
atomic.

The CPU thread reads `s_is_adapter_wanted` and `s_config_rumble_enabled`
in `Output`, while the host thread writes to them in `RefreshConfig`.

The simplest way to trigger this race is to close the `Settings` window
while playing a game with the adapter active.
 2026-04-25 11:16:10 -07:00
Jordan Woyak
0363de56fc
Merge pull request #14618 from Dentomologist/stereomode_unabbreviate_variable_names 
StereoMode: Unabbreviate enum names
 2026-04-25 11:55:03 -05:00
Martino Fontana
c96d1b7b4a GameINI: Add 60 FPS code for Pikmin Squared 2026-04-25 10:45:25 +02:00
Dentomologist
a94854309b
Merge pull request #14608 from JosJuice/gcadapter-auto-start 
GCAdapter: Automatically start and stop thread
 2026-04-24 19:51:51 -07:00
Jordan Woyak
a796486625 QtUtils: Add ShowFileInFolder function and make GameList right-click menu actions use it. 2026-04-24 18:09:39 -05:00
Dentomologist
f67d80c7c1 VideoConfig: Rename StereoMode::TAB to StereoMode::TopAndBottom 2026-04-24 11:19:11 -07:00