* Started adding the egg-hatch level constants.
Added the offsets for Ruby & Sapphire so far. These addresses are all the same, apart from v1.1 increasing all of them by 0x20.
Credits: Jambo51 and VersekrDark (with the help of ModExe Ruby)
The anchor name could change.
* Added the lines for FireRed, LeafGreen, & Emerald.
I also specified the domain of valid levels in the comments. According to the PokéCommunity thread (linked in the Pull Request description), the game bugs out when choosing a constant greater than 100.
Credits: Jambo51 & Wobbu
* Added `data.maps.roaming.sets` for Emerald.
It's called `sRoamerLocations` in the decomps. Looks like there are 6 locations per major table entry instead of 7.
* FireRed & LeafGreen: Location params use map names.
Each location parameter references a map name instead of showing a literal now.
* Added level 50 & open level battle pike tables.
All 8 anchors have the same formatting.
* Added the Resort Gorgeous rewards table anchor.
* Added the `scripts.elevator.floor` anchor.
I tested this, and these anchors work as intended, as well.
* Hold Effects Table: 1st param. references a table.
* Renamed "bag.inside3" to "bag.pokemart".
Requested by 1RWT16KU1D.
* Made a certain table's Trigger field a hex field.
I have not tested this yet. There's a chance this could lead to metadata irregularities.
* Added Emerald's vrsn. of the town map annotations.
Testing on a fresh ROM will commence shortly.
* Lowered the length of `scripts.text.destinations`.
The correct length is 8, not 14.
* Fixed a failed test involving an anchor change.
With `graphics.bag.inside.3.palette` and company renamed, the relevant assertion in `Upgrades.cs` should now succeed correctly. I just needed to supply the old names in one spot and the new names in another spot.
* Added the banlist for FireRed & LeafGreen.
This is for the battle tower.
Requested by Sylinuser.
* Added the same banlist for Ruby & Sapphire.
* Updated HUBOL's move names count to 896.
Previously, two "Rapid Flow" moves were left out of the hard−coded formatting.
Testing will be required.
* Fixed a typo in the "trainerabilities" variable.
* Added HUBOL's move effect options.
Yak Attack's feature request.
The code could be improved so that it replaces the vanilla move effect options [[List]].
This code has not been tested yet.
* Fixed the indentation.
* Removed all `\t`s in favor of spaces.
* Added the code to update the "effectiveness" list.
This is if the CFRU was detected.
* Added the code to add the type chart anchor.
Address 145BB74 is the anchor reference pointer, not the location of the anchor itself.
This should be updated as `AdjustFormatForCFRU()` makes its initial call.
* Readded C9 Btl. Script alias. Fixed syntax errors.
The `jumpifattackandspecialattackcannotfall` alias no longer throws a compiler error due to its length, so it's fair game to readd it.
The other syntax errors came from implementing more things for HUBOL's metadata.
* Fixed the move effects [[List]] generation.
The existing code did not account for all of the new move effects, and the list added earlier was not completely accurate. Now, the move effect names _should_ be correct.
Some of the move effects (like Endure) are unused in HUBOL's _moves,_ but they're still used in some tables referenced by the vanilla AI.
* Optimized the code for two [[List]]s.
* Removed some comments.
* Optimized the code for making the type chart taЫe.
* Added Decorate's move effect to the metadata.
Decorate uses its own move effect (#245), and that was previously overlooked.
During the first pass, scripts that are detected that are earlier than the current script are given a length of 1 to prevent recursion.
The script parser can now produce a second pass on these addresses if they're recognized as scripts, to make sure that the full script gets concatenated rather than truncated to the first command.
* Updated the battleOptions observable collection.
Axcellerator's feature request.
I updated the third & fourth option and reformatted the last option. Separating these lists for the Kanto & Hoenn games would be useful, though challenging to implement, I think.
* Two table reference touch-ups
Made the pokemonOffset & trainerOffset fields in Emerald's `data.pokedex.stats` unsigned.
Made the worldmapflag in the `graphics.overworld.firstpersonview.sprites` table show as a base-16 number.
* A 3rd table reference touch-up
Updated the back throw anchor's fields from a, b, c to size, index.
* A fourth and fifth table reference touch-up
Yogia's feature request: Implement a fixed `data.famechecker.trainerpics` anchor.
RedKraken's feature request: Implement an anchor for the PC script.
As for the name, there's only 1 `pc` subdirectory under `scripts`, and it's under `newgame`, so that's where it was located. However, this new anchor name can be adjusted.
* The final feature request in this pull request
In `scriptReference.md`, parameter fields that format numbers as entries from a named anchor will have the words "is from" instead of just "from."
We want a macro that can "set the current move" for use in battle scripts, for setting how the animation should work. This needs to set a low-byte high-byte pair based on a move id, which requires 2 separate commands. In order for this macro to work, the code needs to be able to read the two split bytes as a single value, and write the single value as 2 split bytes. This is now supported.
the constant in R/S/E has a `lsl 1` on it, so the table cannot be naturally expanded. It may be better to just remove the limiter, which is near the 2nd-to-last pointer to the table.
add teachy-tv table
add comment explaining how ListMenu works. Add table that ListMenu uses.
setweather takes a weather enum now instead of a number
setworldmapflag values are displayed in hex, and no longer offer flag-picking since it's a different list of flags
choose-save background palette
script args should be able to handle <null>
don't add/remove runs inside the method that isn't supposed to touch the runs collection
handle race condition where UI may be aware of tab being removed before ViewModel gets a chance to notify it
fix bounds checking in map editor collision counting
better default value for newly added map script tables
fix width/height double-check when failing to import multi-sprites
fix cutoff text
fix spelling error
