Commit Graph

69 Commits

Author SHA1 Message Date
Rangi
0e49aef88e
Use macros to enforce "hidden object" constraints, and rename them to "hidden events" (#559) 2026-01-07 22:05:37 -05:00
Rangi
fe1e76466b
Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" (#557) 2026-01-07 22:05:20 -05:00
Narishma-gb
e9d3324bc0
Comment more unreferenced local labels (#550) 2025-12-15 15:14:17 -05:00
Narishma-gb
3a4382c605
Use more Pokemon data constants, create MOVE_NAME_LENGTH (#543)
Some checks failed
CI / build (push) Has been cancelled
2025-11-27 13:39:25 -05:00
Rangi
e92d1af478
Avoid magic numbers for most CopyData calls (#542)
Some checks failed
CI / build (push) Has been cancelled
2025-11-25 16:53:29 -06:00
Narishma-gb
f332678625
Use more hardware and graphics constants (#532)
Some checks failed
CI / build (push) Has been cancelled
- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
2025-11-18 15:17:31 -05:00
Rangi
5943b96cf6
Use features of RGBDS 1.0.0 (#537)
Some checks are pending
CI / build (push) Waiting to run
2025-11-12 15:44:07 -05:00
Narishma-gb
4d2594cb24
Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Narishma-gb
126c3f3366
Document a bug in PrintBenchGuyText (#523)
Some checks failed
CI / build (push) Has been cancelled
2025-08-17 10:00:34 -04:00
Rangi
5e8b835ba3
Use dname macro to automatically pad names with "@" characters (#525) 2025-08-17 09:58:09 -04:00
Rangi42
78e44a8fb1 Use combined hardware constants 2025-06-30 13:45:24 -04:00
Rangi
56c405de09
Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
dannye
fd043a66c2 Fix typos 2025-06-03 23:48:35 -05:00
Narishma-gb
0ecc36c83a
Use constants in PrintBCDNumber calls (#503)
Some checks failed
CI / build (push) Has been cancelled
2025-04-08 22:17:32 -05:00
SatoMew
cf73d6ee0f
Further improve NPC trade labels and comments (#493) 2025-04-08 22:17:12 -05:00
edave64
e1b7b8af0a
Use constants for PP masks instead of magic numbers (#504)
Some checks failed
CI / build (push) Has been cancelled
2025-04-02 10:49:15 -04:00
Rangi
147914d179
Use constants for trade text indexes (#501) 2025-03-08 11:16:42 -05:00
Rangi
ec37f6117d
Consistently capitalize ASSERT directives (#489)
Some checks failed
CI / build (push) Has been cancelled
2025-01-28 23:31:27 -05:00
Rangi
afb8990169
Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Rangi42
67084c9d26 Remove redundant parentheses 2024-12-16 10:35:55 -05:00
Rangi42
ff76bba507 Use "gray", not "grey"
This matches the in-game text, e.g. Pewter is "A Stone Gray City"
2024-12-16 10:29:59 -05:00
Sylvie
635b9c4cab
Identify wCurrentMapScriptFlags bits (#467) 2024-09-24 11:39:44 -04:00
Sylvie
b5d2540e7c
Identify more bit flags (#465)
* Identify more bit flags

* Space
2024-09-24 09:33:33 -04:00
Sylvie
8f1dcf07e5
Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie
5a622f628d
Identify remaining uses of wd0b5 and wd11e (#463) 2024-09-18 21:41:58 -04:00
Sylvie
613d34678b
Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Sylvie
77d051479b
Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 10:05:33 -04:00
Sylvie
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 12:21:59 -04:00
Sylvie
8fafca714c
Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
colawsol
f6017ddbfd
Correct StarterDex function comment (#440) 2023-12-06 19:34:37 -06:00
Vortyne
7a7a6d689c
Identify the unnamed HRAM variables and one WRAM label (#438) 2023-11-20 17:23:22 -05:00
Rangi42
26a342b104 Identify more map script labels 2023-11-18 19:44:03 -05:00
vulcandth
d001ced41b
Add macros, constants, and labels for map scripts and text (#367)
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
2023-07-13 21:27:56 -04:00
Rangi
bbb0e7e82d
Use the same music headers as pokecrystal (#382) 2022-08-11 21:23:08 -04:00
Rangi
8f81e71f19 Identify some .asm_* labels 2022-07-10 21:11:03 -04:00
Rangi
a66adbcc5c Sync Pokédex rating text with pokeyellow 2022-07-10 19:26:18 -04:00
Rangi
927b5a4700 Identify Pokédex rating text 2022-07-10 19:16:17 -04:00
Colton G. Rushton
cc46b0e510
wOAMBuffer -> wShadowOAM (#370) 2022-07-09 17:18:18 -04:00
vulcandth
6b5be9129c
RGBDS syntax updates (#358)
New MACRO and DEF syntax
2022-06-06 17:25:31 -04:00
Yoann Fievez
8349bfd8e6
Refactorize check button pressed (#340) 2021-11-05 15:40:15 -04:00
Rangi
7ee8a6509e wcf4b -> wStringBuffer 2021-08-28 17:02:20 -04:00
Rangi
6a31663c96 Use {interpolation} to generate sequences of RAM labels
Fixes #319
2021-04-27 15:49:59 -04:00
Rangi
95ec2cf039 Verify data table and name list sizes with assertion macros
Fixes #312
2021-03-25 16:44:41 -04:00
dannye
66377fca32 Fix file modes 2020-11-14 20:52:10 -06:00
Rangi
bfd9f617c9 Use constants to delineate map types, and factor out more data 2020-08-31 10:23:19 -04:00
Rangi
6ee9cb9f97 Document more hidden object data and behavior 2020-08-30 15:45:41 -04:00
Rangi
69788c536b Add comments associating constants with data, and identify some more data 2020-07-20 12:31:35 -04:00
Rangi
76289dfda0 Port dbsprite macro for OAM y,x,tile,attr data from pokecrystal 2020-07-17 15:58:06 -04:00
Rangi
594c58a289 Revise some map scripts, mostly for getting items 2020-07-16 11:19:05 -04:00
Rangi
4b4ad9894e Disassemble the BLUEMONS.GB debug ROM 2020-07-15 13:35:39 -04:00