Commit Graph

269 Commits

Author SHA1 Message Date
SnorlaxMonster
85b9d866c8
Align move grammar with pokecrystal (#565)
Add comments explaining the redundant move grammar categories inherited from the Japanese version.
2026-01-17 16:41:37 -05:00
Rangi
0e49aef88e
Use macros to enforce "hidden object" constraints, and rename them to "hidden events" (#559) 2026-01-07 22:05:37 -05:00
Rangi
fe1e76466b
Use macros to enforce "missable/hide/show object" constraints, and rename them to "toggleable objects" (#557) 2026-01-07 22:05:20 -05:00
Rangi
d79c578abd
Specify a max item length for list_start (#552)
Some checks failed
CI / build (push) Has been cancelled
2025-12-15 15:16:40 -05:00
Rangi
e1948fe4b3
Clarify how the order of map constants matters for the Town Map (#553) 2025-12-15 15:02:37 -05:00
Rangi
9a6bb3ed0c
Define player and rival names once, to be used in two places (#545)
Some checks are pending
CI / build (push) Waiting to run
2025-12-01 11:00:56 -05:00
PokefanMarcel
c2d81fb598
Expand comment on _AfterTrade2Text to mention pokeyellow's changes (#536)
Some checks failed
CI / build (push) Has been cancelled
2025-11-06 14:06:33 -05:00
Narishma-gb
4d2594cb24
Label and constant cleanup (#528)
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
2025-09-03 11:56:09 -04:00
Rangi
5e8b835ba3
Use dname macro to automatically pad names with "@" characters (#525) 2025-08-17 09:58:09 -04:00
Rangi42
c51d1b7a1d List end markers (-1 aka $FF) are not part of table data
Some checks failed
CI / build (push) Has been cancelled
2025-08-13 15:09:12 -04:00
Rangi
56c405de09
Replace hardware_constants.asm with hardware.inc (#511) 2025-06-30 12:47:22 -04:00
Rangi42
d47f74ee1f Rename Green1/2/3 to Rival1/2/3 for consistency
Some checks failed
CI / build (push) Has been cancelled
2025-04-20 10:39:32 -04:00
SatoMew
cf73d6ee0f
Further improve NPC trade labels and comments (#493) 2025-04-08 22:17:12 -05:00
Narishma-gb
ca7b62fec3
Correct vc_patch length (#499) 2025-03-08 11:19:17 -05:00
Narishma-gb
43f21cc494
Fix some label typos, and add some constants instead of raw numbers (#492)
Some checks failed
CI / build (push) Has been cancelled
2025-01-30 17:26:55 -05:00
Rangi
ec37f6117d
Consistently capitalize ASSERT directives (#489)
Some checks failed
CI / build (push) Has been cancelled
2025-01-28 23:31:27 -05:00
Rangi
afb8990169
Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
2025-01-28 23:31:15 -05:00
Rangi
cd647df3b5
Don't pass redundant label names to table_width and list_start (#484) 2024-12-27 12:52:24 -05:00
Rangi42
ff76bba507 Use "gray", not "grey"
This matches the in-game text, e.g. Pewter is "A Stone Gray City"
2024-12-16 10:29:59 -05:00
Sylvie
f801d67f8e
Assert the relations between some move effect constants (#478)
Some checks failed
CI / build (push) Has been cancelled
2024-11-24 19:13:11 -05:00
Sylvie
8f1dcf07e5
Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie
613d34678b
Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Sylvie
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 12:21:59 -04:00
Sylvie
8fafca714c
Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
Vortyne
5f7b444ae8
Use constant in wram for hidden item flags (#445)
Prevents defining more hidden items than the flag array has room for
2024-05-05 09:56:08 -05:00
SatoMew
07cefd462f
Clean up item comments (#443) 2023-12-18 18:30:37 -06:00
dannye
3c76871600 Fix some map text constants 2023-11-21 20:25:12 -06:00
Rangi42
0a616ae560 Get rid of wEvosMoves, MAX_EVOLUTIONS, and EVOLUTION_SIZE
Fixes #430
2023-11-21 20:33:03 -05:00
Rangi42
13079730ac Rename two unused items as ITEM_XX like pokecrystal 2023-11-21 20:21:14 -05:00
SatoMew
a681f718ac
Rename EV_* constants to EVOLVE_* like pokecrystal (#407) 2023-11-21 19:54:39 -05:00
dannye
27940a7298 Fix SAFFRONCTIY typo 2023-11-19 17:25:49 -06:00
dannye
12a2f7a903 Fix inconsistent B1F object consts 2023-11-19 16:41:19 -06:00
dannye
e7f94cc520 Fix inconsistent object const names 2023-11-19 16:03:49 -06:00
dannye
3adf1e22ab Remove incorrect sign object consts 2023-11-19 16:00:44 -06:00
dannye
9f2d6aa0a8 Fix Celedon typo 2023-11-19 12:33:30 -06:00
dannye
b302e93674
Use map object consts in data/maps/hide_show_data.asm (#432) 2023-10-11 20:12:25 -05:00
Zachary Buhman
8003cca603
text_2.asm: trivial missing whitespace (#425) 2023-08-26 10:11:55 -05:00
Vortyne
35d8064317
Correct constant name (SILPH, not SLIPH) (#422) 2023-08-26 10:08:29 -05:00
SatoMew
f46db37d50
Thoroughly document debug code (#410) 2023-07-15 18:36:59 -04:00
vulcandth
d001ced41b
Add macros, constants, and labels for map scripts and text (#367)
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
2023-07-13 21:27:56 -04:00
Vortyne
17eaf761e3
Name some unnamed animation constants (#396) 2023-03-25 23:31:59 -04:00
RainbowMetalPigeon
a76ae055cc
Dex weights are in tenths of a pound 2023-03-25 23:28:55 -04:00
dannye
e076ee0a40 Add list assertion to TrainerNames 2022-12-28 21:48:55 -06:00
vulcandth
20ebfd079f
Add table assertion to TrainerDataPointers (#403)
* Add table assertion to `TrainerDataPointers`

* Add table assertion to `TrainerNamePointers`
2022-12-28 21:47:27 -06:00
Vortyne
3e72d0834e
Bug: SUBANIMTYPE_COORDFLIP should be SUBANIMTYPE_HVFLIP (#394)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-26 11:12:43 -04:00
BlueZangoose
0f5a9eb146
Change names of move subanimations to be meaningful (#389)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-09-25 14:17:39 -04:00
Rangi
c299cf1067 Use a SPRITE_SET_LENGTH constant 2022-09-24 11:39:39 -04:00
Rangi
d2be79adf1
Add constants and table macros for the map sprite sets (#392)
Fixes #391
2022-09-24 11:30:29 -04:00
Rangi
d809d3d59c Add UNUSED_TYPE/UNUSED_TYPE_END constants
Fixes #385
2022-09-11 15:02:51 -04:00
SatoMew
63a7eb2cf5
Improve NPC trade labels and comments (#384)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-10 13:44:31 -04:00