Commit Graph

1044 Commits

Author SHA1 Message Date
tillgeissler
af8e4634b7 fix SBIN checksum comparison 2024-06-16 18:45:54 +02:00
Fexty12573
61708a99e1 PR Feedback: rename fields, params, functions and some restructuring 2024-06-16 11:44:16 +02:00
Fexty12573
3951b9f24a PR Feedback: rename files and reorganize structs 2024-06-16 11:03:40 +02:00
RavePossum
1ee4ab00bf PR feedback: constant for special var start and clean-up 2024-06-15 15:25:13 -04:00
RavePossum
b0d0e431ad PR feedback: re/name DecrementTimer and GetVar 2024-06-15 14:51:48 -04:00
RavePossum
47228d7008 rename and partially document some common script commands 2024-06-15 11:18:01 -04:00
tillgeissler
43c0e6849b Continue documenting wild encounter including PR feedback 2024-06-15 04:38:51 +02:00
Fexty12573
49168d50a2 Some more names + readability improvements 2024-06-14 22:39:12 +02:00
Fexty12573
8f618cead5 more naming 2024-06-14 16:23:54 +02:00
Fexty12573
a4558e428c label the majority of missing encounter functions 2024-06-14 13:19:15 +02:00
tillgeissler
5af14e70d8 Rename WildEncounterData variables 2024-06-14 01:40:00 +02:00
tillgeissler
3c0db94c5e Rename UnkStruct_ov6_02242634 to WildEncounterData 2024-06-13 23:22:39 +02:00
cbt6
43750877a4 Name map message bank files 2024-06-14 00:19:23 +08:00
cbt6
ce871482c0 Name message bank files 2024-06-14 00:04:27 +08:00
Fexty12573
dca10e7018 ScreenScrollManager cleanup 2024-06-13 15:37:42 +02:00
Fexty12573
91ba1a2da7 document BufferManager/ScreenScrollManager 2024-06-13 14:55:55 +02:00
Fexty12573
8d4c2142f1 0v5_021E2338 -> encounter_effect_core 2024-06-13 11:08:02 +02:00
Rachel
46780a9aba
Merge pull request #218 from cbt6/field-events
Name field event structs
2024-06-12 09:08:09 -07:00
Fexty12573
bcee617717 Labelled some trainer related encounter effects 2024-06-12 16:26:06 +02:00
Fexty12573
0762fe650c document cave encounter effects 2024-06-12 10:07:12 +02:00
Fexty12573
a011156c3e Improved some names 2024-06-12 10:07:12 +02:00
Fexty12573
5918a87a1c Document tall grass encounter effects (+ water partially) 2024-06-12 10:07:12 +02:00
Fexty12573
353520ca08 label some things in EncounterEffect struct 2024-06-12 10:07:12 +02:00
Fexty12573
46525162d5 document ScreenSplitEffect 2024-06-12 10:07:12 +02:00
Fexty12573
6ba0f54c49 document ScreenSliceEffect 2024-06-12 10:07:12 +02:00
Fexty12573
f6059d2450 document HBlankSystem 2024-06-12 10:07:00 +02:00
Fexty12573
b58a6f737e WIP screen slice effect 2024-06-12 10:06:37 +02:00
Fexty12573
85b4248398 document interpolation tasks 2024-06-12 10:06:37 +02:00
Fexty12573
de0799b2e8 Document BrightnessFadeTask 2024-06-12 10:06:37 +02:00
Fexty12573
78ad186ee4 document LinearInterpolationTaskS32 and encounter effect state enum 2024-06-12 10:06:37 +02:00
Fexty12573
ff337f6dbd WIP mapping of EncounterEffect_Flash and brightness fade 2024-06-12 10:06:37 +02:00
Fexty12573
dcf551d1c2 Clean up and organize encounter effect structs and general formatting 2024-06-12 10:06:37 +02:00
Fexty12573
500fbf903f Little bit of documenting in encounter_effect and name some task functions 2024-06-12 10:06:36 +02:00
Fexty12573
27754d7dff Rename ov5_021DDBE8 -> encounter_effect 2024-06-12 10:06:36 +02:00
Fexty12573
a6b217c092 PR feedback (playtime -> playTime, playtime.* -> play_time.*) 2024-06-10 18:45:37 +02:00
Fexty12573
0d45c0cb6f PR feedback (Playtime -> PlayTime, label fields/params, remove struct_def/decl file) 2024-06-10 18:45:02 +02:00
Fexty12573
ec541cb79e Some playtime related stuff 2024-06-10 18:45:02 +02:00
Fexty12573
2aaeed7a92 Document some savedata stuff related to playtime 2024-06-10 18:45:02 +02:00
Fexty12573
5dab46cd62 document playtime.c 2024-06-10 18:45:02 +02:00
Fexty12573
9527895787 struct/unk 02025E5C -> Playtime 2024-06-10 18:45:02 +02:00
cbt6
088c4f3552 Document map_header_data.c 2024-06-09 10:25:01 +08:00
cbt6
2c636859f0 Name CoordEvent struct 2024-06-09 10:07:05 +08:00
cbt6
39a0b343e3 Name WarpEvent struct 2024-06-09 10:06:01 +08:00
cbt6
77b1ad789e Name ObjectEvent struct (from MapObjectHeader) 2024-06-09 10:04:44 +08:00
cbt6
74feb9477a Name BgEvent struct 2024-06-09 10:03:28 +08:00
cbt6
1319c90b00 Document vars_flags.c 2024-06-08 11:05:00 +08:00
Fexty12573
dff6c92dba Rename events -> varsflags 2024-06-07 09:02:35 +02:00
Fexty12573
a667690266 PR feedback 2024-06-07 08:21:59 +02:00
Fexty12573
5a90627ab5 Various cleanup (unnecessary parens, naming, formatting) 2024-06-07 08:21:08 +02:00
Fexty12573
2f922974e2 rename sub_020628D8 to MapObject_GetStateFlag 2024-06-07 08:19:34 +02:00
Fexty12573
cc2a514faf Rename a bunch of functions from Events_ to VsSeeker_ 2024-06-07 08:19:34 +02:00
Fexty12573
9d8d51548e Fix struct names and enum/constant usage 2024-06-07 08:16:43 +02:00
Fexty12573
0b2cc1700b Simplify Script_IsTrainerDoubleBattle 2024-06-07 08:14:12 +02:00
Fexty12573
86461fd659 More constants 2024-06-07 08:14:12 +02:00
Fexty12573
d86969746a GetTrainerIDFromEventID -> GetTrainerID 2024-06-07 08:11:33 +02:00
Fexty12573
e29b8b121e HasBeatenTrainer -> IsTrainerDefeated 2024-06-07 08:11:33 +02:00
Fexty12573
19f634290a GetNpcCount -> GetNPCCount 2024-06-07 08:11:33 +02:00
Fexty12573
2f2a1b698a Final parameter name changes 2024-06-07 08:11:33 +02:00
Fexty12573
20858aa223 Finish labelling the rest of vs seeker functions and static variables 2024-06-07 08:10:17 +02:00
Fexty12573
ac0237b044 Finish labelling some structures 2024-06-07 08:02:23 +02:00
Fexty12573
2cb22ed3b4 Document main part of vs seeker code. Rename some external functions for clarity 2024-06-07 08:01:41 +02:00
Fexty12573
9db889837a Change * alignment and rename a few things 2024-06-07 07:53:20 +02:00
Fexty12573
50405eb220 Rename ov5_021DB888 to vs_seeker 2024-06-07 07:49:09 +02:00
Adrienn Tindall
f956fff0db
Merge branch 'main' into main 2024-06-06 10:12:25 -05:00
Adrienn Tindall
1384926086 Fix merge error 2024-06-06 11:05:35 -04:00
Adrienn Tindall
f637181625 Requested Changes 2024-06-06 08:47:13 -04:00
RavePossum
1133cd486c Use verbs for PlayerPos and DistortionState functions 2024-06-05 19:02:53 -04:00
Adrienn Tindall
7094828b09 Merge branch 'main' into main-adrienntindall 2024-06-05 11:26:16 -04:00
Adrienn Tindall
d88da37bba FieldEvents -> VarsFlags 2024-06-05 11:06:25 -04:00
Adrienn Tindall
ccaeaa1cd3 field_overworld_state 2024-06-05 07:37:13 -04:00
RavePossum
00419055b1 PR feedback - rename firstmon and champion ribbon functions, use enums for distortion state, cleanup 2024-06-03 15:30:46 -04:00
RavePossum
78225a77bd Document/rename a couple more DW functions, catch a couple more DW state consts, fix player_avatar_h header guard 2024-06-03 13:20:57 -04:00
RavePossum
8326ef7dda document some party-related functions 2024-06-03 10:44:40 -04:00
RavePossum
9c2ff9f98e add preproc constant for PAD_KEY 2024-06-02 22:42:52 -04:00
Adrienn Tindall
b00b77d195 Move overworld weather consts 2024-06-02 22:33:55 -04:00
Adrienn Tindall
10d33c357a Name journal files 2024-06-02 22:07:41 -04:00
Adrienn Tindall
c8ca914d36 unk_020530C8 -> field_map_change 2024-06-02 06:54:30 -04:00
Adrienn Tindall
aea5b883ff Identify Journal struct 2024-06-02 06:31:53 -04:00
Adrienn Tindall
40930d8f58 Begin documenting FieldStatus struct functions 2024-06-02 06:24:08 -04:00
Adrienn Tindall
9ece715560 More FieldTask functions 2024-06-02 05:46:01 -04:00
Adrienn Tindall
9395fbddf9 Begin Documenting Field Task functions 2024-06-02 05:25:18 -04:00
Adrienn Tindall
0e4cdd87b6 Location->unk_08, unk_0C => x, z 2024-06-02 04:47:32 -04:00
Adrienn Tindall
c8650b9da1 Events -> FieldEvents
Just for clarity
2024-06-02 03:09:27 -04:00
Adrienn Tindall
011c9463a6 UnkStruct_020507E4 -> Events
Based on SaveData_Events function
2024-06-02 03:08:42 -04:00
Adrienn Tindall
0adf43c584 Location->unk_00 => mapId 2024-06-02 02:38:18 -04:00
Adrienn Tindall
276897d6c8 fieldSystem->unk_1C => location 2024-06-02 01:40:20 -04:00
RavePossum
d6428e6641 add rest of distortion world states and name state function 2024-05-31 09:27:10 -04:00
RavePossum
cb76e5c281 unused -> dummy fields for FieldInput, comment on condition needed to match 2024-05-31 09:25:20 -04:00
RavePossum
9372ff5c68 Name HasTwoAliveMons, standardize multiline conditionals 2024-05-31 09:25:20 -04:00
RavePossum
70d623bd76 PR feedback - cleanup, NextPlayerPos->Step 2024-05-31 09:24:22 -04:00
RavePossum
084d4f0615 actually rename the header guards (ugh) 2024-05-31 09:24:22 -04:00
RavePossum
1466347b99 event_check -> field_control 2024-05-31 09:23:24 -04:00
RavePossum
db3d4e0fdf FieldEventCheck->FieldInput, lots of new function names 2024-05-31 09:23:24 -04:00
RavePossum
470215f5f9 rename to files to event_check 2024-05-31 09:22:00 -04:00
RavePossum
e6e32d4e8c document most of field event check 2024-05-31 09:22:00 -04:00
RavePossum
9778530f9a field event check struct in related header instead of its own file 2024-05-31 09:18:26 -04:00
Adrienn Tindall
965bdcf719 Added packet size consts 2024-05-31 02:42:21 -04:00
Adrienn Tindall
35454c7678 Comm Packet Size Of Functions 2024-05-31 02:18:32 -04:00
Adrienn Tindall
86c70f0688 Map object dx/dy from dir 2024-05-30 01:38:03 -04:00
Adrienn Tindall
b0fbb781fb Requested changes 2024-05-28 06:56:41 -04:00
Adrienn Tindall
c3d733e1fb Fix merge error 2024-05-27 18:09:00 -04:00
Adrienn Tindall
7eaa4a9e69 Merge remote-tracking branch 'upstream/main' 2024-05-27 17:45:16 -04:00
Adrienn Tindall
2b17be4805 Every instance of FieldSystem 2024-05-27 17:33:40 -04:00
Adrienn Tindall
87e381ab82 Name all instances of PlayerAvatar 2024-05-23 21:00:41 -04:00
Rachel
8c9136da46 Document ChooseStarter_Main 2024-05-22 08:56:19 -07:00
Rachel
7b4dce2b1c Document SetupBGL, MakeMessageWindow, MakeSprite, MakeSpriteDisplay 2024-05-22 08:56:18 -07:00
Rachel
720541850a Document starter species selection mapping 2024-05-22 08:56:16 -07:00
Rachel
26d97f7e57 Identify app functions for choose_starter 2024-05-22 08:51:11 -07:00
Rachel
e25ce27a4b Identify choose_starter_app 2024-05-22 08:51:11 -07:00
Adrienn Tindall
70e4bdfb57 More Accessor Changes 2024-05-21 00:17:32 -04:00
Rachel
4ca3010186
Merge pull request #202 from adrienntindall/main
Documentation Dump from a side project
2024-05-20 17:42:41 -07:00
Adrienn Tindall
a574d9917f Third Pass Changes 2024-05-20 20:34:13 -04:00
Adrienn Tindall
0c394865aa Add Direction Constts
Also slowly starting to change accessor terminology
2024-05-20 20:01:24 -04:00
Adrienn Tindall
a1145b41bb identify map_object_move.c 2024-05-20 02:47:05 -04:00
Adrienn Tindall
160848ed11 Map Object Position Accessors/Setters 2024-05-20 02:18:29 -04:00
Rachel
ce08786ddf Clean up build logic and file structure 2024-05-19 23:02:48 -07:00
Rachel
f5702cd16f Generate tutorable moves table; use source data in make_species_tables.py 2024-05-19 22:55:57 -07:00
Rachel
2b8dfe3bd5 Post-rebase fixes to alter generated header includes 2024-05-19 22:53:35 -07:00
Rachel
1df6ac2a4d PR feedback - TUTOR_LOCATION, clean up unnecessary parens 2024-05-19 22:34:02 -07:00
Rachel
40ea4248fd Clean up tutor_movesets.h 2024-05-19 22:34:02 -07:00
Bepis
b402d1397b Generate footprint size data table 2024-05-19 22:34:00 -07:00
Bepis
0ed8f42727 Species table generation code 2024-05-19 22:28:32 -07:00
Adrienn Tindall
3362a4b22f Some Map Object Functions 2024-05-20 01:17:48 -04:00
Adrienn Tindall
4c29d878dd Second Pass Changes 2024-05-20 00:18:48 -04:00
Adrienn Tindall
300bc7a688 Player Avatar Sprite Change Functions 2024-05-19 20:12:01 -04:00
Adrienn Tindall
5fe7705267 FieldSystem templates 2024-05-19 18:17:10 -04:00
Adrienn Tindall
35de262ebd UnkStruct_02049FA8 -> Location 2024-05-19 18:04:51 -04:00
Adrienn Tindall
fbff222d9f identify field_system.c 2024-05-19 18:01:07 -04:00
Adrienn Tindall
8318595095 First Pass Changes 2024-05-19 17:06:43 -04:00
Rachel
f6cfe2d046 Atomize individual generated constants-headers 2024-05-18 22:53:57 -07:00
Adrienn Tindall
546e21a13d Add player_avatar.h constants file 2024-05-18 14:43:13 -04:00
Adrienn Tindall
e0e200bc08 gender 2024-05-18 13:51:16 -04:00
Adrienn Tindall
f9415758a1 Pos Vector Accessors 2024-05-18 13:45:07 -04:00
Adrienn Tindall
9e862ed632 Map Object X/Z Pos Accessors 2024-05-18 13:40:03 -04:00
Adrienn Tindall
4ee4ce6fe3 MapObject_(Set)Dir 2024-05-18 13:34:29 -04:00
Adrienn Tindall
8a9fe917d2 Merge remote-tracking branch 'upstream/main' 2024-05-17 18:43:24 -04:00
Adrienn Tindall
44887bb174 unk_38 -> mapObjMan in FieldSystem 2024-05-17 18:40:54 -04:00
Adrienn Tindall
9c6eca2f70 Field Map Template 2024-05-17 15:39:50 -04:00
Adrienn Tindall
ba35728f4d Identify PlayerData struct 2024-05-17 15:21:10 -04:00
Adrienn Tindall
f6a5b96fee Added some MAP_OBJ_STATUS flags 2024-05-17 14:44:17 -04:00
Adrienn Tindall
0dcf1d5976 identify player_avatar.c 2024-05-17 13:59:06 -04:00
Adrienn Tindall
411bda763c Identify map_object.c 2024-05-17 13:47:44 -04:00
Adrienn Tindall
f8ce642c12 LocalMapObj -> MapObk 2024-05-17 13:11:34 -04:00
Adrienn Tindall
e5914857ab movementChanged flag 2024-05-15 12:57:55 -04:00
Adrienn Tindall
702c0363b6 More comm sys, what else is new 2024-05-13 16:25:40 -04:00
Adrienn Tindall
0b3f13ad11 Misc communication_system functions 2024-05-12 20:08:24 -04:00
Adrienn Tindall
dc50baf508 Fully document CommRing 2024-05-09 19:18:41 -04:00
Adrienn Tindall
8901c06ea7 More misc names 2024-05-09 06:17:55 -04:00
Adrienn Tindall
e10611d02b General Function Naming + Identify BmpList 2024-05-09 05:58:47 -04:00
Rachel
1bc1c14772 Use generated sub_seq.naix header in C sources 2024-05-07 19:46:01 -07:00
Adrienn Tindall
41e0adb739 More function docing 2024-05-07 12:33:09 -04:00
RavePossum
580486306a string_util -> ascii_util, IsJapaneseChar->IsFullWidthChar, remove references to GF encoding in ascii function 2024-05-06 14:38:03 -04:00
RavePossum
c8785312b8 PR feedback - remove unnecessary ascii constants, buffer->buf, polish 2024-05-06 13:55:11 -04:00
RavePossum
bffed4c069 improve ambiguous name for getting SpeciesName 2024-05-06 13:45:41 -04:00
RavePossum
5cdabd60ef document string util 2024-05-06 13:26:35 -04:00
RavePossum
84fdf5db14 mass rename string util files 2024-05-06 11:56:24 -04:00
RavePossum
05464885ba document message_util 2024-05-06 10:25:12 -04:00
RavePossum
af9540c434 mass rename message_util files 2024-05-06 09:08:54 -04:00
Adrienn Tindall
0fc7dcfd0e CommCmdTable 2024-05-04 05:52:14 -04:00
Adrienn Tindall
ddc4ae8bf0 Minor Function Documentation 2024-05-01 22:24:45 -04:00
Adrienn Tindall
ddf1daff78 Merge remote-tracking branch 'upstream/main' 2024-05-01 20:55:12 -04:00
cbt6
b8de0527e5 Give script command functions temporary names 2024-05-01 17:13:40 +08:00
Adrienn Tindall
a825ad329a replace.sh missed some things 2024-04-18 15:25:01 -04:00
Adrienn Tindall
9309dc8c1f Identify comm_ring 2024-04-18 15:21:44 -04:00
Adrienn Tindall
60f3c8bbfd Trans Type + Misc Funcs 2024-04-18 14:42:02 -04:00
Adrienn Tindall
82c6f0d857 Merge remote-tracking branch 'upstream/main' 2024-04-18 06:09:15 -04:00
Adrienn Tindall
e036c9d8fc Start identifying comm tool 2024-04-18 05:58:39 -04:00
cbt6
80b6d912fd Rename unk_0203E724.c to field_script_context.c 2024-04-18 10:19:09 +08:00
cbt6
a90ee90900 Document unk_0203E724.c 2024-04-18 01:29:07 +08:00
cbt6
7ba592f6f4 Move UnkStruct_0203E724 to unk_0203E724.h 2024-04-18 01:12:58 +08:00
TrainerRiley
95148c5036
Merge branch 'main' into poketch_buttons 2024-04-14 14:25:57 -07:00
Trainer Riley
ffaddb7c92 Address pull request comments 2024-04-14 13:43:38 -07:00
RavePossum
2e065a25ac add enum type to SetSystemButtonMode signature 2024-04-14 16:31:43 -04:00
RavePossum
a404d5156f PR feedback - change setter methods to use enums, remove duplicate include 2024-04-14 16:21:32 -04:00
RavePossum
d8319696c6 PR feedback - sound method->mode, allocmemory->new 2024-04-14 16:21:32 -04:00
RavePossum
97a4370166 Options_GetTextFrameDelay -> Options_TextFrameDelay 2024-04-14 16:21:31 -04:00
RavePossum
dc486fa0e4 delete options struct def, find a couple random places for new enum labels 2024-04-14 16:20:10 -04:00
RavePossum
36cfcbfaec mass renames for options 2024-04-14 16:20:10 -04:00
RavePossum
30b684ed8a document options, add constants file for options 2024-04-14 16:17:45 -04:00
RavePossum
554577e509 move options struct definition to options file, mass rename to game_options 2024-04-14 16:17:45 -04:00
Rachel
8c00f42e17
Merge pull request #187 from adrienntindall/main
Rename unk_0C -> saveData in FieldSystem struct
2024-04-14 12:56:58 -07:00
Adrienn Tindall
56967e4f66 Requested change
Also renamed like, one static function in field_comm_manager
2024-04-14 15:15:18 -04:00
Trainer Riley
877f06144c Rename touch_screen file 2024-04-13 23:07:00 -07:00
Trainer Riley
a4dec2033b Document PoketchButton and PoketchButtonManager, name Touch Screen location structs 2024-04-13 22:49:32 -07:00
Adrienn Tindall
8504f36ef2 TaskManager_Environment 2024-04-13 22:56:22 -04:00
TrainerRiley
59ba2ce8dd
Merge branch 'pret:main' into poketch_buttons 2024-04-12 22:05:51 -07:00
Adrienn Tindall
6bae1c3e78 Identify TaskManager 2024-04-12 21:42:04 -04:00
Adrienn Tindall
ca1a8a91b3 Identify MapObjectManager struct 2024-04-12 21:21:12 -04:00
Adrienn Tindall
84ab81d010 Rename unk_0C -> saveData in FieldSystem struct 2024-04-12 21:01:15 -04:00
Trainer Riley
259843b407 Trivial variables in button manager 2024-04-11 23:33:52 -07:00
Trainer Riley
4b25e5c53a Header declaration and redundant include 2024-04-11 23:28:29 -07:00
Trainer Riley
b43e92646a Move Button struct to header 2024-04-11 23:21:18 -07:00
Trainer Riley
c1e717f66b Rename structs and consolidate headers 2024-04-11 23:14:59 -07:00
cbt6
e3f48ae742 Use designated initializers in sMapHeaders 2024-04-12 03:33:10 +08:00
Adrienn Tindall
803d0e7dc2 Merge remote-tracking branch 'upstream/main' 2024-04-11 13:15:08 -04:00
Adrienn Tindall
264332081f Field Menu State consts 2024-04-11 13:02:11 -04:00
Rachel
ecd9ac0022 Document and clean up string_template.c 2024-04-10 15:57:34 -07:00
Rachel
69ea0c0d56 Document charcode.c 2024-04-10 15:53:27 -07:00
Rachel
e9d2fbf746 Label extern functions in charcode.h 2024-04-10 15:51:53 -07:00
Rachel
32a80719bb unk_0201D0C8 -> charcode 2024-04-10 15:50:56 -07:00
Rachel
7614259d48 Move charcode.h -> constants/charcode.h 2024-04-10 15:50:30 -07:00
Rachel
51aa33af4d UnkEnum_ov66_022324D0 -> enum PlazaMinigame 2024-04-10 15:46:01 -07:00
Rachel
56394398f3 Label extern functions in string_template.h 2024-04-10 15:38:56 -07:00
Rachel
9890becf13 StringFormatter -> StringTemplate 2024-04-10 15:23:32 -07:00
Rachel
c854473a3e unk_0200B358.[h,c] -> string_template.[h,c] 2024-04-10 15:15:46 -07:00
Rachel
42ebc60be3 Collapse struct typedef into unk_0200B358.h 2024-04-10 15:12:59 -07:00
Rachel
bcf020ad58
Merge pull request #183 from adrienntindall/main
identify communication club
2024-04-10 13:58:44 -07:00
Adrienn Tindall
d43d50850e Update comm_type.h 2024-04-10 15:58:49 -04:00
Adrienn Tindall
0ca9748f22 Added some constants 2024-04-10 15:42:05 -04:00
Rachel
dc50d8559a
Merge pull request #184 from ravepossum/misc_save
Document most of misc save block
2024-04-08 09:26:44 -07:00
Rachel
08f945c5c4
Merge pull request #181 from TrainerRiley/poketch_system
Begin Documenting Poketch System
2024-04-08 09:22:09 -07:00
RavePossum
24e930289f pr feedback: duplicate includes, string consts, filler & bitfield styling 2024-04-08 11:55:10 -04:00
RavePossum
912964b71b add newline to EOF of misc save constants 2024-04-08 10:51:27 -04:00
Adrienn Tindall
3e9b62c71c Identify field_menu.c 2024-04-08 00:29:51 -04:00
RavePossum
febc1e51a1 add typedef for extra save key 2024-04-08 00:05:06 -04:00
RavePossum
c553134f15 document most of misc save block, add constants file for misc save 2024-04-07 23:57:19 -04:00
Trainer Riley
520dea63bf Addressed pr comments. Went and found all the places that were using 7 and 8 for Heap IDs and replaced them with new IDs in constants/heap.h, and also included that header in heap.h. 2024-04-07 14:33:06 -07:00
RavePossum
7d14cfa237 move, rename, and start to document misc save structs 2024-04-07 16:11:28 -04:00
RavePossum
e93aba31ef name savedata_misc files 2024-04-07 15:44:23 -04:00
Adrienn Tindall
1753d94e07 Merge remote-tracking branch 'upstream/main' 2024-04-07 15:40:23 -04:00
Adrienn Tindall
9914197081 identify communication club 2024-04-07 15:37:59 -04:00
RavePossum
87f8e63dc0 mass renames for save data 2024-04-07 10:57:59 -04:00
RavePossum
fed1d2bd60 document the rest of savedata.c 2024-04-07 10:57:59 -04:00
Trainer Riley
85d3c6c204 Name a couple more functions and variables 2024-04-06 18:15:53 -07:00
TrainerRiley
7653399b29
Merge branch 'pret:main' into poketch_pedometer_app 2024-04-06 15:50:26 -07:00
Rachel
bf31433186
Merge pull request #177 from adrienntindall/main
Comm Player Manager
2024-04-06 08:47:59 -07:00
Trainer Riley
919f262544 Documenting Poketch System 2024-04-06 01:12:18 -07:00
TrainerRiley
0668c85c97
Merge branch 'pret:main' into poketch_pedometer_app 2024-04-05 20:24:53 -07:00
Adrienn Tindall
f15a347dd0 Requested changes 2024-04-04 12:08:26 -04:00
Rachel
ae703289a6 Rename subfolders overlay016 -> battle 2024-04-03 21:05:28 -07:00
Rachel
6f9a8aceae Document init/main/exit functions and template for battle overlay 2024-04-03 20:59:10 -07:00
Adrienn Tindall
b84b8bdc8f Rename file 2024-04-03 23:03:34 -04:00
Adrienn Tindall
81530e0dbb More docing 2024-04-03 22:37:08 -04:00
Adrienn Tindall
3672f376f7
Merge branch 'pret:main' into main 2024-04-03 18:41:03 -05:00
Adrienn Tindall
1e43770d0a v0, v1 2024-04-03 19:40:34 -04:00
Adrienn Tindall
fdc6be0ae9 Doc v2s 2024-04-03 14:27:17 -04:00
Adrienn Tindall
aa6d519b1e Identify LocalMapObject 2024-04-03 12:29:34 -04:00
Adrienn Tindall
af78055ba0 Identify PlayerAvatar 2024-04-03 11:59:08 -04:00
Trainer Riley
a20379a361 Move PoketchSystem struct and consolidate headers 2024-04-02 23:58:23 -07:00
Rachel
b8cfc8c384 Clean up overlay_manager.c 2024-04-02 21:50:16 -07:00
Trainer Riley
1591ad5d3e Merge branch 'poketch_pedometer_app' of https://github.com/TrainerRiley/pokeplatinum into poketch_system 2024-04-02 21:35:26 -07:00
Rachel
334472411b Label extern OverlayManager routines 2024-04-02 21:34:16 -07:00
Trainer Riley
9d287f9901 Rename struct to PoketchSystem 2024-04-02 21:25:53 -07:00
TrainerRiley
ecf1b686c2
Merge branch 'pret:main' into poketch_pedometer_app 2024-04-02 21:24:07 -07:00
Rachel
f5c6036f9d Document fields for structs OverlayManager and OverlayManagerTemplate 2024-04-02 21:21:58 -07:00
Rachel
a356b7cd28 unk_020067E8.[h,c] -> overlay_manager.[h,c] 2024-04-02 21:06:40 -07:00
Rachel
58a83127d8 Consolidate struct definitions for OverlayManager(Template) into single header 2024-04-02 20:55:41 -07:00
Rachel
cfb18041a1 UnkStruct_0208BE5C -> OverlayManagerTemplate 2024-04-02 18:41:31 -07:00
Rachel
319c26c4d0 UnkStruct_020067E8 -> OverlayManager 2024-04-02 18:34:47 -07:00
Adrienn Tindall
ae08bfce74 Player_{XZ}Pos 2024-04-02 19:34:31 -04:00
Adrienn Tindall
268938b9d3 CommPlayerLocation struct 2024-04-02 18:24:05 -04:00
Adrienn Tindall
815478d9d4 CommPlayerData -> CommPlayerInfo
basically the player data is better used for the coords of players on the map lol
2024-04-02 12:18:16 -04:00
Rachel
5ed4770cd9
Merge pull request #173 from adrienntindall/main
Partially document field_comm_manager
2024-04-02 09:07:09 -07:00
Adrienn Tindall
0f2291efad Destroy all traces of struct_0203CDB0 2024-04-02 11:51:00 -04:00
Adrienn Tindall
20a0be2890 rename field_comm_manager 2024-04-01 14:34:02 -04:00
Adrienn Tindall
b414311232 Begin documenting field communication manager 2024-04-01 14:07:28 -04:00
Adrienn Tindall
360517a451 UnkStruct_0203CDB0 -> FieldSystem 2024-04-01 12:44:02 -04:00
Rachel
8185c23439
Merge pull request #172 from adrienntindall/main
Document communication_information
2024-04-01 09:04:44 -07:00
Trainer Riley
d63738b1ee consolidate pedometer headers + rename header 2024-03-31 23:49:12 -07:00
Adrienn Tindall
a89a1a211b Nitpicks 2024-04-01 02:26:15 -04:00
Adrienn Tindall
6fe69ac182 requested changes 2024-04-01 01:42:36 -04:00
Rachel
6010f54a32
Merge pull request #170 from TrainerRiley/finish_poketch_data
Finished documenting PoketchData
2024-03-31 22:19:34 -07:00
Trainer Riley
45739073c0 Update dot art function names 2024-03-31 22:12:19 -07:00
Trainer Riley
40018b162c renamed pedometer functions + tweaked a couple variable names 2024-03-31 21:53:00 -07:00
Adrienn Tindall
afc558a4b1 Finish up whatever I can 2024-03-31 23:56:22 -04:00
RavePossum
bd65ac115e rename check info->valid 2024-03-31 23:53:29 -04:00
RavePossum
784d09b387 address PR feedback - pointer spacing, some names, removing unnecessary parens 2024-03-31 23:50:31 -04:00
Adrienn Tindall
f4a193de79 More communication information docing 2024-03-31 23:25:06 -04:00
Adrienn Tindall
33b191ec3c communication information more documentation 2024-03-31 22:38:21 -04:00
Adrienn Tindall
6b80f436ef identify unk_020329E0 -> communication_information 2024-03-31 21:44:49 -04:00
Adrienn Tindall
e184a2dca0 sub_02025E38 -> SaveData_GetTrainerInfo 2024-03-31 19:29:52 -04:00
Adrienn Tindall
cc888724be Identify communication_system.h 2024-03-31 19:02:36 -04:00
Trainer Riley
18d5079853 Renamed functions for clarity and removed redundant comments. 2024-03-30 14:21:33 -07:00
RavePossum
11249eaeb4 mass renames for save state documentation 2024-03-30 14:31:48 -04:00
RavePossum
6bd0a39fc1 document more save data, mostly save state 2024-03-30 14:31:48 -04:00
Trainer Riley
b96f8b96db Change unrelated enums to defines and update src and dst parameters 2024-03-29 23:26:49 -07:00
Trainer Riley
b757633b2e Finished documenting PoketchData 2024-03-29 21:49:31 -07:00
TrainerRiley
1a6121494b
Merge branch 'pret:main' into PoketchData_Calendar 2024-03-24 15:09:09 -07:00
TrainerRiley
39978b4d5f
update comments on enum values
Co-authored-by: cbt6 <91667135+cbt6@users.noreply.github.com>
2024-03-24 13:01:56 -07:00
ravepossum
455ad6e69f address PR feedback: heap enums, struct names, c99 declarations, EOF newlines, etc 2024-03-24 09:48:58 -04:00
Trainer Riley
4ec1ab0482 Add names & comments to variables and functions for the calendar in PoketchData. Also style guide cleanup. 2024-03-24 00:57:50 -07:00
ravepossum
07ead576ee rename savedata.c and .h 2024-03-23 15:46:18 -04:00
ravepossum
18990cbe8a create save table constants file, move save data structs to .h file 2024-03-23 15:19:53 -04:00
ravepossum
60b004087c move savedata struct declaration out of separate file 2024-03-23 14:57:18 -04:00
ravepossum
0b5762eb55 more documentation for savedata, better names 2024-03-23 14:43:46 -04:00
ravepossum
add731128f further documentation of save data 2024-03-23 14:41:52 -04:00
ravepossum
09389bb31b start documenting save system 2024-03-23 14:41:52 -04:00
Trainer Riley
51752d105a simplified SaveData_PoketchData, doxygenized comments, and more style guide/formatting cleanup 2024-03-22 14:53:59 -07:00
Trainer Riley
c070a7802d Replaced defines with enums, moved struct definition to the header file (and removed the old declaration header), and formatting/style guide fixes 2024-03-22 14:11:17 -07:00
Trainer Riley
706285ed88 Remove unnamed poketch data file & rename struct declaration file 2024-03-21 20:34:10 -07:00
Trainer Riley
68965f6495 Updated comments and replaced more magic numbers with defined values.
It looks like it was safe to add the save_table header in the c file; the rom still matches.
2024-03-21 19:57:13 -07:00
Trainer Riley
12dd7cc9cd More functions in PoketchData named, variables named, and comments added to all known Poketch functions so far. 2024-03-21 00:06:38 -07:00
Trainer Riley
666bcd3092 Poketch Data - named most variables in the struct, named many of its functions, and started adding comments. 2024-03-20 00:09:58 -07:00
Mr-Toodguy
0d00df331c map_headers.h spacing 2024-03-15 23:59:12 -05:00
Mr-Toodguy
f16f84298e Change mapHeaders to sMapHeaders 2024-03-15 23:53:38 -05:00
Mr-Toodguy
8981221d0f mapHeaders struct declarations & separate file 2024-03-15 23:50:56 -05:00
Mr-Toodguy
44a4ecef31 map_header struct names
mapLabelTextID & mapLabelWindowID struct parameters and lookup functions.
2024-03-15 18:43:43 -05:00
Mr-Toodguy
5dc7549581 Comments & Flag Constants for map headers 2024-03-15 18:28:13 -05:00
Rachel
7c729b6b97
Merge pull request #153 from lhearachel/trainer-ai
Rebuild trainer AI byte-code script from ASM macros
2024-02-22 09:49:32 -08:00
Rachel
01db0cca9b Dump trainer AI byte-code script 2024-02-21 13:09:55 -08:00
Rachel
6d082cafb1
Merge pull request #152 from lhearachel/summary-screen
Document core routines and structs used by the Pokemon summary screen
2024-02-21 12:25:32 -08:00
Rachel
55be86cee4 Move BattleStat and CompareSpeedResult to constgen manifest 2024-02-21 11:20:17 -08:00
Rachel
d590dd7888 Label EventFlag_VisitedContestHall, SaveData_Events 2024-02-19 15:46:19 -08:00
Rachel
6e6ecd1768 unk_0208C324 -> pokemon_summary_app + label public routines 2024-02-19 15:30:19 -08:00
Rachel
3a2fa196f6 Label fields for PokemonSummaryApp sub-structs 2024-02-19 15:27:48 -08:00
Rachel
75ef503a56 UnkStruct_0208D7BC -> PokemonSummaryApp + label struct fields 2024-02-19 15:27:42 -08:00
Rachel
93f09562ac UnkStruct_02098D38 -> PokemonSummary + label struct fields 2024-02-19 12:25:01 -08:00
Rachel
2a88567e80 Rename AnimationControlFlags -> Options + label struct fields 2024-02-19 11:25:30 -08:00
FroggestSpirit
9e5e9e7921 Update sdat.h 2024-02-14 20:53:26 -05:00
Rachel
59163ac8e9 Document Healthbar_DrawBattlerName 2024-02-11 12:18:33 -08:00
Rachel
ec274059e8 Label structs and functions used by Healthbar_DrawBattlerName
- UnkStruct_0200B358 → StringFormatter
- ov16_0223E0D0 → BattleSystem_StringFormatter
- sub_0200B5CC → StringFormatter_BufferNickname
- sub_0201D7E0 → PrintStringWithColorAndMargins
- sub_0201A870 → BGL_AddFramelessWindow
- sub_02021F98 → SpriteActor_ImageProxy
2024-02-11 12:18:32 -08:00
Rachel
0422c043a1 Document Healthbar_LoadResources 2024-02-11 12:15:37 -08:00
Rachel
337d0192bb Label routines used by Healthbar_DrawInfo 2024-02-11 12:15:37 -08:00
Rachel
72f8e8be56 Clean up Healthbar_DrawGauge 2024-02-11 12:15:37 -08:00
Rachel
b7abc09f4d Document Healthbar_DrawInfo 2024-02-11 12:15:37 -08:00
Rachel
c3a72122b9 Document routines for the healthbar scroll 2024-02-11 12:15:37 -08:00
Rachel
6c2d8d998f sub_0200D494 -> SpriteActor_SetPositionXY 2024-02-11 12:15:37 -08:00
Rachel
70cb3c61d4 Document Healthbar_Enable 2024-02-11 12:15:37 -08:00
Rachel
9961ee355a Label Healthbar member fields used by Healthbar_Enable 2024-02-11 12:15:37 -08:00
Rachel
0c75103c93 BattlerData::unk_28 -> healthbar 2024-02-11 12:15:37 -08:00
Rachel
751c1cd688 sub_0200D3F4 -> SpriteActor_EnableObject 2024-02-11 12:15:36 -08:00
Rachel
282f216aa9 Rename ov16_02266F1C -> healthbar 2024-02-11 12:12:52 -08:00
Rachel
92b461ab86 Clean up and document BattleDisplay_SlideHealthbar[In,Out] 2024-02-11 12:12:52 -08:00
Rachel
40e08d5f5d Document BtlIOCmd_SlideHealthbar[In,Out] 2024-02-11 12:12:52 -08:00
Rachel
825cc22c0b Clean up + document BattleIO_SlideHealthbar[In,Out] 2024-02-11 12:12:52 -08:00
Bepis
7287ea0105
Finish struct renames 2024-02-12 05:03:35 +11:00
Bepis
21c031dc4d
Rename typedef to PokedexData 2024-02-12 05:03:34 +11:00
Bepis
7e2ab88011
Rename forms to movesets 2024-02-12 05:03:33 +11:00
Bepis
661aa74990
Determine required pokedex expansion constants 2024-02-12 05:03:33 +11:00
Rachel
3471f61119
Merge pull request #143 from wildfire248/dex_numbers
Build SinnohDex<->NatDex mappings from source
2024-02-11 09:33:51 -08:00
wildfire
ddee29c51e Rename functions to to better fit codebase style 2024-02-11 15:42:01 +00:00
Rachel
58abb1920a Document and clean up BattleMessage_Print 2024-02-09 21:17:38 -08:00
Rachel
1374012d92 Document BattleMessage_Format 2024-02-09 20:52:00 -08:00
Rachel
e13b99d606 sub_0200C388 -> StringFormatter_Format 2024-02-09 20:46:37 -08:00
Rachel
730c99d60e Clean up and document BattleMessage_CheckSide 2024-02-09 20:28:47 -08:00
Rachel
61202bde13 Label routines used by BattleMessage_Print 2024-02-09 19:59:13 -08:00
Rachel
f9f322f442 Clean up WaitForBattleMessagePrint and BattleDisplay_PrintMessage 2024-02-09 19:56:39 -08:00
Rachel
54f84b4925 Rename some functions in battle_display.c 2024-02-09 19:45:24 -08:00
Rachel
c6b4546a92 Rename some files in overlay 16 according to function 2024-02-09 19:40:47 -08:00
Rachel
08dca8b324 Document core routines for printing text in battle 2024-02-09 19:30:33 -08:00
Rachel
8176ae0ffe Clean up improper include guard on party_gauge.h 2024-02-08 22:26:50 -08:00
Rachel
8d4cd6b9da Clean up [Show,Hide]Pokeballs routines 2024-02-08 22:19:03 -08:00
Rachel
3228d2422a Document [Show,Hide]Arrow 2024-02-08 22:19:03 -08:00
Rachel
6a178edfe3 Document SpriteTemplate struct 2024-02-08 22:19:03 -08:00
Rachel
613541aaf9 Label sprite-drawing routines used by party gauge tasks 2024-02-08 22:19:03 -08:00
Rachel
3f108548fa Document externally-visible functions for the party gauge 2024-02-08 22:19:03 -08:00
Rachel
2e2b185a0d Label routines for loading graphics resources from open NARCs
Names are copied from pokeheartgold.
2024-02-08 22:19:03 -08:00
Rachel
3fdcf8791b Synchronize struct names for graphics rendering with pokeheartgold 2024-02-08 22:19:03 -08:00
Rachel
06517be4e4 ov16_0226D094 -> party_gauge, label external routines 2024-02-08 22:19:03 -08:00
Rachel
f896d7f911 Label fields for top-level PartyGauge struct 2024-02-08 08:56:19 -08:00
Rachel
7e3fba41f9 Document enum values for controlling PartyGauge display 2024-02-08 08:54:12 -08:00
wildfire
277621e201 Document functions for NatDex/SinnohDex mapping 2024-02-08 13:35:59 +00:00
Rachel
575607a3e2 Document Battler-level PartyGauge routines 2024-02-07 16:27:04 -08:00
Rachel
f75124a49e Label struct fields for PartyGaugeTask 2024-02-07 16:17:21 -08:00
Rachel
bc303a1a86 Label core routines and struct fields for party gauge 2024-02-07 16:17:04 -08:00
Rachel
b0077dd410 Document BattleIO routines for the party gauge 2024-02-07 15:35:05 -08:00
Rachel
d64f2f90ee Document PartyGaugeData_New routine 2024-02-07 13:55:12 -08:00
Rachel
2a1de2dda8 Label PartyGaugeData struct and member fields 2024-02-07 13:29:26 -08:00
Rachel
393b24ab89
Merge pull request #139 from lhearachel/json2bin_constgen
Migrate json2bin scripts to constgen headers
2024-02-07 09:04:46 -08:00
Rachel
fdc5540fb7 Move consts used by json2bin to constgen 2024-02-06 22:29:22 -08:00
Rachel
aa7792cf03 Clean up [Get,Set]DataInternal functions in pokemon.c 2024-02-06 15:14:25 -08:00
Rachel
9246e4b890 Bulk rename known values for enum PokemonDataParam 2024-02-06 15:08:04 -08:00
Rachel
29a6c70d69 Document remaining fields in PokemonDataBlock structs + update Doxygen comments 2024-02-06 14:07:36 -08:00
froggestpsirit
2039f30af6 Pokeradar cleanup 2024-02-03 11:21:06 -05:00
Frogg
c15039e2cb
Merge branch 'pret:main' into main 2024-01-31 19:19:45 -05:00
FroggestSpirit
1ad4045316 Initial pokeradar documentation 2024-01-31 19:15:28 -05:00
Maja Kądziołka
f3604018fe
Label some code referenced by main (#133)
* main callback, hblank

* HandleConsoleFold

* WaitFrame, SoftReset, UpdateSound

* HeapCanary

* Label the RTC code

* Address review comments
2024-01-29 12:14:41 -08:00
Rachel
b7fffbfc76
Rebase + clean-up PR#115 with current project state (#134)
* improving readability

also seemingly located the party healing function

* readability

* clean it up

* Update pokemon.h

* add function names

Adds names to many unnamed functions for readability. Also adds names to a couple structs.

* add function names

* add struct names

* more functions with human names

* rename chatotcrydata

* doxygen documentation

* update box mon function

ProcessBoxPokemonWithTrainerInfo is now UpdateBoxMonStatusAndTrainerInfo and all params are labeled

* fixing formatting

---------

Co-authored-by: Jack <schoenjack98@gmail.com>
2024-01-28 19:05:12 -08:00
Rachel
2443a136ee
Merge pull request #129 from lhearachel/pokemon_cries
Document routines for initializing Pokemon cries
2024-01-28 14:59:01 -08:00
Maja Kądziołka
e4edaa7744
Apply suggestions from review 2024-01-28 02:57:28 +01:00
Maja Kądziołka
2a325ba041
File reading functions 2024-01-28 02:15:42 +01:00
Maja Kądziołka
af2ac550b1
Label touch input processing 2024-01-28 02:05:15 +01:00
Maja Kądziołka
27c4682368
Label pad input processing 2024-01-28 01:51:16 +01:00
Rachel
9535a09487 First pass at labelling AI script commands 2024-01-26 21:49:07 -08:00
Rachel
620cab7dc0 Document entry-routines for playing Pokemon cries 2024-01-26 21:41:57 -08:00
Rachel
825e3f3cc4 Label functions used for playing Pokemon cries 2024-01-26 20:48:55 -08:00
Rachel
4739e0ed14 Label + document ChatotCry struct 2024-01-26 20:43:50 -08:00
Rachel
7e1574a1ee
Merge pull request #126 from lhearachel/hidden_items
Document hidden field items table
2024-01-25 11:13:56 -08:00
Rachel
2cec41cc12 Document hidden field items table 2024-01-25 10:35:46 -08:00
Rachel
09e74fff71 Document mid-turn switch AI functions 2024-01-24 22:33:30 -08:00
Rachel
b876960686 Document AI-visible damage calc 2024-01-24 22:33:25 -08:00
Rachel
60661e1270 Document simple non-command static functions in trainer_ai.c 2024-01-24 22:25:07 -08:00
Rachel
e90979f61c
Merge pull request #123 from lhearachel/battle_scripts
Dump + rebuild the contents of battle scripting NARCs
2024-01-24 22:24:49 -08:00
Rachel
9d7019b8b0 Add new consts used by battle scripts 2024-01-23 17:34:18 -08:00
Rachel
f46a747f0e Rename BATTLE_SUBSEQ consts to BATTLE_SUBSCRIPT + move to constgen manifest 2024-01-23 17:34:11 -08:00
Rachel
ba60196b55 Move global-level consts used by battle scripts to constgen manifest 2024-01-23 17:33:17 -08:00
Rachel
5dcb0c3657 Update battle-constant headers for assembler compatibility 2024-01-21 15:41:30 -08:00
Rachel
3ebdbdc042 Document Main routines for singles and doubles AI 2024-01-20 21:13:35 -08:00
Rachel
0ecc4a679c Document extern functions for overlay 14 (trainer AI) 2024-01-20 19:49:31 -08:00
Rachel
93d56d6d5c Label extern functions in overlay 14 2024-01-20 18:40:11 -08:00
Rachel
36cc961bc9 Rename ov14_0221FC20.[ch] -> trainer_ai.[ch] 2024-01-20 18:38:44 -08:00
Rachel
7bf253a4d6 Move enum-based battle constants to constgen schema 2024-01-08 20:50:36 -08:00
Rachel
04a0cbf3a8 Document functions for loading data from height.narc and height_o.narc 2023-11-28 13:16:32 -08:00
Rachel
067064329c Document functions for loading data from pl_poke_data archive 2023-11-18 21:45:29 -08:00
Rachel
d65696c042 Label functions for PokeSprite data-loading 2023-11-18 21:42:06 -08:00
Rachel
1d055f3048 Document structs used for loading data from pl_poke_data.narc 2023-11-18 21:17:55 -08:00
Rachel
fb8632ce43 Rename ov16_0225177C -> battle_lib 2023-11-14 22:45:28 -08:00
Rachel
0052320f3b Document BattleAI_SwitchedSlot, Battle_RecordingStopped, and BattleSystem_InitPartyOrder 2023-11-14 21:42:27 -08:00
Rachel
bfefa854aa Document BattleSystem_SetPokemonCatchData 2023-11-14 21:42:27 -08:00
Rachel
6c05a9aa6e Document App_BarColor, HealthBar_Color, and Battler_CryModulation 2023-11-14 21:42:27 -08:00