Users on Discord have been reporting issues with this setting enabled. The reason given for disabling `SyncOnSkipIdle` 13 years ago was "Idle skipping slows down the game." Re-enabling it gets rid of the issue entirely.
I've ported a couple of shaders from RetroArch - particularly the
crt-pi and crt-lottes-fast ones. Unlike other shaders such as
crt-royale, these shaders are single-pass, allowing them to work
within Dolphin's framework. These look pretty good when paired with
native resolution and SSAA.
The main use case is for games that in theory should be compatible with `EFBToTextureEnable = True`, as the CPU never reads the EFB texture and only writes to it completely.
However, if what the CPU writes is only zeros, if the texture in RAM was already zeros then Dolphin wouldn't notice the change in RAM and thus wouldn't invalidate the texture in VRAM.
This happens in Rhythm Heaven Fever, and with this change it doesn't require `EFBToTextureEnable = False` anymore.
But there are other use cases, like setting a clear value that is closer to what the EFB copy would be, like in Excite Truck.
(`EFBToTextureEnable` is still `False` by default.)
Other games are more subjective (and not changed here): for instance Mario Kart Wii samples the EFB copy to decide whether to display a sun flare.
Currently with `EFBToTextureEnable = True` (default) it will never be shown, but maybe someone would prefer for the flare to always be shown, even behind walls.
The option currently only supports setting a single byte (that will be memset to the entire texture), as setting a color would be more complex given that a texture can be in multiple formats, and there is no use case (yet) for it.
This game contains a special episode of the Pokémon anime as an FMV.
When playing it, if only a tiny part of the image has changed between
frames, Dolphin's texture hashing can fail to notice that anything
changed, or it can notice that the chroma changed but not the luma, or
vice versa.
512 samples reduces the problem but doesn't get rid of it entirely, but
with 2048 I'm unable to see the problem.
Some of the speed hacks were not approved for RetroAchievements, meaning that users had to choose between not getting hardcore achievements, or having poor performance.
Also, renamed the instances of `$Limit internal FPS to VPS (improves performance)` to `$Limit internal frame rate (speed hack)` for consistency. They are enabled by default, so unless the user disabled them, it won't break the configuration.
Extrems said that it's unnecessary because GBIHF doesn't use the GPU.
Video output doesn't work in GBIHF in Dolphin regardless of this
setting, so I can't actually test it.