Add flags to pkl, +2 to each entry (oh well, maybe they'll add maxIV too)
Use flags to for random met date to a more reasonable day.
Use flags to remap displayed date range to the reasonable range.
Slot objects now require 3 less bytes to store their properties
pkl encounters now store minIV, minLevel, BallRestrict separately from PogoType
PogoType remains as decorative, no derivations
Simplify date/day juggling, only need DateOnly day numbers.
my only dump was from 2016; was updated later for gen7 & usum, so that new larger format needed support too.
just auto-update the gen6 dump, nobody should have it besides a select few archivists
extra warnings:
- do not move/deposit/withdraw pokemon: the upload-format tracking will desync as it is not updated. the box-slot readwrite api is not virtualized where I can easily start doing that.
- do not read unconverted gen6 slots. the program assumes they are gen7 format already. if ripping data out, be sure to reference the format byte. once more savefile examples are looked at, maybe I can figure something out.
Closes#4866: Slot Set now uses default settings instead of "None" update. `SlotEditor.cs`
Closes#4865: Return entire list of party data instead of first slot. No need to filter `GetChangelogSlots`.
Resolves#4867: Update Run button enabled state when finishing the applicability scan.
Add a note about bad rand range (`.Species=$100,$200` causes an internal error when executed). We don't care if SetRandomRange fails.
Uses the slot-present count in the box data header, same logic as Stadium 1.
Closes#4861
I assume Japanese-Stadium1 has the same issue, but I cannot find a reference save file with any box slots present. The count might be at offset 0x14 based on previous documentation threads on pporg.
add ampersand escape for display, and add some suppression for roslynator error that isn't needed.
illegal by default, opt in
It's an extremely precise exploit that can even apply ribbons to eggs; RSBOX allows mutating the party when it should be "locked" in the brief moment before the ribbons are awarded. Permitting this exploit is generally against community consensus, so it's an opt-in. Eggs will be flagged, even though the exploit can be used to get ribbons on the eggs.
ty C87H176 via pporg:
https://projectpokemon.org/home/forums/topic/68163-how-to-give-ribbons-to-legendary-pok%C3%A9mon-using-pok%C3%A9mon-box-ruby-sapphire/
I considered making this an enum setting like the others, but the ribbon API doesn't support non-boolean verdicts at this time.
also translate the new batch editor controls from the previous pull request
if you close the form after running a batch edit, it allows you to undo
if you want to undo while the form is still up, you can reset back to the initial state
buttons only enable when sufficient progress/available slots (so it doesn't run on 0/0)
shows a live-updating count of how many pkm slots will be edited by your currently entered command
Pass CancellationToken thru and better scan drive types to see if we bother trying to access them.
Network drives and CD drives are now disallowed, which should lessen the amount of hang-hiccups on startup for some users' hardware setup.
* Recursive egg chain solver
Supercedes #4444
- Handles Volbeat/NidoranM specific inheritance cases
- Handles Smoochum(female-only) male father search cases
- Allocation free, result struct
Closes#4426
Removed unreachable eggmoves from gs:
no Charm for Bulbasaur
no Charm for Oddish
no Charm for Snorlax
no AuroraBeam for Staryu
no Barrier for Staryu
no Supersonic for Staryu
no LovelyKiss for Smoochum
pass a ref struct storing the result, which updates with transactions to log the verification state during the recursion.
* Print traced chain in verbose report
Added functionality to exclude the opposite-gender rival (self) from PokeGear callers.
* Remove Bike Shop from Pokegear callers list: It's not legally obtainable you only get called once you've used the Bike enough you never get to save it.
* Exclude bike shop in caller list logic
Updated logic to exclude both the rival and bike shop from the caller list.
Better there and now public for anyone to use (why would they want to check that lol)
make the Battle Frontier hashset a ReadOnlySpan;
- since the list is sorted, use BinarySearch to reduce worst case from 43 ops to 6.
- no static ctor in RibbonRules (yay no nanosecond hiccup)
that was the last static HashSet in the repo 👀
It's stored as a 3-variable value. Decompose & recompose in the GUI.
Closes#4841 -- Raffle is values 1-10, which explains the observed behavior in the issue.
The old GUI would set [-1, 7], if modified to any selected Shop type, results in all being Raffle (incorrect behavior).
By unpacking to separate variables, the 1-321 combinations are user adjustable rather than just showing the raw value for edits. Sure the Version could be localized, and Shop Rank could be [1,10] instead of [0,9]...
ref: https://bulbapedia.bulbagarden.net/wiki/Join_Avenue#Shop_rank
Windows.Forms quirk where it don't hide the dropdown when it tries to Suggest via the separate Suggest pop-down.
Since all comboboxes that do the databind+suggest are impacted by this, just add the event when initializing binding. There don't appear to be any reapply-binding cases where it is set to suggest (only case is Battle Revolution save select, which isn't textual entry).
Closes#4846
Ensure all have dashes at front
for multiple strings, separate out the GB/VC to a separate tag.
No longer does the program show `SAV3FRLGUGBA` instead of `SAV3FRLG-U [GBA]`, which is a little more transparent to the end user.
I accidentally reverted my intermediate value sum for the channel solver after I discovered the counterexample -- now with the refinements as detailed in the issue, we can proceed with many `long` => `uint`
The xoroshiro128+ solvers aren't really set up to take advantage of the eager returns; the iterator struct (not class) would have to be made heavier to store the intermediate values for a given `assume`. Probably would have to inline the methods and break out their inner Update steps. Probably not worth the hassle :)
Closes#4844
Co-Authored-By: StarfBerry <65578604+StarfBerry@users.noreply.github.com>
#4844
not yet implemented: xoroshiro algorithmic improvements
overflow counterexample for channel IV reversal regarding s32 vs s64 noted in the github issue
Co-Authored-By: StarfBerry <65578604+StarfBerry@users.noreply.github.com>
