dannye
c42e577957
Fix CorkscrewPunchName and FireWingName labels
2025-12-06 15:34:10 -06:00
dannye
49fdda705f
Remove extra space
2025-12-06 15:12:24 -06:00
dannye
334b34c46f
Fix some typos
...
and other minor cleanup
2025-12-06 15:09:54 -06:00
dannye
fc6d216c17
Merge pull request #50 from ElectroDeoxys/master
...
Extract and document effect commands
2025-12-06 15:08:50 -06:00
dannye
d129e4eef5
Improve mail data macros
...
and other minor cleanup
2025-12-06 11:28:07 -06:00
dannye
bc54f4603f
Merge pull request #48 from mdraves91/pause-menu-disasm
...
Disassemble and document pause menu functions
2025-12-06 11:24:49 -06:00
Electro
7af67c323a
Extract and document effect commands
2025-12-03 15:11:15 +00:00
Mitchell Draves
5d6428884c
apply PR suggestion
...
Co-authored-by: Kensuke Sano <earthoul@users.noreply.github.com >
2025-11-28 17:43:10 -06:00
mdraves91
f6aaaf1e69
rename settings to config
2025-11-28 17:40:30 -06:00
mdraves91
833a6e927f
batching up a few PR suggestions from @earthoul:
...
- create MAIL_MAX_ON_SCREEN
- fix call to stray Func_8f6b label
- disasm new .SpriteAnimGfxParams
- touch-ups to DrawMinicomMainScreen
2025-11-20 09:20:05 -06:00
Mitchell Draves
411a03e52e
Apply suggestions from code review
...
from @earthoul. small amendments by myself to fix names of functions called that did not come through the github commit.
Co-authored-by: Kensuke Sano <earthoul@users.noreply.github.com >
2025-11-20 08:58:00 -06:00
mdraves91
d123b4619f
replace a ld with appropriate character constant "の"
2025-11-16 15:58:26 -06:00
mdraves91
3371096210
light documentation of UpdateMailboxPage and functions in its call hierarchy
2025-11-16 15:56:34 -06:00
mdraves91
8602c8802e
disasemble Func_1ef2a
2025-11-16 15:23:04 -06:00
mdraves91
eec0aa5c59
send_mail script command
...
missed adding this file two commits ago, oops
2025-11-16 13:20:24 -06:00
mdraves91
f9f9f28bbd
fixed minicom typo
...
I mistyped minicom as minicon in a lot of places. oops
2025-11-16 13:04:47 -06:00
mdraves91
1316fa2fc8
documenting a number of commands related to sending/delivering mail
...
also identified script_command_64 as the send_mail command!
2025-11-16 13:02:23 -06:00
mdraves91
2fef8e6783
adding a few more mail-related constants
2025-11-16 11:12:25 -06:00
mdraves91
0f444f8e41
documenting mail body commands
2025-11-16 10:59:42 -06:00
mdraves91
f2d40cc2fa
labelling mail body text
2025-11-16 09:58:19 -06:00
mdraves91
e8c62bde65
dumping mail data
2025-11-16 09:37:27 -06:00
mdraves91
9525678649
disassembling mailbox scene data
2025-11-16 09:24:25 -06:00
mdraves91
7cdeea6f20
documenting lots of code and wram related to the minicom mailbox
...
I checked the new WRAM values in-game with a debugger
2025-11-16 09:15:56 -06:00
mdraves91
6718adb2c0
disassemble .minicon_functions
2025-11-14 22:11:26 -06:00
mdraves91
a7af3d69a2
documenting code that came from disassembling the DeckBuildingParams function
...
like previous commits, most of these names were copied from poketcg1 (where the code was the same)
2025-11-14 21:48:10 -06:00
mdraves91
b2c3808230
disassemble function map
2025-11-14 15:08:54 -06:00
mdraves91
77b6460ecf
disassemble DeckBuildingParams function
2025-11-14 14:48:57 -06:00
mdraves91
e26340f332
documenting deck menu
...
the bulk of the names for functions, labels, wram and constants came from corresponding code in poketcg1
this refactoring extends outside the scope of newly disassembled code from the pause menu, and into code that was disassembled from the big mapfunctions dump
2025-11-14 13:59:52 -06:00
mdraves91
36bb0e4197
documenting pause menu functions
...
status screen, diary screen, and a the initiaL minicon screen
2025-11-14 10:09:24 -06:00
mdraves91
99bc9feec8
disassembling two menu data structures, using new macros
2025-11-14 08:57:01 -06:00
dannye
22118abff7
Use features of RGBDS 1.0.0 ( #47 )
2025-11-12 21:52:50 -06:00
mdraves91
b55dc16cc4
documenting newly disassembled textitems
2025-11-11 09:33:26 -06:00
mdraves91
58e0119e1e
disassembling text item data in newly dumped functions
2025-11-11 08:30:03 -06:00
mdraves91
6190d4499f
filling in text constants, coords and other magic numbers
...
in functions called by the pause menu
2025-11-11 08:18:30 -06:00
mdraves91
8d4b602bde
disasm pause menu key_functions
2025-11-11 08:13:12 -06:00
dannye
8cbb1f544a
Disassemble GR Island player paths
...
finishes bank c
2025-11-09 12:25:04 -06:00
dannye
bebad8d219
Merge pull request #45 from mdraves91/tcg2disasm-recursive
...
enhance tcg2disasm.py to recursively dump unknown called functions
2025-11-08 15:00:37 -06:00
dannye
0cb28fe068
Merge pull request #44 from earthoul/sfx
...
Identify songs, SFXs, and duel anims
2025-11-08 14:48:48 -06:00
dannye
bce5c8b4b4
Merge branch 'master' of github.com:pret/poketcg2 into sfx
2025-11-08 14:48:05 -06:00
dannye
8f11c20265
Merge pull request #43 from mdraves91/start-up-debug-menu
...
dissasemble Startup debug menu
2025-11-08 14:02:31 -06:00
dannye
0746a74594
Minor cleanup
2025-11-08 13:58:25 -06:00
earthoul
c3453d25d6
Refactor confirm-cancel SFX codes
2025-11-08 18:06:29 +09:00
earthoul
5754313c10
Update music constants
2025-11-06 18:43:06 +09:00
mdraves91
790c5022ab
fix: bank1calls to functions that were not yet disassembled were generating Func_xxx labels that did not point to bank1
2025-11-05 10:39:38 -06:00
earthoul
8f3db0ab88
Fix tileset labels + refactoring
2025-11-05 21:39:40 +09:00
earthoul
31130185df
Fix GR Blimp labels and file names
2025-11-05 19:02:58 +09:00
earthoul
f25a04fb76
Identify songs and slot SFXs
...
Also refactor song labels and files
2025-11-05 18:54:49 +09:00
earthoul
6d55435c70
Update SFX file names
...
Also identify TCG1 leftovers and re-organize a few labels
2025-11-05 14:48:57 +09:00
mdraves91
65c9e971c4
fix: jr opcodes being output twice
2025-11-04 21:30:05 -06:00
mdraves91
de2035f223
change the way tcg2disasm.py handles "end" offsets provided to the script, and allow multiple addresses to be passed for disassembly
...
This allows a more flexible script when working with or without the new recursive feature.
Also, the previous behavior was very unintuitive, and probably not that helpful.
Before, if you provided an "end" offset, the script would go AT LEAST as far as that offset, but would not terminate if it still hadn't found a ret command, and had satisfied all of the other stop conditions. This made it very easy to pass an "end" argument that caused the script to disassemble past the real end of the function, and in many cases get stuck in an infinite loop.
However, if you also provided the "dry-run" arg, it would set the "hard stop" flag, which instead made it so that the disassembler would actually stop dead when hitting the "end" offset.
Now, you must pass the stop offset to the --hard-stop arg, and it will act like the previous dry-run/hard-stop. The other behavior (that likes to get stuck in infinite loops) is no longer available.
2025-11-04 19:22:08 -06:00
