Apply suggestions from code review

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
This commit is contained in:
Narishma-gb 2025-12-15 17:42:31 +01:00 committed by GitHub
parent a2263cdb22
commit 3562d1f774
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 9 additions and 9 deletions

View File

@ -1097,8 +1097,8 @@ SetAnimationBGPalette:
ldh [rBGP], a
ret
AnimationUnusedShakeScreen:
; Shakes the screen for a while. Unreferenced.
AnimationUnusedShakeScreen: ; unreferenced
; Shakes the screen for a while.
ld b, $5
AnimationShakeScreenVertically:

View File

@ -13,7 +13,7 @@ TransformEffect_:
ld de, wBattleMonSpecies
ld bc, wPlayerBattleStatus3
ld [wPlayerMoveListIndex], a
; bug: this should be target's BattleStatus1 (ie wEnemyBattleStatus1)
; bug: this should be target's BattleStatus1 (i.e. wEnemyBattleStatus1)
ld a, [wPlayerBattleStatus1]
.hitTest
bit INVULNERABLE, a ; is mon invulnerable to typical attacks? (fly/dig)

View File

@ -156,7 +156,7 @@ ItemUseBall:
dec a
jr nz, .notOldManBattle
; Old Man Battle
; Old Man battle
ld hl, wGrassRate
ld de, wPlayerName
ld bc, NAME_LENGTH

View File

@ -94,7 +94,7 @@ CalcPositionOfPlayerRelativeToNPC:
ld a, [hli] ; NPC sprite screen Y position in pixels
call CalcDifference
jr nc, .NPCSouthOfOrAlignedWithPlayer
; NPC North of player
; NPC north of player
push hl
ld hl, hNPCPlayerRelativePosFlags
bit BIT_PLAYER_LOWER_Y, [hl]
@ -122,7 +122,7 @@ CalcPositionOfPlayerRelativeToNPC:
ld a, [hl] ; NPC sprite screen X position in pixels
call CalcDifference
jr nc, .NPCEastOfOrAlignedWithPlayer
; NPC West of player
; NPC west of player
push hl
ld hl, hNPCPlayerRelativePosFlags
bit BIT_PLAYER_LOWER_X, [hl]

View File

@ -43,7 +43,7 @@ TryPushingBoulder::
jr z, .pushBoulderLeft
cp SPRITE_FACING_RIGHT
jr z, .pushBoulderRight
; push boulder Down
; push boulder down
bit B_PAD_DOWN, b
ret z
ld de, PushBoulderDownMovementData

View File

@ -546,7 +546,7 @@ ContinueCheckWarpsNoCollisionLoop::
; if no matching warp was found
CheckMapConnections::
; check West map
; check west map
ld a, [wXCoord]
cp $ff
jr nz, .checkEastMap
@ -2046,7 +2046,7 @@ LoadMapHeader::
; copy connection data (if any) to WRAM
ld a, [wCurMapConnections]
ld b, a
; check North
; check north
bit NORTH_F, b
jr z, .checkSouth
ld de, wNorthConnectionHeader