Leahnaya/pokegold
1
0
Fork 0
mirror of https://github.com/pret/pokegold.git synced 2026-04-25 16:20:19 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity
908 Commits 2 Branches 0 Tags 21 MiB
1675a00a42
Commit Graph

908 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rangi42
1675a00a42 Use constants for VBlank handlers 2024-05-22 21:02:56 -04:00
Idain
a62dfe8548 Add more assert cases in the codebase (pret/pokecrystal#1115) 
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
 2024-04-27 12:23:02 -05:00
SnorlaxMonster
144133d98e Rename MON_ID to MON_OT_ID (pret/pokecrystal#1114) 
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2024-04-27 12:21:32 -05:00
vulcandth
202797a008 Fix/update sprite y-coord offscreen definitions (pret/pokecrystal#1108) 2024-04-14 16:09:18 -05:00
mid-kid
41c224f460 Use "pkg" in termux instructions instead of "apt" directly 2024-04-14 15:58:07 -05:00
Rangi42
c41e710a0d Disable LodePNG auto-encoding the bpp2png image 2024-04-14 15:57:55 -05:00
Damien Doury
0929c2a320 Fix wrong text labels in VermilionPort.asm 
The text label said "Monday" when it actually displayed "Wednesday".
 2024-01-30 12:08:13 +00:00
Rangi42
9630f4b0cf Legacy support for refreshscreen and reloadmappart 2024-01-29 18:58:50 -05:00
xCrystal
257d56018d Address PR suggestions (#1078) 2024-01-30 00:42:08 +01:00
xCrystal
df10c9ea1a Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-30 00:41:51 +01:00
xCrystal
59642837e9 more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-30 00:41:00 +01:00
xCrystal
f035cd599c Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-30 00:35:14 +01:00
xCrystal
10d38669b0 In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-30 00:31:05 +01:00
xCrystal
aac0d97362 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
 2024-01-30 00:27:27 +01:00
xCrystal
c0812ca008 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-30 00:26:13 +01:00
mid-kid
a8bb1bf942 Embed warp_connection.asm in map.asm 
It's not a sensible split and falls in the middle of a file.
This realigns the code with what crystal has
 2024-01-29 23:34:06 +01:00
Rangi42
202282b15b Fix bug doc formatting 2024-01-01 22:09:41 -05:00
Rangi42
16571da5eb Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names 2024-01-01 21:58:26 -05:00
SoupPotato
a1c8b2d7dd Document SFX_RUN does not play correctly when a wild Pokemon flees from battle (pret/pokecrystal#1099) 
Co-authored-by: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
 2024-01-01 20:42:29 -06:00
mid-kid
dee2edf200 Clarify windows versions in INSTALL.md 2024-01-01 20:40:33 -06:00
Rangi42
8570f05068 charmap.asm should come first so other files can use them 2024-01-01 20:39:06 -06:00
Rotekoppen
f69e256d60 Update install instructions for Arch Linux 
RGBDS is now available in the official repos as community/rgbds
 2023-11-21 17:00:36 -06:00
vulcandth
7301cf40de Move charmap.asm to constants/ 
Resolves #1090
 2023-11-17 22:03:29 -06:00
AnonymousRandomPerson
bea7f055f4
Replaced decomp list with pret.github.io link (#112) 
* Replaced decomp list with pret.github.io link

* Align with pokecrystal's readme

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-11-17 20:28:15 -06:00
Idain
859b45abcf Improve use of palette macro and use PAL_* constants (pret/pokecrystal#1087) 
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-11-17 18:27:43 +00:00
SnorlaxMonster
7266ac4bdc Correct macro for default Mystery Gift item (pret/pokecrystal#1084) 
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-11-17 18:19:26 +00:00
Idain
5140706094 Use proper constant for battle stats (pret/pokecrystal#1088) 2023-10-23 19:10:43 +00:00
vulcandth
70f883dc86 Sync sprite and battle anim consts/labels (pret/pokecrystal#1055) 
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
 2023-09-17 14:48:08 -05:00
Tiddlywinks
1a5c2b0414 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:07:13 +02:00
vulcandth
573f07e5fa CI copy .map files to symbols branch 2023-08-23 13:04:10 +02:00
SoupPotato
97a3786fc8 Labeled framesets and related constants (pret/pokecrystal#1063) 
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-08-21 19:11:14 -05:00
Idain
caffcdd9f7 Replace hardcoded numbers for stats (pret/pokecrystal#1073) 2023-08-21 15:56:09 +00:00
AnonymousRandomPerson
e86e45ee58 Added newer decomp projects to readme 2023-08-19 13:30:54 +00:00
Rangi
e06a6b1550 Fix segfaults at EOF, add token/newline checks, and support '\r' in scan_includes.c 2023-08-15 19:22:24 -04:00
vulcandth
51a98ac773 Define relationship between map_object and object_events (pret/pokecrystal#1054) 2023-08-14 14:20:46 +00:00
vulcandth
47c19fd588 Document fix about AI item pointer overflowing (pret/pokecrystal#1066) 
Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
 2023-08-10 17:26:32 -05:00
SnorlaxMonster
a4aa97213d Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (pret/pokecrystal#1058) 
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-07-27 10:53:25 -05:00
Idain
63d552f6e5 Replace magic numbers with TILE_WIDTH (pret/pokecrystal#1056) 
* Replace magic numbers with TILE_WIDTH

* Address more instances
 2023-07-27 10:51:54 -05:00
SatoMew
f78c622e62
Port pokered's comments about NullChar (#110) 2023-07-26 20:03:05 -05:00
vulcandth
13b703511b Use BattleAnim_Dummy in data/moves/animations.asm (pret/pokecrystal#1052) 2023-07-18 16:24:23 -05:00
vulcandth
3edd4eb48d Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (pret/pokecrystal#1053) 2023-06-01 12:54:49 +00:00
Idain
be7c950f05 Use NO_INPUT instead of magic number (pret/pokecrystal#1051) 
This is for the Virtual Console builds, where it disables the print functions of Unown and Mail.
 2023-05-28 09:17:03 -05:00
mid-kid
b926758efb Fix tools/free_space.awk for new rgbds (pret/pokecrystal#1049) 2023-05-17 15:55:33 +00:00
Idain
dc77fcf2c7 Fix macro definitiosn for unused commands 2023-05-08 01:11:57 +02:00
mid-kid
d8512cd864 Use time capsule label for time capsule copies 2023-04-19 19:11:32 +02:00
mid-kid
d04f895040 Use more appropriate labels for link operations 2023-04-19 19:11:26 +02:00
mid-kid
4cd953c1e5 Define SERIAL_PATCH_PREAMBLE_LENGTH 
Crystal: 86cc644b970eecfb616b858ad8b697f9a09f57eb
 2023-04-19 19:11:15 +02:00
mid-kid
5801a30424 Label wOTLinkBattleRNData 2023-04-19 19:09:40 +02:00
mid-kid
7050425c82 Document link patch lists a little bit better 
Crystal: c8738a3aaecacd1ceec96bc6ccd80592f44de0fc
 2023-04-19 19:09:25 +02:00
mid-kid
f69fc68d0a Unionize wSwitchMonBuffer 2023-04-19 19:08:40 +02:00