PikalaxALT
14aa5bf52f
Remove unused, unneeded fields from BattleHealthboxInfo
2021-03-15 20:17:47 -04:00
PikalaxALT
81da6acff5
battle_gfx_sfx_util sync emerald names to unnamed syms
2021-03-15 19:32:49 -04:00
PikalaxALT
c6563b78c0
Sync new field name in BattleStruct
2021-03-15 16:19:15 -04:00
PikalaxALT
2f4f63afdb
Document old man batttle controller
2021-03-15 14:27:50 -04:00
PikalaxALT
df9bed0548
Revert HERE and USED macros
2021-03-15 08:33:37 -04:00
PikalaxALT
37537e38f9
Merge branch 'master' of github.com:pret/pokefirered into battle_multi_buffer
2021-03-14 21:04:11 -04:00
PikalaxALT
31f4edbe50
Document more symbols in battle
2021-03-14 20:10:19 -04:00
GriffinR
077faeb1bd
Use global symbols for assembly on modern
2021-03-14 19:13:23 -04:00
PikalaxALT
99ec579deb
Name symbols in battle_anim_special.c
2021-03-14 16:29:33 -04:00
PikalaxALT
75b9fbc92f
check __CLION_IDE__ predefine in global.h
2021-03-13 17:51:27 -05:00
PikalaxALT
f7f7e9a70d
More documentation in battle_main
2021-03-12 16:56:09 -05:00
PikalaxALT
b38a5a85d4
Resolve link comm buffers in gBattleStruct
2021-03-12 15:37:28 -05:00
GriffinR
1c03a923b7
Merge pull request #399 from Deokishisu/patch-1000
...
Fix Typos / Use Box Constants / Name an Unknown
2021-03-11 15:11:53 -05:00
GriffinR
28e3522acb
Use NONMATCHING on modern for gcc-arm-none-eabi
2021-03-10 17:55:46 -05:00
Deokishisu
0589bd5827
Fix Typos / Use Box Constants
...
The Celadon City scripts that give Eevee misspelled it as Eeevee. Fixed.
The comment explaining `boxRSEggsUnlocked` in the `ExternalEventFlags` struct had an incorrect deposit requirement listed and was fixed.
Also, replaced the literals with the `TOTAL_BOXES_COUNT` and `IN_BOX_COUNT` constants in `pokemon.c`'s `IsPokemonStorageFull` function. Thanks hjk321 for pointing that out.
2021-03-10 16:22:08 -05:00
hjk321
fc16ee9498
Fix storage magic numbers
...
I could *kinda* understand missing SendMonToPc, but IN THE STRUCT ITSELF?!
2021-02-22 10:04:27 -06:00
Deokishisu
57e3f5e0f8
Mirror pokeemerald PR#1329 & PR#1335 to pokefirered
...
The `giftRibbons` field in `SaveBlock1` has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and FRLG. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented.
The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the `obedient` bit was renamed `eventLegal`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.
I still maintain that `eventLegal` is a misnomer and it should be called `fatefulEncounter` in all three repos.
2021-02-16 16:56:31 -05:00
Deokishisu
fc623d2abf
Rename "Hidden" Movement Type to "Buried"
...
This commit mirrors the change to pokeemerald that renames `MOVEMENT_TYPE_HIDDEN` to `MOVEMENT_TYPE_BURIED` to avoid confusion between it and `MOVEMENT_TYPE_INVISIBLE`.
As the files and function labels are not synced between the two repos, only the necessary changes were made based on what pokefirered calls its functions. More syncing of labels with pokeemerald will need to be done in the future.
2021-02-14 14:59:10 -05:00
GriffinR
8c66bde715
Merge pull request #388 from GriffinRichards/constants-localids
...
Use more LOCALID constants
2021-02-14 14:07:32 -05:00
GriffinR
b422fd4a49
Merge pull request #389 from Kurausukun/dexmatching
...
[LEAK-INFORMED] match the rest of pokedex_screen
2021-02-14 11:18:46 -05:00
GriffinR
1b84bd395d
Fix warning about gMonPaletteTable section
2021-02-12 17:18:14 -05:00
Kurausukun
ccd75ad32e
words are hard
2021-02-11 23:12:55 -05:00
Kurausukun
2ff02b3c5a
fix whitespace, update dex category macro
2021-02-11 23:06:33 -05:00
Kurausukun
6c77c7a714
[LEAK-INFORMED] match the rest of pokedex_screen
2021-02-11 21:50:39 -05:00
GriffinR
515dde69af
Use more LOCALID constants
2021-02-10 20:20:15 -05:00
Deokishisu
b423d06cd9
Fix "Compatibility" Misspelling
...
Someone misspelled "compatibility" as "compatability" in pokeemerald and the error was brought over to pokefirered.
2021-02-05 01:17:54 -05:00
GriffinR
1f6dc0e86b
Use trainer constants in flags, automatically update flags/vars count
2021-01-29 15:50:01 -05:00
GriffinR
9350e2d338
Sync mapjson with pokeemerald
2021-01-19 01:38:15 -05:00
GriffinR
9509797b98
Remove deadnaming, sync BgEvent
2020-12-31 14:24:30 -05:00
GriffinR
f8a1bf14fb
Merge pull request #371 from GriffinRichards/data-pokedex
...
Move pokedex_screen data from asm to C
2020-11-27 11:12:05 -05:00
Ashley Coleman
06b6853fb8
Rename farfetchd graphics to match define
2020-11-26 11:26:05 -08:00
GriffinR
1d820d4e0f
Clean up pokedex screen text
2020-11-12 00:06:22 -05:00
GriffinR
66e9059578
Move pokedex_screen data from asm to C
2020-11-11 23:44:30 -05:00
PokeCodec
26ac9c5faf
Match Most of Remaining Functions
2020-09-01 11:42:28 -04:00
GriffinR
bb56d4a3f4
Give songs meaningful english names
2020-08-29 03:11:03 -04:00
luckytyphlosion
ed4a703838
Apply static modifier to static functions in PSS.
2020-07-04 20:54:24 -04:00
luckytyphlosion
1ad6f5270c
Port over PSS data to src.
2020-07-04 20:32:44 -04:00
luckytyphlosion
d7df6bf6e3
Get rid of manual sym defines in sym_ewram.txt and ld_script_modern.txt
2020-07-04 18:14:40 -04:00
luckytyphlosion
db2fb7785d
pokemon_summary_screen.c, part 12.
2020-07-04 16:07:40 -04:00
luckytyphlosion
7cb48a704a
pokemon_summary_screen.c, part 10.
2020-07-03 19:40:10 -04:00
luckytyphlosion
f8247cdd79
pokemon_summary_screen.c, part 9.
2020-07-03 17:42:40 -04:00
luckytyphlosion
9453c154d7
pokemon_summary_screen.c, part 8.
2020-07-02 20:19:37 -04:00
luckytyphlosion
d9d3ac1c5d
pokemon_summary_screen.c, part 7.
2020-07-02 16:45:49 -04:00
luckytyphlosion
91fea55a24
pokemon_summary_screen.c, part 6.
2020-06-25 12:59:37 -04:00
luckytyphlosion
114a5b9b6f
pokemon_summary_screen.c, part 5.
2020-06-24 13:57:19 -04:00
luckytyphlosion
a04106a011
pokemon_summary_screen.c, part 4.
2020-06-23 22:06:21 -04:00
luckytyphlosion
d096f37d75
pokemon_summary_screen.c, part 3.
...
Also commit hgrep.sh for searching in non-c files.
2020-06-23 17:13:23 -04:00
luckytyphlosion
7cabc3d1a5
pokemon_summary_screen.c, part 2.
...
Also fix prototype of MenuHelpers_CallLinkSomething.
2020-06-14 19:04:24 -04:00
luckytyphlosion
bc143a695d
Initial work on pokemon_summary_screen.c
2020-06-14 16:08:21 -04:00
PikalaxALT
85dbd6c93e
Merge pull request #342 from GriffinRichards/sync-mapdatasize
...
Add MAX_MAP_DATA_SIZE alias
2020-05-27 07:54:29 -04:00
