Commit Graph

16698 Commits

Author SHA1 Message Date
Alex
6e5f40d506 Introduces BattlerState struct for the Battle Engine (#5954) 2025-01-11 07:12:22 -03:00
Eduardo Quezada
21bc5cfd30 Debug menu and createmon additions/cleanup (#5994) 2025-01-11 10:07:47 +01:00
Eduardo Quezada
c33c38e020 Remove form change function footguns (#5995) 2025-01-11 09:57:39 +01:00
Pawkkie
f8151f0be5 Missed two uses of new hazard type enum (#5996) 2025-01-10 20:14:15 -03:00
Eduardo Quezada
0fefb444de Multiple removals of hardcoded move IDs (#5964) 2025-01-10 17:07:32 -05:00
Alex
ab49aaf3b1 Dynamic move type was ignored in doubles for spread moves (#5984) 2025-01-10 16:58:51 +01:00
Martin Griffin
1551a33069 Fix leftover test change from #5033 (#5987) 2025-01-09 17:28:09 -03:00
DizzyEggg
83979375d3 Don't write to NULL in TryFindHiddenPokemon (#5983) 2025-01-09 14:19:07 +00:00
psf
81d877339c Removed OW_AUTO_SIGNPOST (#5974) 2025-01-08 21:36:50 +01:00
Martin Griffin
4c4137d600 Revert #5033 change to MapHeaderRunScriptType (#5975) 2025-01-08 19:26:35 +01:00
Martin Griffin
bb781f21a1 Arbitrary trainer scripts + map script/trigger softlock prevention (#5033)
Script_RunImmediatelyUntilEffect runs a script until either a specified
effect may occur or it reaches an end.

All existing script commands and natives, and some specials, call
Script_RequestEffects which allows us to analyze them.

Any downstream script commands/natives/specials will be statically known
not to call Script_RequestEffects and treated as if they have all
effects. Manually tagging them with requests_effects=1 and calling
Script_RequestEffects will make them analyzable.

Using these, we're able to execute scripts until they either exit with
no effect, or would possibly have an effect. This allows us to:
1. Not run on frame map scripts or triggers if they would have no
   effect.
2. Immediately run triggers if they only affect flags/vars. This removes
   the lag frames when biking into the Cycling Road, for example.
3. Migrate on load/on transition/on resume/on return to field/on dive
   warp scripts onto the global script context if they would block
   (approximated via SCREFF_HARDWARE).
4. Support arbitrary control flow in trainer scripts. The trainer does
   not see the player if the script has no effect, and the trainer will
   use whichever trainerbattle command is branched to.
5. Support arbitrary scripts in trainer scripts. cant_see and
   cant_see_if_* commands have been introduced so that scripts are able
   to do something when the player interacts with the trainer even if
   that trainer wouldn't see them.
2025-01-08 10:27:00 +00:00
Alex
5391b451ae Shell Bell Clean up / Simplification and Tests (#5924) 2025-01-07 21:50:23 +01:00
Alex
bc409b3028 Battle Weather Refactor oversight (#5960) 2025-01-06 12:14:13 +01:00
Alex
5317371fea Last fix for Sparkling Aria / Covert Cloak / Shield Dust interaction (#5956) 2025-01-06 12:03:41 +01:00
Eduardo Quezada
40ba25dd3e Converted 2 various to callnative (#5950) 2025-01-05 17:47:49 +01:00
Eduardo Quezada
771156eb3d Merge branch '_RHH/master' into _RHH/upcoming 2025-01-05 10:08:16 -03:00
khbsd
76964dd96a Fly from Pokenav (#5679) 2025-01-05 00:24:58 +01:00
Eduardo Quezada
d7bbb2e628 Easy customizable Hidden Move types (#5872) 2025-01-04 21:42:14 +01:00
Pawkkie
b8ccc29126 Update scope.md (#5948) 2025-01-04 20:40:10 +01:00
psf
a7f77ed08d Adds B_VAR_DIFFICULTY and related functions READ DESC (#5337)
Co-authored-by: sbird <sbird@no.tld>
Co-authored-by: Philipp AUER <SBird1337@users.noreply.github.com>
Co-authored-by: Martin Griffin <martinrgriffin@gmail.com>
Co-authored-by: hedara90 <90hedara@gmail.com>
2025-01-04 14:25:03 +01:00
ghoulslash
03684c6539 Battle Weather Refactor (#5833) 2025-01-04 07:33:25 -05:00
AlexOn1ine
9eee076e64 use one iterator 2025-01-04 12:16:35 +01:00
AlexOn1ine
80df54adc6 review changes 2025-01-04 10:56:56 +01:00
ghoulslash
401df8da4d move overwrittenAbilities field to DisableStruct (#5946)
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2025-01-03 18:17:23 +01:00
hedara90
c3b0f4dd7f Fixes broken link battles (#5940)
Co-authored-by: Hedara <hedara90@gmail.com>
2025-01-03 11:47:45 -03:00
Martin Griffin
404b4daa7b Fix DexNav static asserts (#5944) 2025-01-03 14:42:09 +00:00
Bassoonian
d1ceb11960 Fix DexNav static asserts 2025-01-03 15:40:02 +01:00
Bassoonian
9199b6f3cc Adds Dexnav (#4818) 2025-01-03 14:19:02 +01:00
Alex
8ccb385ce4 Insomnia test used the wrong move in Turn section (#5939) 2025-01-03 14:15:05 +01:00
Cafe
dd985dbb56 Fix formatting in WSL.md (#5942) 2025-01-03 13:49:42 +01:00
Alex
ec1876b826 Remove EWRAM gHpDealt (not needed anymore) (#5925) 2025-01-02 23:37:58 +01:00
ghoulslash
9707d09f79 some more Dexnav -> DexNav 2025-01-02 10:13:06 -05:00
Philipp AUER
94fba81a90 Initialize m4a and IRQ handler in a loaded section (#5912)
Co-authored-by: sbird <sbird@no.tld>
2025-01-02 15:11:32 +01:00
ghoulslash
7a9e847fd4 some clean up 2025-01-02 09:00:56 -05:00
ghoulslash
85787aaa36 add moves.h 2025-01-02 08:43:12 -05:00
ghoulslash
d8ea4fa1ec Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into rhh/dexnav 2025-01-02 08:28:21 -05:00
Philipp AUER
36c8332cd3 Fix Trainer Hill OOB array access (#5930)
Co-authored-by: sbird <sbird@no.tld>
2025-01-02 06:41:46 -03:00
Eduardo Quezada
107984e273 Added "Game Clear" flag toggle to debug menu (#5929) 2025-01-02 00:21:43 +01:00
Eduardo Quezada
a50c78bb1e Merge branch '_RHH/master' into _RHH/upcoming 2025-01-01 18:34:42 -03:00
Alex
875f0f7436 Fixes Trainer Slide messages causing corruption for recoil damage (#5926) 2025-01-01 21:46:42 +01:00
Alex
b7e945fbfb Reverts wrongly done partial Eject Pack fix (#5928) 2025-01-01 21:41:42 +01:00
Pawkkie
92c0039a23 Cleanup fix from 5922 (#5927) 2025-01-01 21:40:29 +01:00
Eduardo Quezada
9669a0554d Encapsulate move data (#5852) 2025-01-01 20:34:33 +01:00
Eduardo Quezada
e040dcb0b4 Begin 1.10.2 cycle 2025-01-01 16:20:40 -03:00
Eduardo Quezada
89699939de Version 1.10.1 2025-01-01 16:17:49 -03:00
Pawkkie
8d818445d2 Fixed ace switching bugs (#5922) 2025-01-01 19:29:45 +01:00
Eduardo Quezada
55f0d3aad5 Added missing Move Effect TODO tests - Volume E (#5915)
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
2025-01-01 16:06:20 +01:00
hedara90
13fba7b31f Added final Sparkling Aria+Shield Dust interaction test (#5923)
Co-authored-by: Hedara <hedara90@gmail.com>
2025-01-01 12:30:59 +01:00
Eduardo Quezada
6b8665d08f Speed up tests in headless mode (#5889) 2025-01-01 10:24:23 +01:00
Eduardo Quezada
e1275594c5 Renamed OW type effectiveness function for clarity (#5917) 2024-12-31 22:55:42 +01:00