Added todos with string DB links

This commit is contained in:
Greg Edwards
2023-02-21 01:54:11 -05:00
parent 4e005e8adb
commit d19a20affe
4 changed files with 13 additions and 1 deletions

View File

@@ -55,6 +55,8 @@ namespace PkmnFoundations.GTS
case RequestType.BattleSubway:
{
// todo: Need more info on this structure
// todo: Perform actual validation here so that we can
// error out before the player actually does their challenge
} break;
*/
// todo: there also appears to be a Battle Video request?
@@ -90,7 +92,9 @@ namespace PkmnFoundations.GTS
}
// placeholder for signature.
// Should be 128 bytes of an unknown hashing/signing algorithm
context.Response.OutputStream.Write(new byte[128], 0, 128);
context.Response.Write("Hey this is a totally legit pkvldtprod signature pwease accept it uwu");
context.Response.OutputStream.Write(new byte[69], 0, 69); // nice
//context.Response.OutputStream.Write(new byte[128], 0, 128);
}
private enum PartyValidationResult : byte

View File

@@ -674,6 +674,9 @@ namespace PkmnFoundations.GTS
foreach (var p in record.Party)
{
// todo: add battle tower specific checks:
// item clause, species clause, banned species, banned items
// https://bulbapedia.bulbagarden.net/wiki/Battle_Tower_(Sinnoh)#Restrictions
if (!p.Validate().IsValid)
{
// Tell the client it was successful so they don't keep retrying.

View File

@@ -577,6 +577,9 @@ namespace PkmnFoundations.GTS
foreach (var p in record.Party)
{
// todo: add battle tower specific checks:
// item clause, species clause, banned species, banned items
// https://bulbapedia.bulbagarden.net/wiki/Battle_Subway#Restrictions
if (!p.Validate().IsValid)
{
// Tell the client it was successful so they don't keep retrying.

View File

@@ -39,6 +39,8 @@ namespace PkmnFoundations.Structures
public int PID { get; set; }
public ulong SerialNumber { get; set; }
// todo: Document this data structure.
// List of decorations: https://projectpokemon.org/rawdb/diamond/msg/338.php
private byte[] m_data;
public byte[] Data
{