diff --git a/gts/pkvldtprod.ashx.cs b/gts/pkvldtprod.ashx.cs index 4a1e75cf..cff78159 100644 --- a/gts/pkvldtprod.ashx.cs +++ b/gts/pkvldtprod.ashx.cs @@ -55,6 +55,8 @@ namespace PkmnFoundations.GTS case RequestType.BattleSubway: { // todo: Need more info on this structure + // todo: Perform actual validation here so that we can + // error out before the player actually does their challenge } break; */ // todo: there also appears to be a Battle Video request? @@ -90,7 +92,9 @@ namespace PkmnFoundations.GTS } // placeholder for signature. // Should be 128 bytes of an unknown hashing/signing algorithm - context.Response.OutputStream.Write(new byte[128], 0, 128); + context.Response.Write("Hey this is a totally legit pkvldtprod signature pwease accept it uwu"); + context.Response.OutputStream.Write(new byte[69], 0, 69); // nice + //context.Response.OutputStream.Write(new byte[128], 0, 128); } private enum PartyValidationResult : byte diff --git a/gts/pokemondpds.ashx.cs b/gts/pokemondpds.ashx.cs index 56b66b2c..260dce39 100644 --- a/gts/pokemondpds.ashx.cs +++ b/gts/pokemondpds.ashx.cs @@ -674,6 +674,9 @@ namespace PkmnFoundations.GTS foreach (var p in record.Party) { + // todo: add battle tower specific checks: + // item clause, species clause, banned species, banned items + // https://bulbapedia.bulbagarden.net/wiki/Battle_Tower_(Sinnoh)#Restrictions if (!p.Validate().IsValid) { // Tell the client it was successful so they don't keep retrying. diff --git a/gts/syachi2ds.ashx.cs b/gts/syachi2ds.ashx.cs index af7bae49..3ab1aef2 100644 --- a/gts/syachi2ds.ashx.cs +++ b/gts/syachi2ds.ashx.cs @@ -577,6 +577,9 @@ namespace PkmnFoundations.GTS foreach (var p in record.Party) { + // todo: add battle tower specific checks: + // item clause, species clause, banned species, banned items + // https://bulbapedia.bulbagarden.net/wiki/Battle_Subway#Restrictions if (!p.Validate().IsValid) { // Tell the client it was successful so they don't keep retrying. diff --git a/library/Structures/DressupRecord4.cs b/library/Structures/DressupRecord4.cs index d3657353..9c471864 100644 --- a/library/Structures/DressupRecord4.cs +++ b/library/Structures/DressupRecord4.cs @@ -39,6 +39,8 @@ namespace PkmnFoundations.Structures public int PID { get; set; } public ulong SerialNumber { get; set; } + // todo: Document this data structure. + // List of decorations: https://projectpokemon.org/rawdb/diamond/msg/338.php private byte[] m_data; public byte[] Data {