* [Refactor] Moved joker_object_score() to round.c
* Used macro for argument NULL-check
* Replaced `set_and_shift_text()` with single call to `tte_printf()`
* Removed unnecessary comment
* Added explicit matching of substate enums to functions
* Reverted adding s_ prefix in blind_select.c to avoid unrelated changes and conflicts in the PR
* Add guidelines to check and open issues to CONTRIBUTING.md
* A few rephrases
Co-authored-by: MeirGavish <meir.gavish@gmail.com>
* Another small rephrase
* Added sprite_hide and sprite_object_hide functions
* Changed calls to obj_unhide to sprite_unhide
* Fix embarrasing errors
* clang-format...?
* Imported renames from #557
* Removed last uses of obj_hide in round
* Added documentation
* Changed Sprite.idx from int to s16
* Added proper NULL-check macro usage in sprite.c
* Updated all static variables to have the s_ prefix and constants to upper case
* Renamed missed sneaky functions in round.c (+ clang-format...)
* Renamed a few more missed constants
* Updated rng_update() documentation
* Apply suggestions from Copilot's code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Added missed suggestion
* Updated rng_update() comment
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Turned SpriteObject into a member of JokerObject and CardObject and expiremented with casting
* Extracted shop code to use generic `SpriteObject`
* Extracted shop joker generation to a function
* Renamed object -> item
* Added setters and getters for `SpriteObject` members and updated all accesses to use them with casting (AI used for tedious work and reviewed - model Raptor mini)
* Added sprite_object_set_vx() because sprite_object_set_vy() exists and reordered the function order to have x,y parameters first, then targets
* Added Item object to act as a purchasable interface for the shop - AI used (model Raptor mini)
* Added -fms-extensions and switched to anonymous inheritance
* Fixed anonymous inheritance for joker and added direct access for that too
* fix build error from previous commit + clang-format
* Fixed build errors + clang-format for real this time (I hope...)
* clang-format one last time, I don't understand it anymore
* clang-format is annoying
* Added uses of CHECK_NULL_ARG macros
* Merged item_defs.h into item.h and fixed build error from previous commit
* clang-format...?
* Changed sprite_object_new() into sprite_object_init() and made it accept a parameter instead of returning one to make it less awkward
* Updated sprite_object_init() documentation
* Updated sprite_object_destroy documentation
* More clang-format
* Renamed add_to_inventory to acquire and updated documentation
* Added function documentations
* Update documentation + swap order of consumable and playing card types
* Added documentation for new files (+ small addition to button.h)
* clang-format
* Used typedef
* A bit more documentation
* Changed sho pcode to use generic Item instead of SpriteObject
* clang-format + fixed NULL-check error
* Revert weird clang-format...?
* clang-format for real
* Fixed errors from rebase on log_function_name
* Fixed build errors from rebase on main
* Added some more documentation about first member struct inheritance
* typo fix
* typo fix for real
* Removed SpriteObject field getters/setters (AI used - model Raptor mini)
* Renamed item_acquire -> item_on_acquired
* Added item_can_acquire()
* clang-format
* Fixed some sprite issues but not all...
* Fixed some more issues
* Cleanup JokerObject some more JokerObjects in the shop
* Added `item_destroy()`
* Added item_set_available_to_shop, CHECK_ITEM_TYPE macros + small documentation updates
* Another small JokerObject->Item replacement
* Removed item_set_available_to_shop and replaced with item_roll_new() and item_dispose(), also changed "available_to_shop" semantics to "rollable"
* Re-applied changes from game.c to round.c after rebase on main
* Added partial implementations of item functions for playing cards
* Line endings fix...
* Macro renames, function documentations
* Updated documentations
* Apply fixes from Copilot review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Fix card_object_get_buy_price type checking
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Avoid double pointer cast on dispose
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Apply suggestions from @ricfehr3's code review
Co-authored-by: Rickey <ric@rf3.xyz>
* Remove redundant comments
* Moved error checking before joker_get_random_rarity
Co-authored-by: Rickey <ric@rf3.xyz>
* Fixed build error from rebase
* clang-format
* Added doxygen documentation for Item explaining inheritance
* Removed unnecessary comment
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Rickey <ric@rf3.xyz>
* Added function name logging to mgba_logger
* Addendum to no-op defines
* Fixed compile errors
* Added "()" to function name in log to make it clearer it's a function
* Corrected documentation
* clang-format...?
* Removed MGBA_LOG_LEVEL_MASK magic number
* Added CHECK_NULL_ARG macros
* clang-format...?
* clang-format for real
* Added documentation for CHECK_NULL_ARG_VOID and CHECK_NULL_ARG_RET
* Fixed typo
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Fixed macro safety by wrappinh with do-while
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Fixed format string cut risk in mgba_func_printf
* clang-format
* clang-format some more
* clang-format for real
* Fixed DEBUG -> INFO in comment
Co-authored-by: Rickey <ric@rf3.xyz>
* Moved NULL-check macros to util.h and renamed them
* Small additions - macro rename + clang-format
* Truncate the string instead of the function name
* Cleaned up code from previous commit
* clang-format
* Added mgba_logger_available check to mgba_func_printf
* Updated documentation for latest change
* Changed CHECK_NULL_ARG functions to generic RETURN_ON_ERROR_VAL functions.
* clang-format
* Changed back to specifically check NULL
* clang-format
* Changed "=" into "==" in the error message
* clang-format
* Fixed forgotten "=="
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Rickey <ric@rf3.xyz>
* Everything works, need to clean up
* cleanup
* fix rebase issue
* clang format
* docs
* clang format
* clang format
* address part of review
* Protect against edge case when discarding at end of hand
* Protect undiscard against popping a discarded card that doesn't exist
* Protect against out of bounds access to the `played` cards stack
* fix condition in `select_four_of_a_kind_cards_in_played_hand`
* change `get_played_top() + 1` to `get_played_size()`
* move `can_play/discard_hand` functions to round.c
---------
Co-authored-by: MathisMartin31 <mathis.martin31@gmail.com>
* Touchups (QOL Changes)
- Tweaked Logo to look slightly different (moved the "G" and "!" closer to other letters and connected them like in the actual logo from the full game)
- Changed the face down decks to have their colors changed. The red used before was darker than the one on the shop and round screens. I color matched them from the full game.
- I changed the borders of some Jokers to be white, like how they are in the full game. (Minor tweaks were made to them)
*I tested them and it seems to not break anything sprite-wise*
* Undo Joker Art Changes + Fix Logo
- Added changes to Joker Borders
- (Blue Joker has gray border to match the others, the only Joker with a different border is Blackboard)
- Reverted "!" Point (It's two pixels closer to the other letters unlike the original)
* Implement `sprite_object_update_all`
* clang format
* Change update order
* tmp
* make it crash
* Fix bad address crash
* Address @MeirGavish's comments
* Tweaked card draw position further
* Tweaked card draw position further, again
---------
Co-authored-by: MathisMartin31 <mathis.martin31@gmail.com>
* Refine controls section in README.md
Updated control descriptions for clarity and consistency.
* Update control instructions in README.md
* Update README.md
Co-authored-by: MeirGavish <meir.gavish@gmail.com>
---------
Co-authored-by: MeirGavish <meir.gavish@gmail.com>
* WIP
* WIP
* WIP
* WIP
* Tags are bugged but it's looking good
* Centering is bugged, almost there
* WIP
* Fixed centeriiiing, yaaaay
* good progress
* add proper '\n' support
* WIP descriptions
* All descriptions are there ^^
* missing 9-patch for pretty display
* WIP
* fix rebase issues
* Fix minor Run Setup screen issues
* Almost done, only one fix to go
* Aaaalmooost doooneeeee
* make desc frame size adaptative
* add rarity color and text
* final cleanup
* clang format
* clang format
* clang format
* clang format
* clang format
* Fix Joker update loop index
* Fix const and Bull description
* Fix unwanted button SFX
* fix tte colors
* Add misprint description
* Fix justified line length computation
* Add safeguards to tag parsing loop
* clang format
* Fix Ante bugged display at boss blind end
* Tweak suit colors
* Final fixes
* Simplified the way we print descriptions
* simplify further
* get rid of weird macro
* Fix Onwed joker price when holding A after showing its description
---------
Co-authored-by: MathisMartin31 <mathis.martin31@gmail.com>
