Ryan C. Gordon 6f0c9da0cd Date: Sat, 2 Feb 2008 22:08:05 +0100 ...

From: Marcus von Appen
To: sdl@lists.libsdl.org
Subject: [SDL] [Patch] SDL-1.2 SDL_revcpy() asm patch for the cld flag

Hi,

as reported through the FreeBSD bug tracking system in SDL 1.2.13 (and
in the 1.2 branch, if I see that correctly) the SDL_revcpy() macro sets
the direction flag (std), but does not clear it afterwards (cld), which
is wrong according to the GCC and SYS V specs.  This can cause some
weird side effects, which in turn can lead to memory corruption.

You can read the full report with a detailed description and test
program at http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/120052

Attached is the submitted patch, which fixes the issue.

Regards
Marcus

--HG--
branch : SDL-1.2

2008-02-04 17:22:56 +00:00

..

begin_code.h

Removed some C++ style comments from the public headers.

2007-08-05 03:21:18 +00:00

close_code.h

Use consistent identifiers for the various platforms we support.

2006-02-21 08:46:50 +00:00

SDL_active.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_audio.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_byteorder.h

Fixed build problem with SDL_string.c

2006-02-09 09:38:05 +00:00

SDL_cdrom.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_config_dreamcast.h

A less rude way of doing the same thing...

2006-03-23 21:55:13 +00:00

SDL_config_macos.h

Hey, whaddy know! MacOS Classic has 64-bit types!

2006-05-13 16:30:59 +00:00

SDL_config_macosx.h

Fixed Mac OS X config header when compiling with -Wundef.

2007-03-28 00:36:35 +00:00

SDL_config_minimal.h

A less rude way of doing the same thing...

2006-03-23 21:55:13 +00:00

SDL_config_nds.h

Added initial support for Nintendo DS, based on the work by Troy Davis (GPF)

2007-06-25 00:50:20 +00:00

SDL_config_os2.h

A less rude way of doing the same thing...

2006-03-23 21:55:13 +00:00

SDL_config_symbian.h

Removed stray C++ comment

2007-12-28 07:50:01 +00:00

SDL_config_win32.h

Whoops, fixed previous VC6 support patch.

2007-06-21 18:48:13 +00:00

SDL_config.h.default

Added S60 port.

2007-06-24 18:26:35 +00:00

SDL_config.h.in

Made the mprotect() fix for SDL_SoftStretch() more general for hardened linux, etc.

2007-12-29 05:18:33 +00:00

SDL_copying.h

Updated copyright information and removed rcs id lines (problematic in branch merges)

2006-02-01 06:32:25 +00:00

SDL_cpuinfo.h

*** empty log message ***

2006-02-24 10:23:49 +00:00

SDL_endian.h

Patched to compile on BeOS and old, old GCC releases.

2007-02-05 06:44:51 +00:00

SDL_error.h

New configure-based build system. Still work in progress, but much improved

2006-02-16 10:11:48 +00:00

SDL_events.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_getenv.h

Fixed build problem with SDL_string.c

2006-02-09 09:38:05 +00:00

SDL_joystick.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_keyboard.h

Fixed bug #112

2006-03-13 01:41:32 +00:00

SDL_keysym.h

Updated copyright information and removed rcs id lines (problematic in branch merges)

2006-02-01 06:32:25 +00:00

SDL_loadso.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_main.h

*** empty log message ***

2006-03-05 22:18:15 +00:00

SDL_mouse.h

Fixed bug #464

2007-12-29 06:08:17 +00:00

SDL_mutex.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_name.h

Added a new header file: SDL_loadso.h

2002-03-06 05:20:11 +00:00

SDL_opengl.h

From Anders F Bjorklund:

2006-04-12 14:37:05 +00:00

SDL_platform.h

Removed broken AmigaOS support.

2006-10-29 03:58:27 +00:00

SDL_quit.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_rwops.h

Added read-ahead support for Win32 file IO

2007-07-10 04:01:46 +00:00

SDL_stdinc.h

Date: Sat, 2 Feb 2008 22:08:05 +0100

2008-02-04 17:22:56 +00:00

SDL_syswm.h

Fixed bug #278

2006-09-24 00:08:28 +00:00

SDL_thread.h

Added S60 port.

2007-06-24 18:26:35 +00:00

SDL_timer.h

More header massaging... works great on Windows. ;-)

2006-02-10 06:48:43 +00:00

SDL_types.h

Fixed build problem with SDL_string.c

2006-02-09 09:38:05 +00:00

SDL_version.h

Updated version to 1.2.13

2007-12-29 05:20:51 +00:00

SDL_video.h

Const correctness patch for SDL_MapRGB and SDL_MapRGBA.

2007-04-04 09:40:40 +00:00

SDL.h

Updated for Visual Studio Express 2005

2006-02-24 08:17:28 +00:00