Kurt
df287f8fc5
Fix concatbinary load
...
Closes #1509
I think I had two ideas on how I wanted the method to work and
incorrectly blended the two together.
2017-10-03 16:51:13 -07:00
Kurt
b7b449e65c
Add move length check
...
Closes #1507
2017-10-03 16:44:12 -07:00
Kurt
ec491cdd52
Fix sav2 badge/tmhm clearing
...
Closes #1505
Thanks @fattard !
2017-10-02 23:17:00 -07:00
Kurt
a9892203c7
Refactoring
...
extract pkm loading routines to smaller methods
reduce code duplication (rely on empty setters to ignore some calls)
should be much easier to understand the load/save process; the original
setup (pk6) was following the structure from 0x00-end, no point still
doing that as everything is now abstracted.
2017-10-02 23:13:40 -07:00
Kurt
b23658dee1
Misc tweaks
...
allow cute charm static encounters
ignore user-entry control types
2017-10-01 21:25:23 -07:00
Kurt
c28575aad7
Refactor/rewrite form translation
...
1. faster control retrieval (fetch all once rather than search for each)
1. smaller methods & added comments (ez understanding)
3. easier to dump control list (ez translation file updates, future)
2017-10-01 10:50:00 -07:00
Kurt
44c0b53852
Provide map for Z Crystals KeyItem->HeldItem
...
allows for loading sprites for the key items (they're smaller than the
key item but better than missingno sprite)
Closes #1504
2017-09-30 20:57:32 -07:00
Kurt
9700ee79ad
Add used/unused all toggle to mg form
...
Closes #1503
2017-09-30 18:25:21 -07:00
Kurt
3300afdd19
More gen1/2 str encoding updates
...
Thanks theSlayer!
i blame rhydon
2017-09-30 18:20:23 -07:00
Kurt
593f31ff02
hashset contains over array contains
...
faster++, reduces some linq ToArray() allocations
2017-09-30 14:08:35 -07:00
Kurt
3552e6396c
Move pidivmatches check outside secondary check
...
gen3/4 generators auto-defer bad PIDIVs to end, so no need to keep
skipping to the very end
2017-09-30 13:42:57 -07:00
Kurt
e6f43ff629
Add 6 gen2 jp characters to encoding list
...
?!ゥェォ and space
other half-width characters are already present
2017-09-30 11:18:08 -07:00
Kurt
b201ded8e8
Fix エ decapping to ェ
...
Both characters map back to character 0x83, but 0x83 previously mapped
back to the lowercase variant which was unlike the others.
(オ and ォ -> オ)
Thanks Afepoke & smileynation!
2017-09-30 09:37:09 -07:00
Kurt
32bbd2cee0
old cleanup
...
revisit comboitem providing, simplify some methods with fancy linq
probably faster as there's no use of dictionaries and Array.IndexOf
after sorting, as the values are kept with the text.
2017-09-30 01:07:30 -07:00
Kurt
1e377c2963
interpolation++
...
no functional change (assumed)
2017-09-29 22:58:25 -07:00
Kurt
a93a3897b3
Cache pgt/pk4 when read from gift file
...
speeds up repeat accessing (legality checks and mgdb opening)
2017-09-29 22:40:35 -07:00
Kurt
ce4e5f739e
Fix korean Gold/Silver saving
...
closes #1496
2017-09-29 19:13:03 -07:00
Kurt
ed1b934374
Misc refactoring
...
expose some useful IEnumerable methods (sorting / bin->pkm / copy) to
simplify some common operations
change some explicit arrays to IList for flexibility
remove old memecrypto bool (no longer necessary as XP is not supported)
rename some methods for more clarity
2017-09-28 22:20:27 -07:00
Kurt
212a489335
Add gen6+ link trade egg edge case
...
slakoth with play rough with x/y version
why u modify game origin when hatched???
2017-09-28 17:11:30 -07:00
Kurt
14697f47d3
misc simplifications
...
recognize 01 01 01 00 xd saves
simplify some detection to be easier to follow, less lines is nice too
2017-09-27 23:22:41 -07:00
Kurt
cd88313fad
Merge branch 'master' of https://github.com/kwsch/PKHeX
2017-09-27 19:39:32 -07:00
Kurt
2c8e2176e9
Fix gen4 egg transfer egg location
...
Egg Location wasn't explicitly kept, only the 'faraway place' was kept.
Closes #1498
2017-09-27 19:39:30 -07:00
Kurt
f5582e438a
Merge pull request #1499 from kwsch/f/emergency-error-logging
...
Add emergency exception handling
2017-09-27 14:44:29 -07:00
Evan Dixon
9ced921f15
Add the ability to log error details to a file if there's an error displaying error details
2017-09-27 16:21:25 -05:00
Kurt
7c58bf0161
frlg eventflag recognition fix
...
referenced wrong string resource
note that frlg has no data so no flags/consts will appear (only custom
mods allowed).
closes #1497
2017-09-27 09:19:31 -07:00
Kurt
a52f88dd5c
Add ice punch feraligatr non-relearn link gift move
...
Thanks cicciochiave!
2017-09-27 08:32:35 -07:00
Kurt
c270479bf9
Show SID7 on hover
...
Closes #1494
2017-09-26 23:14:29 -07:00
Kurt
8b02f05bd5
Faster crc16 ccitt
...
insert lenny face here
>4x faster, relative speed is higher for larger input arrays
2017-09-26 23:10:31 -07:00
Kurt
9699cdefae
Gen2 egg gift bypass fix
...
Gen4+ static encounter eggs could slide through the VC case
prevent empty moves from appearing before suggested moves (relearnbase
being empty)
2017-09-26 20:09:18 -07:00
Kurt
8d0af0bd5b
Handle all gc remapped languages
...
good stuff genius sonority
2017-09-26 19:56:08 -07:00
Kurt
532cee406a
Add gen1 overworld respawner
2017-09-25 23:06:16 -07:00
SciresM
4272ad56ae
We know what Key 9 is for (Cap Pikachu).
...
Refactor for Memecrypto API incoming in the next few days.
Gonna add a public overload that takes in a memekey, to facilitate Local Wireless memecrypto.
2017-09-25 17:51:17 -07:00
Kurt
bbff1e086a
relax RB/Y detection when no starter chosen
...
value is 0 until a starter is chosen
2017-09-24 16:58:19 -07:00
Kurt
4950909d97
Add Red/Blue vs Yellow savefile detection
...
use the player's starter choice species value :)
2017-09-24 16:36:51 -07:00
Kurt
ccf9cd2284
Update japanese translation
...
Thanks smileynation!
2017-09-24 14:44:27 -07:00
Kurt
499126f9a4
Update gen1/2 move fetch
...
recent commit changed GetEncounterMoves to return 4 always rather than a
variable size array; double check the output for actual movecount
2017-09-24 12:39:12 -07:00
Kurt
e166f1eaa9
Show gen3+ berry analogues on gen2
...
also change "Reset key" to "Reset Password" to be closer to the game's
prompt
2017-09-24 12:05:36 -07:00
Kurt
c0f5166184
Fix rtc reset key generation
...
money into 3 bytes => sum
psypokes only does the 2 lowest bytes, is missing the high byte
Closes #1490
2017-09-24 10:59:35 -07:00
Kurt
1b354624b1
Korean move validation fixes
...
Korean g/s cannot access gen1 movesets, so pruning gen1 was necessary.
Rather than rebuilding the array (slow), just futureproof the entire
method to not rely on '7' (in case this code is ever used on Gen8).
2017-09-24 10:52:39 -07:00
Kurt
9ef2016d35
Encounter Learnset move duplication fix
...
a level 15/16 magmar has leer/smog twice in its learnset (at level 1 and
at actual levels); returning just the 4 previous learned moves at level
15/16 yields duplicates for Smog. [Smog, Leer, Fire Punch, Smog | Leer,
Ember]. By ignoring moves already added, the true movepool is acquired
also fix TradebackType getting overwritten at the end of the method (in
case of nontradeback like korean/egg)
2017-09-24 10:36:16 -07:00
Kurt
e5d7a063af
Fix jpn/kor pkm collision
...
OTname length is 6 in JP games and 11 in kor/eng
Thanks smileynation!
https://projectpokemon.org/home/forums/topic/41689-bug-reporting-japanese-name-of-kin-gin-version-vc-jpn
2017-09-24 08:36:10 -07:00
Kurt
496cc35f97
Fix mew male gender
...
Closes #1489
2017-09-23 22:44:54 -07:00
Kurt
12187a5128
Expose gen2 RTC resetkey
...
#1487
also expose gen1 event flags (well, the crappy ones at least)
constants/event_constants.asm
2017-09-23 22:13:48 -07:00
Kurt
16341b4d91
Add SPA/ENG Oct16 Diancie collision handling
...
Card 0525 was accidentally uploaded without the 3 flawless IVs setting;
sometimes when the internal event binary is built, the 3IV card comes
before the 0IV.
Play favorites with the 0IV.
2017-09-23 17:11:19 -07:00
Kurt
d8c2cdb8e3
Use EnumerateFiles over GetFiles in some cases
...
https://msdn.microsoft.com/en-us/library/07wt70x2.aspx
iterating as an ienumerable (ie not consuming the whole collection) can
be more efficient by not waiting for the whole collection
2017-09-23 17:02:28 -07:00
Kurt
da8ba46d22
Fix gen1/2 shinify/gender change behavior
...
Closes #1488
also fixes female->shinify starters not flipping back to male gender
(changingFields was set back to the same value)
2017-09-23 16:50:38 -07:00
Kurt
7974943bcf
Refactoring
...
slight simplification related to #1486
2017-09-23 16:24:22 -07:00
Kurt
caf25efb46
Add RTC ResetKey calc
2017-09-23 16:04:02 -07:00
Kurt
cc70939dc2
Merge pull request #1486 from javierhimura/KoreanRestrictions
...
Korean and Chinese restrictions
2017-09-23 16:03:49 -07:00
javierhimura
ea86032480
Comments and a fix for AllowGen2Crystal function
2017-09-23 21:00:57 +02:00