* Check all namespaces, not just final namespaces.
* Allow 16 elements in the top-level namespaces, and 9 in lower levels.
* Include some exemptions for categories that are already too large, but would be brittle to fix.
* Rename tables/images to get things back under the limit.
* Upgrade tests to provide better failure information
Special Thanks to Axcellerator for providing the information.
This is for Emerald only as only Emerald has scrolling multichoices without 3rd-party implementations.
* Added the table at Emerald's address 5DE02C.
Added the list of Pokémon available from the Slateport Battle Tent.
The formatting is the way it is presumably due to a bug that thinks that putting a space after a nested table field invalidates the entire table format. It may change.
* Added the corresponding trainers table.
Same formatting deal as the preceding commit.
The `pokemon<>` field should be `pokemon<[pokemon:data.pokemon.names]!FFFF>`, but HMA does not allow that.
* Added the corresponding data for Verdanturf's tent
* Added the corresponding data for Fallarbor's tent.
* tweaked some battle script commands
tweaked some battle script commands to allow reading pointers for those that support it
* Implemented macros and lists for battle scripts
Implemented many macros from the decomps along with many new lists relevant to battle scripting
* Implemented a list for stat animation
Implemented a list for playstatchangeanimation which shows which stats are displayed exactly
* Implemented HMA-consistent macros
Implemented HMA-consistent macros alongside the decomp macros per haven's request
- Added the animation bg. table anchor reference for Emerald.
- Added the addresses that contain pointers to specific animation bgs. for Emerald, as well.
- Added the table formats & their meanings of \`uct\` and \`ucm` into the file, as well.
* scripts.battle.thumb→scripts.commands.battlescript
* Made "scripts.commands.battle" encompass a lot.
I'm trying to make sure that while restructuring the `scripts` subdirectory so that commands are in one place, I don't radically change the preexisting naming schemes.
* scripts.callstd → scripts.commands.events.callstd
* Multiple renames
scripts.specials.thumb → +scripts.commands.events.specials
Put "buffercommands" underneath "commands". Same with events onstep & both "weather" subdirectories.
* scripts.events.thumb→scripts.commands.events.thumb
* Moved the animation script commands table.
* Added the "scripts.battle.badge.obey" category.
Credit to Axcellerator for finding these offsets.
For the life of me, I could not link the flags table to the other 4 new anchors.
Since all of these are part of a THUMB routine, nothing points to these individual anchors, so I had to put them here.
The 0badges to 6badges anchors link to each other, so that's why 3 of them do not have a 1 after their [level.] formatting.
* Fixed a typo from a merge-fix commit.
* Added obedience anchors for FireRed/LeafGreen 1.0.
I tested these, and they seem to work and load correctly.
* Added obedience anchors for FireRed/LeafGreen 1.1.
* Added obedience anchors for Ruby & Sapphire.
I tested it, and these 5 additions work universally for AXVE0, AXVE1, AXPE0, and AXPE1.
* Added the encounter songs [[List]].
Different trainers in FRLG use different numbers for their intro music field, so I decided to put their numbers after the words "boy," "girl," and "rocket" to keep track.
* Mentioned the [[List]] in the trainer table.
instead of just preferring to match the lowest possible ID that counts as a partial match, add some extra criteria to make it act closer to how people expect.
* prefer entries where no letters are skipped
* prefer entries where the start of the partial matches the start of the full
* Brought in the changes from PR #170.
I'll need to get the anchor refs for RS & FRLG.
I also bundled the \`tse` feature request for this file.
* Fixed Emerald's addresses.
Previously, they were addresses of the strings themselves instead of anchor references.
* Nested "speeches" under "professor."
* Making progress on finding FRLG anchor refs.
There are a few more I still need to add.
* Finished the Anchor refs for FRLG.
The Ruby/Sapphire Anchor refs are being started.
* Finished the Anchor refs for Ruby & Sapphire.
I tested them, and all of the anchors show up in the Generation III games.
"buffer1" is associated with 0 for a parameter in a command like "buffernumber." That misalignment by 1 can cause some confusion, so this change will allow the word "buffer1" to be used instead of 0 for such commands to line up with the \\ 02 text macro ([buffer1]) that would be used afterwards.
* pressing escape should close the script tip
* fix automatic inclusion of <auto> behavior
* Fix possible crash when looking for closing } when there isn't one
* Only update TextEditor layers if they've changed (performance)
* creating a new event script should include lock/faceplayer/release
* adjust focus when switching tabs (close open tips)
* only try to access list coments if the list isn't null
Adding a field `name|python=function` to a table will add a button to the table. Clicking the button will run a python function from `hma.py`. The function is expected to have one element, which will be the current selected element of the table as a `ModelArrayElement`. This python code still has access to the entire rom and the print() function.
The button's text is based on the name of the field, and therefore cannot have a spaces or special characters, just letters / numbers.
The button will get tooltip that is based on the comment of the chosen function.
* show hex values with leading 0x
* allow parsing hex values in non-hex fields and non-hex values in hex fields
* flags are shown in hex everywhere else, show them in hex in the table tool too
* Avoid using foreach/enumorables in `MacroScriptLine.Matches` since it's called so often.
* Use Span<char> to reduce string allocations in `ArrayRun.ctor` and `ArrayRunEnumSegment.GetOptions`
* don't store the delta object used for initial setup
* avoid making lambdas in `ScriptLine.Matches`, which is called very often.
* use use List<int> instead of SortedSpan<int> for building the initial DestinationToSource cache, since we're already guaranteed that they'll be added in order and without duplicates. This greatly reduces the number of int[] arrays created during startup.
* allow `ArrayRunPointerSegment` to cache the table content results from parsing its InnerFormat, so it doesn't have to re-parse each time. This greatly reduces the number of string allocations.
* Use `ThreadSafeDictionary` for `TryGetValueCaseInsensitive` so we don't need to create a new collection of keys each time we call the method. Also add key caching to `ThreadSafeDictionary` so we don't need to make a new collection each time it's requested.
* Make `GetOptions` return a readonly list. We already know it's unique, this means we don't have to make a new collection every time we parse segments.
* limit the number of undo tokens we store (default 100) to save memory
* Use `byte[]` and `Array.Copy` instead of `List<byte>` and `AddRange` to reduce byte array allocations when loading a file.
* Freeze geometries in the `Icons` collection.
* add option for running garbage collection from the developer menu
* use a custom `AutomationPeer` to prevent WPF from holding memory after controls have been closed.
* Remove the `compact` macro, since it's just a combination of 3 macros that each make sense by themselves. The goal for macros is to put them in situations where you wouldn't ever want the command by itself.
* Move the `if` macros down to live with the other `if` macros.
* The `(` symbol has been moved.
This was supposed to go in the previous pull request, but I was too late...
* Added another `msgbox.yesno` macro.
No testing has been done yet.
* Added if.yes & if.no macroes.
Caution: These macroes will show up unintentionally if you're using commands other than msgbox.yesno that involve comparing the last result variable (800D) with the literal number 1.
* Fixed the `ptr` pointer format.
my bad
* Configured the macroes.
* Added comments to the macros.
They seem all jumbled up.
* Added corresponding cmds. for trainerbattle 0−8.
Testing needs to be done to make sure they work atm.
* Updated trainerbattle 09 & 0C.
though trainerbattle 09 will need another change.
* Added trainerbattle 09 types based on a bit field.
Right-most bit: Whether or not the player can lose
Second-right-most bit: Tutorial battle w/ Professor Oak
Based on the combinations of bits, I added more variants to FRLG's `trainerbattle 09` command.
* LocalIDs are correctly filled in as 1/2-words now.
My bad
---------
Co-authored-by: haven1433 <haven1433@gmail.com>
I thought the Berry Master & his wife would pull items from this table to give to the player if the player inputted the correct phrases; however, this specific table is only referenced in the `SetOpponentsBerryData` function in Pokémon Emerald.
* Added a macro for multichoice's allowCancel field.
0 = the game does not ignore B presses (OK to cancel out)
1 = the game ignores B presses (forbid canceling out)
* Clarified by adding "Cancel" to each option.
* Added "movenpc" command.
The exact things will be subj to change.
* Fixed "move.npc" and added "move.player."
I'll need to test these soon.
* Switched the order of 2 command macroes.
Switched the order of move.player and move.npc.
* Fixed the move.player command macro.
I can't specify base-10 numbers to hard code, apparently.
* Added the "move.camera" macro.
* Each new movement macro has 2 lines of flavor text
* Removed the constant references for the XY coords.
We may need to do the same for the default BPEF and BPEI `.toml` files.
These addresses are actually part of thumb instructions and don't have anything to do with the spawn coordinates.
Actually, Emerald's code makes the player spawn at (−1, −1), which is a pair of invalid coordinates; therefore, the player actually spawns in the centre of the map. Another tricky thing is that there's no indication in the thumb code about those −1 coordinates — at least one we haven't found yet..
* Removed XY starting constants for Ruby & Sapphire.
(same reason as Emerald's case from a while ago)
when generating data for a new stream and the pointer is to freespace, be aware that we're creating a stream starting from length zero, rather than whatever the model data parses as the length. The parsed length doesn't matter, because we're pointing at freespace.
* In sky attack, after the two-turn-animation command, the `end` command is pointed to by other pieces of script. Since its address actually matters, don't combine things together into a single script.
* Both CollectScripts and FindLength have script aggregation logic that needs to be limited.
For script performance:
* call data.GetGameCode() less often, using a cached value for the ScriptParser
* use a 4-byte game code instead of string parsing for the game code
For map previews in the table tool performance
* Don't use dispatcher foreground/background thread swapping, it's safe to add the previews to the collection from the background thread.
* Check the exit condition more often
For drawing performance:
* Use Array.Copy when we don't need to worry about Transparency, since it's much faster.
* Make `Darken` faster, we call it a lot
* Reuse DarkenRect utility in HighlightCollision
Other performance changes
* Protototype for ObserableList<T> for a more configurable version of ObservableCollection
Situation:
* Script A refers to B and C. B and C occur right after eachother.
* Scirpt B does not refer to script C, so C doesn't get included in the same body.
-> when editing B, B needs to know that its length does not include C. So the script-length-cache that B uses shouldn't know about C, since B doesn't refer to C.
-> Therefore, B can't use the same cache as A.
* track length caches based on the code body start, not based on the entire model. This lets each code body have its own cache.
* fadescreen should use screenfades list
* map object graphics should use overworld sprites enum (allows finding events from the overworld sprites table)
* change field name from 'unused' to 'padding' for final part of object event data
* Updated the "jumpiftype" commands' type field.
* Added the other keypadIcons anchor.
The name was very similar in the decomps, but this anchor refers to a table instead of a sprite sheet.
* Added the HM logo image in tableReference.txt.
Thank you VersekrDarkYT for notifying us about this image in #feature-requests!
* Added Emerald's message box graphics anchor refs.
Thank you Lunos for the feature request! The word "noframe" for Emerald's message box identifies the message box graphics used for stuff like the "Would you like to save the game?" prompt. These type of message boxes are independent of the text frame configured by the player.
* Miscellaneous typo fixed.
We previously had code that tried to find lengths of sub-scripts from scripts, but only followed pointers forward, not backward, to prevent infinite loops. But it didn't properly handle scripts that _do_ have backwards pointers: it was returning a length of 1 for those, which is wrong.
* Updated the "graphics.text.importer" formatting.
The "a" field was actually supposed to be 4 one-byte fields.
* Added the table for Japanese bold glyphs in EM.
* Added support for the keypad characters image.
I don't know what palette is associated with this image, though.
* Moved new table to a more appropriate location.
* Added "data.fonts" support for Emerald.
The table in EM is formatted differently than in RS. I'm going to make an "allFonts" [[List]] soon for Ruby, Sapphire, and Emerald.
There is 1 tab character before the first offset in some of the rows of tableReference.txt (like on lines 784 to 788), which may require revamping the file altogether.
* Started the [[List]] of all fonts for Emerald.
A few notes:
− "short2" comes before "short" because of the naming conventions HMA already has in place for the two short fonts that are similar but have different lower-case Ls. (short2 has the lower-case L that's used in battles, etc.). The regular "short" is "short_narrow" in the decomps.
− I suspect that the "?" entries are Japanese fonts, but I'm not sure about which ones.
I still need to make Ruby's list and do some testing.
* Added a table for the multipliers on stats.
These are the values that are multiplied (then divided) when your Pokémon's at −6, −5, ..., +5, or +6 in battle.
* Filled in the rest of the allFonts List for EM.
07 = japan2
08 = japan1
02-05 = japan3
The game uses some font slots for multiple fonts. If you used \CC0608 before text, you would get glyphs from "graphics.text.font.short.characters" OR "graphics.text.font.japan1.characters", depending on what language you specified in your text string.
* Added the allFonts [[List]] for Ruby & Sapphire.
Many of the fonts in "data.fonts" are duplicates, albeit with minor numerical changes here and there.
I'd be fine with removing the '-01,' '-02,' etc. and just leaving duplicates of font names ('japan1,' 'japan1∼2,' etc.) if that's less confusing.
* Moved and standardized the stat changes table.
Changed the name and location, as well as adding another field to the table formatting.
* don't allow streams to have <section> labels
* update the <auto> algorithm to allow stream pointers to be picked up in the middle of a script. This will get changed if the script is recompiled to put the streams at the end, but it allows longer scripts to be read no matter where the streams were placed.
* Implemented Skyzio's BPEF .toml into the defaults.
I think we still have to whitelist BPEF so that more bytes get formatted instead of just the header, game code, etc.
* Updated the default.bpef.toml file.
* Updated .csproj file to incorporate the BPEF .toml
* Move particle names start at index 0 now.
Having them start at 10k didn't work the way I wanted them to work.
Also, I removed the low lines from each item in the list because it unintentionally triggered the letter abbreviations when shown in the hex content viewer.
* Implemented the move_particle list.
I will need to test these changes very soon.
The animation script commands would show the names of the move particles instead of numerals, and the move particles tables' length would be controlled by the newly-added list.
* Undid the animationScript change.
This change caused crashes, though I think those crashes could be resolved.
* Broke apart the "japan2" font.
In Emerald, HMA renders its "japan2" font incorrectly. It's only supposed to contain 16,384 bytes worth of characters while the preceding bytes are actually unused font sheets and widths. Those are now formatted as separate runs. The issue is that I can't put any of these changes in "tableReference.txt" because none of those tables/images have anchors to reference since they're unused.
* Fixed the japan2 characters format.
* Filled in missing font addresses.
Two fonts in Japanese that are rendered backwards in HMA (and possibly unused) and the short font used when showing Pokémon nicknames in battle.
* Removed an overlooked comment.
also fix possible race condition when refreshing border render while drawing the map
also fix condition where writing script data content formats shouldn't write empty runs if the token doesn't allow changes.
* better for experts because they can more easily parse a handful of section headers compared to random hex addresses
* Better for new users because it helps them learn that they can use whatever names they want for the headers of scripts and for pointers.
