mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-04-04 16:44:56 -05:00
286a7494d3
* Remove `isView` flag from CardZone
This flag is used for two purposes:
1. It is used as a check for casting to a zone to a `ZoneViewZone`;
2. Non-view zones are added to the player's zones on construction
This patch removes the `isView` flag and instead:
1. We directly cast zones to `ZoneViewZone` using a dynamic (qobject)
cast and use the result of the cast instead of the `isView` flag to
detect if we are a view zone or not;
2. The player records its own zones when they are created, simplifying
control flow.
* Review
* client: Support arbitrary game zones
Currently, the client ignores cards in unknown zones, as there is an
implicit assumption that the set of zones known by the server and the
client are the same.
This patch makes it so that the client accept "custom zones" from the
server (zones outside the builtin deck, graveyard, exile, sideboard,
table, stack and hand zones) using the information from the
ServerInfo_CardZone. Moving cards from/into these zones happens
through a "View custom zone" action in the Game > Player menu and
properly appears in the chat.
Note that this patch intentionally does not introduce any support for
having the server actually create such zones. Instead, this patch aims
to improve backwards compatibility for when we do get to adding this
capability in the future, by making sure that current clients will be
able to interact with future new zones (even if suboptimally).
|
||
|---|---|---|
| .. | ||
| lib | ||
| pb | ||
| sfmt | ||
| CMakeLists.txt | ||
| color.h | ||
| debug_pb_message.cpp | ||
| debug_pb_message.h | ||
| decklist.cpp | ||
| decklist.h | ||
| expression.cpp | ||
| expression.h | ||
| featureset.cpp | ||
| featureset.h | ||
| get_pb_extension.cpp | ||
| get_pb_extension.h | ||
| passwordhasher.cpp | ||
| passwordhasher.h | ||
| rng_abstract.cpp | ||
| rng_abstract.h | ||
| rng_sfmt.cpp | ||
| rng_sfmt.h | ||
| room_message_type.h | ||
| server_abstractuserinterface.cpp | ||
| server_abstractuserinterface.h | ||
| server_arrow.cpp | ||
| server_arrow.h | ||
| server_arrowtarget.cpp | ||
| server_arrowtarget.h | ||
| server_card.cpp | ||
| server_card.h | ||
| server_cardzone.cpp | ||
| server_cardzone.h | ||
| server_counter.cpp | ||
| server_counter.h | ||
| server_database_interface.cpp | ||
| server_database_interface.h | ||
| server_game.cpp | ||
| server_game.h | ||
| server_player_reference.h | ||
| server_player.cpp | ||
| server_player.h | ||
| server_protocolhandler.cpp | ||
| server_protocolhandler.h | ||
| server_remoteuserinterface.cpp | ||
| server_remoteuserinterface.h | ||
| server_response_containers.cpp | ||
| server_response_containers.h | ||
| server_room.cpp | ||
| server_room.h | ||
| server.cpp | ||
| server.h | ||
| serverinfo_user_container.cpp | ||
| serverinfo_user_container.h | ||
| trice_limits.h | ||
| user_level.h | ||