5893 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
transifex-integration[bot]	067fe9b534	Translate cockatrice/cockatrice_en@source.ts in it (#6724) ... 100% translated source file: 'cockatrice/cockatrice_en@source.ts' on 'it'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>	2026-03-21 10:13:43 +01:00
RickyRister	38c85e6db1	[Dialog] Reduce spacing in create local game dialog (#6719)	2026-03-18 10:24:34 -07:00
RickyRister	c5cd7d8700	[ShortcutsSettings] Fix duplicate aPlay shortcut; change play shortcut's group (#6716) ... * [ShortcutsSettings] Fix duplicate aPlay shortcut; change play shortcut's group * update description	2026-03-18 10:13:36 +01:00
DawnFire42	fc453c68a7	Add card selection counter (#6685) ... * feat(game): add drag selection counter overlay Display count of selected cards inside the lasso during drag selection. Count appears near cursor, repositioning to stay within selection bounds. Includes SelectionRubberBand subclass to allow label to appear above band. QRubberBand calls raise() in showEvent/changeEvent to stay on top - this subclass suppresses that behavior so dragCountLabel can be visible. Adds user setting to enable/disable the drag count overlay. * feat(game): add persistent selection counter overlay. Display total count of selected cards in bottom-right corner when multiple cards are selected. Updates on selection changes and window resize. The counter connects to QGraphicsScene::selectionChanged to stay up-to-date without requiring manual refresh. Adds user setting to enable/disable the total count overlay. --------- Co-authored-by: RickyRister <42636155+RickyRister@users.noreply.github.com>	2026-03-16 23:44:29 +01:00
ebbit1q	69c046cca4	remove all separate storing of widget sizes, rely on geometry (#6712)	2026-03-16 23:38:47 +01:00
tooomm	dd8164611b	revert env name (#6711)	2026-03-16 23:38:04 +01:00
dependabot[bot]	b4a5c863d7	Bump docker/metadata-action from 5 to 6 (#6713) ... Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 5 to 6. - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](https://github.com/docker/metadata-action/compare/v5...v6) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-03-16 21:11:32 +01:00
dependabot[bot]	4a3d79d00b	Bump docker/build-push-action from 6 to 7 (#6714) ... Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6 to 7. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](https://github.com/docker/build-push-action/compare/v6...v7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-03-16 21:10:22 +01:00
tooomm	96f436b65e	CI: Resolve to latest Qt version in range for Windows as well (#6700) ... * CI: Resolve to latest Qt version in range for Windows as well * install aqt * Check dedicated win version	2026-03-15 17:47:48 +01:00
tooomm	cf01dc770b	CI: Adjustments to ccache usage (#6703) ... * Increase ccache size * Fix Arch ccache usage * more cleanup * harmonize names	2026-03-15 17:41:17 +01:00
DawnFire42	ce652de272	Fix/cmake test only build (#6709) ... * fix(cmake): guard filter_string_test behind WITH_ORACLE or WITH_CLIENT. filter_string_test links against libcockatrice_filters, which is only built when WITH_ORACLE or WITH_CLIENT is enabled. Without this guard, test-only builds fail at configure time because the target doesn't exist. The guard condition mirrors the one in the root CMakeLists.txt that controls whether libcockatrice_filters is built. * fix(cmake): centralize TEST_QT_MODULES in FindQtRuntime.cmake Each test CMakeLists.txt was independently defining TEST_QT_MODULES with its own subset of Qt modules. This duplicated knowledge that already lives in FindQtRuntime.cmake (which handles module discovery for all other targets: SERVATRICE, COCKATRICE, ORACLE). Consolidate into a single definition using the union of all test requirements (Concurrent Network Svg Widgets), matching the existing pattern for application-target modules. This ensures test-only builds (-DTEST=ON without application targets) discover all necessary Qt components. * fix(cmake): guard libcockatrice_network behind application targets. libcockatrice_network is only needed by the client, server, and oracle targets. Other application-specific libraries (settings, models, filters) already have similar guards. This was an oversight that caused test-only builds to fail when network dependencies weren't available.	2026-03-15 17:24:50 +01:00
DawnFire42	9bb399606c	refactor: extract shared card insertion algorithm from hand/stack zones (#6701) ... Hand and stack zones had near-identical addCardImpl() implementations, differing only in whether resetState() preserves annotations. Extract the shared pattern into a template function (CardZoneAlgorithms::addCardToList) to eliminate duplication and enable isolated testing without Qt dependencies. Pile, table, and zone-view logic are intentionally excluded — their post-add behavior (signals, coordinate placement, hidden cards) is materially different.	2026-03-15 00:39:44 -07:00
tooomm	8180d2e3b0	CI: Update compiler cache on hit (#6691) ... * update ccache * Update desktop-build.yml * Update desktop-build.yml	2026-03-14 15:12:10 +01:00
RickyRister	33d5721490	[Game] Fix not using zone-specific card menu for opponent's cards (#6695)	2026-03-14 11:41:38 +01:00
transifex-integration[bot]	2b2a6db081	Translate oracle/oracle_en@source.ts in it (#6692) ... 100% translated source file: 'oracle/oracle_en@source.ts' on 'it'. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>	2026-03-13 21:22:48 +01:00
DawnFire42	aa4592dc9e	Add local game options (#6669) ... * Add local game options dialog. Introduces LocalGameOptions struct and DlgLocalGameOptions dialog to replace the previous QInputDialog for starting local games. Encapsulates game configuration with a simple interface that prevents parameter explosion as options are added. The dialog provides UI with settings persistence via SettingsCache * integrate local game options into main window. Replaces QInputDialog with DlgLocalGameOptions in actSinglePlayer(). The startLocalGame() function now accepts LocalGameOptions, enabling configuration of starting life total and spectator visibility in addition to player count. Also adds user documentation for the local game options flow. * Removed superfluous documentation file * removed spectator option and moved structure definition * Now remember settings separately and & shortcuts removed * re-run checks	2026-03-12 14:30:01 -07:00
RickyRister	20ad9af989	[CacheSettings] Refactor country list creation (#6687)	2026-03-12 11:00:32 -07:00
DawnFire42	9e2276a59f	Refactor zone names (#6686) ... * Add ZoneNames constants for protocol zone identifiers. Introduce a centralized ZoneNames namespace providing constexpr constants for zone identifiers used in the client-server protocol. This establishes a single source of truth for zone names like TABLE, GRAVE, EXILE, HAND, DECK, SIDEBOARD, and STACK. The protocol values remain unchanged (e.g., EXILE maps to rfg for backwards compatibility) while providing meaningful constant names. * refactor(server): use ZoneNames constants in server game logic Replace hardcoded zone name strings with ZoneNames:: constants in: - server_player.cpp: zone setup, draw, shuffle, mulligan operations - server_abstract_player.cpp: card movement and token destruction - server_game.cpp: returning cards when players leave No functional changes - purely mechanical string literal replacement. * refactor(client): use ZoneNames constants in core player/zone logic Update the foundational player and zone classes to use ZoneNames:: constants instead of string literals. Changes include: - player.h/cpp: zone initialization and builtinZones set - card_zone_logic.cpp: zone name translation for UI display - table_zone.cpp: table zone operations No functional changes - purely mechanical string literal replacement. * refactor(client): use ZoneNames constants in player actions and events Replace zone name strings with ZoneNames:: constants in the player action and event handling code. player_actions.cpp contains the most extensive changes (~90+ replacements) covering all card movement commands. No functional changes - purely mechanical string literal replacement. * refactor(client): use ZoneNames constants in zone menu handlers Update all zone-specific menu files to use ZoneNames:: constants for QAction data values and zone targeting. This covers context menus for cards, graveyard, hand, and exile (RFG) zones. No functional changes - purely mechanical string literal replacement. * refactor(client): use ZoneNames constants in game scene components Update remaining game scene components to use ZoneNames:: constants: - arrow_item.cpp: arrow drawing between cards - game_scene.cpp: zone view positioning - message_log_widget.cpp: removes duplicate local static constants that were previously defining zone names redundantly - phases_toolbar.cpp: phase actions (untap all) Notable: message_log_widget.cpp previously had its own local constants (TABLE_ZONE_NAME, GRAVE_ZONE_NAME, etc.) which are now removed in favor of the centralized ZoneNames:: constants. * formatting fix	2026-03-12 00:34:05 +01:00
tooomm	42cec10457	CI: Cleanup (#6677) ... * Cleanup vcpkg matrix * Add filename with extension as output * fix name -> fullname, cleanup	2026-03-09 21:32:47 +01:00
dependabot[bot]	95d7e027fc	Bump docker/setup-buildx-action from 3 to 4 (#6682) ... Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3 to 4. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](https://github.com/docker/setup-buildx-action/compare/v3...v4) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-03-09 21:30:47 +01:00
dependabot[bot]	8268311fab	Bump docker/setup-qemu-action from 3 to 4 (#6683) ... Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 3 to 4. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](https://github.com/docker/setup-qemu-action/compare/v3...v4) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-03-09 21:22:26 +01:00
tooomm	413b4b637b	sign+notarize only releases (#6678)	2026-03-09 21:20:38 +01:00
RickyRister	e79bbc67b9	[DeckEditor] Fix undo/redo clearing legality (#6675)	2026-03-08 15:57:39 -07:00
RickyRister	15a1d5440b	[DeckEditor] Fix undo/redo resetting deck sorting (#6673)	2026-03-08 23:50:54 +01:00
tooomm	fd293444c5	tweaks (#6674)	2026-03-08 23:50:33 +01:00
tooomm	852429f248	remove unused zip command (#6676)	2026-03-08 23:48:30 +01:00
tooomm	4606fcdbd5	Add description for code docs (#6679)	2026-03-08 23:27:15 +01:00
tooomm	c375cdbb1a	CI: Upload artifact files directly (#6654) ... * Upload artifact files directly * match pdbs name * Update name variable	2026-03-08 18:03:01 +01:00
tooomm	f15b70e4ae	Use new attest action (#6671)	2026-03-08 17:53:16 +01:00
RickyRister	2f10634ca2	[DeckList] Fix double-faced cards not importing correctly (#6665) ... * [DeckList] Fix double-faced cards not importing correctly * make tests compile	2026-03-06 11:48:17 -08:00
RickyRister	dead993639	[DeckList] Refactor load from plaintext to take normalizer as param (#6664) ... * [DeckList] Refactor load from plaintext to take normalizer as param * update usages * weaken unit test * weaken unit test more * revert unit test * move CardNameNormalizer to libcockatrice_card * update unit test * formatting	2026-03-06 10:39:04 -08:00
DawnFire42	bd5cbb89d4	refactor: extract CARD_HEIGHT to shared CardDimensions header (#6668) ... * refactor: extract CARD_HEIGHT to shared CardDimensions header Move duplicated CARD_WIDTH/CARD_HEIGHT constants to card_dimensions.h. Fixed documentation in z_value_layer_manager.h. * WIDTH_F used directly instead of casting * Improved consistency and added missing newlines at end of files	2026-03-05 19:13:58 -08:00
tooomm	14f1925edc	Add icon to exe (#6655)	2026-03-06 01:50:15 +01:00
ebbit1q	e39bbd2b31	take default theme name from startup instead of using empty (#6663)	2026-03-06 00:19:10 +01:00
DawnFire42	04f06206b7	Refactor/z value constants (#6651) ... * feat(z-values): add centralized Z-value constants infrastructure Magic numbers scattered across the codebase make Z-value layering hard to understand and maintain. Centralizing them provides: - Self-documenting layer hierarchy - Validation utilities for development - Single source of truth for Z-value ranges Two-tier header design: - z_value_layer_manager.h: Foundation with constants and validation - z_values.h: User-facing namespace with semantic constants * refactor(z-values): replace magic Z-value numbers with ZValues constants Magic numbers like 2000000007 are impossible to understand without context. Named constants (ZValues::DRAG_ITEM) are self-documenting. This intentionally renumbers overlay Z-values to use a cleaner offset sequence. The relative stacking order is preserved, which is what matters for correct rendering. Each consumer now includes z_values.h and uses semantic constants instead of magic numbers. * refactor(z-values): removed redundant inline with contexpr, Updated doc, magic numbers removed from TableZone.	2026-03-05 11:47:14 -08:00
RickyRister	1bcea27a44	[Game] Add face down versions of move cards from library actions (#6661) ... * implement actions * add new actions to menu * update shortcuts	2026-03-04 18:19:41 -08:00
RickyRister	e7a3ad86eb	[Game] Refactor move cards from library actions (#6658) ... * refactor move top/bottom cards actions * minor cleanup * translate zone display names	2026-03-04 15:00:18 +01:00
ebbit1q	b36ab66583	nullcheck printing's set in home tab background art crop (#6646) ... * nullcheck printing's set in home tab background art crop * set warning and properly set timer * fix merge	2026-03-04 00:49:50 +01:00
ebbit1q	566c876bdc	fix scaling for background images on home tab (#6656)	2026-03-04 00:16:45 +01:00
ebbit1q	43acac5f5d	empty card info when switching back to theme background (#6657)	2026-03-04 00:16:19 +01:00
RickyRister	846ecb7e8d	[Client] Support face-down cards in all public zones (#6602) ... * [Server] Support face-down cards in all public zones * add null check * Check using zone names instead * add comment * Rename properties and only pass forceFaceDown * [Game] Refactor CardDragItem faceDown logic * revert refactor * leave face_down unset unless forced * [Client] Support face-down cards in all public zones * leave face_down unset unless forced * log face down * update remaining logs	2026-03-03 23:19:26 +01:00
RickyRister	2fba5dcd20	[Game] Refactor CardDragItem faceDown logic (#6552) ... * Rename properties and only pass forceFaceDown * [Game] Refactor CardDragItem faceDown logic * revert refactor * leave face_down unset unless forced	2026-03-03 23:18:21 +01:00
RickyRister	2828854d32	[Server] Support face-down cards in all public zones (#6539) ... * [Server] Support face-down cards in all public zones * add null check * Check using zone names instead * add comment	2026-03-03 23:17:35 +01:00
dependabot[bot]	9794893b63	Bump actions/attest-build-provenance from 3 to 4 (#6653) ... Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 3 to 4. - [Release notes](https://github.com/actions/attest-build-provenance/releases) - [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md) - [Commits](https://github.com/actions/attest-build-provenance/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/attest-build-provenance dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-03-02 23:06:35 +01:00
ebbit1q	e57ee8e9c9	fix set sorting (#6630)	2026-03-02 23:06:05 +01:00
dependabot[bot]	f978407a19	Bump actions/upload-artifact from 6 to 7 (#6652) ... Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-03-02 23:04:15 +01:00
tooomm	59ce70afc5	Add Code Docs link to issue template (#6649)	2026-03-02 01:59:18 +01:00
DawnFire42	208ccc3a1a	fix(docs): correct typos in README (#6640) ... Fix 'projet' -> 'project' and 'invovled' -> 'involved'.	2026-02-26 21:53:39 -08:00
tooomm	6f8f9f016a	CI: windows-2025 runner (#6632) ... * `windows-2025` runner * Install NSIS * fix naming	2026-02-26 22:31:18 +01:00
Rob Blanckaert	7ad2481e3d	Update UnescapedStringListPart to include parentheses (#6631) ... * Update UnescapedStringListPart to include parentheses * also update deck_filter_string * add unit test --------- Co-authored-by: RickyRister <ricky.rister.wang@gmail.com>	2026-02-25 23:55:34 -08:00