Leahnaya/wfc-server
1
0
Fork 0
mirror of https://github.com/WiiLink24/wfc-server.git synced 2026-05-24 06:06:38 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Sake: Apply lint suggestions

Browse Source
This commit is contained in:
Palapeli 2026-04-06 07:08:36 -04:00
parent 277cee6e57
commit a4a7fb43ce
No known key found for this signature in database
GPG Key ID: 1FFE8F556A474925
3 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sake/mario_kart_wii.go
View File

@ -209,7 +209,9 @@ func handleMarioKartWiiFileDownloadRequest(moduleName string, responseWriter htt
responseWriter.Header().Set(SakeFileResultHeader, strconv.Itoa(SakeFileResultSuccess))
responseWriter.Header().Set("Content-Length", strconv.Itoa(len(file)))
responseWriter.Write(file)
if _, err := responseWriter.Write(file); err != nil {
logging.Error(moduleName, "Failed to write response:", err)
}
}
func handleMarioKartWiiGhostDownloadRequest(moduleName string, responseWriter http.ResponseWriter, request *http.Request) {
@ -274,7 +276,9 @@ func handleMarioKartWiiGhostDownloadRequest(moduleName string, responseWriter ht
responseWriter.Header().Set(SakeFileResultHeader, strconv.Itoa(SakeFileResultSuccess))
responseWriter.Header().Set("Content-Length", strconv.Itoa(len(responseBody)))
responseWriter.Write(responseBody)
if _, err := responseWriter.Write(responseBody); err != nil {
logging.Error(moduleName, "Failed to write response:", err)
}
}
func handleMarioKartWiiFileUploadRequest(moduleName string, responseWriter http.ResponseWriter, request *http.Request) {
@ -365,7 +369,9 @@ func handleMarioKartWiiGhostUploadRequest(moduleName string, responseWriter http
responseWriter.Header().Set(SakeFileResultHeader, strconv.Itoa(SakeFileResultFileNotFound))
return
}
defer file.Close()
defer func() {
common.ShouldNotError(file.Close())
}()
if fileHeader.Size < common.RKGDFileMinSize || fileHeader.Size > common.RKGDFileMaxSize {
logging.Error(moduleName, "The size of the ghost file is invalid:", aurora.Cyan(fileHeader.Size))
@ -392,7 +398,7 @@ func handleMarioKartWiiGhostUploadRequest(moduleName string, responseWriter http
ghostData.RecalculateCRC()
if isContest {
ghostFile = nil
ghostData = nil
}
err = db.InsertMarioKartWiiGhostFile(regionId, courseId, score, pid, playerInfo, []byte(ghostData))
@ -462,10 +468,9 @@ func filterMarioKartWiiFriendInfo(value string, isOwner bool) (string, Result) {
}
binaryData, err := base64.StdEncoding.DecodeString(value)
if err != nil {
// Shouldn't happen after validation
panic(err)
}
// Shouldn't error after validation
common.ShouldNotError(err)
// Only change if the Mii checksum is valid
if len(binaryData) < 0x4C {
return value, ResultSuccess

4
sake/storage.go
View File

@ -232,7 +232,9 @@ func handleStorageRequest(moduleName string, w http.ResponseWriter, r *http.Requ
w.Header().Set("Content-Type", "text/xml")
w.Header().Set("Content-Length", strconv.Itoa(len(payload)))
w.Write(payload)
if _, err := w.Write(payload); err != nil {
logging.Error(moduleName, "Failed to write response:", err)
}
}
func getRequestIdentity(moduleName string, request StorageRequestCommon) (uint32, common.GameInfo, Result) {

2
sake/tables.go
View File

@ -127,7 +127,7 @@ var TableDefinitions = map[string]SakeTable{
OwnerPermDelete: PermissionAllowed,
Hardened: true,
Reserved: true,
SearchForRecordsHandler: getMarioKartWiiStoredGhostDataRecord,
SearchForRecordsHandler: getMarioKartWiiGhostDataRecord,
Fields: map[string]SakeFieldDefinition{
"fileid": {
Type: database.SakeFieldTypeInt,