Leahnaya/wfc-server
1
0
Fork 0
mirror of https://github.com/WiiLink24/wfc-server.git synced 2026-08-27 19:14:02 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

GPCM: Parse and sanitize friend messages

Browse Source 
This will need to be done in QR2 as well
This commit is contained in:
mkwcat
2023-11-24 21:09:32 -05:00
parent 0b1df70196
commit 54dec238ba
2 changed files with 53 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
common/encoding.go
View File

@@ -1,9 +1,12 @@
package common
import (
"encoding/base64"
"fmt"
)
var Base64DwcEncoding = base64.NewEncoding("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789.-").WithPadding('*')
func Base32Encode(value int64) string {
alpha := "0123456789abcdefghijklmnopqrstuv"

64
gpcm/friend.go
View File

@@ -166,23 +166,59 @@ func (g *GameSpySession) bestieMessage(command common.GameSpyCommand) {
return
}
mutex.Lock()
defer mutex.Unlock()
if toSession, ok := sessions[uint32(toProfileId)]; ok && toSession.LoggedIn {
if !toSession.isFriendAdded(g.User.ProfileId) {
logging.Error(g.ModuleName, "Destination", aurora.Cyan(toProfileId), "is not friends with sender")
g.replyError(ErrMessageNotFriends)
return
}
// TODO SECURITY: Sanitize message (there's a stack overflow exploit in DWC here)
sendMessageToSession("1", g.User.ProfileId, toSession, command.OtherValues["msg"])
msg, ok := command.OtherValues["msg"]
if !ok || msg == "" {
logging.Error(g.ModuleName, "Missing message value")
g.replyError(ErrMessage)
return
}
logging.Error(g.ModuleName, "Destination", aurora.Cyan(toProfileId), "is not online")
g.replyError(ErrMessageFriendOffline)
// Parse message for security and room tracking purposes
if len(msg) < 10 || msg[0:4] != "GPCM" || msg[6:10] != "vMAT" {
logging.Error(g.ModuleName, "Invalid message prefix")
g.replyError(ErrMessage)
return
}
if msg[4] < '1' || msg[4] > '9' || msg[5] < '0' || msg[5] >= '9' {
logging.Error(g.ModuleName, "Invalid message version number")
g.replyError(ErrMessage)
return
}
cmd := msg[10]
msgData, err := common.Base64DwcEncoding.DecodeString(msg[11:])
if err != nil {
logging.Error(g.ModuleName, "Invalid message base64 data")
g.replyError(ErrMessage)
return
}
msgMatchData, ok := common.DecodeMatchCommand(cmd, msgData)
common.LogMatchCommand(g.ModuleName, strconv.FormatInt(int64(toProfileId), 10), cmd, msgMatchData)
if !ok {
logging.Error(g.ModuleName, "Invalid match command data")
g.replyError(ErrMessage)
return
}
mutex.Lock()
defer mutex.Unlock()
var toSession *GameSpySession
if toSession, ok = sessions[uint32(toProfileId)]; !ok || !toSession.LoggedIn {
logging.Error(g.ModuleName, "Destination", aurora.Cyan(toProfileId), "is not online")
g.replyError(ErrMessageFriendOffline)
return
}
if !toSession.isFriendAdded(g.User.ProfileId) {
logging.Error(g.ModuleName, "Destination", aurora.Cyan(toProfileId), "is not friends with sender")
g.replyError(ErrMessageNotFriends)
return
}
sendMessageToSession("1", g.User.ProfileId, toSession, msg)
}
func sendMessageToSession(msgType string, from uint32, session *GameSpySession, msg string) {