fix profile update modal

components/t/TeamProfileModal.tsx

@@ -32,20 +32,19 @@ import { GetTeamData } from "prisma/queries/getTeam";
 import { useState } from "react";
 import { useForm } from "react-hook-form";
 import { FaTwitter } from "react-icons/fa";
-import { FiEdit } from "react-icons/fi";
 import { mutate } from "swr";
 import * as z from "zod";
 
 interface Props {
   team: NonNullable<GetTeamData>;
+  closeModal: () => void;
 }
 
 type FormData = z.infer<typeof teamSchema>;
 
-const TeamProfileModal: React.FC<Props> = ({ team }) => {
+const TeamProfileModal: React.FC<Props> = ({ team, closeModal }) => {
   const { i18n } = useLingui();
   const toast = useToast();
-  const [isOpen, setIsOpen] = useState(false);
   const [sending, setSending] = useState(false);
 
   const { handleSubmit, errors, register, watch } = useForm<FormData>({
@@ -57,7 +56,7 @@ const TeamProfileModal: React.FC<Props> = ({ team }) => {
   const watchRecruitingPost = watch("recruitingPost", team.recruitingPost);
 
   const onSubmit = async (formData: FormData) => {
-    const modifiedData: FormData = {};
+    const modifiedData: FormData = formData;
 
     for (const [key, value] of Object.entries(formData)) {
       if (value === "" || value === undefined) {
@@ -76,99 +75,85 @@ const TeamProfileModal: React.FC<Props> = ({ team }) => {
 
     toast(getToastOptions(t`Team profile updated`, "success"));
 
-    setIsOpen(false);
+    closeModal();
   };
 
   return (
-    <>
-      <Button leftIcon={<FiEdit />} onClick={() => setIsOpen(true)} size="sm">
-        <Trans>Edit team profile</Trans>
-      </Button>
-      {isOpen && (
-        <Modal
-          isOpen
-          onClose={() => setIsOpen(false)}
-          size="xl"
-          closeOnOverlayClick={false}
-        >
-          <ModalOverlay>
-            <ModalContent>
-              <ModalHeader>
-                <Trans>Editing team profile</Trans>
-              </ModalHeader>
-              <ModalCloseButton borderRadius="50%" />
-              <form onSubmit={handleSubmit(onSubmit)}>
-                <ModalBody pb={6}>
-                  <FormControl isInvalid={!!errors.twitterName}>
-                    <FormLabel htmlFor="twitterName">
-                      <Box
-                        as={FaTwitter}
-                        display="inline-block"
-                        mr={2}
-                        mb={1}
-                        color="#1DA1F2"
-                      />{" "}
-                      <Trans>Twitter name</Trans>
-                    </FormLabel>
-                    <InputGroup>
-                      <InputLeftAddon children="https://twitter.com/" />
-                      <Input
-                        name="twitterName"
-                        ref={register}
-                        placeholder="olivesplatoon"
-                      />
-                    </InputGroup>
-                    <FormHelperText>
-                      <Trans>
-                        Twitter is also used to get the team's avatar.
-                      </Trans>
-                    </FormHelperText>
-                    <FormErrorMessage>
-                      {errors.twitterName?.message}
-                    </FormErrorMessage>
-                  </FormControl>
-
-                  <MarkdownTextarea
-                    fieldName="bio"
-                    title={i18n._(t`Bio`)}
-                    error={errors.bio}
-                    register={register}
-                    value={watchBio ?? ""}
-                    maxLength={TEAM_BIO_CHARACTER_LIMIT}
-                    placeholder={i18n._(
-                      t`# I'm a header
-                  I'm **bolded**. Embedding weapon images is easy too: :luna_blaster:`
-                    )}
+    <Modal isOpen onClose={closeModal} size="xl" closeOnOverlayClick={false}>
+      <ModalOverlay>
+        <ModalContent>
+          <ModalHeader>
+            <Trans>Editing team profile</Trans>
+          </ModalHeader>
+          <ModalCloseButton borderRadius="50%" />
+          <form onSubmit={handleSubmit(onSubmit)}>
+            <ModalBody pb={6}>
+              <FormControl isInvalid={!!errors.twitterName}>
+                <FormLabel htmlFor="twitterName">
+                  <Box
+                    as={FaTwitter}
+                    display="inline-block"
+                    mr={2}
+                    mb={1}
+                    color="#1DA1F2"
+                  />{" "}
+                  <Trans>Twitter name</Trans>
+                </FormLabel>
+                <InputGroup>
+                  <InputLeftAddon children="https://twitter.com/" />
+                  <Input
+                    name="twitterName"
+                    ref={register}
+                    placeholder="olivesplatoon"
                   />
+                </InputGroup>
+                <FormHelperText>
+                  <Trans>Twitter is also used to get the team's avatar.</Trans>
+                </FormHelperText>
+                <FormErrorMessage>
+                  {errors.twitterName?.message}
+                </FormErrorMessage>
+              </FormControl>
 
-                  <MarkdownTextarea
-                    fieldName="recruitingPost"
-                    title={i18n._(t`Recruiting post`)}
-                    error={errors.recruitingPost}
-                    register={register}
-                    value={watchRecruitingPost ?? ""}
-                    maxLength={TEAM_RECRUITING_POST_CHARACTER_LIMIT}
-                    placeholder={i18n._(
-                      t`# I'm a header
+              <MarkdownTextarea
+                fieldName="bio"
+                title={i18n._(t`Bio`)}
+                error={errors.bio}
+                register={register}
+                value={watchBio ?? ""}
+                maxLength={TEAM_BIO_CHARACTER_LIMIT}
+                placeholder={i18n._(
+                  t`# I'm a header
                   I'm **bolded**. Embedding weapon images is easy too: :luna_blaster:`
-                    )}
-                  />
-                </ModalBody>
+                )}
+              />
 
-                <ModalFooter>
-                  <Button mr={3} type="submit" isLoading={sending}>
-                    <Trans>Save</Trans>
-                  </Button>
-                  <Button onClick={() => setIsOpen(false)} variant="outline">
-                    <Trans>Cancel</Trans>
-                  </Button>
-                </ModalFooter>
-              </form>
-            </ModalContent>
-          </ModalOverlay>
-        </Modal>
-      )}
-    </>
+              <MarkdownTextarea
+                fieldName="recruitingPost"
+                title={i18n._(t`Recruiting post`)}
+                error={errors.recruitingPost}
+                register={register}
+                value={watchRecruitingPost ?? ""}
+                maxLength={TEAM_RECRUITING_POST_CHARACTER_LIMIT}
+                placeholder={i18n._(
+                  t`# I'm a header
+                  I'm **bolded**. Embedding weapon images is easy too: :luna_blaster:`
+                )}
+              />
+            </ModalBody>
+
+            <ModalFooter>
+              <Button mr={3} type="submit" isLoading={sending}>
+                <Trans>Save</Trans>
+              </Button>
+              <Button onClick={closeModal} variant="outline">
+                <Trans>Cancel</Trans>
+              </Button>
+            </ModalFooter>
+          </form>
+        </ModalContent>
+      </ModalOverlay>
+    </Modal>
   );
 };
 

pages/t/[team].tsx

@@ -37,6 +37,7 @@ import Image from "next/image";
 import { getTeam, GetTeamData } from "prisma/queries/getTeam";
 import { Fragment, useEffect, useState } from "react";
 import { FaTwitter } from "react-icons/fa";
+import { FiEdit } from "react-icons/fi";
 import useSWR, { mutate } from "swr";
 
 interface Props {
@@ -106,6 +107,7 @@ const TeamPage: React.FC<Props> = (props) => {
   const team = data!;
 
   const [sending, setSending] = useState(false);
+  const [profileModalIsOpen, setProfileModalIsOpen] = useState(false);
   const [user] = useUser();
   const toast = useToast();
 
@@ -133,6 +135,12 @@ const TeamPage: React.FC<Props> = (props) => {
 
   return (
     <MyContainer>
+      {profileModalIsOpen && (
+        <TeamProfileModal
+          team={team}
+          closeModal={() => setProfileModalIsOpen(false)}
+        />
+      )}
       <Flex align="center" justify="center">
         {team.twitterName && (
           <TwitterAvatar twitterName={team.twitterName} size="lg" mr={2} />
@@ -159,7 +167,7 @@ const TeamPage: React.FC<Props> = (props) => {
       {teamXPData.teamXP !== "2000" && (
         <Popover trigger="hover" variant="responsive">
           <PopoverTrigger>
-            <Center mt={2}>
+            <Center>
               <Image src={`/layout/xsearch.png`} height={24} width={24} />
               <SubText ml={1}>{teamXPData.teamXP}</SubText>
             </Center>
@@ -210,7 +218,13 @@ const TeamPage: React.FC<Props> = (props) => {
         <Center my={4}>
           <Stack direction={["column", "row"]} spacing={4}>
             <TeamManagementModal team={team} />
-            <TeamProfileModal team={team} />
+            <Button
+              leftIcon={<FiEdit />}
+              onClick={() => setProfileModalIsOpen(true)}
+              size="sm"
+            >
+              <Trans>Edit team profile</Trans>
+            </Button>
           </Stack>
         </Center>
       )}