Leahnaya/sendou.ink
1
0
Fork 0
mirror of https://github.com/Sendouc/sendou.ink.git synced 2026-09-13 14:46:10 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't show rosters as skipped on All rosters tab

Browse Source
This commit is contained in:
Kalle
2026-08-21 08:13:03 +03:00
parent e4a850c9d5
commit dba6136f5f
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/features/leaderboards/LeaderboardRepository.server.test.ts
View File

@@ -277,6 +277,14 @@ describe("LeaderboardRepository.findTeamLeaderboardBySeason", () => {
})
).map((entry) => [entry.identifier, entry.placementRank]);
const allRostersPlacements = async () =>
(
await LeaderboardRepository.findTeamLeaderboardBySeason({
season: SEASON,
onlyOneEntryPerUser: false,
})
).map((entry) => [entry.identifier, entry.placementRank, entry.isSkipped]);
beforeEach(async () => {
await users.create(9);
await playSeasonInWith(topRoster());
@@ -300,6 +308,16 @@ describe("LeaderboardRepository.findTeamLeaderboardBySeason", () => {
]);
});
test("places a skipped team normally on the all rosters leaderboard", async () => {
await skipTeam(topRoster());
expect(await allRostersPlacements()).toEqual([
[userIdsToIdentifier(topRoster()), 1, false],
[userIdsToIdentifier(sharedPlayersRoster()), 2, false],
[userIdsToIdentifier(beatenRoster()), 3, false],
]);
});
test("gives a team its placement back when it is unskipped", async () => {
await skipTeam(topRoster());
await LeaderboardRepository.deleteTeamSkip({

5
app/features/leaderboards/LeaderboardRepository.server.ts
View File

@@ -121,9 +121,12 @@ export async function findTeamLeaderboardBySeason({
season: number;
onlyOneEntryPerUser: boolean;
}) {
// skipping is about the season finale qualification which the all rosters leaderboard is not concerned with
const entries = addSkipped({
entries: await teamLeaderboardBySeasonQuery(season).execute(),
skippedIdentifiers: await findAllTeamSkipIdentifiersBySeason(season),
skippedIdentifiers: onlyOneEntryPerUser
? await findAllTeamSkipIdentifiersBySeason(season)
: new Set<SkillTeamIdentifier>(),
});
const withNonSqPlayersHandled = onlyOneEntryPerUser
? await filterOutNonSqPlayers({ season, entries })