Prefetch chunks behind modal buttons

This commit is contained in:
Kalle
2022-06-11 15:30:58 +03:00
parent 2c93ac9b77
commit 904f9877d1
2 changed files with 9 additions and 3 deletions

View File

@@ -60,7 +60,7 @@ type LinkButtonProps = Pick<
ButtonProps,
"variant" | "children" | "className" | "tiny"
> &
Pick<RemixLinkProps, "to"> & { "data-cy"?: string };
Pick<RemixLinkProps, "to" | "prefetch"> & { "data-cy"?: string };
export function LinkButton({
variant,
@@ -68,6 +68,7 @@ export function LinkButton({
tiny,
className,
to,
prefetch,
"data-cy": testId,
}: LinkButtonProps) {
return (
@@ -75,6 +76,7 @@ export function LinkButton({
className={clsx("button", variant, { tiny }, className)}
to={to}
data-cy={testId}
prefetch={prefetch}
>
{children}
</Link>

View File

@@ -161,7 +161,11 @@ export default function PlusSuggestionsPage() {
</div>
{canSuggestNewUserFE({ user, suggestions: data.suggestions }) ? (
// TODO: resetScroll={false} https://twitter.com/ryanflorence/status/1527775882797907969
<LinkButton to="new" data-cy="new-suggest-button">
<LinkButton
to="new"
data-cy="new-suggest-button"
prefetch="render"
>
Suggest
</LinkButton>
) : null}
@@ -249,7 +253,6 @@ function SuggestedUser({
invariant(data.suggestions);
// xxx: should comment/new modal links preload? does it cause many preloads if we do?
return (
<div className="stack md">
<div className="plus__suggested-user-info">
@@ -279,6 +282,7 @@ function SuggestedUser({
variant="outlined"
to={`comment/${tier}/${suggested.suggestedUser.id}`}
data-cy="comment-button"
prefetch="render"
>
Comment
</LinkButton>