Leahnaya/sendou.ink
1
0
Fork 0
mirror of https://github.com/Sendouc/sendou.ink.git synced 2026-09-30 15:17:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't allow too old tournaments to contribute to already closed seasonal rankings

Browse Source
This commit is contained in:
Kalle
2026-05-01 15:51:40 +03:00
parent 609bb2de7a
commit 8a773650fd
1 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
app/features/tournament-bracket/actions/to.$id.brackets.finalize.server.ts
View File

@@ -1,3 +1,4 @@
import { differenceInHours } from "date-fns";
import type { ActionFunctionArgs } from "react-router";
import { requireUser } from "~/features/auth/core/user.server";
import * as BadgeRepository from "~/features/badges/BadgeRepository.server";
@@ -65,10 +66,7 @@ export const action = async ({ request, params }: ActionFunctionArgs) => {
const results = allMatchResultsByTournamentId(tournamentId);
invariant(results.length > 0, "No results found");
const seasonAttributionDate = tournament.isLeagueDivision
? new Date()
: tournament.ctx.startTime;
const season = Seasons.current(seasonAttributionDate)?.nth;
const season = resolveFinalizationSeason(tournament);
const seedingSkillCountsFor = tournament.skillCountsFor;
const standingsResult = Standings.tournamentStandings(tournament);
@@ -77,7 +75,7 @@ export const action = async ({ request, params }: ActionFunctionArgs) => {
teams: tournament.ctx.teams,
finalStandings,
results,
calculateSeasonalStats: tournament.ranked,
calculateSeasonalStats: tournament.ranked && typeof season === "number",
queryCurrentTeamRating: (identifier) =>
queryCurrentTeamRating({ identifier, season: season! }).rating,
queryCurrentUserRating: (userId) =>
@@ -118,9 +116,9 @@ export const action = async ({ request, params }: ActionFunctionArgs) => {
await updateSeriesTierHistory(tournament);
}
if (tournament.ranked) {
if (tournament.ranked && typeof season === "number") {
try {
refreshUserSkills(season!);
refreshUserSkills(season);
} catch (error) {
logger.warn("Error refreshing user skills", error);
}
@@ -214,3 +212,18 @@ async function updateSeriesTierHistory(tournament: Tournament) {
logger.error("Error updating series tier history", error);
}
}
function resolveFinalizationSeason(tournament: Tournament) {
// league divisions might be running for many weeks
const attributionDate = tournament.isLeagueDivision
? new Date()
: tournament.ctx.startTime;
const season = Seasons.current(attributionDate);
if (!season) return undefined;
// don't allow changing seasons that have already been closed for a long while
// even if you were sluggish with finalizing the tournament
if (differenceInHours(new Date(), season.ends) >= 24) return undefined;
return season.nth;
}