Leahnaya/sendou.ink
1
0
Fork 0
mirror of https://github.com/Sendouc/sendou.ink.git synced 2026-05-09 04:02:40 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix wrong max count showing on suggestion comment

Browse Source
This commit is contained in:
Kalle 2022-06-25 21:50:47 +03:00
parent bca8fd6da8
commit 80a53085c5
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/routes/plus/suggestions/comment.$tier.$userId.tsx
View File

@ -98,7 +98,7 @@ export default function PlusCommentModalPage() {
{userBeingCommented.suggestedUser.discordName}'s +
{tierSuggestedTo} suggestion
</h2>
<CommentTextarea />
<CommentTextarea maxLength={PlUS_SUGGESTION_COMMENT_MAX_LENGTH} />
<div className="plus__modal-buttons">
<Button type="submit" data-cy="submit-button">
Submit

8
app/routes/plus/suggestions/new.tsx
View File

@ -150,7 +150,7 @@ export default function PlusNewSuggestionModalPage() {
<ErrorMessage>{selectedUserErrorMessage}</ErrorMessage>
) : null}
</div>
<CommentTextarea />
<CommentTextarea maxLength={PlUS_SUGGESTION_FIRST_COMMENT_MAX_LENGTH} />
<div className="plus__modal-buttons">
<Button
type="submit"
@ -199,7 +199,7 @@ function getSelectedUserErrorMessage({
}
// TODO: better UX - allow going over but prevent submit like Twitter
export function CommentTextarea() {
export function CommentTextarea({ maxLength }: { maxLength: number }) {
const [value, setValue] = React.useState("");
return (
<div>
@ -207,7 +207,7 @@ export function CommentTextarea() {
htmlFor="text"
valueLimits={{
current: value.length,
max: PlUS_SUGGESTION_FIRST_COMMENT_MAX_LENGTH,
max: maxLength,
}}
>
Your comment
@ -219,7 +219,7 @@ export function CommentTextarea() {
rows={4}
value={value}
onChange={(e) => setValue(e.target.value)}
maxLength={PlUS_SUGGESTION_FIRST_COMMENT_MAX_LENGTH}
maxLength={maxLength}
data-cy="comment-textarea"
required
/>