Remove target="_blank" from internal navigation links

All links to internal routes should stay in the same tab to maintain user context and provide a better SPA experience. Closes #2619

app/features/img-upload/routes/upload.admin.tsx

@@ -56,12 +56,7 @@ function ImageValidator() {
 								</FormWithConfirm>
 							</div>
 							<img src={userSubmittedImage(image.url)} alt="" />
-							<Link
-								to={`/u/${image.submitterUserId}`}
-								className="text-xs"
-								target="_blank"
-								rel="noopener noreferrer"
-							>
+							<Link to={`/u/${image.submitterUserId}`} className="text-xs">
 								From: {image.username}
 							</Link>
 						</div>

app/features/lfg/routes/lfg.new.tsx

@@ -234,7 +234,7 @@ function Languages() {
 			</div>
 			<FormMessage type="info">
 				{t("lfg:new.editOn")}{" "}
-				<Link to={SENDOUQ_SETTINGS_PAGE} target="_blank" rel="noreferrer">
+				<Link to={SENDOUQ_SETTINGS_PAGE}>
 					{t("lfg:new.languages.sqSettingsPage")}
 				</Link>
 			</FormMessage>
@@ -262,7 +262,7 @@ function WeaponPool() {
 			</div>
 			<FormMessage type="info">
 				{t("lfg:new.editOn")}{" "}
-				<Link to={userEditProfilePage(user!)} target="_blank" rel="noreferrer">
+				<Link to={userEditProfilePage(user!)}>
 					{t("lfg:new.weaponPool.userProfile")}
 				</Link>
 			</FormMessage>

app/features/sendouq/components/GroupCard.tsx

@@ -302,11 +302,7 @@ function GroupMember({
 					) : (
 						<Avatar user={member} size="xs" />
 					)}
-					<Link
-						to={userPage(member)}
-						className="q__group-member__name"
-						target="_blank"
-					>
+					<Link to={userPage(member)} className="q__group-member__name">
 						{member.inGameName ? (
 							<>
 								<span className="text-lighter font-bold text-xxxs">
@@ -752,7 +748,7 @@ function TierInfo({ skill }: { skill: TieredSkill | "CALCULATING" }) {
 							{skill.tier.name}
 							{skill.tier.isPlus ? "+" : ""}
 						</div>
-						<Link to={TIERS_PAGE} className="text-xxs" target="_blank">
+						<Link to={TIERS_PAGE} className="text-xxs">
 							{t("q:looking.allTiers")}
 						</Link>
 					</div>

app/features/tournament-bracket/components/TeamRosterInputs.tsx

@@ -461,7 +461,7 @@ function TeamRosterInputsCheckboxes({
 								</span>
 							</label>
 						</div>
-						<Link to={userPage(member)} target="_blank">
+						<Link to={userPage(member)}>
 							<Avatar size="xxs" user={member} />
 						</Link>
 					</div>

app/features/tournament/routes/to.$id.seeds.tsx

@@ -414,7 +414,6 @@ function RowContents({
 						<div key={member.userId} className="tournament__seeds__team-member">
 							<Link
 								to={userResultsPage(member, true)}
-								target="_blank"
 								className="tournament__seeds__team-member__name"
 							>
 								{member.username}