mirror of
https://github.com/pret/poketcg.git
synced 2026-10-02 05:46:45 -05:00
Adjust formatting according to review comments
This commit is contained in:
@@ -263,12 +263,12 @@ A missing line in AI logic might result in strange behavior when executing the e
|
||||
```diff
|
||||
AIDecide_PokemonTrader_PowerGenerator: ; 2200b (8:600b)
|
||||
...
|
||||
ld a, RAICHU_LV40
|
||||
call LookForCardIDInDeck_GivenCardIDInHandAndPlayArea
|
||||
- jr c, .find_duplicates
|
||||
+ jp c, .find_duplicates
|
||||
ld a, PIKACHU_LV14
|
||||
ld b, RAICHU_LV40
|
||||
ld a, RAICHU_LV40
|
||||
call LookForCardIDInDeck_GivenCardIDInHandAndPlayArea
|
||||
- jr c, .find_duplicates
|
||||
+ jp c, .find_duplicates
|
||||
ld a, PIKACHU_LV14
|
||||
ld b, RAICHU_LV40
|
||||
...
|
||||
call LookForCardIDInDeck_GivenCardIDInHand
|
||||
jr c, .find_duplicates
|
||||
@@ -284,13 +284,12 @@ AIDecide_PokemonTrader_PowerGenerator: ; 2200b (8:600b)
|
||||
|
||||
; a card in deck was found to look for,
|
||||
; check if there are duplicates in hand to trade with.
|
||||
...
|
||||
.set_carry
|
||||
scf
|
||||
...
|
||||
.set_carry
|
||||
scf
|
||||
+; fallthrough
|
||||
+ .no_carry
|
||||
ret
|
||||
|
||||
+.no_carry
|
||||
ret
|
||||
```
|
||||
|
||||
## AI never uses Energy Trans in order to retreat Arena card
|
||||
@@ -340,7 +339,7 @@ There is a mistake in the AI logic for deciding which Pokémon for Sam to switch
|
||||
inc a ; PLAY_AREA_BENCH_2
|
||||
```
|
||||
|
||||
**Fix:** Edit `AIDecide_PokemonTrader_PowerGenerator` in [src/engine/duel/ai/decks/sams_practice.asm](https://github.com/pret/poketcg/blob/master/src/engine/duel/ai/decks/sams_practice.asm):
|
||||
**Fix:** Edit `AIPerformScriptedTurn` in [src/engine/duel/ai/decks/sams_practice.asm](https://github.com/pret/poketcg/blob/master/src/engine/duel/ai/decks/sams_practice.asm):
|
||||
```diff
|
||||
AIPerformScriptedTurn: ; 1483a (5:483a)
|
||||
...
|
||||
@@ -415,8 +414,9 @@ HandleAIShift: ; 22476 (8:6476)
|
||||
```
|
||||
## Challenge host uses wrong name for the first rival
|
||||
When playing the challenge cup, player name is used instead of rival name before the first fight, as seen here: https://www.youtube.com/watch?v=1igDbNxRfUw&t=17310s
|
||||
|
||||
**Fix:** Edit `Text0533` in `text6.asm`:
|
||||
```
|
||||
```diff
|
||||
- text "Presently, <RAMNAME> is still"
|
||||
+ text "Presently, <RAMTEXT> is still"
|
||||
```
|
||||
Reference in New Issue
Block a user