Commit Graph

2651 Commits

Author SHA1 Message Date
mudskipper13
d19aa216dd ov7_0224CD28/shop menu: doc most of ShopMenu fields 2025-02-26 08:02:02 +07:00
mudskipper13
27bbbdb8bc ov7_0224CD28/shop menu: partial UnkStruct_ov7_0224D008 -> ShopMenu 2025-02-26 08:02:02 +07:00
mudskipper13
647febaeb7 ov7_0224CD28/shop menu: slightly better names for alt window templates 2025-02-26 08:02:02 +07:00
mudskipper13
b494c72a43 ov7_0224CD28/shop menu: ov7_0224CDA4 -> Shop_Start 2025-02-26 08:02:02 +07:00
mudskipper13
bf6c1ad017 ov7_0224CD28/shop menu: HeapId enum usage 2025-02-26 08:02:01 +07:00
mudskipper13
13ee165892 ov7_0224CD28/shop menu: unk_2A9 -> martType 2025-02-26 08:02:01 +07:00
mudskipper13
6f0b70bc2b ov7_0224CD28/shop menu: document most of const data
the exceptions are:
- `Unk_ov7_0224F49C`, very unclear of what it does yet
- `v1` in `ov7_0224E8CC`, i'd like to document it together with the function
2025-02-26 08:02:01 +07:00
Rachel
5e3e9577b0
Merge pull request #386 from h2o-DS/Pokedex_Menu_Text
Some checks are pending
build / build (push) Waiting to run
Document pokedex_main, pokedex_memory, and core pokedex structs
2025-02-25 06:09:01 -08:00
h2o-DS
8e99248ce0 Merge branch 'Pokedex_Menu_Text' of https://github.com/h2o-DS/pokeplatinum into Pokedex_Menu_Text 2025-02-25 08:26:30 -05:00
h2o-DS
65bef2399a Merge branch 'Pokedex_Menu_Text' of https://github.com/h2o-DS/pokeplatinum into Pokedex_Menu_Text
Polish

Created moved PokedexApp to pokedex_app.h
Documented some PokedexApp variable names
Decomposed PokedexOverlayData into PokedexApp double pointer
Extended PokedexBootMode names

StartMenu Merge
2025-02-25 08:23:22 -05:00
h2o-DS
f1f90bea97 Merge branch 'Pokedex_Menu_Text' of https://github.com/h2o-DS/pokeplatinum into Pokedex_Menu_Text 2025-02-25 08:04:09 -05:00
h2o-DS
597a49eb03 StartMenu Merge 2025-02-25 07:59:54 -05:00
h2o-DS
358a5fdbfe Polish
Created moved PokedexApp to pokedex_app.h
Documented some PokedexApp variable names
Decomposed PokedexOverlayData into PokedexApp double pointer
Extended PokedexBootMode names
2025-02-25 07:59:46 -05:00
h2o-DS
d137ce45a6 pokedex_main
ov21_021D0D80 -> pokedex_main
unk_0209ACBC-> pokedex_memory
struct_ov21_021D3320 -> pokedex_sort_data
UnkStruct_ov21_021D13FC -> PokedexGraphicData
UnkStruct_ov21_021D0F60 -> PokedexApp
enum HeapId HEAP_ID_POKEDEX
2025-02-25 07:59:10 -05:00
h2o-DS
658d078939 StartMenu Merge 2025-02-25 06:45:13 -05:00
h2o-DS
8f0da81c9d Merge remote-tracking branch 'upstream/main' into Pokedex_Menu_Text 2025-02-25 06:24:57 -05:00
h2o-DS
3281d4fe36 Polish
Created moved PokedexApp to pokedex_app.h
Documented some PokedexApp variable names
Decomposed PokedexOverlayData into PokedexApp double pointer
Extended PokedexBootMode names
2025-02-25 06:15:58 -05:00
Rachel
3dd2197369
Merge pull request #399 from cbt6/field-event-constants
Some checks are pending
build / build (push) Waiting to run
Use various constants in field events
2025-02-24 20:39:13 -08:00
Rachel
4763b753c0
Merge pull request #397 from Kuruyia/feat/document-map-prop-animation
Document map prop animation
2025-02-24 19:50:30 -08:00
Rachel
1def5cc0f7
Merge pull request #396 from CharlesFolz4/JubilifeLottery
Document unk_020480A8 as the JubilifeLottery
2025-02-24 19:37:11 -08:00
cbt6
4f1e58ee21 Use map header constants in field events 2025-02-25 11:19:53 +08:00
cbt6
2b50c2ee48 Use bg event dir constants in field events 2025-02-25 11:17:07 +08:00
cbt6
aabc9efc77 Use trainer type constants in field events 2025-02-25 11:15:35 +08:00
cbt6
a8aa814e85 Use object event constants in field events 2025-02-25 11:13:29 +08:00
cbt6
bdc430f8b1 Use movement type constants in field events 2025-02-25 11:12:06 +08:00
Kuruyia
207f789689 Document map prop animation
This documents the `ov5_021D37AC.c` file, which is in charge of managing
the animations on map props.

The map prop animation code is actually split into two separate
managers:
* The `MapPropAnimationManager`, which is in charge of loading animation
  data from the two related NARC files, and managing long-running
  animations (e.g. Valley Windworks windmills, Fuego Ironworks furnace,
  Veilstone Game Corner lights...)
* The `MapPropOneShotAnimationManager`, which is in charge of loading
  and playing "one shot" animations (e.g. any door opening/closing, the
  Pokémon Center stairs...)

Signed-off-by: Kuruyia <github@kuruyia.net>
2025-02-24 11:53:11 +01:00
narf0708@gmail.com
9274549f44 make format 2025-02-23 17:30:01 -05:00
narf0708@gmail.com
4fe2b5aaf2 More PR feedback 2025-02-23 17:25:35 -05:00
narf0708@gmail.com
7bfcfc3e77 TRUE -> FALSE for checksum match 2025-02-23 17:09:28 -05:00
narf0708@gmail.com
87a71f6728 PR feedback 2025-02-23 16:42:04 -05:00
narf0708@gmail.com
34f1d81aae Document unk_020480A8 as the JubilifeLottery 2025-02-23 16:31:42 -05:00
Rachel
dc5440a466
Merge pull request #393 from Viperio19/document-scripts
Some checks failed
build / build (push) Has been cancelled
Document lake trio cavern scripts
2025-02-23 12:38:27 -08:00
Viperio19
54909d6c13 I still missed one constant somehow 2025-02-23 11:16:29 +01:00
Viperio19
5fa168c989 Two more constants usages for PlayCry 2025-02-23 10:47:00 +01:00
Viperio19
7b8ab80544 Using constants for poketch apps and removing unused variable for PlayCry 2025-02-22 22:12:10 +01:00
Rachel
2873d3f9e4
Merge pull request #392 from Kuruyia/feat/document-area-data
Some checks failed
build / build (push) Has been cancelled
Document area data
2025-02-22 11:32:39 -08:00
Viperio19
0a03b1624d Renaming script commands and using constants for PlayCry 2025-02-22 16:06:47 +01:00
Kuruyia
be823a26bb Document area data
This documents the `ov5_021EF75C.c` file, which is in charge of loading
various "area data" NARCs that, in the end, contain the textures of
maps, the textures and models of map props, and lighting information.

Also, renamed `MapProp.id` to `MapProp.modelID` for more clarity
(especially when interacting with the new area data functions).

Signed-off-by: Kuruyia <github@kuruyia.net>
2025-02-22 13:38:54 +01:00
RavePossum
38db1294f5
Merge pull request #395 from Gudf/field-menu-rename
Some checks are pending
build / build (push) Waiting to run
Rename `FieldMenu` to `StartMenu`
2025-02-22 00:07:35 -05:00
RavePossum
519bb3f934
Merge pull request #394 from lhearachel/accept-script-entries-flag
Some checks are pending
build / build (push) Waiting to run
Use a flag to forbid using ScriptEntry after ScriptEntryEnd
2025-02-21 23:54:02 -05:00
Rachel
0ba0d64eee Use a flag to forbid using ScriptEntry after ScriptEntryEnd 2025-02-21 11:06:49 -08:00
Gudf
bfa39b9d0d Rename FieldMenu to StartMenu 2025-02-20 21:54:54 +01:00
Rachel
a9bf501977
Merge pull request #388 from lucie-sharpe/PoketchDigitalClockApp
Some checks failed
build / build (push) Has been cancelled
Poketch digital clock app
2025-02-20 10:31:45 -08:00
Viperio19
913d67dd10 Document lake trio caverns 2025-02-20 18:14:04 +01:00
Lucie
6ec00bbabe updated overlay name 2025-02-20 13:41:09 +00:00
RavePossum
49650d5bce
Merge pull request #390 from Viperio19/document-scripts
Some checks are pending
build / build (push) Waiting to run
Using more constants in scripts
2025-02-19 08:19:31 -05:00
Viperio19
b54c5cef55 Rename SetAssistantPartnerTeam to SetPlayerCounterpartPartnerTeam 2025-02-19 10:17:17 +01:00
Viperio19
b9ce1ae906 Use pocket constants, true/false, and trainer constants for tag battles / first battle 2025-02-19 00:24:29 +01:00
Viperio19
01c0e43473 Use gender and yes/no constants in scripts 2025-02-18 23:17:52 +01:00
Viperio19
313b3e8aaa Merge branch 'pret' into document-scripts 2025-02-18 22:38:08 +01:00