mirror of
https://github.com/smogon/pokemon-showdown.git
synced 2026-04-25 07:22:09 -05:00
8fb16faf70
* Improvements to room FAQs and repeats - Removed /rfaq alias check when setting a topic to repeat. If a /rfaq alias is set to repeat, the text of the topic the alias is set for is displayed, rather than the topic's ID. - If a /rfaq is deleted, repeats linked to it or one of its aliases will also be deleted, preventing a crash caused by trying to display a nonexistent topic. - A separate problem, but the ability to set a topic as an alias of itself has been removed. Because this is possible, you can have a topic which is registered in the server, but does not appear at all if you type /rfaq. * Remove unnecessary toID * Update room-faqs.ts Avoiding lint error array-callback-return * Use for loop instead of map * Update room-faqs.ts * Restore original code, prevent overriding topics Turns out it is possible to cause a similar crash that is not related to repeats. This can be done by creating two topics (Topic 1 and Topic 2) and making Topic 2 have an alias (Topic 3). You can then make Topic 2 an alias of Topic 1, making Topic 3 an alias of an alias. Deleting Topic 1 will delete Topic 2 but not Topic 3, and typing /rfaq Topic 3 will cause a crash. It feels like it would overcomplicate the code to try to redirect existing aliases. I don't know how often people override topics, but the removal of this does not seem like too much of an inconvenience (just one extra step to convert a topic to an alias). Also, for some reason, removing an alias would remove a repeat linked to the topic. Not sure why it was made that way, so I made it so that removing the topic is the only thing that should remove the repeat. |
||
|---|---|---|
| .. | ||
| randombattles | ||
| trivia | ||
| abuse-monitor.ts | ||
| announcements.ts | ||
| battlesearch.ts | ||
| blackjack.ts | ||
| calculator.ts | ||
| cg-teams-leveling.ts | ||
| chat-monitor.ts | ||
| chatlog.ts | ||
| COMMANDS.md | ||
| daily-spotlight.ts | ||
| datasearch.ts | ||
| friends.ts | ||
| github.ts | ||
| hangman.ts | ||
| helptickets-auto.ts | ||
| helptickets.ts | ||
| hosts.ts | ||
| jeopardy.ts | ||
| lottery.ts | ||
| mafia.ts | ||
| modlog-viewer.ts | ||
| othermetas.ts | ||
| permalocks.ts | ||
| poll.ts | ||
| quotes.ts | ||
| repeats.ts | ||
| responder.ts | ||
| rock-paper-scissors.tsx | ||
| room-events.ts | ||
| room-faqs.ts | ||
| sample-teams.ts | ||
| scavenger-games.ts | ||
| scavengers.ts | ||
| smogtours.ts | ||
| suspect-tests.ts | ||
| tcgtabletop.ts | ||
| teams.ts | ||
| the-studio.ts | ||
| thecafe.tsx | ||
| thing-of-the-day.ts | ||
| uno.ts | ||
| username-prefixes.ts | ||
| usersearch.tsx | ||
| wifi.tsx | ||
| youtube.ts | ||