Handle new TypeScript version (#8449)

Co-authored-by: Guangcong Luo <guangcongluo@gmail.com>

.eslintrc-no-types.json

@@ -1,7 +1,7 @@
 {
   "root": true,
   "parserOptions": {
-    "ecmaVersion": 9,
+    "ecmaVersion": 10,
     "sourceType": "script",
     "ecmaFeatures": {
       "globalReturn": true

.eslintrc.json

@@ -5,7 +5,7 @@
       "files": ["./config/*.ts", "./data/**/*.ts", "./lib/*.ts", "./server/**/*.ts", "./sim/**/*.ts", "./tools/set-import/*.ts"],
       "parser": "@typescript-eslint/parser",
       "parserOptions": {
-        "ecmaVersion": 9,
+        "ecmaVersion": 10,
         "sourceType": "module",
         "tsconfigRootDir": ".",
         "project": ["./tsconfig.json"]

lib/crashlogger.ts

@@ -24,11 +24,11 @@ let transport: any;
  * to receive them.
  */
 export function crashlogger(
-	error: Error | string, description: string, data: AnyObject | null = null
+	error: unknown, description: string, data: AnyObject | null = null
 ): string | null {
 	const datenow = Date.now();
 
-	let stack = (typeof error === 'string' ? error : error?.stack) || '';
+	let stack = (typeof error === 'string' ? error : (error as Error)?.stack) || '';
 	if (data) {
 		stack += `\n\nAdditional information:\n`;
 		for (const k in data) {
@@ -51,7 +51,7 @@ export function crashlogger(
 		if (!transport) {
 			try {
 				require.resolve('nodemailer');
-			} catch (e) {
+			} catch {
 				throw new Error(
 					'nodemailer is not installed, but it is required if Config.crashguardemail is configured! ' +
 					'Run npm install --no-save nodemailer and restart the server.'
@@ -65,7 +65,7 @@ export function crashlogger(
 		} else {
 			try {
 				transport = require('nodemailer').createTransport(Config.crashguardemail.options);
-			} catch (e) {
+			} catch {
 				throw new Error("Failed to start nodemailer; are you sure you've configured Config.crashguardemail correctly?");
 			}
 

lib/fs.ts

@@ -110,7 +110,7 @@ export class FSPath {
 	readIfExistsSync() {
 		try {
 			return fs.readFileSync(this.path, 'utf8');
-		} catch (err) {
+		} catch (err: any) {
 			if (err.code !== 'ENOENT') throw err;
 		}
 		return '';
@@ -342,7 +342,7 @@ export class FSPath {
 		if (global.Config?.nofswriting) return;
 		try {
 			fs.unlinkSync(this.path);
-		} catch (err) {
+		} catch (err: any) {
 			if (err.code !== 'ENOENT') throw err;
 		}
 	}
@@ -389,7 +389,7 @@ export class FSPath {
 		if (global.Config?.nofswriting) return;
 		try {
 			fs.mkdirSync(this.path, mode);
-		} catch (err) {
+		} catch (err: any) {
 			if (err.code !== 'EEXIST') throw err;
 		}
 	}
@@ -401,7 +401,7 @@ export class FSPath {
 	async mkdirp(mode: string | number = 0o755) {
 		try {
 			await this.mkdirIfNonexistent(mode);
-		} catch (err) {
+		} catch (err: any) {
 			if (err.code !== 'ENOENT') throw err;
 			await this.parentDir().mkdirp(mode);
 			await this.mkdirIfNonexistent(mode);
@@ -415,7 +415,7 @@ export class FSPath {
 	mkdirpSync(mode: string | number = 0o755) {
 		try {
 			this.mkdirIfNonexistentSync(mode);
-		} catch (err) {
+		} catch (err: any) {
 			if (err.code !== 'ENOENT') throw err;
 			this.parentDir().mkdirpSync(mode);
 			this.mkdirIfNonexistentSync(mode);

lib/process-manager.ts

@@ -144,10 +144,6 @@ export class QueryProcessWrapper<T, U> implements ProcessWrapper {
 			if (!resolve) throw new Error(`Invalid taskId ${message.slice(0, nlLoc)}`);
 			this.pendingTasks.delete(taskId);
 			const resp = this.safeJSON(message.slice(nlLoc + 1));
-			if (resp instanceof Error) {
-				// we'd fail here anyway if it crashed, so at least this way we can log it
-				return false;
-			}
 			resolve(resp);
 
 			if (this.resolveRelease && !this.getLoad()) this.destroy();
@@ -161,13 +157,13 @@ export class QueryProcessWrapper<T, U> implements ProcessWrapper {
 		}
 		try {
 			return JSON.parse(obj);
-		} catch (e) {
+		} catch (e: any) {
 			// this is in the parent, so it should usually exist, but it's possible
 			// it's also futureproofing in case other external modfules require this
 			// we also specifically do not throw here because this json might be sensitive,
 			// so we only want it to go to emails
 			global.Monitor?.crashlog?.(e, `a ${path.basename(this.file)} process`, {result: obj});
-			return new Error(e);
+			return undefined;
 		}
 	}
 
@@ -638,7 +634,7 @@ export class StreamProcessManager extends ProcessManager<StreamProcessWrapper> {
 				let value;
 				({value, done} = await stream.next());
 				process.send!(`${taskId}\nPUSH\n${value}`);
-			} catch (err) {
+			} catch (err: any) {
 				process.send!(`${taskId}\nTHROW\n${err.stack}`);
 			}
 		}
@@ -765,7 +761,7 @@ export class RawProcessManager extends ProcessManager<RawProcessWrapper> {
 				let value;
 				({value, done} = await stream.next());
 				process.send!(value);
-			} catch (err) {
+			} catch (err: any) {
 				process.send!(`THROW\n${err.stack}`);
 			}
 		}

lib/repl.ts

@@ -31,7 +31,7 @@ export const Repl = new class {
 			for (const s of Repl.socketPathnames) {
 				try {
 					fs.unlinkSync(s);
-				} catch (e) {}
+				} catch {}
 			}
 			if (code === 129 || code === 130) {
 				process.exitCode = 0;
@@ -48,7 +48,7 @@ export const Repl = new class {
 			let handler;
 			try {
 				handler = require('node-oom-heapdump')();
-			} catch (e) {
+			} catch (e: any) {
 				if (e.code !== 'MODULE_NOT_FOUND') throw e;
 				throw new Error(`node-oom-heapdump is not installed. Run \`npm install --no-save node-oom-heapdump\` and try again.`);
 			}
@@ -94,7 +94,7 @@ export const Repl = new class {
 				eval(cmd, context, unusedFilename, callback) {
 					try {
 						return callback(null, evalFunction(cmd));
-					} catch (e) {
+					} catch (e: any) {
 						return callback(e, undefined);
 					}
 				},

lib/sql.ts

@@ -51,7 +51,7 @@ type ErrorHandler = (error: Error, data: DatabaseQuery) => void;
 function getModule() {
 	try {
 		return require('better-sqlite3') as typeof sqlite.default;
-	} catch (e) {
+	} catch {
 		return null;
 	}
 }
@@ -143,7 +143,7 @@ export class SQLDatabaseManager extends QueryProcessManager<DatabaseQuery, any>
 					this.state.statements.set(query.data, this.database.prepare(query.data));
 					return query.data;
 				}
-			} catch (error) {
+			} catch (error: any) {
 				return this.onError(error, query);
 			}
 		});

lib/utils.ts

@@ -117,7 +117,7 @@ export function visualize(value: any, depth = 0): string {
 					stringValue !== `[object ${constructor}]`) {
 				return `${constructor}(${stringValue})`;
 			}
-		} catch (e) {}
+		} catch {}
 	}
 	let buf = '';
 	for (const key in value) {

logs/chat/README.md

@@ -1 +0,0 @@
-Logs of chat rooms are stored in this directory if `logchat` is enabled.

logs/logging.md

@@ -1,21 +0,0 @@
-Pokémon Showdown Logging
-========================================================================
-
-This is the Pokémon Showdown log directory.
-
-Pokémon Showdown will, by default, log rated battles in each format, but not unrated
-battles. To enable logging of unrated battles, turn on the config setting `logchallenges`.
-There is currently no config option to disable logs for rated battles.
-Battle logs are placed under a subdirectory for each month (e.g. `2013-02`).
-
-Moderator actions are logged in the subdirectory `modlog`.
-Each chat room has a separate log file (e.g. `modlog_lobby.txt`).
-Battle rooms share a single log file, which is named `modlog_battle.txt`.
-
-If the server or the simulator process crashes, a stack trace will
-usually be logged to `errors.txt`.
-
-By default, Pokémon Showdown does not log chat rooms. However, you can
-enable their logging by setting the `logchat` option in `config.js`.
-If you enable it, the logs are written in the subdirectory named `chat`.
-Each room gets their own subdirectory within, which are furthermore classified by month.

logs/modlog/README.md

@@ -1 +0,0 @@
-Logs of moderation actions are stored in this directory.

logs/repl/README.md

@@ -1,9 +0,0 @@
-# repl directory
-
-The REPL feature is enabled by default; it can be disabled in `config.js`.
-
-This directory is used by default to store the REPL sockets to all of showdown's processes.
-
-The intended uses of these REPL sockets are for debugging (especially when the server is seemingly frozen) and scripting.
-
-You can use any tool capable of talking to Unix sockets such as `nc`. e.g. `nc -U app`, replacing `app` with the name of any socket in this directory.

logs/tickets/README.md

@@ -1 +0,0 @@
-Logs of ticket stats are stored in this directory.

package.json

@@ -5,7 +5,6 @@
   "main": ".sim-dist/index.js",
   "dependencies": {
     "@swc/core": "^1.2.61",
-    "@types/better-sqlite3": "^5.4.0",
     "probe-image-size": "^5.0.0",
     "sockjs": "^0.3.21",
     "ts-node": "^10.0.0"
@@ -71,18 +70,19 @@
   ],
   "license": "MIT",
   "devDependencies": {
-    "@types/cloud-env": "^0.2.1",
-    "@types/node": "^14.14.6",
-    "@types/node-static": "^0.7.5",
-    "@types/nodemailer": "^6.4.0",
-    "@types/sockjs": "^0.3.32",
-    "@typescript-eslint/eslint-plugin": "^4.6.0",
-    "@typescript-eslint/parser": "^4.6.0",
-    "eslint": "^7.31.0",
+    "@types/better-sqlite3": "^7.4.0",
+    "@types/cloud-env": "^0.2.2",
+    "@types/node": "^14.17.12",
+    "@types/node-static": "^0.7.7",
+    "@types/nodemailer": "^6.4.4",
+    "@types/sockjs": "^0.3.33",
+    "@typescript-eslint/eslint-plugin": "^4.30.0",
+    "@typescript-eslint/parser": "^4.30.0",
+    "eslint": "^7.32.0",
     "eslint-plugin-import": "^2.22.1",
     "husky": "^4.3.0",
     "mocha": "^8.2.0",
     "smogon": "^1.4.5",
-    "typescript": "^4.1.0"
+    "typescript": "^4.4.2"
   }
 }

server/chat-commands/admin.ts

@@ -114,7 +114,7 @@ async function updateserver(context: Chat.CommandContext, codePath: string) {
 		}
 
 		return true;
-	} catch (e) {
+	} catch {
 		// failed while rebasing or popping the stash
 		await exec(`git reset --hard ${oldHash}`);
 		if (stashedChanges) await exec(`git stash pop`);
@@ -744,7 +744,7 @@ export const commands: Chat.ChatCommands = {
 			} else {
 				return this.errorReply("Your hot-patch command was unrecognized.");
 			}
-		} catch (e) {
+		} catch (e: any) {
 			Rooms.global.notifyRooms(
 				['development', 'staff'] as RoomID[],
 				`|c|${user.getIdentity()}|/log ${user.name} used /hotpatch ${target} - but something failed while trying to hot-patch.`
@@ -1259,7 +1259,7 @@ export const commands: Chat.ChatCommands = {
 				this.sendReply(`|html|${generateHTML('<', result)}`);
 			}
 			logRoom?.roomlog(`<< ${result}`);
-		} catch (e) {
+		} catch (e: any) {
 			const message = ('' + e.stack).replace(/\n *at CommandContext\.eval [\s\S]*/m, '');
 			const command = uhtmlId ? `|uhtmlchange|${uhtmlId}|` : '|html|';
 			this.sendReply(`${command}${generateHTML('<', message)}`);
@@ -1325,14 +1325,14 @@ export const commands: Chat.ChatCommands = {
 			// presume it's attempting to get data first
 			result = await database.all(query, []);
 			if ((result as any).err) parseError(result as any);
-		} catch (err) {
+		} catch (err: any) {
 			// it's not getting data, but it might still be a valid statement - try to run instead
 			if (err.stack?.includes(`Use run() instead`)) {
 				try {
 					result = await database.run(query, []);
 					if ((result as any).err) parseError(result as any);
 					result = Utils.visualize(result);
-				} catch (e) {
+				} catch (e: any) {
 					result = ('' + e.stack).replace(/\n *at CommandContext\.evalsql [\s\S]*/m, '');
 				}
 			} else {

server/chat-commands/info.ts

@@ -2475,7 +2475,7 @@ export const commands: Chat.ChatCommands = {
 		if (!/^(https?:\/\/)?(www\.)?(youtube\.com|youtu\.be)(\/|$)/i.test(link)) {
 			try {
 				dimensions = await Chat.fitImage(link);
-			} catch (e) {
+			} catch {
 				throw new Chat.ErrorMessage('Invalid link.');
 			}
 		}
@@ -2589,7 +2589,7 @@ export const commands: Chat.ChatCommands = {
 				const [width, height, resized] = await Chat.fitImage(link);
 				buf = Utils.html`<img src="${link}" width="${width}" height="${height}" />`;
 				if (resized) buf += Utils.html`<br /><a href="${link}" target="_blank">full-size image</a>`;
-			} catch (err) {
+			} catch {
 				return this.errorReply('Invalid image');
 			}
 		}
@@ -2636,7 +2636,7 @@ export const commands: Chat.ChatCommands = {
 		let rawResult;
 		try {
 			rawResult = await Net(`https://${Config.routes.root}/users/${target}.json`).get();
-		} catch (e) {
+		} catch (e: any) {
 			if (e.message.includes('Not found')) throw new Chat.ErrorMessage(`User '${target}' is unregistered.`);
 			throw new Chat.ErrorMessage(e.message);
 		}

server/chat-commands/moderation.ts

@@ -213,11 +213,14 @@ export const commands: Chat.ChatCommands = {
 			const userid = toID(toPromote);
 			if (!userid) return this.parse('/help roompromote');
 
-			const oldSymbol = room.auth.getDirect(userid);
+			// weird ts bug (?) - 7022
+			// it implicitly is 'any' because it has no annotation and is "is referenced directly or indirectly in its own initializer."
+			// dunno why this happens, but for now we can just cast over it.
+			const oldSymbol: GroupSymbol = room.auth.getDirect(userid);
 			let shouldPopup;
 			try {
 				shouldPopup = runPromote(user, room, userid, nextSymbol, toPromote, force);
-			} catch (err) {
+			} catch (err: any) {
 				if (err.name?.endsWith('ErrorMessage')) {
 					this.errorReply(err.message);
 					continue;

server/chat-plugins/battlesearch.ts

@@ -31,7 +31,7 @@ export async function runBattleSearch(userids: ID[], month: string, tierid: ID,
 	let files = [];
 	try {
 		files = await FS(pathString).readdir();
-	} catch (err) {
+	} catch (err: any) {
 		if (err.code === 'ENOENT') {
 			return results;
 		}
@@ -47,7 +47,7 @@ export async function runBattleSearch(userids: ID[], month: string, tierid: ID,
 		let output;
 		try {
 			output = await ProcessManager.exec(['rg', '-i', regexString, '--no-line-number', '-P', '-tjson', ...files]);
-		} catch (error) {
+		} catch {
 			return results;
 		}
 		for (const line of output.stdout.split('\n').reverse()) {

server/chat-plugins/calculator.ts

@@ -191,7 +191,7 @@ export const commands: Chat.ChatCommands = {
 				resultStr = `<strong>${result}</strong>`;
 			}
 			this.sendReplyBox(`${expression}<br />= ${resultStr}`);
-		} catch (e) {
+		} catch (e: any) {
 			this.sendReplyBox(
 				Utils.html`${expression}<br />= <span class="message-error"><strong>Invalid input:</strong> ${e.message}</span>`
 			);

server/chat-plugins/chat-monitor.ts

@@ -68,7 +68,7 @@ export const Filters = new class {
 			} else {
 				return new RegExp((isShortener ? `\\b${word}` : word), (isReplacement ? 'igu' : 'iu'));
 			}
-		} catch (e) {
+		} catch (e: any) {
 			throw new Chat.ErrorMessage(
 				e.message.startsWith('Invalid regular expression: ') ? e.message : `Invalid regular expression: /${word}/: ${e.message}`
 			);
@@ -153,7 +153,7 @@ export const Filters = new class {
 		let data;
 		try {
 			data = FS(LEGACY_MONITOR_FILE).readSync();
-		} catch (e) {
+		} catch (e: any) {
 			if (e.code !== 'ENOENT') throw e;
 		}
 		if (!data) return;

server/chat-plugins/chatlog.ts

@@ -66,7 +66,7 @@ export class LogReaderRoom {
 		try {
 			const listing = await FS(`logs/chat/${this.roomid}`).readdir();
 			return listing.filter(file => /^[0-9][0-9][0-9][0-9]-[0-9][0-9]$/.test(file));
-		} catch (err) {
+		} catch {
 			return [];
 		}
 	}
@@ -75,7 +75,7 @@ export class LogReaderRoom {
 		try {
 			const listing = await FS(`logs/chat/${this.roomid}/${month}`).readdir();
 			return listing.filter(file => file.endsWith(".txt")).map(file => file.slice(0, -4));
-		} catch (err) {
+		} catch {
 			return [];
 		}
 	}
@@ -212,7 +212,7 @@ export const LogReader = new class {
 				const days = (await FS(`logs/${month}/${tier}/`).readdir()).filter(this.isDay).sort();
 				firstDay = days[0];
 				break;
-			} catch (err) {}
+			} catch {}
 			months.shift();
 		}
 		if (!firstDay) return null;
@@ -225,7 +225,7 @@ export const LogReader = new class {
 				const days = (await FS(`logs/${month}/${tier}/`).readdir()).filter(this.isDay).sort();
 				lastDay = days[days.length - 1];
 				break;
-			} catch (err) {}
+			} catch {}
 			months.pop();
 		}
 		if (!lastDay) throw new Error(`getBattleLog month range search for ${tier}`);
@@ -242,7 +242,7 @@ export const LogReader = new class {
 				Utils.sortBy(battles, getBattleNum);
 
 				return [getBattleNum(battles[0]), getBattleNum(battles[battles.length - 1])];
-			} catch (err) {
+			} catch {
 				return null;
 			}
 		};
@@ -1085,7 +1085,7 @@ export class RipgrepLogSearcher extends Searcher {
 				cwd: `${__dirname}/../../`,
 			});
 			results = stdout.split(resultSep);
-		} catch (e) {
+		} catch (e: any) {
 			if (e.code !== 1 && !e.message.includes('stdout maxBuffer') && !e.message.includes('No such file or directory')) {
 				throw e; // 2 means an error in ripgrep
 			}
@@ -1230,7 +1230,7 @@ export class RipgrepLogSearcher extends Searcher {
 				const battleName = name.split('/').pop()!;
 				results.push(battleName.slice(0, -9));
 			}
-		} catch (e) {
+		} catch (e: any) {
 			if (e.code !== 1) throw e;
 		}
 		return results.filter(Boolean);
@@ -1268,7 +1268,7 @@ export const PM = new ProcessManager.QueryProcessManager<AnyObject, any>(module,
 			Monitor.slow(`[Slow chatlog query]: ${elapsedTime}ms: ${JSON.stringify(data)}`);
 		}
 		return result;
-	} catch (e) {
+	} catch (e: any) {
 		if (e.name?.endsWith('ErrorMessage')) {
 			return LogViewer.error(e.message);
 		}

server/chat-plugins/daily-spotlight.ts

@@ -11,7 +11,7 @@ export let spotlights: {[k: string]: {[k: string]: {image?: StoredImage, descrip
 
 try {
 	spotlights = JSON.parse(FS(SPOTLIGHT_FILE).readIfExistsSync() || "{}");
-} catch (e) {
+} catch (e: any) {
 	if (e.code !== 'MODULE_NOT_FOUND' && e.code !== 'ENOENT') throw e;
 }
 if (!spotlights || typeof spotlights !== 'object') spotlights = {};
@@ -50,7 +50,7 @@ export async function renderSpotlight(roomid: RoomID, key: string, index: number
 				const [width, height] = await Chat.fitImage(image, 150, 300);
 				imgHTML = `<td><img src="${image}" width="${width}" height="${height}" style="vertical-align:middle;"></td>`;
 				spotlights[roomid][key][index].image = [image, width, height];
-			} catch (err) {}
+			} catch {}
 		}
 	}
 
@@ -179,7 +179,7 @@ export const commands: Chat.ChatCommands = {
 			img = img.trim();
 			try {
 				[width, height] = await Chat.fitImage(img);
-			} catch (e) {
+			} catch {
 				return this.errorReply(`Invalid image url: ${img}`);
 			}
 		}

server/chat-plugins/hangman.ts

@@ -37,7 +37,7 @@ try {
 	if (save) {
 		FS(HANGMAN_FILE).writeUpdate(() => JSON.stringify(hangmanData));
 	}
-} catch (e) {}
+} catch {}
 
 const maxMistakes = 6;
 

server/chat-plugins/helptickets.ts

@@ -100,7 +100,7 @@ try {
 			tickets[t] = ticket;
 		}
 	}
-} catch (e) {
+} catch (e: any) {
 	if (e.code !== 'ENOENT') throw e;
 }
 
@@ -124,7 +124,7 @@ function writeStats(line: string) {
 	const month = Chat.toTimestamp(date).split(' ')[0].split('-', 2).join('-');
 	try {
 		FS(`logs/tickets/${month}.tsv`).appendSync(line + '\n');
-	} catch (e) {
+	} catch (e: any) {
 		if (e.code !== 'ENOENT') throw e;
 	}
 }
@@ -453,7 +453,7 @@ export class HelpTicket extends Rooms.RoomGame {
 				lines = await ProcessManager.exec([
 					`rg`, `${__dirname}/../../logs/tickets/${date ? `${date}.jsonl` : ''}`, ...args,
 				]);
-			} catch (e) {
+			} catch (e: any) {
 				if (e.message.includes('No such file or directory')) {
 					throw new Chat.ErrorMessage(`No ticket logs for that month.`);
 				}
@@ -766,7 +766,7 @@ export async function getOpponent(link: string, submitter: ID): Promise<string |
 			const body = await replayUrl.get();
 			const data = JSON.parse(body);
 			return data.p1id === submitter ? data.p1id : data.p2id;
-		} catch (e) {
+		} catch {
 			return null;
 		}
 	}
@@ -793,7 +793,7 @@ export async function getBattleLog(battle: string): Promise<BattleInfo | null> {
 				url: `https://${Config.routes.replays}/${battle}`,
 			};
 		}
-	} catch (e) {}
+	} catch {}
 	return null;
 }
 

server/chat-plugins/hosts.ts

@@ -256,7 +256,7 @@ export const commands: Chat.ChatCommands = {
 			let result;
 			try {
 				result = IPTools.checkRangeConflicts(range, IPTools.ranges, widen);
-			} catch (e) {
+			} catch (e: any) {
 				return this.errorReply(e.message);
 			}
 			if (typeof result === 'number') {

server/chat-plugins/mafia.ts

@@ -114,7 +114,7 @@ function readFile(path: string) {
 			return false;
 		}
 		return Object.assign(Object.create(null), JSON.parse(json));
-	} catch (e) {
+	} catch (e: any) {
 		if (e.code !== 'ENOENT') throw e;
 	}
 }

server/chat-plugins/net-filters.ts

@@ -34,7 +34,7 @@ interface TrainingLine {
 function modelExists() {
 	try {
 		require.resolve('brain.js');
-	} catch (e) {
+	} catch {
 		return false;
 	}
 	return true;
@@ -49,7 +49,7 @@ export class NeuralNetChecker {
 	constructor(path?: string) {
 		try {
 			this.model = new (require('brain.js').recurrent.LSTM)();
-		} catch (e) {
+		} catch {
 			this.model = null;
 		}
 		if (path) this.load(path);
@@ -109,7 +109,7 @@ export class NeuralNetChecker {
 		if (!this.model) return result;
 		try {
 			result = this.model.run(data);
-		} catch (e) {}
+		} catch {}
 		// usually means someone didn't train it, carry on
 		// acceptable to drop since training is very slow
 		return result;
@@ -178,7 +178,7 @@ export const PM = new QueryProcessManager<NetQuery, any>(module, async query =>
 		let response = '';
 		try {
 			response = net.run(data as string);
-		} catch (e) {} // uninitialized (usually means intializing, which can be slow) - drop it for now
+		} catch {} // uninitialized (usually means intializing, which can be slow) - drop it for now
 		return response;
 	case 'train':
 		return net.train(data as TrainingLine[], options?.iterations);
@@ -187,7 +187,7 @@ export const PM = new QueryProcessManager<NetQuery, any>(module, async query =>
 	case 'load':
 		try {
 			net.load(data as string);
-		} catch (e) {
+		} catch (e: any) {
 			return e.message;
 		}
 		return 'success';

server/chat-plugins/responder.ts

@@ -18,7 +18,7 @@ export let answererData: {[roomid: string]: PluginData} = {};
 
 try {
 	answererData = JSON.parse(FS(DATA_PATH).readSync());
-} catch (e) {}
+} catch {}
 
 /**
  * A message caught by the filter.

server/chat-plugins/the-studio.ts

@@ -82,7 +82,7 @@ export class LastFMInterface {
 					limit: 1, api_key: Config.lastfmkey, format: 'json',
 				},
 			});
-		} catch (e) {
+		} catch {
 			throw new Chat.ErrorMessage(`No scrobble data found.`);
 		}
 		const res = JSON.parse(raw);
@@ -108,7 +108,7 @@ export class LastFMInterface {
 			let videoIDs: string[] | undefined;
 			try {
 				videoIDs = await YouTube.searchVideo(trackName, 1);
-			} catch (e) {
+			} catch (e: any) {
 				throw new Chat.ErrorMessage(`Error while fetching video data: ${e.message}`);
 			}
 			if (!videoIDs?.length) {
@@ -158,7 +158,7 @@ export class LastFMInterface {
 		let raw;
 		try {
 			raw = await Net(API_ROOT).get({query});
-		} catch (e) {
+		} catch {
 			throw new Chat.ErrorMessage(`No track data found.`);
 		}
 		const req = JSON.parse(raw);
@@ -182,7 +182,7 @@ export class LastFMInterface {
 			let videoIDs: string[] | undefined;
 			try {
 				videoIDs = await YouTube.searchVideo(searchName, 1);
-			} catch (e) {
+			} catch (e: any) {
 				throw new Chat.ErrorMessage(`Error while fetching video data: ${e.message}`);
 			}
 			if (!videoIDs?.length) {

server/chat-plugins/thing-of-the-day.ts

@@ -394,7 +394,7 @@ class OtdHandler {
 			try {
 				const [width, height] = await Chat.fitImage(winner.image, 100, 100);
 				output += Utils.html `<td><img src="${winner.image}" width=${width} height=${height}></td>`;
-			} catch (err) {}
+			} catch {}
 		}
 		output += `<td style="text-align:right;margin:5px;">`;
 		if (winner.event) output += Utils.html `<b>Event:</b> ${winner.event}<br />`;

server/chat-plugins/trivia/database.ts

@@ -621,7 +621,7 @@ export class TriviaSQLiteDatabase implements TriviaDatabase {
 		try {
 			triviaData = JSON.parse(FS(this.legacyJSONPath).readIfExistsSync() || "{}");
 			if (!triviaData) throw new Error(`no JSON`);
-		} catch (e) {
+		} catch {
 			return;
 		}
 
@@ -704,7 +704,7 @@ export class TriviaSQLiteDatabase implements TriviaDatabase {
 		// move legacy JSON file
 		try {
 			await FS(this.legacyJSONPath).rename(this.legacyJSONPath + '.converted');
-		} catch (e) {}
+		} catch {}
 	}
 
 	private rowToQuestion(row: AnyObject): Promise<TriviaQuestion> {

server/chat-plugins/trivia/trivia.ts

@@ -168,7 +168,7 @@ function getMastermindGame(room: Room | null) {
 function getTriviaOrMastermindGame(room: Room | null) {
 	try {
 		return getMastermindGame(room);
-	} catch (e) {
+	} catch {
 		return getTriviaGame(room);
 	}
 }
@@ -1627,7 +1627,7 @@ const triviaCommands: Chat.ChatCommands = {
 			const mastermindRound = getMastermindGame(room).currentRound;
 			if (!mastermindRound) throw new Error;
 			game = mastermindRound;
-		} catch (e) {
+		} catch {
 			game = getTriviaGame(room);
 		}
 
@@ -2310,7 +2310,7 @@ const triviaCommands: Chat.ChatCommands = {
 		try {
 			await mergeAlts(user.id, altid);
 			return this.sendReply(`Your Trivia leaderboard score has been transferred to '${altid}'!`);
-		} catch (err) {
+		} catch (err: any) {
 			if (!err.message.includes('/trivia mergescore')) throw err;
 
 			await requestAltMerge(altid, user.id);

server/chat-plugins/username-prefixes.ts

@@ -28,7 +28,7 @@ export class PrefixManager {
 		let data: AnyObject;
 		try {
 			data = JSON.parse(FS(PREFIXES_FILE).readSync());
-		} catch (e) {
+		} catch (e: any) {
 			if (e.code !== 'ENOENT') throw e;
 			return;
 		}

server/chat-plugins/youtube.ts

@@ -170,7 +170,7 @@ export class YoutubeInterface {
 			raw = await Net(`${ROOT}videos`).get({
 				query: {part: 'snippet,statistics', id, key: Config.youtubeKey},
 			});
-		} catch (e) {
+		} catch (e: any) {
 			throw new Chat.ErrorMessage(`Failed to retrieve video data: ${e.message}.`);
 		}
 		const res = JSON.parse(raw);
@@ -336,7 +336,7 @@ export const Twitch = new class {
 				},
 				query: {query: channel},
 			});
-		} catch (e) {
+		} catch (e: any) {
 			throw new Chat.ErrorMessage(`Error retrieving twitch channel: ${e.message}`);
 		}
 		const data = JSON.parse(res);

server/chat.ts

@@ -451,7 +451,7 @@ export class PageContext extends MessageContext {
 		try {
 			if (typeof handler !== 'function') this.pageDoesNotExist();
 			res = await handler.call(this, parts, this.user, this.connection);
-		} catch (err) {
+		} catch (err: any) {
 			if (err.name?.endsWith('ErrorMessage')) {
 				if (err.message) this.errorReply(err.message);
 				return;
@@ -598,7 +598,7 @@ export class CommandContext extends MessageContext {
 
 				message = this.checkChat(message);
 			}
-		} catch (err) {
+		} catch (err: any) {
 			if (err.name?.endsWith('ErrorMessage')) {
 				this.errorReply(err.message);
 				this.update();
@@ -2094,7 +2094,7 @@ export const Chat = new class {
 		try {
 			// eslint-disable-next-line no-new
 			new RegExp(word);
-		} catch (e) {
+		} catch (e: any) {
 			throw new Chat.ErrorMessage(
 				e.message.startsWith('Invalid regular expression: ') ?
 					e.message :

server/config-loader.ts

@@ -32,7 +32,7 @@ export function load(invalidate = false) {
 	if (config.usesqlite) {
 		try {
 			require('better-sqlite3');
-		} catch (e) {
+		} catch {
 			throw new Error(`better-sqlite3 is not installed or could not be loaded, but Config.usesqlite is enabled.`);
 		}
 	}
@@ -149,7 +149,7 @@ export function checkRipgrepAvailability() {
 				await ProcessManager.exec(['rg', '--version'], {cwd: `${__dirname}/../`});
 				await ProcessManager.exec(['tac', '--version'], {cwd: `${__dirname}/../`});
 				return true;
-			} catch (error) {
+			} catch {
 				return false;
 			}
 		})();

server/friends.ts

@@ -99,7 +99,7 @@ export class FriendsDatabase {
 			let val;
 			try {
 				val = database.prepare(`SELECT val FROM database_settings WHERE name = 'version'`).get().val;
-			} catch (e) {}
+			} catch {}
 			const actualVersion = FS(`databases/migrations/friends`).readdirIfExistsSync().length;
 			if (val === undefined) {
 				// hasn't been set up before, write new version.
@@ -118,7 +118,7 @@ export class FriendsDatabase {
 		for (const k in ACTIONS) {
 			try {
 				statements[k] = database.prepare(ACTIONS[k as keyof typeof ACTIONS]);
-			} catch (e) {
+			} catch (e: any) {
 				throw new Error(`Friends DB statement crashed: ${ACTIONS[k as keyof typeof ACTIONS]} (${e.message})`);
 			}
 		}
@@ -383,7 +383,7 @@ export const PM = new ProcessManager.QueryProcessManager<DatabaseRequest, Databa
 			result.result = statements[statement].all(data);
 			break;
 		}
-	} catch (e) {
+	} catch (e: any) {
 		if (!e.name.endsWith('FailureMessage')) {
 			result.error = "Sorry! The database process crashed. We've been notified and will fix this.";
 			Monitor.crashlog(e, "A friends database process", query);

server/index.ts

@@ -80,7 +80,7 @@ function setupGlobals() {
 				// by battle prefixes manually specified in config.js
 				Chat.plugins['username-prefixes']?.prefixManager.refreshConfig(true);
 				Monitor.notice('Reloaded ../config/config.js');
-			} catch (e) {
+			} catch (e: any) {
 				Monitor.adminlog("Error reloading ../config/config.js: " + e.stack);
 			}
 		});
@@ -188,7 +188,7 @@ if (Config.startuphook) {
 if (Config.ofemain) {
 	try {
 		require.resolve('node-oom-heapdump');
-	} catch (e) {
+	} catch (e: any) {
 		if (e.code !== 'MODULE_NOT_FOUND') throw e; // should never happen
 		throw new Error(
 			'node-oom-heapdump is not installed, but it is a required dependency if Config.ofe is set to true! ' +

server/ip-tools.ts

@@ -624,7 +624,7 @@ export const IPTools = new class {
 					this.torProxyIps.add(ip);
 				}
 			}
-		} catch (e) {}
+		} catch {}
 	}
 };
 

server/ladders-local.ts

@@ -73,7 +73,7 @@ export class LadderStore {
 			// console.log('Ladders(' + this.formatid + ') loaded tsv: ' + JSON.stringify(this.ladder));
 			ladderCaches.set(this.formatid, (this.ladder = ladder));
 			return this.ladder;
-		} catch (err) {
+		} catch {
 			// console.log('Ladders(' + this.formatid + ') err loading tsv: ' + JSON.stringify(this.ladder));
 		}
 		ladderCaches.set(this.formatid, (this.ladder = []));
@@ -272,7 +272,7 @@ export class LadderStore {
 			);
 
 			room.update();
-		} catch (e) {
+		} catch (e: any) {
 			if (!room.battle) return [p1score, null, null];
 			room.addRaw(`There was an error calculating rating changes:`);
 			room.add(e.stack);

server/ladders.ts

@@ -65,7 +65,7 @@ class Ladder extends LadderStore {
 
 		try {
 			this.formatid = Dex.formats.validate(this.formatid);
-		} catch (e) {
+		} catch (e: any) {
 			connection.popup(`Your selected format is invalid:\n\n- ${e.message}`);
 			return null;
 		}

server/loginserver.ts

@@ -23,7 +23,7 @@ function parseJSON(json: string) {
 	const data: {error: string | null, json: any[] | null} = {error: null, json: null};
 	try {
 		data.json = JSON.parse(json);
-	} catch (err) {
+	} catch (err: any) {
 		data.error = err.message;
 	}
 	return data;
@@ -76,7 +76,7 @@ class LoginServerInstance {
 			}
 			this.openRequests--;
 			return [json.json!, null];
-		} catch (error) {
+		} catch (error: any) {
 			this.openRequests--;
 			return [null, error];
 		}
@@ -154,7 +154,7 @@ class LoginServerInstance {
 			}
 
 			this.requestEnd();
-		} catch (error) {
+		} catch (error: any) {
 			for (const resolve of resolvers) {
 				resolve([null, error]);
 			}

server/monitor.ts

@@ -75,15 +75,15 @@ export const Monitor = new class {
 	/*********************************************************
 	 * Logging
 	 *********************************************************/
-	crashlog(error: Error, source = 'The main process', details: AnyObject | null = null) {
-		if (!error) error = {} as any;
+	crashlog(err: any, source = 'The main process', details: AnyObject | null = null) {
+		const error = (err || {}) as Error;
 		if ((error.stack || '').startsWith('@!!@')) {
 			try {
 				const stack = (error.stack || '');
 				const nlIndex = stack.indexOf('\n');
 				[error.name, error.message, source, details] = JSON.parse(stack.slice(4, nlIndex));
 				error.stack = stack.slice(nlIndex + 1);
-			} catch (e) {}
+			} catch {}
 		}
 		const crashType = crashlogger(error, source, details);
 		Rooms.global.reportCrash(error, source);
@@ -349,7 +349,7 @@ export const Monitor = new class {
 
 			await this.sh(`git reset`, options);
 			await index.unlinkIfExists();
-		} catch (err) {}
+		} catch {}
 		return hash;
 	}
 };

server/room-battle.ts

@@ -753,7 +753,7 @@ export class RoomBattle extends RoomGames.RoomGame {
 				if (!this.room) return; // room deleted in the middle of simulation
 				this.receive(next.split('\n'));
 			}
-		} catch (err) {
+		} catch (err: any) {
 			// Disconnected processes are already crashlogged when they happen;
 			// also logging every battle room would overwhelm the crashlogger
 			if (err.message.includes('Process disconnected')) {
@@ -1379,7 +1379,7 @@ if (!PM.isParentProcess) {
 		global.__version.head = ('' + head).trim();
 		const origin = ('' + merge).trim();
 		if (origin !== global.__version.head) global.__version.origin = origin;
-	} catch (e) {}
+	} catch {}
 
 	if (Config.crashguard) {
 		// graceful crash - allow current battles to finish before restarting

server/roomlogs.ts

@@ -138,7 +138,7 @@ export class Roomlog {
 		try {
 			FS(link0).symlinkToSync(relpath); // intentionally a relative link
 			FS(link0).renameSync(basepath + 'today.txt');
-		} catch (e) {} // OS might not support symlinks or atomic rename
+		} catch {} // OS might not support symlinks or atomic rename
 		if (!Roomlogs.rollLogTimer) void Roomlogs.rollLogs();
 	}
 	add(message: string) {

server/rooms.ts

@@ -1163,7 +1163,7 @@ export class GlobalRoomState {
 		try {
 			this.settingsList = require('../config/chatrooms.json');
 			if (!Array.isArray(this.settingsList)) this.settingsList = [];
-		} catch (e) {} // file doesn't exist [yet]
+		} catch {} // file doesn't exist [yet]
 
 		if (!this.settingsList.length) {
 			this.settingsList = [{
@@ -1250,7 +1250,7 @@ export class GlobalRoomState {
 		let lastBattle;
 		try {
 			lastBattle = FS('logs/lastbattle.txt').readSync('utf8');
-		} catch (e) {}
+		} catch {}
 		this.lastBattle = Number(lastBattle) || 0;
 		this.lastWrittenBattle = this.lastBattle;
 	}

server/sockets.ts

@@ -75,7 +75,7 @@ export const Sockets = new class {
 				const cloudenv = (require as any)('cloud-env');
 				bindAddress = cloudenv.get('IP', bindAddress);
 				port = cloudenv.get('PORT', port);
-			} catch (e) {}
+			} catch {}
 		}
 		if (bindAddress !== undefined) {
 			Config.bindaddress = bindAddress;
@@ -293,13 +293,13 @@ export class ServerStream extends Streams.ObjectReadWriteStream<string> {
 				if (!fs.statSync(key).isFile()) throw new Error();
 				try {
 					key = fs.readFileSync(key);
-				} catch (e) {
+				} catch (e: any) {
 					crashlogger(
 						new Error(`Failed to read the configured SSL private key PEM file:\n${e.stack}`),
 						`Socket process ${process.pid}`
 					);
 				}
-			} catch (e) {
+			} catch {
 				console.warn('SSL private key config values will not support HTTPS server option values in the future. Please set it to use the absolute path of its PEM file.');
 				key = config.ssl.options.key;
 			}
@@ -310,13 +310,13 @@ export class ServerStream extends Streams.ObjectReadWriteStream<string> {
 				if (!fs.statSync(cert).isFile()) throw new Error();
 				try {
 					cert = fs.readFileSync(cert);
-				} catch (e) {
+				} catch (e: any) {
 					crashlogger(
 						new Error(`Failed to read the configured SSL certificate PEM file:\n${e.stack}`),
 						`Socket process ${process.pid}`
 					);
 				}
-			} catch (e) {
+			} catch (e: any) {
 				console.warn('SSL certificate config values will not support HTTPS server option values in the future. Please set it to use the absolute path of its PEM file.');
 				cert = config.ssl.options.cert;
 			}
@@ -325,7 +325,7 @@ export class ServerStream extends Streams.ObjectReadWriteStream<string> {
 				try {
 					// In case there are additional SSL config settings besides the key and cert...
 					this.serverSsl = https.createServer({...config.ssl.options, key, cert});
-				} catch (e) {
+				} catch (e: any) {
 					crashlogger(new Error(`The SSL settings are misconfigured:\n${e.stack}`), `Socket process ${process.pid}`);
 				}
 			}
@@ -370,7 +370,7 @@ export class ServerStream extends Streams.ObjectReadWriteStream<string> {
 
 			this.server.on('request', staticRequestHandler);
 			if (this.serverSsl) this.serverSsl.on('request', staticRequestHandler);
-		} catch (e) {
+		} catch (e: any) {
 			if (e.message === 'disablenodestatic') {
 				console.log('node-static is disabled');
 			} else {
@@ -396,7 +396,7 @@ export class ServerStream extends Streams.ObjectReadWriteStream<string> {
 			try {
 				const deflate = (require as any)('permessage-deflate').configure(config.wsdeflate);
 				options.faye_server_options = {extensions: [deflate]};
-			} catch (e) {
+			} catch {
 				crashlogger(
 					new Error("Dependency permessage-deflate is not installed or is otherwise unaccessable. No message compression will take place until server restart."),
 					"Sockets"
@@ -454,7 +454,7 @@ export class ServerStream extends Streams.ObjectReadWriteStream<string> {
 		for (const socket of this.sockets.values()) {
 			try {
 				socket.destroy();
-			} catch (e) {}
+			} catch {}
 		}
 		this.sockets.clear();
 		this.rooms.clear();
@@ -477,7 +477,7 @@ export class ServerStream extends Streams.ObjectReadWriteStream<string> {
 			// address from connection request headers.
 			try {
 				socket.destroy();
-			} catch (e) {}
+			} catch {}
 			return;
 		}
 
@@ -559,7 +559,7 @@ if (!PM.isParentProcess) {
 	if (Config.sockets) {
 		try {
 			require.resolve('node-oom-heapdump');
-		} catch (e) {
+		} catch (e: any) {
 			if (e.code !== 'MODULE_NOT_FOUND') throw e; // should never happen
 			throw new Error(
 				'node-oom-heapdump is not installed, but it is a required dependency if Config.ofesockets is set to true! ' +

server/tournaments/index.ts

@@ -211,7 +211,7 @@ export class Tournament extends Rooms.RoomGame {
 	setCustomRules(rules: string) {
 		try {
 			this.fullFormat = Dex.formats.validate(`${this.baseFormat}@@@${rules}`);
-		} catch (e) {
+		} catch (e: any) {
 			throw new Chat.ErrorMessage(`Custom rule error: ${e.message}`);
 		}
 

server/verifier.ts

@@ -21,7 +21,7 @@ export const PM = new QueryProcessManager<{data: string, signature: string}, boo
 	let success = false;
 	try {
 		success = verifier.verify(Config.loginserverpublickey, signature, 'hex');
-	} catch (e) {}
+	} catch {}
 
 	return success;
 });

sim/battle-stream.ts

@@ -63,7 +63,7 @@ export class BattleStream extends Streams.ObjectReadWriteStream<string> {
 		} else {
 			try {
 				this._writeLines(chunk);
-			} catch (err) {
+			} catch (err: any) {
 				this.pushError(err, true);
 				return;
 			}
@@ -202,7 +202,7 @@ export class BattleStream extends Streams.ObjectReadWriteStream<string> {
 					result = result.replace(/\n/g, '\n||');
 					battle.add('', '<<< ' + result);
 				}
-			} catch (e) {
+			} catch (e: any) {
 				battle.add('', '<<< error: ' + e.message);
 			}
 			break;

sim/dex-formats.ts

@@ -508,7 +508,7 @@ export class DexFormats {
 			if (!Array.isArray(customFormats)) {
 				throw new TypeError(`Exported property 'Formats' from "./config/custom-formats.ts" must be an array`);
 			}
-		} catch (e) {
+		} catch (e: any) {
 			if (e.code !== 'MODULE_NOT_FOUND' && e.code !== 'ENOENT') {
 				throw e;
 			}
@@ -595,7 +595,7 @@ export class DexFormats {
 				try {
 					name = this.validate(name);
 					isTrusted = true;
-				} catch (e) {}
+				} catch {}
 			}
 			const [newName, customRulesString] = name.split('@@@', 2);
 			name = newName.trim();

sim/dex.ts

@@ -283,8 +283,8 @@ export class ModdedDex {
 			shortDesc: '',
 		};
 		for (let i = this.gen; i < dexes['base'].gen; i++) {
-			const curDesc = entry[`gen${i}`]?.desc;
-			const curShortDesc = entry[`gen${i}`]?.shortDesc;
+			const curDesc = entry[`gen${i}` as keyof typeof entry]?.desc;
+			const curShortDesc = entry[`gen${i}` as keyof typeof entry]?.shortDesc;
 			if (!descs.desc && curDesc) {
 				descs.desc = curDesc;
 			}
@@ -405,7 +405,7 @@ export class ModdedDex {
 			for (const j in searchObj) {
 				const ld = Utils.levenshtein(cmpTarget, j, maxLd);
 				if (ld <= maxLd) {
-					const word = searchObj[j].name || searchObj[j].species || j;
+					const word = (searchObj[j] as DexTable<any>).name || (searchObj[j] as DexTable<any>).species || j;
 					const results = this.dataSearch(word, searchIn, word);
 					if (results) {
 						searchResults = results;
@@ -429,7 +429,7 @@ export class ModdedDex {
 				throw new TypeError(`${filePath}, if it exists, must export an object whose '${dataType}' property is an Object`);
 			}
 			return dataObject[dataType];
-		} catch (e) {
+		} catch (e: any) {
 			if (e.code !== 'MODULE_NOT_FOUND' && e.code !== 'ENOENT') {
 				throw e;
 			}

sim/teams.ts

@@ -549,7 +549,7 @@ export const Teams = new class Teams {
 					}
 				}
 				return team;
-			} catch (e) {}
+			} catch {}
 		}
 
 		const lines = buffer.split("\n");

sim/tools/runner.ts

@@ -220,7 +220,7 @@ class DualStream {
 		const test = this.test.battle.toJSON();
 		try {
 			assert.deepEqual(State.normalize(test), State.normalize(control));
-		} catch (err) {
+		} catch (err: any) {
 			if (this.debug) {
 				// NOTE: diffing these directly won't work because the key ordering isn't stable.
 				fs.writeFileSync('logs/control.json', JSON.stringify(control, null, 2));

test/main.js

@@ -43,7 +43,7 @@ require('./../lib/process-manager').ProcessManager.disabled = true;
 try {
 	const chatrooms = require('../config/chatrooms.json');
 	chatrooms.splice(0, chatrooms.length);
-} catch (e) {}
+} catch {}
 
 // Don't create a REPL
 require('../lib/repl').Repl.start = noop;

test/server/ladders.js

@@ -129,7 +129,7 @@ describe('Matchmaker', function () {
 					p2: {user: this.p1, team: this.s2.team},
 					rated: 1000,
 				});
-			} catch (e) {}
+			} catch {}
 			assert.equal(room, undefined);
 		});
 

tools/build-utils.js

@@ -113,7 +113,7 @@ function sucrase(src, out, opts, excludeDirs = []) {
 		if (!force && !needsSucrase(src, out) && src !== "./config") {
 			return false;
 		}
-	} catch (e) {}
+	} catch {}
 	const sucraseOptions = {
 		transforms: ["typescript", "imports"],
 		enableLegacyTypeScriptModuleInterop: true,
@@ -255,7 +255,7 @@ exports.transpile = (doForce, decl) => {
 exports.buildDecls = () => {
 	try {
 		child_process.execSync(`node ./node_modules/typescript/bin/tsc -p sim`, {stdio: 'inherit'});
-	} catch (e) {}
+	} catch {}
 	for (const file of fs.readdirSync(`./.sim-dist/lib/`)) {
 		fs.renameSync(`./.sim-dist/lib/${file}`, `./.lib-dist/${file}`);
 	}

tools/modlog/converter.ts

@@ -9,7 +9,7 @@ if (!global.Config) {
 	let hasSQLite = true;
 	try {
 		require.resolve('better-sqlite3');
-	} catch (e) {
+	} catch {
 		console.warn(`Warning: the modlog conversion script is running without a SQLite library.`);
 		hasSQLite = false;
 	}
@@ -394,7 +394,7 @@ export function modernizeLog(line: string, nextLine?: string): string | undefine
 		if (line.includes(oldAction)) {
 			try {
 				return prefix + modernizerTransformations[oldAction](line);
-			} catch (err) {
+			} catch (err: any) {
 				if (Config.nofswriting) throw err;
 				process.stderr.write(`${err.message}\n`);
 			}

tools/set-import/importer.ts

@@ -399,7 +399,7 @@ const SMOGON = {
 const getAnalysis = retrying(async (u: string) => {
 	try {
 		return smogon.Analyses.process(await request(u));
-	} catch (err) {
+	} catch (err: any) {
 		// Don't try HTTP errors that we've already retried
 		if (err.message.startsWith('HTTP')) {
 			return Promise.reject(err);
@@ -426,7 +426,7 @@ async function getAnalysesByFormat(pokemon: string, gen: GenerationNum) {
 		}
 
 		return analysesByFormat;
-	} catch (err) {
+	} catch {
 		error(`Unable to process analysis for ${pokemon} in generation ${gen}`);
 		return undefined;
 	}