Commit Graph

23714 Commits

Author SHA1 Message Date
Cathy J. Fitzpatrick
871ed33d78 Fix move choice validation properly
The previous implementation of move choice validation allowed various
checks to be bypassed with crafted /move commands. For example, it was
possible to use arbitrary moves while in the invincibiltiy phase of
two-turn moves:

  http://pokemonshowdown.com/replay/dev-customgamenoteampreview-205

This commit fixes the validation mecahnics.

Compared to the last attempt at this, this commit also properly
handles Hidden Power.
2013-06-10 20:05:38 -06:00
Cathy J. Fitzpatrick
e4b5c92a27 Revert "Fix move choice validation" for now
This reverts commit 59ae64f840.
2013-06-10 19:56:35 -06:00
Cathy J. Fitzpatrick
59ae64f840 Fix move choice validation
The previous implementation of move choice validation allowed various
checks to be bypassed with crafted /move commands. For example, it was
possible to use arbitrary moves while in the invincibiltiy phase of
two-turn moves:

  http://pokemonshowdown.com/replay/dev-customgamenoteampreview-205

This commit fixes the validation mecahnics.
2013-06-10 16:19:37 -06:00
Marty-D
5ad404001c Limit one of each move less repetitively. 2013-06-10 16:14:28 -04:00
Marty-D
743c85127c Fix Transform.
- Gen 5: User cannot Transform if it or the target is already
Transformed.
- Gens 2-4: User cannot Transform if the target is already Transformed.
- Gen 1: User can Transform in both situations.
2013-06-10 11:52:25 -04:00
Cathy J. Fitzpatrick
65fb12dddc Introduce appealurl config option 2013-06-10 00:38:29 -06:00
Marty-D
a5796b98c7 Correct references to Grip Claw's effect. 2013-06-09 18:26:52 -04:00
Cathy J. Fitzpatrick
2a98fd4bb2 Check for another SockJS bug 2013-06-09 02:32:40 -06:00
Marty-D
bb3d870db7 Fix Gastro Acid.
- Ability should be ignored, not replaced.
- Also the effect can be Baton Passed.
2013-06-08 20:08:00 -04:00
Cathy J. Fitzpatrick
3d69a9e9a6 Better check for user already banned/locked
I believe this should always be correct for banning, but may be wrong
in some obscure corner cases for locking.
2013-06-08 13:46:42 -06:00
Marty-D
bf5750a5f5 Gen V: Display Abilities swapped by Skill Swap. 2013-06-07 20:43:33 -04:00
Cathy J. Fitzpatrick
cee40172b3 Improve stale assertion error message 2013-06-07 18:35:31 -06:00
Marty-D
6d31c256b0 Fix a crash in /forcewin. 2013-06-07 15:01:29 -04:00
Marty-D
d85b966b51 Merge pull request #248 from moraesfire/master
Fixed /weakness type.id output
2013-06-07 08:06:07 -07:00
moraesfire
2dc6fe0530 Fixed /weakness types.id 2013-06-07 11:49:45 -03:00
Guangcong Luo
2df64c763b NEXT: More clarification on how signature Pokemon work 2013-06-07 06:32:06 -05:00
Guangcong Luo
0b708bcd05 NEXT: No need for weird spacing in README anymore
(The weird spacing was previously there to work around a GitHub
markdown rendering bug, but they appear to have fixed it now.)
2013-06-07 06:32:06 -05:00
Cathy J. Fitzpatrick
dad06ad7f3 Send |unlink| message when banning user 2013-06-07 01:39:39 -06:00
Guangcong Luo
f762f34385 Suppress a crash when a user leaves during a switch 2013-06-06 18:41:23 -05:00
Marty-D
8972920d99 Gen III: Fix up formats-data. 2013-06-06 09:34:19 -04:00
Guangcong Luo
0901a8e7ee Merge pull request #247 from moraesfire/master
Added /weak command
2013-06-05 21:01:38 -07:00
moraesfire
d8f2afbfe8 Added /weakness command 2013-06-06 00:48:48 -03:00
Guangcong Luo
43ac9728f4 Tweak phrasing 'due to inactivity' 2013-06-05 15:10:28 -07:00
Marty-D
81ad4f97ac Gen III: Preliminary status fixes. 2013-06-05 13:01:16 -04:00
Cathy J. Fitzpatrick
f0d9c4a92d International-friendly anti-spam function 2013-06-05 04:59:04 -06:00
Cathy J. Fitzpatrick
8878269ff5 Basic anti-spam function only applies to the lobby 2013-06-04 22:19:17 -06:00
Cathy J. Fitzpatrick
fc5aadebb6 Implement basic anti-spamming mechanism 2013-06-04 20:51:17 -06:00
Guangcong Luo
4b2f3c8e40 Fix bug in muting? 2013-06-04 15:08:12 -07:00
Guangcong Luo
eee2c02da9 Merge pull request #244 from Joimer/patch-21
Update /help command
2013-06-04 11:41:43 -07:00
Joim
e5d22736aa Update /help command
Show /forcerenameto only on ~ now that it has its own permission not given to leaders by default.
Fix small bug on /help forcetie, which had === instead of = so matched was not found.
2013-06-04 15:26:08 +02:00
Cathy J. Fitzpatrick
25a04b0a73 Remove modchat registered 2013-06-04 00:53:56 -06:00
Guangcong Luo
f527634692 Suppress an error for a weird race condition 2013-06-03 18:39:05 -05:00
Guangcong Luo
0fae404d57 Merge pull request #241 from Joimer/patch-20
Update /help command
2013-06-03 16:38:08 -07:00
The Immortal
2993b14e27 Remove Pain Split from Swalot 2013-06-04 01:31:45 +04:00
The Immortal
cbf9f36d65 Correct "Swift Swift" mistake 2013-06-04 01:31:00 +04:00
Guangcong Luo
d362b6e4c3 Merge pull request #243 from Joimer/junejubilee
Improvements to June Jubilee
2013-06-03 11:20:04 -07:00
Joimer
cc0efcbc47 June Jubilee: Add Hariyama and Aggron to the Pokémon pool
Added Hariyama with Surf and Aggron with Surf to the list of summer Pokémon to June Jubilee as per player request.
2013-06-03 15:15:09 +02:00
Joimer
b2fb0dc62c June Jubilee: Better message for North Dakota
Since weather can be controlled by players, the message upon clear skies North Dakota is now re-worded so it always makes sense.
2013-06-03 15:12:06 +02:00
Joimer
3e534b1281 June Jubilee: Add Sleep Clause
Added Sleep Clause to June Jubilee as apparently it's abused commonly.
2013-06-03 15:10:49 +02:00
Guangcong Luo
8310735825 Every room should have logEntry 2013-06-03 01:26:38 -07:00
Cathy J. Fitzpatrick
bce493ad28 Fix two typos in config-example.js 2013-06-03 02:06:06 -06:00
Cathy J. Fitzpatrick
2959315811 Update proxyip documentation 2013-06-03 02:04:18 -06:00
Guangcong Luo
741e259218 Merge pull request #242 from brehvgc/patch-1
Update learnsets.js
2013-06-02 21:06:54 -07:00
brehvgc
e01d682339 Update learnsets.js
Nosepass cannot legally learn Head Smash
2013-06-02 21:49:40 -06:00
Guangcong Luo
8c47c9856b Fix crash when muting 2013-06-02 20:23:49 -05:00
Cathy J. Fitzpatrick
0d828d5e1a Fix proxyip code 2013-06-02 18:17:53 -06:00
Cathy J. Fitzpatrick
a3b7850dc6 Fix a proxyip bug 2013-06-02 17:16:04 -05:00
Cathy J. Fitzpatrick
5174e0d939 More sophisticated proxyip feature 2013-06-02 16:10:42 -06:00
Cathy J. Fitzpatrick
8da626cbc8 Specify correct sockjs_url 2013-06-02 15:40:18 -06:00
Cathy J. Fitzpatrick
ee0cf88f7c Revert "Correct turn order mechanics"
This reverts commit c21674c835.
2013-06-02 15:15:54 -06:00