such as Lucario. Instead of always setting `setupType` to `Special` for
those cases, it now sets it to the one with the most attacks (or random
if it’s equal).
Also, added another check to fix the issue of too many Dark type
attacks on a Pokemon.
- Fixed Stealth Rock (and Defog/Spin, which isn’t as big of a problem)
being on multiple Pokemon
- Reject Snow Cloak without Snow Warning on the team
- Reject Swift Swim without Drizzle/Rain Dance on the team
- Give Mega Venuasaur Chlorophyll as a starting ability (because
Overgrow is useless)
- Give RestTalk Pokemon Leftovers (so they don’t get Focus Sash if they
are the lead)
This fixes a problem introduced by 77b6b666 causing certain Pokemon
with mega stones (and base forme of Audino) to have level 90 in
randbats.
This commit intentionally doesn't introduce any new levels for mons who
have their tier in parenthesis. Looking over the list of mons who don't
have hardcoded levels, most of them are barely improvement over their
base forme, which is the issue in a standard tiers with its limit of
one mega. However, because teams don't have to use a mega in randbats
(because of how its generator works), getting just a slightly version
of a Pokemon is not a big deal as it's still an improvement, even if
minor.
Mold Breaker is rated high but Basculin always prefer Adaptability. Add
Safeguard as an alternative to Destiny Bond for Wobbuffet (but prevent
both on the same set), and Sitrus Berry as an alternative to Leftovers.
Prevent Counter, Metal Burst and Mirror Coat from being rejected. They
only apply to Bastiodon, Chansey and Wobbuffet, who don’t care about
STAB.
Life Orb is selected unless the Speed Boost user has Substitute (in
which case Leftovers is selected later on). Also moved the Speed Boost
check above the Choice checks so that they don’t have to check for
Speed Boost.
The full description is in the comments of the Endless Battle
Clause entry in rulesets.js.
This update fixes a lot of the issues with yesterday's version.
Also included: A minor refactor of deductPP, which did not need
a success variable.
Rainbow Road is a Mario Kart and color themed seasonal.
Every few turns, a player can get an item that changes the course of the
battle, such as a Mushroom to increase speed.
Pokemon also get color moves that are super-effective on certain other
colors.
- Reject Sunny Day if the Pokemon lacks an ability that benefits, and
lacks SolarBeam
- Add Dark Pulse to Pyroar to fix the issue raised in #2063
- Reordered the Status cases to weather/status/recovery/other instead
of just alphabetical
Implement new function getMoveTargets to list all move targets given a
user and a move. Refactor Battle system to remove redundancies with
checking move targets. Run the RedirectTarget in this function instead of
later after TryMove, since technically single-target moves changing
targets should occur before the move is attempted.
Refactor the DeductPP event to be a singleEvent that targets the Pokemon's
ability instead of a global event. Run this event on the move's targets as
calculated by BattlePokemon#getMoveTargets.
Add a new event ModifyAccuracy that affects all moves other than OHKO
moves and switched many event handlers that originally used the Accuracy
event to ModifyAccuracy instead.
- On failure, they will no longer trigger the `AfterMoveSecondarySelf` event. It was a common pattern to check for success on its handlers, so this removes some duplication.
- All failed moves will now run any set `MoveFail` single events.
- Life Orb will now harm the holder if a successful attack did 0 damage (e.g. False Swipe on a 1 HP target).
Added BattlePokemon#isGrounded to check for the grounded-ness of a
Pokemon. Also BattlePokemon#isSemiInvulnerable for whether a Pokemon is
in the first turn of a two-turn move that makes them semi-invulnerable.
Fixed Terrain bugs involving Pokemon in a semi-invulnerable state.
Changed OHKO move check to use BattlePokemon#isSemiInvulnerable, fixing a
graphical bug that would display an immunity message when a Pokemon
attempted an OHKO move on a higher-leveled Pokemon that was being held by
the effect of Sky Drop.
Fixed Misty Terrain bug that was causing Rest and the effect of Yawn to
put Pokemon to sleep.
Fixed Misty Terrain bug that was causing Yawn to fail.
Fixed Electric Terrain bug that was causing Yawn to succeed.
Instead of having a hardcode in scripts.js that people needed to
reference, it seemed more intuitive to take advantage of the Damage
event instead, and have Rock Head negate damage within the event.
Fixed a bug in Gen-NEXT Rock Head exhibiting the same behavior that
was causing the original Rock Head + Mummy glitch.
- Removed Trick/Gyro Ball checks as no Pokemon uses that combination.
- Reject Life Orb on Pokemon with 55 or less base Speed.
- Add a check for slow and strong Regenerator Pokemon to receive Assault
Vest, at slightly higher priority than Sitrus Berry.
- Reject teams significatively weak to a single attack type.
- Improve rejection of multiple megas.
- Reject weather-based abilities without their associated weather.
In place of Challenge Cup 1v1. Challenge Cup 1v1 under the new Challenge
Cup rules (f73ea6a0ea) isn't a good
format. It's supposed to have some competitive element in that you can
make predictions on what an opponent might have to beat your "best"
choice and as a result you can counter-pick. But with the new Challenge
Cup, that goes out the window.
This adds a slightly updated version of the old CC generator.
- CC now follows Hackmons mechanics to differentiate it from Random
further (in other words, CC is now Hackmons CC)
- Took this opportunity to finally rename CC 1v1
- Commented out Gen 1 CC
- Sheer Force may not be user's Ability by the time `AfterMoveSecondary`
effects are checked
- Sheer Force boosted moves called by other moves now ignore
`AfterMoveSecondary` effects properly
This was implemented exactly the wrong way and showed fail messages
in a lot of situations they shouldn't show up, such as when
Close Combat's Def/SpD drops didn't happen.
This reverts commit 1edc40f936.
- Promoted Acedia and Audiosurfer.
- Fixed one of Diatom's ranks.
- Moved shaymin's and MattL's moves to the correct areas, as well as
Acedia's and Audiosurfer's.
STAB Hidden Power without the Pokemon's other STAB can be bad. Since
there's no real way to check if the Pokemon has the other STAB with the
current system, it's better to remove that check.
Reject Hidden Power with Special setup and 2 Special moves if:
- It is not STAB
- It is not part of a Ghost/Fighting combination
- It is not part of an Electric/Ice combination
- It is not being used by Lilligant, which needs it for coverage
This will help reduce repetition, and also will allow for the move
tracking to easily update after the final moveset modification
(for example, allowing Choice Band/Scarf Mega Rayquaza if its last
Status move was overwritten by Dragon Ascent).
Ninetales and Politoed are kept because weather is banned in UU (and
below) so they are PU as a result. However, weather is in Random Battle
so they are lowered to RU level. The same applies to Wobbuffet and
Shadow Tag.
While move.affectedByImmunities was always a Boolean value to denote if
the move was affected by immunities, move.ignoreImmunity can be a Boolean
value if it ignores or is affected by all type immunities, but also can
act as an object such that !!move.ignoreImmunity[type] means it ignores
immunities of that type.
Reject Hydro Pump with Waterfall (affects Samurott and Kingdra).
Reduce the number of moves available to Porygon2 so it has a higher chance
of getting Recover.
Added `%QuoteCS`'s Pokémon, move, and entering/dying phrases (I
talked with him on PS! for info on what he wanted).
Fixed casing on `%Birkal`, `%DTC`, and `%raseri`.
Moved `@rekeri`'s and `@Timbuktu`'s moves to the correct places.
The Doubles EV generator means it's more beneficial to give Huntail all
Physical moves (252 Atk Ice Fang outdamages 0 SpA Ice Beam, for example)
Remove Icy Wind/HP-Ice redundancy check because Keldeo no longer has
Hidden Power Ice on its random battle sets.
fixed casing on astara, bean, barton, and haunter
fixed `@Timbuktu`'s rank and added custom messages
added MattL and shaymin to voices since they 'retired/resigned'
Single Battle: Replace Rock Climb with Return if Tauros does not have
Sheer Force (1/3 chance of getting Intimidate)
Double Battle: Remove Rock Climb for Return and add Stone Edge, since
Tauros always has Intimidate in Random Double Battles
TryPrimaryHit, originally created for Substitute, is currently
being used for Substitute, gems, and auras. Neither of these
should affect all, foeSide, and allySide moves, so the event no
longer fires in these cases.
Included: Bonus: unit test for Substitute not blocking Stealth Rock
Disregard puny OM of the Month thing. That's for losers anyway.
From now on, the strongest and best OM is going to be added as the OM of the Decaed.
It will only be changed when a strongest OM appears and beats it off.
Right now, with no contender really, that OM is Final Destination. Any other OMs just pale in comparison.
If Ambipom doesn't have any Technician moves, give it Pickup instead of
Skill Link because Skill Link is useless on it and it might as well have
a slight chance of recovering an item if its item is Knocked Off.
With the EV generation policy in place for Doubles, it is detrimental
for Pokemon to run mixed sets, so some physical moves were removed
from Charizard and Dewgong.
Added Double-Edge to standard Pidgeot to give it extra damage output.
Reject Unburden on super-fast Pokemon (Accelgor) in Doubles like it is in
Singles.
Reject Wood Hammer with Giga Drain (Abomasnow)
In Generation 4, Simple did not double stat boosts as they changed.
Instead, it treated each stat boost as if it had twice the effect.
Reimplemented the deprecated ModifyBoost event, but with slightly
different functionality as before; it now modifies the live boosts so that
they work properly with Simple.
- Remove Sucker Punch from Hitmonlee as it gets Unburden majority of the
time (100% actually, according to usage stats) and already has Knock Off
- Remove old check specific to Breloom
- Fix Breloom getting Poison Heal when it wants Technician
- Sorted checks
- Removed old and unused checks
- Added new checks and updated several current ones
Moves:
- Moved some cases to be in the appropriate section
Abilities:
- Fixed a Pokemon's third ability never being used if it has the same
rating as `ability1` (example: Iron Fist has 0% usage on Conkeldurr
because it is rated the same as Guts)
Items:
- Reordered the checks / changed priority of items
- Update Eevee General's moves
- Add Shame That
- Slightly nerf Dell by removing the accuracy boost, which means he
actually has some risk with Jump Kick
Fix a typo in bloobblob's faint sentence.
chaos's move should not be bounceable.
Update Goddess Briyella's move: change name and animation.
Update Beowulf's moveset, make Spiky Shield mandatory.
Update Legitimate Username's moveset.
Update Queez, he's now a moderator.
This Seasonal is a joined effort of the whole staff team.
It contains over 100 custom sets and moves, allowing users to play the whole month and still find new things.
For format editing purposes, let it be noted that the Seasonal starts on line 348 and ends on line 3211 on formats.js as of this commit.
While I'm making the final commit to the master repository, let it be noted that this huge code is a joined effort of some members of the staff.
Special thanks to people who have worked on this code, without whose contributions this Seasonal couldn't have been finished for this month:
@ascriptmaster @cadaeic @Slayer95 @TheImmortal @xfix
More information for this special format can be found here:
http://www.smogon.com/forums/threads/3491902/page-6#post-6093168
- Removed it from Pokemon that are too weak to use it.
- Reject Feint with Fake Out (for Persian).
- Update move checking to not count single hit moves with 30 base power as
damaging moves.
Added a new variable hasAbility that keeps track of all available
abilities on a Pokemon, reducing the verbosity of ability checks
within the move rejection stage of the algorithm.
Also, change the Solarbeam check to look for Drought directly.
- Previously, a Pokemon unable to execute Pursuit against a slower
target would attempt to execute Pursuit again should its target switch
out with U-turn, Volt Switch, or Parting Shot, which would run two sleep
checks, freeze checks, etc.
- Accept Baton Pass with Wish, speed setup, Pokemon with Speed Boost.
- Removed Baton Pass from Glaceon in favor if Wish and Protect.
- Removed Agility from Emolga since it doesn't need it; added Encore.
- Try to improve Spiritomb by giving it Calm Mind as an option
- Prevent Shadow Sneak with RestTalk
- Prevent Storm Throw with Circle Throw in some cases
- Reject Rest if the Pokemon does not have Sleep Talk but has it in its
move pool (Pokemon with RestTalk are designed to use both and not just
Rest)
- Combine setup checks and allow a single attack with setup only if the
Pokemon has RestTalk
Just like the recent change to make Protean count all moves as STAB, do
the same with -ate abilities and Normal moves.
Manually include Nature Power as a damaging move since it becomes Tri
Attack. Its placement lets it automatically increment the -ate counter as
well.
- Do not count Fake Out as STAB because it can only be used once per
switch-in
- Protean means the Pokemon always has STAB and shouldn't get any move
removed in post-processing
- Prevent too many Dark-type moves
It currently gets Leftovers if it has Stealth Rock, and has a chance of
getting Expert Belt as well, but it should never get any other item. It
is a special case because there isn't a glass cannon as extreme as this.
It is not acceptable as the only STAB move because it is a 40 base power
Normal-type attack... No Normal-type Technician gets it either, unlike
other priority moves.
It's used on defensive Pokemon that shouldn't get Life Orb, Choice or
Expert Belt. Also removed checks that where added because of the old
Weakness Policy selection.
The previous one doesn't apply to Dragonite or Lugia. This prevents
Focus Sash Lugia if it is your first Pokemon.
Also moved the low priority Black Sludge selection above Leftovers for
the case of Poison/Flying Pokemon.
- Reject Trick/Switcheroo with Acrobatics so that the Pokemon can properly
receive Flying Gem
- Reject Rapid Spin with setup
- Do not reject Knock Off with setup
Mostly Gen 1-2 Pokemon were changed.
Added Moonblast where the usage stats were indicating that it was as
commonly used than Dazzling Gleam in Doubles. Reject Moonblast with
Dazzling Gleam.
Reject Return with Double Hit (for Ambipom).
Reject Power Split with Guard Split (for Shuckle).
Reject Acid Spray with Sludge Bomb (for Tentacruel).
Pokemon with Focus Energy have Scope Lens.
Aeroblast is now considered STAB.
- Reject Body Slam instead of Glare (so Dunsparce has a higher chance of
getting Glare + Headbutt rather than Body Slam + Headbutt)
- Reject Substitute with Taunt
- Update moves that are unacceptable as the only attacking move
- STAB is required for almost every mono-attacking case, exception is
that Fairy is allowed for Psychic types and Ice is allowed for certain
Normal types
- Always give Sylveon Hyper Voice
The current variables in place to check for STAB do not work as intended.
If a Pokemon has two STAB moves of the same type, and one of them is set
as a move that shouldn't be counted as STAB, the Pokemon will be counted
as not having STAB. Since nothing in the code checks for Pokemon having
STAB of a specific type, it is refactored to be a boolean instead.
In order to avoid a situation where a move like Infestation sets the STAB
variable to true when it doesn't count as a damaging move, these kinds of
moves no longer increment counters for abilities that boost damage, like
Adaptability.
- Force Super Luck on Unfezant (it has a 33% chance of getting Big Pecks)
- Force Scope Lens on Unfezants with enough attacking moves
- Give Unfezant Night Slash
- Replace Wish with Roost in Doubles
- Reject Water Spout and Eruption with setup or RestTalk
- Allow Origin Pulse with RestTalk
- Give Extremespeed users and Sucker Punch users without STAB Life Orb
instead of Expert Belt
- Prevent Life Orb with Dragon Tail
- Low priority: give Leftovers to Pokemon weak to Stealth Rock
Super Luck + Scope Lens gives a 50% chance of crit, but isn't a very high
priority since a consistent damage boost from a Choice item can be a
better pick.
- Lumineon and Poliwrath have Storm Drain and Water Absorb respectively,
which is always chosen over Swift Swim, so Rain Dance is unneccessary.
- Give Pokemon with Unburden a Focus Sash
- Give Unburden mons with stat-lowering moves a White Herb (specifically
targets Sceptile)
- Added speedsetup counter
- Improve Weakness Policy selection (might give it to more than just
speedsetup later on but this is much better than the previous
implementation that gave it to very bad sets)
- Added Lustrous Orb as a low priority option for Palkia
- Slightly increased defensive requirement of Assault Vest
- 30% more op/s for randomTeam, randomDoublesTeam and randomCCTeam
- 300% more op/s for randomHackmonsCCTeam
- Implement helper method `sampleNoReplace`: takes an array parameter, removes a random element and returns it.
- Random team makers now follow the game RNG. Therefore, it's now possible to reconstruct the teambuilding process for bad sets, given that the starting seed is known.
Went through all fully-evolved Pokemon and updated their moves. Also
removed illegal moves on several Pokemon...
- Added Superpower to SetupException
- Reject Water Pulse with Scald
- Reject Acrobatics with Hurricane
- Prevent Focus Blast and Superpower together
- Reject Physical moves with Acid Spray (only affects Eelektross)
- Do not reject Baton Pass with Protect
- Reject Healing Wish with setup
- Reject Hydro Pump with RestTalk
- Prevent Precipice Blades with Earthquake
- In accepting Shadow Ball + HP Fighting, ensure that it's HP Fighting
(relevant for Reuniclus, Chandelure, and Sylveon, which have Hidden
Power that aren't Fighting)
- If Hidden Power changes the IVs but is later removed by another
processing cycle, reset the IVs to 31 all
- Removed old check for "bulky" Pokemon as it would give Leftovers to
Pokemon that would prefer Life Orb or even Assault Vest. For example,
Kyurem-White and Goodra, respectively.
- If the Pokemon has three attacking moves, give Life Orb to those with
either setup or a recovery move, and give Leftovers to everything else.
- Give Keldeo HP Flying instead of HP Ghost
- Reject Hidden Power if the Pokemon has a special setup move and only
one other special attack
- Dark/Fighting is resisted by Fairy this generation and isn't a
"perfect" combination anymore
- Remove Feint from Pikachu/Raichu
- Replace Rock Blast with Rock Slide on Golem line
- Add Surf to Octillery
- Reject Strong Jaw without bite moves
- Update Iron Fist check to use the punch flag
- Give preference to Rock Slide over Head Smash
- Give preference to Discharge over Thunderbolt and Electroweb
- Modify Tyrantrum's moves
- Add bite moves counter for Strong Jaw
- Use punch flag for ironfist counter
- Give preference to Stone Edge over Head Smash
Mechanics Changes:
- Fire Rocket does less damage, cannot crit.
- Fire Rocket is no longer a bullet move (for Chesnaught)
- Only Li Shang can Train Recruits.
- Recruits start with lowered defenses as well.
- Edit Mushu's movepool.
Flavor Changes:
- Train Recruits now uses Bulk Up's animation.
- Fire Rocket now uses Eruption's animation. Backfires cause the animation
to strike the user instead!
- Use Searing Shot as Fire Rocket instead of Octazooka.
Unaware currently doesn't work because the ModifyMove event is fired on the move before each target is caculated in doubles and triples.
This means that the ModifyMove event should be fired for each target and the move not modified unless it fits the attacker-target.
It's easier and less expensive to use an ability property to check on attacker/target than to fire events.
This fixes Unaware in doubles/triples.
It takes account interaction with Mold Breaker, Gastro Acid, and other ability supressers.
Seasonal is based on Mulan, in honor of Chinese New Year.
General Shang must defeat the Huns, but his new recruits are weak! Over
time, however, they will get stronger over time by training (just like the
movie, they train during I'll Make A Man Out Of You.) Singing will also
make them train faster.
The Han Chinese also have powerful rockets at their disposal (select
Octazooka in battle). However, the rockets sometimes backfire on new
recruits, but as they train the chance of backfire goes down.
