onBasePower events now affect the base power modifier as opposed to the
base power directly. Also some moves had their base power changes moved
from basePowerCallback to onBasePower. These moves affect the modifier
and not the base power.
Note: The effects of weather and burn are still incorrectly applied as
base power modifiers
10: Figure out a way to apply these directly to the stat later
...
6: Target Ability
5: User Ability
4: Target's Ally Abilities
3: User's Ally Abilities
2: Target's Item
1: User's Item
To be honest it's mostly for posterity's sake as well as to match the
soon-to-be-corrected base power modifiers. At the moment all stat
modifiers are either *1.5 or *2 which have the same result no matter
which order you chain them in. However a mod or ability/item in the
future could add a value that isn't as clean.
Water-type moves should not fail against Storm Draim Pokémon.
Test, Gastrodon + Qwilfish, turn 2 switching the first to Escavalier:
Storm drain is making Hydro Pump accuracy true
Storm drain is making Hydro Pump accuracy true
Storm drain is making Hydro Pump accuracy true
Storm drain is making Hydro Pump accuracy true
Accuracy for Recover: true
Accuracy for Recover: true
Accuracy for Hydro Pump: 80
Accuracy for Hydro Pump: 80
No Fire-type move should fail against Flash Fire Pokémon.
Test on two turns:
Flash fire is making Will-O-Wisp accuracy to true.
Flash fire is making Will-O-Wisp accuracy to true.
Accuracy for Earth Power: 100
Accuracy for Earth Power: 100
Accuracy for Will-O-Wisp: 75
Accuracy for Will-O-Wisp: 75
Accuracy for Substitute: true
Accuracy for Substitute: true
- Gen 5: User cannot Transform if it or the target is already
Transformed.
- Gens 2-4: User cannot Transform if the target is already Transformed.
- Gen 1: User can Transform in both situations.
Now, those abilities will not report their activation if the stat drop would have been caused by a secondary effect.
They will also only report their activation once, even if multiple stats would have been lowered.
Specifically, formes that normally require a specific condition,
such as Darmanitan-Z and Arceus-Fire, are now available in Hackmons.
The previous confusion stemmed from that Arceus-Fire is actually
Normal-type, and the Arceus forme is handled separately from
Multitype and plates, which is what actually gives it the Fire
typing.
This doesn't yet handle modded formats that don't validate ability
selection in the ordinary manner. Those formats will continue to work
essentially in the same manner as before, rather than with the correct
mechanics.
Specifically, the TryFieldHit event no longer exists.
Instead, Magic Bounce has separate event handlers for TryHit and
TryHitSide.
This also fixes it so Magic Coat/Bounce happen before ability
absoption (like Water Absorb).
- Moves that are 'evaded' can no longer be critical hits.
- Gems are no longer used up if a move is 'evaded'.
- The issue with Struggle being 'evaded' while the Wonder Guard user has
a Substitute is fixed.
Type changes have been moved out of ModifyPokemon, and now are only
updated manually such as at clearVolatile or during forme changes.
This fixes interaction between: Transform, forme changes,
Conversion, Conversion2, Soak, Camouflage, Reflect Type, and
Color Change.
We're now one more step closer to getting rid of the ModifyPokemon
event.
Type changes in gen3 and gen4 will need to be redone for the new
typechange system.
- Stats are now cached and recalculated every clearVolatile (switchout)
- Power Trick, Power Split, Guard Split, Transform, forme changes now
modify the cached stat value
- This eliminates the need for pokemon.baseSet, so it's been removed
- pokemon.transformInto has been split into transformInto and formeChange
- pokemon.baseBoosts have also been eliminated, boost changes are now
calculated on-the-fly like stats themselves
- Overall, stat changes should be a lot more like the cartridge games now
- We're also one step closer to finally getting rid of the ModifyPokemon
event
- Choice items now lock into a new move properly after losing the
original locked move (due to Mimic/Sketch/Transform)
- Choice items now continue locking into the original locked move (if
there was one) after Embargo, Klutz, or Magic Room's effects end
- General fixes to the priority of ignoring items
- Magic Room is now usable again
- A previous change to Illusion + Mold Breaker interaction broke some UI
for tracking Illusion status.
- This changes Illusion again, to have its clearing be hardcoded... which
isn't a big deal, because most of the rest is hardcoded anyway.
- This also fixes a minor animation bug so Illusion clears before taking
damage, not after
