Leahnaya/pokemon-showdown
1
0
Fork 0
mirror of https://github.com/smogon/pokemon-showdown.git synced 2026-05-27 10:59:16 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Performance: fix memory leak when destroying chatrooms (#2821)

Browse Source 
The log writing stream was never closed when chatrooms were deleted.
This commit is contained in:
Ben Davies 2016-10-05 06:18:47 -03:00 committed by Guangcong Luo
parent 2de233e338
commit 71400a22be
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rooms.js
View File

@ -1636,6 +1636,12 @@ class ChatRoom extends Room {
}
this.logUserStatsInterval = null;
if (!this.isPersonal) {
this.modlogStream.destroySoon();
this.modlogStream.removeAllListeners('finish');
}
this.modlogStream = null;
// get rid of some possibly-circular references
Rooms.rooms.delete(this.id);
}