From 71400a22be42ba644457cb4dbecd53e156905e76 Mon Sep 17 00:00:00 2001 From: Ben Davies Date: Wed, 5 Oct 2016 06:18:47 -0300 Subject: [PATCH] Performance: fix memory leak when destroying chatrooms (#2821) The log writing stream was never closed when chatrooms were deleted. --- rooms.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rooms.js b/rooms.js index 222ccc56ba..8e24aea030 100644 --- a/rooms.js +++ b/rooms.js @@ -1636,6 +1636,12 @@ class ChatRoom extends Room { } this.logUserStatsInterval = null; + if (!this.isPersonal) { + this.modlogStream.destroySoon(); + this.modlogStream.removeAllListeners('finish'); + } + this.modlogStream = null; + // get rid of some possibly-circular references Rooms.rooms.delete(this.id); }