Because commands are frequently called from buttons as well as
textboxes, passing the clicked button is useful.
The textbox is also passed if the command is typed rather than from
a button. Mostly this just lets us spawn popups closer to where users
are already looking, which I've been wanting to do for `/nick` for
a while.
Major
- Team editor is now its own file, so that it can be used outside of PS.
- New wizard editor (more like old teambuilder)
- Text editor now supports undo
- Don't let species be cleared
- Finish pokemon/ability/item/move lists
- Currently selected options are highlighted
- Keyboard navigation
- Mobile support!
- Text editor now uses big icons on desktop
- With only a few remaining issues, we have reached parity with the old
teambuilder.
Minor
- Fix links to abilities and moves
- New <ul class="tabbar"> CSS. Unfortunately not backportable, so it'll
have to wait until Preact client is released before it can be used.
- Two-tone stats bar chart
- EV editor stub mobile support
In unclear cases, the minimize/close buttons would be too tall,
interfering with the rest of the window. Setting it one pixel shorter
solves this (a solution already in use in Preact client).
- New export format
- NOT FINAL, wow did Twitter freak out when they saw this
- I have not made a decision on whether to keep this new export format
- Stub details form
- Checkbox for old export format
- 510 EV limit
- Show full search results (with windowing)
- Choosing generations rather than specific formats
- Searching/filtering/sorting results
- Reverse sorting filter columns (move types/categories and
pokemon types/abilities) is now possible even on oldclient
Bugfixes:
- Gen 1 (no item) species selection
- "Add pokemon" button positioning
- Dark mode results
- Width (to fit the final column of results)
- Highlighted line width
Minor
- Light mode scrollbar in line with dark mode
- OS default scrollbars all look ugly for some reason, unless you use
macOS's hidden scrollbars, which are nice except they're hidden.
- Add Aurastic to credits
- Fix subtle notifications
- Fix "Copy" button and HTML popups
- These are both for the replay upload popup.
- Fix escaping in teambuilder tables
- They're escaped in Preact but raw HTML in old client, so using
Unicode make them work correctly in both.
- Fix a weird issue where history.replaceState was being called too
often
- I don't know exactly why this is only recently became a problem,
but it's easy enough to fix...
Trivial
- More ARIA roles (for blind users)
- The accessibility tree looks great now.
- Fix an unnecessary closure in AvatarsPanel
- Fix non-ASCII in battle.ts
- Fix class="readmore" to work like class="details" (re: don't do
expand/collapse hover effect if hovering over a link)
- Fix resizing from one-panel to two-panel mode
- This was really just one bug in `focusRoom` left over from an old
architecture where mini-rooms could be panels in vertical tab mode.
- But I took the opportunity to refactor a bunch of panel code to be
clearer.
- Slightly redesign open team sheets
- The yellow and black "construction" message no longer needs nested
divs
Weather/status damage already animate simultaneously, but I forgot
about healing. This brings them on par, which should make Gen 2-3
games animate noticeably faster.
Non-Preact testclients don't deal well with non-full builds anymore,
now that battledata includes data/text.js. This fixes it so that
they're usable (although no longer being able to edit battle-dex etc
without an initial full build still sucks, it's unavoidable).
The page should be a lot more accessible now.
All the aria-hiddens may be distracting; the most important change is
role="tab" and role="tabpanel" for panels, and role="dialog" for
popups.
- Add format chooser
- Show team name in title
- Support selecting species/item/ability/move from menu
- Clicking species/item/ability/move selects the text for easy replace
- Add Stats menu
- Add placeholder Details menu
- Add types and item icon
- "Add Pokemon" button
It's still a very long way to go, but it's starting to look properly
like the vision I have in my mind.
Minor
- Refactor
- Fix cachebuster for teambuilder CSS
- Improve teambuilder resources HTML
Minor
- Fix `/help` for server commands
- Fix multiline DMs
- Redesign collapsed userlists
- Refactor topbar to use display:table and inline-blocks, instead of
floats and manual margin calculations
- I nearly used flexbox, but fake tables work just as well so I
figure why not. The old client actually manually calculates margin
to do the thing where the right tabbar expands to the right and
then to the left and it's nice to not to need that anymore.
- Document `.gray` in STYLING
- Convert all buttons that make sense as links to <a class="button">
- That would be all the main menu links, plus the
usercount/battlecount in Rooms.
- Fix dismissing popups in iOS Safari
- Add an icon for being disconnected
Trivial
- Fix stars in the old client format dropdown
- Use "Cmd" instead of "Ctrl" on Macs in the chat formatting panel
- Fix some code style in panel-popups
- Update supported browser list in README
- Add Preact keys where they make sense
- For the most part I think requiring keys is too strict. I still
think they're unnecessary or actively detrimental for any list
that isn't long/complex and also rearranged ever.
- ESLint: Set no-shadow to warn
1:
We now have some new CSS for details elements. Simply use
`<details class="details">` to make them look nicer.
It also has a lot of neat features (since it was designed for
expandable dexsearch). It's fully documented in STYLING.
https://play.pokemonshowdown.com/style/STYLING.html
2:
Links are now styled, with hover effects. It's just a slightly nicer
blue (and a slightly nicer purple for visited links). I haven't done
this before because it interferes with other CSS too much, but the
new(ish) `:where` selector makes it easy to cheat specificity problems.
3:
Subtle buttons are no longer different from subtle links. I've
introduced ilink buttons which behave like the old subtle buttons,
and new subtle buttons simply work exactly like subtle links.
4:
Infoboxes in dark mode are now slightly easier to see.
Minor
- Don't allow reconnects (force refresh) after a day of uptime
- Don't toggle <details> when selecting text
- Preserve bottom-scroll position when expanding <details>
- Prevent certain kinds of overscroll on mobile
- Scrolling on mobile should now be "less wobbly". Also, swiping
down to refresh no longer happens inside rooms like a chat room
or the main menu (although you can still do it intentionally by
swiping down in the left menu).
- Fix selection in the old newish dexsearch responses
Trivial
- Add Date.now polyfill
- Linter: `no-constant-condition` is now a warning
- Support `PS.confirm` and `PS.prompt`
- Make close buttons in the left sidebar bigger
- Add a `Net.formData` function to get form data
Minor
- Load UI before BattleLog (and thus Caja)
- Remove BattleLog dependencies from panels and panel-mainmenu
- We now have Preact as our only dependency for the first load
- Load times should be really fast now.
- I remember thinking about what the load screen would look like
but how many people would even see it?
- Don't navigate chat history when cursor isn't on the first/last
character
- Make the main menu sticky
- This involved refactoring most of main menu's HTML. It's very
different now.
- Support notification coloring in mini windows
- Fix a variety of button propagation bugs
- Most noticeably, canceling a challenge would immediately send a new
challenge
- Fix a volume slider regression on regular client (Fixes#2383)
- Fix a Firefox issue where sending messages didn't reset the cursor
position
- Add a `/closeand` command, mostly for buttons (Fixes#2386)
Trivial
- Refactor ChatTextEntry for readability
- `setValue` should be impossible to use incorrectly now
- Make mini-window minimize/maximize/close buttons slightly bigger
- Remove resize handle from teambuilder text editor
This adds support for reconnecting to the server after being
disconnected, without needing to refresh.
This is a little dangerous at the moment - one reason we've never done
this in the past is to enforce that everyone's using the newest client
version. This is fine in Preact Alpha but at some point we'll need to
find some way to enforce refreshing at a certain point.
Minor
- Fix "[Gen 6]" appearing in wrong places for the last time
- Fix a bunch of bugs in back/forward history
- Support short links (`news` can't be supported because it conflicts
with the mini-window)
- Support `no-panel-intercept`
- Fix Z-move alignment
- Speed up loading by not using SockJS in newer browsers
- Fix backgrounds
- Uploads required pressing Done, but it's supposed to be a close
button
- Random backgrounds weren't working
- Support ctrl+clicking and shift+clicking links
- Adjust main menu padding
- Mini windows are now 20px wider
- Fix mini-window minimize buttons in Safari
- Add a maximize button to mini windows
- Stop special-casing News mini-window CSS
- Support mini-windows in vertical tab mode
- PMs still default to being full tab, but News is now a mini-window
on screens of any size, because the full tab is actually pretty
unergonomic
- Fix highlight notification room in chat rooms
- This is also refactored to be better code now
- Fix tab overflow
- Give 180px space for userbar instead of 165px
- Fix calculation of when to overflow
- Improve tab list design
- Add checkbox to switch to vertical tabs
- Fix race condition leading to connection failure
Trivial
- Options is now a semimodal
- Fix crash in load tracker
- Remove unused `update = forceUpdate` code in Popups
- Use the redesigned dark mode popups from the design refresh #2175
Minor
- Unhide right panel when choosing "Two panels" layout option
- Refactor focusing
- Correctly focus next room when closing currently active room
- Correctly focus room when joining new room
- Use strict mode on all compiled files
- Fix router when started on `/` (it previously required starting on a
non-empty room ID, which wasn't noticeable back when the URL needed
to be `/preactalpha`)
- Update teambuilder sidebar CSS, to make it easier to add regular text
- This is mainly for the "Tournaments" button in the main menu,
which shares the CSS
- Fix new tournament elim tree text in Safari
- Update new tournament elim tree highlighted links to reliably
link every still-playing game
- Remove latest gen from format name displays everywhere
- Previously, they would only be removed from the format dropdown,
but now they're also gone from the Ladder tab, battle tabs, and
`/rank`
- Support async d3 loading
- This allows chatrooms to be loaded way before all our dependencies
are fully downloaded
- Remove "[Gen 9]" from format names everywhere (previously it was only
removed from the format dropdown)
- Also add "[Gen 6]" to unlabeled formats in `/rank` (Gen 6 was the
last time we didn't have format generation as part of format names)
Trivial
- Stricter JSX linting
- (unfortunately, most of the JSX style enforcement I actually want
isn't possible in @stylistic)
- Make room.subscribeTo's second parameter optional
- Rearrange and comment loading order
- Rename hiddenInit -> focusNextUpdate (clarity)
- Rename PSMain -> PSView (clarity)
- Fix button spacing in Change Password
- Add `touch-action: manipulation` to <a> tags
- Refactor `nodeSize` in elim tour trees
Minor
- Fix crashes/bugs in backported elim tournament redesign
- Support opting into Preact client via cookie
- Fix popup positioning when parent element is unmounted (i.e. when you
switch layouts in the Options menu)
Trivial
- Focus Main Menu and not Rooms when loading home page in single panel
mode
- Correctly set user.registered
( Fixes https://github.com/smogon/pokemon-showdown/pull/11031 )
- Fix some text in the Options menu
